--- loncom/auth/lonroles.pm 2022/01/01 19:28:28 1.269.2.39.2.1 +++ loncom/auth/lonroles.pm 2024/12/29 02:02:29 1.269.2.42 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # User Roles Screen # -# $Id: lonroles.pm,v 1.269.2.39.2.1 2022/01/01 19:28:28 raeburn Exp $ +# $Id: lonroles.pm,v 1.269.2.42 2024/12/29 02:02:29 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -177,7 +177,8 @@ ENDREDIR sub finish_loading_course { my ($r,$msg,$url) = @_; - my $link = ''; + my $link = ''; my $end_page = &Apache::loncommon::end_page(); my $js_url = &js_escape($url); $r->print(< $link $end_page @@ -255,7 +257,7 @@ sub handler { my $r = shift; # Check for critical messages and redirect if present. - my ($redirect,$url) = &Apache::loncommon::critical_redirect(300,'roles'); + my ($redirect,$url) = &Apache::loncommon::critical_redirect(300); if ($redirect) { &Apache::loncommon::content_type($r,'text/html'); $r->header_out(Location => $url); @@ -273,43 +275,8 @@ sub handler { $update = $then; } - my ($norolelist,$blocked_by_ip,$blocked_type,$clientip); + my ($blocked_by_ip,$blocked_type,$clientip); $clientip = &Apache::lonnet::get_requestor_ip($r); - if (($env{'request.course.id'}) && ($env{'request.deeplink.login'})) { - my $cnum = $env{'course.'.$env{'request.course.id'}.'.num'}; - my $cdom = $env{'course.'.$env{'request.course.id'}.'.domain'}; - my $crstype = $env{'course.'.$env{'request.course.id'}.'.type'}; - my $deeplink_symb = &Apache::loncommon::deeplink_login_symb($cnum,$cdom); - if ($deeplink_symb) { - my ($menucoll,$deeplinkmenu,$menuref) = &Apache::loncommon::menucoll_in_effect(); - if (ref($menuref) eq 'HASH') { - unless (($menuref->{'role'}) || ($env{'request.role.adv'})) { - foreach my $envkey (keys(%env)) { - next unless ($envkey =~ /^form\./); - if ($envkey =~ m{\./($match_domain)/($match_courseid)(?:/(\w+)|$)}) { - unless (($1 eq $cdom) && ($2 eq $cnum)) { - delete($env{$envkey}); - } - } - } - if ($env{'form.selectrole'}) { - if ($env{'form.switchrole'} =~ m{\./($match_domain)/($match_courseid)(?:/(\w+)|$)}) { - unless (($1 eq $cdom) && ($2 eq $cnum)) { - delete($env{'form.selectrole'}); - delete($env{'form.switchrole'}); - } - } elsif ($env{'form.newrole'} =~ m{\./($match_domain)/($match_courseid)(?:/(\w+)|$)}) { - unless (($1 eq $cdom) && ($2 eq $cnum)) { - delete($env{'form.selectrole'}); - delete($env{'form.newrole'}); - } - } - } - $norolelist = 1; - } - } - } - } if ($env{'form.selectrole'}) { my ($role,$cdom,$cnum,$rest); @@ -672,7 +639,7 @@ sub handler { $env{'user.name'}, &mt('Assigned from [_1] at [_2] for [_3]' ,$ip - ,&Apache::lonlocal::locallocaltime() + ,&Apache::lonlocal::locallocaltime($now) ,$trolecode) ); unless ($assignresult eq 'ok') { @@ -767,19 +734,8 @@ ENDCLOSE my %prog_state = &Apache::lonhtmlcommon::Create_PrgWin($r,undef,$preamble); &Apache::lonhtmlcommon::Update_PrgWin($r,\%prog_state,&mt('Loading ...')); $r->rflush(); - my ($msg,$blockcrit,$critmsg_check); + my ($msg,$critmsg_check); $critmsg_check = 1; - $blockcrit = &Apache::loncommon::blocking_status('alert',$clientip,$cnum,$cdom,undef,1); - if ($blockcrit) { - my $checkrole = "cm./$cdom/$cnum"; - if ($csec ne '') { - $checkrole .= "/$csec"; - } - unless ((&Apache::lonnet::allowed('evb',undef,undef,$checkrole)) && - ($trolecode !~ m{^st\./$cdom/$cnum})) { - $critmsg_check = 0; - } - } my ($furl,$ferr)= &Apache::lonuserstate::readmap($cdom.'/'.$cnum,$critmsg_check); &Apache::lonhtmlcommon::Update_PrgWin($r,\%prog_state,&mt('Finished!')); @@ -978,9 +934,6 @@ ENDCLOSE $msg = '

'.&mt('Entering [_1] ...', $env{'course.'.$cdom.'_'.$cnum.'.description'}). '

'; - if ($env{'form.ttoken'}) { - $dest .= (($dest =~/\?/)? '&':'?').'ttoken='.$env{'form.ttoken'}; - } &finish_loading_course($r,$msg,$dest); $r->rflush(); return OK; @@ -1036,7 +989,7 @@ ENDCLOSE } else { $access = &Apache::lonnet::allowed('bre',$unencfurl); } - if ((!$access) || ($access eq 'B') || ($access eq 'D')) { + if ((!$access) || ($access eq 'B')) { $furl = &Apache::lonpageflip::first_accessible_resource(); if ($furl eq '') { $furl = '/adm/navmaps?showOnlyHomework=1'; @@ -1113,10 +1066,6 @@ ENDCLOSE $recent = &mt('Recent Courses'); $standby = &mt('Course selected. Please stand by.'); } - if (($norolelist) && ((split(/:/,$env{'user.error.msg'}))[2])) { - $crumbtext = 'Access Denied'; - $pagetitle = 'Unauthorized'; - } my $brcrum =[{href=>"/adm/roles",text=>$crumbtext}]; my %roles_in_env; @@ -1128,16 +1077,16 @@ ENDCLOSE if ($domdefs{'catauth'}) { $cattype = $domdefs{'catauth'}; } - my ($funcs,$crumbsright); - unless (($norolelist) && ((split(/:/,$env{'user.error.msg'}))[2])) { - $funcs = &get_roles_functions($showcount,$cattype); - if ($env{'browser.mobile'}) { - $crumbsright = $funcs; - undef($funcs); - } + my ($funcs,$crumbsright,$crumbs_style); + $funcs = &get_roles_functions($showcount,$cattype); + if ($env{'browser.mobile'}) { + $crumbsright = $funcs; + undef($funcs); + $crumbs_style = 'overflow: visible;'; } my $start_page=&Apache::loncommon::start_page($pagetitle,undef,{bread_crumbs=>$brcrum, - bread_crumbs_component=>$crumbsright}); + bread_crumbs_component=>$crumbsright, + bread_crumbs_style=>$crumbs_style,}); &js_escape(\$standby); my $noscript='
'.&mt('Use of LON-CAPA requires Javascript to be enabled in your web browser.').'
'.&mt('As this is not the case, most functionality in the system will be unavailable.').'
'; @@ -1241,16 +1190,8 @@ ENDHEADER } if ($nochoose) { $r->print("

".&mt('Sorry ...')."

\n". - &mt('This action is currently not authorized.').''); - if ($error && $norolelist) { - $r->print('

'. - &mt('As your session was launched from a web page external to LON-CAPA some course content may be unavailable, including the resource you were trying to access.'). - '

'. - '

'. - &mt('You may need to login to LON-CAPA directly, or re-launch from a different external system.'). - '

'); - } - $r->print(&Apache::loncommon::end_page()); + &mt('This action is currently not authorized.').''. + &Apache::loncommon::end_page()); return OK; } else { if ($updateresult || $reqauthor || $hotlist) { @@ -1320,26 +1261,6 @@ ENDHEADER } } - if ($norolelist) { - if ($env{'request.role'}) { - my ($roletext,$role_text_end) = &display_curr_role($env{'request.role'}); - if ($roletext) { - $r->print(&Apache::loncommon::start_data_table('LC_textsize_mobile'). - &Apache::loncommon::start_data_table_row(). - $roletext. - &Apache::loncommon::end_data_table_row()); - if ($role_text_end) { - $r->print(&Apache::loncommon::continue_data_table_row(). - $role_text_end. - &Apache::loncommon::end_data_table_row()); - } - $r->print(&Apache::loncommon::end_data_table()); - } - } - $r->print(&Apache::loncommon::end_page()); - return OK; - } - # No active roles if ($countactive==0) { my $elapsed = 0; @@ -1638,9 +1559,9 @@ sub gather_roles { foreach my $rolename (sort(keys(%{$domdef{'adhocroles'}}))) { if (ref($domdef{'adhocroles'}{$rolename}) eq 'HASH') { $adhocdesc{$tdom}{$rolename} = $domdef{'adhocroles'}{$rolename}{'desc'}; - $desc = $adhocdesc{$tdom}{$rolename}; } } + $desc = $adhocdesc{$tdom}{$rolename}; } } if ($desc ne '') { @@ -2079,7 +2000,7 @@ sub build_roletext { $trolecode."','".$buttonname.'\');" />'; } } - if (($trolecode !~ m/^(dc|ca|au|aa)\./) && (!$skipcal)) { + if (($trolecode !~ m/^(ca|aa)\./) && ($trest ne '') && (!$skipcal)) { $tremark.=&Apache::lonannounce::showday(time,1, &Apache::lonannounce::readcalendar($tdom.'_'.$trest)); } @@ -2344,38 +2265,6 @@ sub display_cc_role { } } return ($roletext,$roletext_end); -} - -sub display_curr_role { - my ($currentrole) = @_; - my ($roletext,$roletext_end); - my $advanced = $env{'user.adv'}; - my $tryagain = $env{'form.tryagain'}; - my ($role,$rest) = split(m{\./},$currentrole,2); - unless (!defined($role) || $role eq '') { - if ($rest =~ m{^($match_domain)/($match_courseid)(?:/(\w+)|$)}) { - my $cdom = $1; - my $cnum = $2; - my $csec = $3; - my $cid = $cdom.'_'.$cnum; - my $ttype = $env{'course.'.$cid.'.type'}; - my $skipcal = 1; - my $tbg='LC_roles_is'; - my $twhere = $env{'course.'.$cid.'.description'}. - ' '. - &Apache::loncommon::syllabuswrapper(&mt('Syllabus'),$cnum,$cdom). - ''; - my $trole = &Apache::lonnet::plaintext($role,$ttype,$cid); - if ($csec) { - $twhere.= '  '.&mt('Section').': '.$csec; - } - if ($role ne 'st') { - $twhere.= '  '.&mt('Domain').': '.$cdom; - } - ($roletext,$roletext_end) = &build_roletext($currentrole,$cdom,$cnum,'is',$tryagain,$advanced,'',$tbg,$trole,$twhere,'','','',1,'','','',$skipcal); - } - } - return ($roletext,$roletext_end); } sub adhoc_roles_row {