--- loncom/cgi/graph.png	2003/10/27 21:21:08	1.29
+++ loncom/cgi/graph.png	2003/10/29 15:18:09	1.31
@@ -1,6 +1,6 @@
 #!/usr/bin/perl
 #
-# $Id: graph.png,v 1.29 2003/10/27 21:21:08 matthew Exp $
+# $Id: graph.png,v 1.31 2003/10/29 15:18:09 matthew Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -38,19 +38,18 @@ graph.png
 
 =head1 SYNOPSIS
 
-produces plots based on input
+produces plots from data stored in users environment.
 
 =head1 DESCRIPTION
 
-graph.png is a cgi-bin script which produces plots based on input data.
-
-The query string is expected to be as follows (without whitespace):
-
-escape(Plot title) & escape(X label)& escape(Y label) & Maximum Y value &
-Number of bars & $data1 & $data2
-
-$data1 and $data2 are expected to be comma seperated lists of numbers.
-escape( value ) means the values must be run through lonnet::escape.
+graph.png is a cgi-bin script which produces plots based on data stored
+in the users environment.  The users cookie is checked prior to producing
+a plot.  The query string is expected to be an identifier, $id.  
+The parameters defining the plot must be stored in the environment as 
+$ENV{'cgi.'.$id.'.'.$dataname}.  Two types of plots can be produced, 'bar'
+and 'xy'.  The 'xy' graph can will 1 or 2 y-axes if the parameter
+'two_axes' is set to false or true respectively.  See perldoc GD::Graph and
+loncommon::DrawBarGraph, loncommon::DrawXYGraph, and loncommon::DrawXYYGraph.
 
 =cut
 
@@ -90,7 +89,7 @@ END
 my $id = $ENV{'QUERY_STRING'};
 
 #
-# &get_env($name,$default)
+# usage: &get_env($name,$default)
 sub get_env {
     my $key = 'cgi.'.$id.'.'.(shift());
     return shift if (! exists($ENV{$key}));
@@ -113,6 +112,9 @@ END
 
 $|=1;   # Autoflush after each print/write
 
+##
+## Set up the plot
+##
 my $colordefaults = join(',',
                          ('#33ff00', 
                           '#0033cc','#990000','#aaaa66','#663399','#ff9933',
@@ -143,7 +145,7 @@ my %GraphSettings = (
 
 $GraphSettings{'x_label_skip'}  = &get_env('xskip',1);
 $GraphSettings{'x_tick_offset'} = &get_env('x_tick_offset',0);
-$GraphSettings{'y_max_value'}   = &get_env('Max',undef);
+$GraphSettings{'y_max_value'}   = &get_env('y_max_value',1);
 
 my $MyGraph;
 if ($PlotType eq 'bar') {
@@ -168,6 +170,13 @@ if ($PlotType eq 'bar') {
     $GraphSettings{'x_label_skip'}  = $skip_x;
     $GraphSettings{'x_tick_offset'} = $x_tick_offset;
     $GraphSettings{'zero_axis'}     = 1;
+    if (&get_env('two_axes',0)) {
+        $GraphSettings{'two_axes'}     = 1;
+        $GraphSettings{'y1_max_value'} = &get_env('y1_max_value',0);
+        $GraphSettings{'y1_min_value'} = &get_env('y1_min_value',1);
+        $GraphSettings{'y2_max_value'} = &get_env('y2_max_value',1);
+        $GraphSettings{'y2_min_value'} = &get_env('y2_min_value',1);
+    }
 }
 #
 # Pick up miscellanious values passed in by the user
@@ -202,9 +211,11 @@ if (! $MyGraph->set(%GraphSettings)) {
 my $plot = $MyGraph->plot(\@Data);
 if (! defined($plot)) {
     my $error = 'Unable to plot the data provided.';
-    $error .= '<pre>'.join(',',@{$Data[0]}).'</pre>';
-    $error .= '<pre>'.join(',',@{$Data[1]}).'</pre>';
-    $error .= '<pre>'.join(',',@{$Data[2]}).'</pre>';
+# Debugging code:    
+#    $error .= '<pre>'.join(',',@{$Data[0]}).'</pre>';
+#    $error .= '<pre>'.join(',',@{$Data[1]}).'</pre>';
+#    $error .= '<pre>'.join(',',@{$Data[2]}).'</pre>' if (ref($Data[2]));
+#    $error .= '<pre>'.join(',',@{$Data[3]}).'</pre>' if (ref($Data[3]));
     print &error($error);
     exit;
 }