--- loncom/homework/bridgetask.pm 2005/05/20 21:23:42 1.29 +++ loncom/homework/bridgetask.pm 2005/05/27 17:08:03 1.32 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # definition of tags that give a structure to a document # -# $Id: bridgetask.pm,v 1.29 2005/05/20 21:23:42 albertel Exp $ +# $Id: bridgetask.pm,v 1.32 2005/05/27 17:08:03 albertel Exp $ # # Copyright Michigan State University Board of Trustees # @@ -144,6 +144,12 @@ sub add_grading_button { my $result=' '; $result.=''; + if ( 1) { + #need a permissions for limitng this to 'powerful users' + #check if review queue has items + $result.=' '; + } return $result; } @@ -154,6 +160,18 @@ sub add_request_another_attempt_button { return $result; } +sub preserve_grade_info { + my $result; + # if we are viewing someone else preserve that info + if (defined $env{'form.grade_symb'}) { + foreach my $field ('symb','courseid','domain','username') { + $result .= ''."\n"; + } + } + return $result; +} + sub start_Task { my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_; @@ -240,13 +258,7 @@ sub start_Task { $result.="$head_tag_start
Found '. - &Apache::lonnet::gettitle($symb).' for '.$uname.' at '.$udom.' |
No user to be graded. |
Found '. + &Apache::lonnet::gettitle($symb).' for '.$uname.' at '.$udom.' |
'; + if ($status_code eq 'stop') { + $result.=&mt("Stopped grading."); + } elsif ($status_code eq 'lock_failed') { + $result.=&mt("Failed to lock the request record."); + } elsif ($status_code eq 'unlock') { + $result.=&mt("Unlocked the requested user."); + } else { + $result.=&mt("No user to be graded."); + } + $result.=' |
resource | ". - "user | type | data |
---|
Empty |
"; } + $result.=" | resource | user | type | data | |
---|---|---|---|---|---|
$title | $uname | "; $result.='lock | '.$queue{$key}.' | ||
$title | "; $result.=' | last queue modification time | '. &Apache::lonlocal::locallocaltime($queue{$key})." | ||
$title | $uname | "; + $result.="||||
$title | $uname | "; my $slot=$queue{$key}->[0]; my %slot_data=&Apache::lonnet::get_slot($slot); $result.='queue entry | Slot: '.$slot.' End time: '. @@ -497,9 +642,9 @@ sub decode_queue_key { } sub queue_key_locked { - my ($key,$cdom,$cnum)=@_; + my ($queue,$key,$cdom,$cnum)=@_; my ($key_locked,$value)= - &Apache::lonnet::get('gradingqueue',["$key\0locked"],$cdom,$cnum); + &Apache::lonnet::get($queue,["$key\0locked"],$cdom,$cnum); if ($key_locked eq "$key\0locked") { return $value; } @@ -507,8 +652,8 @@ sub queue_key_locked { } sub pick_from_queue_data { - my ($check_section,$queue,$cdom,$cnum)=@_; - foreach my $key (keys(%$queue)) { + my ($queue,$check_section,$queuedata,$cdom,$cnum)=@_; + foreach my $key (keys(%$queuedata)) { my ($symb,$uname,$udom)=&decode_queue_key($key); if ($check_section) { my $section=&Apache::lonnet::getsection($uname,$udom); @@ -517,13 +662,13 @@ sub pick_from_queue_data { next; } } - my $slot=$queue->{$key}[0]; + my $slot=$queuedata->{$key}[0]; my %slot_data=&Apache::lonnet::get_slot($slot); if ($slot_data{'endtime'} > time) { &Apache::lonnet::logthis("not time"); next; } - if (&queue_key_locked($key,$cdom,$cnum)) { + if (&queue_key_locked($queue,$key,$cdom,$cnum)) { &Apache::lonnet::logthis("someone already has um."); next; } @@ -533,15 +678,15 @@ sub pick_from_queue_data { } sub find_mid_grade { - my ($symb,$cdom,$cnum)=@_; + my ($queue,$symb,$cdom,$cnum)=@_; my $todo=&Apache::lonnet::unescape($env{'form.gradingkey'}); my $me=$env{'user.name'}.'@'.$env{'user.domain'}; if ($todo) { - my $who=&queue_key_locked($todo,$cdom,$cnum); + my $who=&queue_key_locked($queue,$todo,$cdom,$cnum); if ($who eq $me) { return $todo; } } my $regexp="^$symb\0.*\0locked\$"; - my %locks=&Apache::lonnet::dump('gradingqueue',$cdom,$cnum,$regexp); + my %locks=&Apache::lonnet::dump($queue,$cdom,$cnum,$regexp); foreach my $key (keys(%locks)) { my $who=$locks{$key}; if ($who eq $me) { @@ -553,50 +698,59 @@ sub find_mid_grade { return undef; } +sub lock_key { + my ($queue,$todo)=@_; + my $me=$env{'user.name'}.'@'.$env{'user.domain'}; + my (undef,$cid)=&Apache::lonxml::whichuser(); + my $cnum=$env{'course.'.$cid.'.num'}; + my $cdom=$env{'course.'.$cid.'.domain'}; + my $success=&Apache::lonnet::newput($queue,{"$todo\0locked"=> $me}, + $cdom,$cnum); + &Apache::lonnet::logthis("success $success $todo"); + if ($success eq 'ok') { + return 1; + } + return 0; +} + sub get_from_queue { + my ($queue)=@_; my $result; my ($symb,$cid,$udom,$uname)=&Apache::lonxml::whichuser(); my $cnum=$env{'course.'.$cid.'.num'}; my $cdom=$env{'course.'.$cid.'.domain'}; - my $todo; - # FIXME need to find if I am 'mid grading' - $todo=&find_mid_grade($symb,$cdom,$cnum); + my $todo=&find_mid_grade($queue,$symb,$cdom,$cnum); &Apache::lonnet::logthis("found ".join(':',&decode_queue_key($todo))); if ($todo) { return $todo; } while (1) { my $starttime=time; - &Apache::lonnet::put('gradingqueue',{"$symb\0timestamp"=>$starttime}, + &Apache::lonnet::put($queue,{"$symb\0timestamp"=>$starttime}, $cdom,$cnum); &Apache::lonnet::logthis("$starttime"); my $regexp="^$symb\0queue\0"; - my %queue=&Apache::lonnet::dump('gradingqueue',$cdom,$cnum,$regexp); + my %queue=&Apache::lonnet::dump($queue,$cdom,$cnum,$regexp); #make a pass looking for a user in my section if ($env{'request.course.sec'}) { &Apache::lonnet::logthis("sce"); - $todo=&pick_from_queue_data($env{'request.course.sec'},\%queue, - $cdom,$cnum); + $todo=&pick_from_queue_data($queue,$env{'request.course.sec'}, + \%queue,$cdom,$cnum); &Apache::lonnet::logthis("sce $todo"); } # no one in our section so look for any user that is ready for grading if (!$todo) { &Apache::lonnet::logthis("no sce"); - $todo=&pick_from_queue_data($env{'request.course.sec'},\%queue, - $cdom,$cnum); + $todo=&pick_from_queue_data($queue,$env{'request.course.sec'}, + \%queue,$cdom,$cnum); &Apache::lonnet::logthis("no sce $todo"); } # no user to grade if (!$todo) { last; } &Apache::lonnet::logthis("got $todo"); # otherwise found someone so lets try to lock them - my $success=&Apache::lonnet::newput('gradingqueue', - {"$todo\0locked"=> - $env{'user.name'}.'@'.$env{'user.domain'}}, - $cdom,$cnum); - # someone else already picked them - &Apache::lonnet::logthis("success $todo"); - if ($success ne 'ok') { next; } + # unless someone else already picked them + if (!&lock_key($queue,$todo)) { next; } my (undef,$endtime)= - &Apache::lonnet::get('gradingqueue',["$symb\0timestamp"], + &Apache::lonnet::get($queue,["$symb\0timestamp"], $cdom,$cnum); &Apache::lonnet::logthis("emd $endtime"); # someone else already modified the queue, @@ -605,12 +759,12 @@ sub get_from_queue { # double check. if ($endtime != $starttime) { my ($key,$value)= - &Apache::lonnet::get('gradingqueue',["$todo"], + &Apache::lonnet::get($queue,["$todo"], $cdom,$cnum); &Apache::lonnet::logthis("check $key .. $value"); if ($key eq $todo && ref($value)) { } else { - &Apache::lonnet::del('gradingqueue',["$todo\0locked"], + &Apache::lonnet::del($queue,["$todo\0locked"], $cdom,$cnum); &Apache::lonnet::logthis("del"); next; @@ -663,9 +817,6 @@ sub start_Dimension { } sub get_instance { - #FIXME just grabbing the first one for now, need - #to randomly pick one until all have been seen - #then start repicking &Apache::response::pushrandomnumber(); my @order=&Math::Random::random_permutation(@{$dimension{'instances'}}); my $num=@order; @@ -719,16 +870,18 @@ sub get_instance { ''. ' | '. ''.
- ' '. - ' '. - ' '. - ' '. + ' '. + ' '. + ' '. + ' '. ' | '.
''.
'Prev '. 'Next '. ' '. + ' '. ' |
'; my (undef,undef,$udom,$uname) = &Apache::lonxml::whichuser(); |