CVS log for loncom/homework/bridgetask.pm

Up to [LON-CAPA] / loncom / homework

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- For 2.11
  Backport 1.272, 1.273

- For 2.11.4 (modified)
  Include changes in 1.268, 1.269, 1.270

- For 2.11.4 (modified)
  Include changes in 1.272, 1.273

- xhtml

- Hint to browsers to not autofill password fields.

- 2.11.4 (modified)
  Include changes in 1.266

- For 2.11.3 (modified)
  Include changes in 1.271

- For 2.11
  Backport 1.271

- Bug 6938

- 2.11.3 (modified)
  Include changes in 1.266

- Bug 6754 LON-CAPA as LTI Consumer
  Support for access control using slots for both "gradable" and "non-gradable"
  external tools.

- Bug 6754 LON-CAPA as LTI Consumer
  Support for access control using slots for external tools set to be
  "gradable".

- Bug 6754 LON-CAPA as LTI Consumer
  Support for access control using slots, and also for time interval
  for external tools set to be "gradable".

- For 2.11.2 (modified).
    Use 2.12 feature ("done" button for timed exms) pre-release, in modified
    2.11.2. Domain's configuration must be set to prohibit hosting of sessions
    for domain's users outside own domain, and modification must be in place
    on all nodes in domain.

- For 2.11.2 (modified).
  Use 2.12 feature ("done" button for timed exms) pre-release, in modified
  2.11.2. Domain's configuration must be set to prohibit hosting of sessions
  for user's domains outside own domain, and modification must be in place
  on all nodes in domain.

- Current remote ip address.

- Bug 6763. "Done" button.
  String saved for the Time-Limit (interval) parameter will no longer be a
  pure integer if use of the "done" button has been enabled.

- Slots can now require each student to check-in from a unique IP address
  when using a particular slot for a specific resource. The IP address of
  the student's computer is then tied to that student's access to the resource
  thereafter, until the end date of the slot.
  (Intended use case is high stakes online testing where students are using
  computers with statically assigned IP addresses).

- lonnet::set_first_access() takes interval duration as second arg.

Internationalization: Added missing &mt() calls

XHTML: action attribute in <form> tag required (dummy attribute added)

- Localization - avoid escaped quotes.

- Countdown timer available (leftmost item in icons of right side of inline
  menu in course context) for items with slot access control.
- For a .Task (automatically uses slot access control), time remaining shown
  by default.
- For .problems using slot access control, arrow to left of clock icon needs
  to be clicked to expand disply to show active countdown.

changed <h1> to <p class='LC_error/warning/info'> where a headline is misplaced

- Bug 6450. Course personnel with vgr priv can view student's prior
  versions of a Bridge Task (BT).
  - bridgetask.pm
    - generation of Show Slot list and Show Grading Status buttons moved
      to new routine: &add_slotlist_button().
    - "Show Slot list", "Show Grading Status", "Show a previously done version"
      "Get a submission to grade", "Change reservation" buttons not shown
      when course personnel display student's version of a BT.
    - ensure tags have unique ids (replace duplicate LC_task_feedback with
      LC_task_answer.

  - grades.pm
    - Header: "View of the problem" replaced with "View of the problem for
              <student name>
    - Header: "Correct answer" replaced with "Correct answer for "
              <student name>
    - New routine: &show_previous_task_version() to show student's previous
      version of a BT.
    - New routine: &choose_task_version_form() provides a web form to select
      display of a student's version of a BT (in same window or in pop-up).
    - New routine: &previous_display_javascript() javascript to launch pop-up
      etc. for other version.
    - &startpage() has four additional args: $stuvcurrent,$stuvdisp,$nomenu,$js
      student's current BT version, version being displayed, no page menu (for
      pop-up), and javascript to launch previous version pop-up.a

  - lonhtmlcommon.pm
    - &resource_info_box() has two additional args: $stuvcurrent,$stuvdisp
      student's current BT version, and version being displayed.

- xhtml.

- Bug 5497. Time limits can be used with bridge tasks.
  However, limit parameter should be resource-specific (rather than folder, or course-wide),
  as accesstime is automatically deleted when BT is graded, to allow the user the possibility
  of a later attempt (if user failed this BT), when the next slot becomes available.

- Bug 5633.

- Bug 5921.
  - If gradingkey mismatch is detected, provide information about this to grader.
  - Do not get another submission to grade.

- Bug 5921.
 - If storage could not occur, delete "locked" key, but leave key from check-in
   intact, so consistent status of "Waiting for grade" is maintained.

- Improved student interface for managing files submitted to a bridgetask
  over multiple tries.

- Consistent wording.

- bug 5921.
  - Before calling structuretags::finalize() to store grading, check that username, domain and symb in grading key match those in
    $env{'form.grade_username'}, $env{'form.grade_domain'},
    $env{'form.grade_symb'}.

XHTML conform selected/checked/multiple HTML attributes
and optimized spacing

remove \begin{document} from here as it's now output in londefdef.pm's common
header emission code.. finally latex headers only in one spot (probably).

- Eliminate ending . from button text.
- Use same phrase for both .task and .problem when slots in use and status is "NOT_IN_A_SLOT".

- Error condition if navmap object unavailable.

Standard texthash calls:
- Direct call
- Keys and values in (single) quotes
- Standard indent

consistent wording:
changed "student number" to "student/employee ID"
changed "student ID" to "student/employee ID"
changed "student and eyployee IDs" to "student/employee IDs"

Replaced all hardcoded nowrap styles with LC_nobreak classes

Added missing &mt() call to Regrade button text

- Typo (existant)
- Missing ;
- Add some missing localizations.

Past tense of "occur" is "occurred" (rr!)
Also added some missing &mt() calls and corrected some other little typos

Localization:
- Added missing &mt() calls
- Optimized some &mt() calls
- typo
Note: untested (webserver restart ok)

- er logic backwards

- BUG#5333
   - section restrictions apply when
        - using 'list of user's grade status'
        - whether or not you get to select the section you want to see
        - restricte regrade a user to only users in your section
        - hides the 'show grading status' button if you are section limited

- more restrictive about what is allowed in id numbers (throws errors on in construct to hopefully not break too many users)

- BUG#5333 - task grading can be set to restricted to only allow grading by the section of the selected role

- add in return link when viewinggrading queues

- BUG#5260, Need to put N for it to work

- 2622, task seems to not need a previous submission mechanism

- enable task grading in CSTR

- BUG#5167, if proctors is defined but doesn't contain any vlaid proctor definitions show an error message

- backport 1.229

- enc url's should be enc

- backport 1.226

- removing some dead code

- text chunks for bridgetask edit like other tags now
- enable Edit Mode for tasks
- mae some nice insert routines that insert good default chunks

- add in ability to explicitly control placement of gradeinfo display

- make task's editable (Requied the creation of <CriteriaText>)

- sigh

- clean user input

- requested wording change

- multiple sub aquestions were being parsed in the incorrect order

- got them backwards

- some tweaks to the english of a graded task.

- some tweaks to tasks look, remove the border around questions when doing the task, leave them in for the feedback display

- dealing with some other fallout from extending the lock recors to include the time of locking

- after creating the version store

- prevent submissions of bridgetask answers after slot closes

- add a timestamp to when the lock was aquired and display it on the queue overview screen

- move the overall status message back into the existing div.
- some updates to the css

- make it say subquestion each time

- fix the indenting of sub questions

- add the id of the dim to the div

- some changes to get the existing 'btEninge' style .tasks to work again

- move results of taks parsing to the out of the way results storage
  so arbitrary html can be included

- need to make sure it returns nothing.

- only add the div to not empty <Question>s

- sub sub questions not embedded in a <questionText> weren't being shown properly

- typo

- missing space

- adds a <div> around the whole of a question/dimension
- move the question results to come after the question
- strip the excess start/ending ws from the criteria text

- some updates to the button html layout

- some cleanups to the generated html to make it easier to read

- always need a close </form> in web view

- making the task and question have the same status

- update the dimension status message to separate out criteria and sub questsion
- centralize the counting of components and types

- call sub Dimension/questions subquestion

- fixup webgade display to once again not include the questiontext

- <Criteria> can be directly inside of a <Task> now
- <Task> status is in a separate <div>
- <Criteria> all are shown at the top of the question/task
- factored out some of the <Criteria> display code for reuse

- forwardprot 1.184.2.4

- forgot to return the info.

- backport 1.192

- IE specific styles for tasks

- backport 1.186 -> 1.191

 forward port 1.184.2.1

- better check for a valid comment

- move display of <Criteria> Form the end of the <Dimension> to be at the location of the <Criteria>

- dimensionmandatory got eliminated

- reverse order, first do all grading and commit it before removing from grading queue

- add in some extra text

- adding a <GraderNote> section to <Criteria>

- complte the move of whichuser() from lonnxml -> lonnet

- was occasionally doing two stores (if a new instance got picked during the grading phase)

- find last submission that was a try

- was taking time of first submission not last.
- (-10)%60 is apparently 50
- (some code for edit mdoe of takss...)

- when regrading users and then need to be reinserted into the queue need to recreate the queue_data that originally was there

- properly handle grading of <Dimension> nested inside of <QuestionText>

- backport 1.179

- improving handling of some problem globals to longer be left with dangling values

- typos

- BUG#4835

- replace other create_new_version call with the new check_in

- correcting retriveResources call, we don't want the resources from sub maps (since the parameteres don't penetrate there), and we want only problems/ (or tasks)

- supporting checking of a sequence of resource in one swoop

- backport 1.167

- reworked the nesting algorithm so parsing happens in the expected order

- need to output nested Question when not yet graded

- output is in correct order

- extra my

- nested <Dimension>s almost working, placement of output is not yet correct

- starting work on nesting <Dimension>s

- adding option such that bringing up the Done screen can cause a message
  to be generated an sent to the student and possibly to the notes section
  of the about me page

- factor out the done screen code

- regrading not allowed to grade a task that is still open

- prevent grading of non-checkedout non-versioned tasks

- addign a 'Cancel' to regrading screens that leaves the resource unchanged

- adding <Setup> section, in functionality a <Criteria>less dimension basically a way of getting <instance> selection while not causing anything to be created that needs grading

- backport 1.153

- xhtmlize

- adding a <QuestionText> to <Question>/<Dimension>

- data tabling

&Apache::lonnet::unescape -> &unescape
&Apache::lonnet::escape -> &escape

- only do active users

- improved handling of
  - invalid grading queue entries
  - section priv limiting

- another case of putting @ as the name/domain seperator

- corrected handling of detection of whether a queue entry is ready to be graded

- parsing the instance text during the grade pass in case the info is needed

- non proctored access to slots now works with .tas

- <Question> is a synonym for <Dimension>
- OptionalRequired is allowed on <Question>s (but if it exists on <Instance> it overrides the <Dimension> definition)
- <Criteria> is allowed inside of <Question> and is then used on all <Instance>s

-when visiting a non-slotted (and thus non0proctored) resource need to create  a new version on the frist viewing.

- if instance creation occurs when version is blank dont' store the resutls.

- don't emit the 'request another attempt' button in a non slot environment
- acess the correct starttime for slot versus non-slot access

- converting to use the hash of data in the grading queu
- now understands when it is in non-slotted mode and properly adds itself to the grading queue

- supporting the newly seperated queu only grading priv

- style wants a target

- was getting page headers in answer mode in CSTR

- morphing get_sections so it's easier to use

- forward port 1.128.2.9

- added keyboard support for the grading radio buttons
- submit validation. If a partially graded task is
  submitted the JS will ask for user confirmation
- 'Fail Rest' button statically added to html

- end_page for task/homework

- tasks -> start_page

-end_page

- backport 1.139

- BUG4725, preferenence towards always picking off the top of the queue

- switching to use the more official : as domain username seperator (rather tahn @, since MSU will want @ in valid usernames)

- forward port 1.128.2.7

- address BUG#4725, more strongly favor the head of the queue in shorter queu cases

- backpor 1.135/6

- commit sigh

- typo

- forwardport 1.128.2.5

- don't need the <a> since we have <div> with id's

- backport 1.133

- not really true, or Ineeded to be alot more specfic about that test, sigh

- typo

- typo

- backport 1.131

- removing no longer needed <hr />

- revert 1.129

- stat_file isn't in 2.1

- stat_file isn't in 2.1

- need to do endredir only for <task> <IntroParagraph>

- make it so the after effects of a global <introParagraph> take effect

- /res/adm/includes...

- moving task style info to an external file
- style include in both web and webgrade modes

- adding in an extra <div>

- add titles to both web and webgrade
- add missing </p>

- grading of tasks works again, morphed the name of the input element and didn't carry the change through

- typo

- I meant to use GRADING not GRADE

- file links were incorrect
- commiting code to generate file lists

- backport 1.118

- relabel grading buttons

- adding a wrapper <div> to the whole task
- missed a LC_GRADE class

- adding LC_ and LC_GRADE_ to class elements

- some xhtml cleanups

- if students submitted portfolio items that don't exist let them know

- adding a per criteria grading history

- some more layout updates

- converting from <table> style to <div> style layout

- bug #4663
   - missing a </head>
   - table was being started too early.

- invalid html

- adding a mode to do analysis of grading events for bridge tasks

- typo

- make the interface a little cleaner fro mgq people

- make it easier to regrade a specific user.

- add username to queue display

- improve the display of the grading queue

- add in student username to regrade list

- add who graded a res to the regrade screen

- add 'Comment: ' to preface returned grader comments

- getting the pass message correct.

- eliminate use of rangeing for now
- order the allowed keys by slot endtime and then pick on the first 10, when picking queue entry

- bug #4608
   - adding optional 'range' attribute to dump for controlling the number of results

- perf improvement for the super grader state

- some of BUG#4608, could loop indefinately if unable to lock a student record, now if we fail twice give up and let the grader know we gave up

- grading a BT can cause alot of data spew, so only store items that changed

- was cleaning out the version nu,mber accidently so reorg the versionsing and comment

- make the full BT status message be more like the indiviual Dim ones

- missed a .0. update

- the ++ was being hidden in there

- add in the missing .0. from the expected location in the internal data sturctures for BT's
- move .grader to .regrader

- add ability to check queue status of a specific user
- remove only removes users that are in the queue

- finish off the conversion to allowing style tags get_all_text across tags
- BUG#4428

- modfying standard queue routines to handle problem and task style queu enteries

- adding get_users_in_queue

- eliminate passing of $cid

- better fix for the problem we saw last week with slot reservations
- use cput rather than put

- generalizing the add_to_queu

- de-appendix slots
   - new parm 'useslots' (problems defulat to no, Tasks default to resource)
   - make available and availablestudent exist for problems
   - problems uses check_slot_access
   - problems understand states of 'NOT_IN_A_SLOT' and 'NEEDS_CHECKIN'

- actually get the correct starttime

- new bridgetask randomization mode has been tested and works

- better handling of the Done Buttons and Tries/Submit button

- add_to_queue  now uses newput so as to not overwrite an existing entry
- buglet for publication
- add_to_queue on check_in explicitly

- enable 'show all foils'

- reworking how the randomization in a BT works, now saves away the instance picked and restores taht
- added ability to 'disable' an instance so that it will no longer get picked.

- Enabling CSTR actions on BT (EditXML / differnt randomizations / reset)

- link to the raw version of the handed in file

- allow use of a secret word rather than the password (optionally)

-make things easier for colorblind

- Move Done, Stop buttons and file links to a div at the top of the screen (as per request)

- not sure why I was ifing out construct there, but with the redirection calls it was mucking things up now
- meta mode was getting Dimension spew

- lock keys were being considered as real queue entries

- was showing the header bits twice on the done screen,
- file submission list looks better

- er, <instance> defines OptionalRequired not <Dimension>

- update to passing status info

- adding a Done screen and button

- add section restrivition info to the queue/user selct screens

- rember section restrictions

- only show up when webgrade succeeds

- put in information about when the submission actually occured

- add the ability to limit the display of the queues and the regrade list to a specfic secion or sections

- not allowed to do a regrade on a record in a slot still open

- moved the form to start after the internal messaging location (this way the 'request another slot' button works)

- only show status if they have passed or failed it

- switch to start time

- full task status info and dimension grading info is now given to the student

- modfying the result output to include manadatory/optional info

- don't make a new version on a regrade pass

- some code looks for a submission item, need to crete it even if it;s just empty

- missing .0. was making it so things weren't getting a reall .award assigned

- implement a quick regrade feature for BT
- fixes for blank grading
- mover the %perm handling in grades.pm to a couple of subroutines

- cleanup the file links

- <script> and <display> run during target 'webgrade'
- now delays evaluation of the <InstanceText> of an instance until after we have picked which one to do, and only evaluates that one.
- invalid status submissions are now counted as 'ungraded' rather than correct

- making the subit files box more noticable in BTs

- typo

- add in the student information to the proctor validation screen

- file links weren't displaying

- removing another fixed FIXME

- removing misleading and fixed FIXME

- add permission for bridgetask queue viewing

- versioning the portfoilio submission to a bridge task

- adding uniqueperiod - time period in which a another slot of an overlapping unique period can't be scheduled
- instructors can also see the full reservation table

- after requesting a new slot the 'request a new time' button disappears
- this requires a new slot info to be set 'startreserve'

- can now explictly go back the tohe current version of a task
- starting to wire up the 'schedule a new slot'

- don't allow graders to pick a resource that isn't ready for grading

- add more info about the grading queue status

- review queue fully functional as far as I can tell
- grading queue can also now be managed

- first pass at a review queue
   - review grading goes to the review queue
   - can select a record from the review queue
   - can resume grading a user from the review queue

- starting on review queue
   - if any 'review' toggles are set, user is moved lock stock and barrel to review queue
(still need some way of getting a user out of review queue)

- can now 'stop' grading (which submits the current data and grades it and frees the grader from any commitments)
- parameterize the 'gradingqueue' name

- show previous version works

- couple more version.0 tweaks
- need to reset standr lon-capa status bits on creation of new version

- full cycle of take -> grade -> fail -> take again -> grade again -> pass works

- some ' vs. " typos

- 'versioning' the stored data

- err whoops

- moving to versioning that datums seems like ti will be better in the future

- properly detect state of 'in grading queue' and show info screen
- properly detect state of graded and show criteria and pass/failed status
- grade things correctly

- got a successful grading done

- grding code written not yet tested though

- use the published id numbers

- poking at the grading interface

- whoops, supposed to grade people not in my section if available

- setup env so lonxml::whichuser returns data for user being graded
- need to reset rndseed, since we don't know til the end of <Task> who we are grading
- remember who we are grading

- if uploaded filetypes isn't set can upload any file
- added a lot of debuggin info
- actaully compiles now
- wroks correctly in the null case
- add non-fuctional submissions buttons to improve the look of grade mode
- if no user to grade don't show criteria

- adding gradding queus mechanism
   - submissions adds to grading queue
   - webgrade attempts to find a suitable user to grade and lock it to myself with proper error handling for a variety of failure modes (i.e tries to do a 2 phase commit)

- adding 'webgrade' target for bridgetasks

- was ignore ing the 'INVALID_FILETYPE' award change

- ENV -> env

- bridgetask responses are remebered

- making bridge tasks randomize whihc instance in a dimension is shown

- some cleanups/improvments to the file submission layout
- modularize the file submission code
- allow a user to submit a portfolio file

- remove the tables from the bridge task formatting

- clean up some code in bridgetask

- fixing up the studentphot to have a lonnet command
- making bridgetasks and outputtags use this command

- proctor checkin of user for bridge tasks works now.

- skelton of check_task_access there

- can now publish a bridge task

- can do a very simplistic rendering of a bridge task, doesn't actually implement any of the functionality, just puls it a part, picks the first <Instance> in a <Dimension> and wraps the <Criteria> in a <table> , enough to get started on implementing the proper acces controls logic