--- loncom/homework/caparesponse/caparesponse.pm 2004/02/26 21:13:54 1.136 +++ loncom/homework/caparesponse/caparesponse.pm 2004/03/12 18:41:43 1.140 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # caparesponse definition # -# $Id: caparesponse.pm,v 1.136 2004/02/26 21:13:54 sakharuk Exp $ +# $Id: caparesponse.pm,v 1.140 2004/03/12 18:41:43 albertel Exp $ # # Copyright Michigan State University Board of Trustees # @@ -99,7 +99,7 @@ sub end_numericalresponse { my $tag; if (scalar(@$tagstack)) { $tag=$$tagstack[-1]; } if ( $target eq 'grade' && defined($ENV{'form.submitted'})) { - &Apache::response::setup_params($tag); + &Apache::response::setup_params($tag,$safeeval); $safeeval->share_from('capa',['&caparesponse_capa_check_answer']); my $partid = $Apache::inputtags::part; my $id = $Apache::inputtags::response['-1']; @@ -133,26 +133,26 @@ sub end_numericalresponse { my $hideunit=&Apache::lonnet::EXT('resource.'.$partid.'_'.$id.'.turnoffunit'); foreach my $key (keys(%Apache::inputtags::params)) { - $expression.= ';my $'. #' + $expression.= ';my $__LC__'. #' $key.'="'.$Apache::inputtags::params{$key}.'"'; } #no way to enter units, with radio buttons if ($Apache::lonhomework::type eq 'exam' || lc($hideunit) eq "yes") { - $expression.=';my $unit=undef;'; + $expression.=';my $__LC__unit=undef;'; } #sig fig don't make much sense either if (($Apache::lonhomework::type eq 'exam' || $ENV{'form.submitted'} eq 'scantron') && $tag eq 'numericalresponse') { - $expression.=';my $sig=undef;'; + $expression.=';my $__LC__sig=undef;'; } if ($tag eq 'formularesponse') { - $expression.=';my $type="fml";'; + $expression.=';my $__LC__type="fml";'; } elsif ($tag eq 'numericalresponse') { - $expression.=';my $type="float";'; + $expression.=';my $__LC__type="float";'; } $expression.="');"; my @answer=&Apache::lonxml::get_param_var('answer',$parstack,$safeeval); @@ -298,7 +298,7 @@ sub end_numericalresponse { push (@{ $Apache::lonhomework::analyze{"$part_id.incorrect"} }, @incorrect); } if (scalar(@$tagstack)) { - &Apache::response::setup_params($tag); + &Apache::response::setup_params($tag,$safeeval); } my (@answers)=&Apache::lonxml::get_param_var('answer',$parstack,$safeeval); my (@formats)=&Apache::lonxml::get_param_var('format',$parstack,$safeeval); @@ -382,12 +382,14 @@ sub get_table_sizes { my $cell_width=0; foreach my $member (@$rbubble_values) { my $cell_width_real=0; - if ($member=~/(\d*)\.?(\d*)(E|e)(\+|-)?(\d*)/) { + if ($member=~/(\+|-)?(\d*)\.?(\d*)\s*\$\\times\s*10\^{(\+|-)?(\d+)}\$/) { + $cell_width_real=(length($2)+length($3)+length($5)+7)*$scale; + } elsif ($member=~/(\d*)\.?(\d*)(E|e)(\+|-)?(\d*)/) { $cell_width_real=(length($1)+length($2)+length($5)+9)*$scale; - } elsif ($member=~/(\d*)\.(\d*)/) { + } elsif ($member=~/(\d*)\.(\d*)/) { $cell_width_real=(length($1)+length($2)+3)*$scale; } else { - $cell_width_real=(length($member)+1)*$scale; + $cell_width_real=(length($member)+1)*$scale*0.9; } if ($cell_width_real>$cell_width) {$cell_width=$cell_width_real;} } @@ -461,8 +463,8 @@ sub make_numerical_bubbles { &Apache::lonxml::debug("Answer was :$answer: returning :".$#bubble_values.": whih are :".join(':',@bubble_values)); &Math::Random::random_set_seed(@oldseed); if (defined($format) && $format ne '') { - for(my $i=0;$i<=$#bubble_values;$i++) { - $bubble_values[$i]=&format_number($bubble_values[$i],$format,$target); + foreach my $value (@bubble_values) { + $value=&format_number($value,$format,$target); } } return @bubble_values; @@ -580,7 +582,7 @@ sub end_stringresponse { &Apache::lonxml::default_homework_load($safeeval); } if ( $target eq 'grade' && defined($ENV{'form.submitted'})) { - &Apache::response::setup_params('stringresponse'); + &Apache::response::setup_params('stringresponse',$safeeval); $safeeval->share_from('capa',['&caparesponse_capa_check_answer']); if ($Apache::lonhomework::type eq 'exam' || $ENV{'form.submitted'} eq 'scantron') { @@ -657,7 +659,7 @@ sub end_stringresponse { push (@{ $Apache::lonhomework::analyze{"parts"} },"$part.$id"); $Apache::lonhomework::analyze{"$part.$id.type"} = 'stringresponse'; } - &Apache::response::setup_params('stringresponse'); + &Apache::response::setup_params('stringresponse',$safeeval); if ($target eq 'answer') { $result.=&Apache::response::answer_header('stringresponse'); }