--- loncom/homework/caparesponse/caparesponse.pm 2004/06/04 22:06:07 1.146
+++ loncom/homework/caparesponse/caparesponse.pm 2007/03/01 02:31:29 1.209
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# caparesponse definition
#
-# $Id: caparesponse.pm,v 1.146 2004/06/04 22:06:07 albertel Exp $
+# $Id: caparesponse.pm,v 1.209 2007/03/01 02:31:29 albertel Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -29,23 +29,247 @@
package Apache::caparesponse;
use strict;
use capa;
+use Safe::Hole;
+use Apache::lonmaxima();
use Apache::lonlocal;
+use Apache::lonnet;
+use Apache::response();
+use Storable qw(dclone);
BEGIN {
- &Apache::lonxml::register('Apache::caparesponse',('caparesponse','numericalresponse','stringresponse','formularesponse'));
+ &Apache::lonxml::register('Apache::caparesponse',('numericalresponse','stringresponse','formularesponse'));
+}
+
+my %answer;
+my @answers;
+sub get_answer { return %answer; };
+sub push_answer{ push(@answers,dclone(\%answer)); undef(%answer) }
+sub pop_answer { %answer = %{pop(@answers)}; };
+
+my $cur_name;
+my $tag_internal_answer_name = 'INTERNAL';
+
+sub start_answer {
+ my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;
+ my $result;
+ $cur_name = &Apache::lonxml::get_param('name',$parstack,$safeeval);
+ if ($cur_name =~ /^\s*$/) { $cur_name = $Apache::lonxml::curdepth; }
+ my $type = &Apache::lonxml::get_param('type',$parstack,$safeeval);
+ if (!defined($type) && $tagstack->[-2] eq 'answergroup') {
+ $type = &Apache::lonxml::get_param('type',$parstack,$safeeval,-2);
+ }
+ if (!defined($type)) { $type = 'ordered' };
+ $answer{$cur_name}= { 'type' => $type,
+ 'answers' => [] };
+ if ($target eq 'edit') {
+ $result.=&Apache::edit::tag_start($target,$token);
+ $result.=&Apache::edit::text_arg('Name:','name',$token);
+ $result.=&Apache::edit::select_arg('Type:','type',
+ [['ordered', 'Ordered' ],
+ ['unordered','Unordered'],],
+ $token);
+ $result.=&Apache::edit::end_row().&Apache::edit::start_spanning_row();
+ } elsif ($target eq 'modified') {
+ my $constructtag = &Apache::edit::get_new_args($token,$parstack,
+ $safeeval,'name',
+ 'type');
+ if ($constructtag) {
+ $result = &Apache::edit::rebuild_tag($token);
+ $result.= &Apache::edit::handle_insert();
+ }
+ }
+ return $result;
+}
+
+sub end_answer {
+ my ($target,$token,$tagstack,$parstack,$parser,$safeeval)=@_;
+ my $result;
+ if ($target eq 'edit') {
+ $result .= &Apache::edit::tag_end();
+ }
+
+ undef($cur_name);
+ return $result;
+}
+
+sub insert_answer {
+ return '
+
";
+ if ($unit=~/\$/) { $format="\$".$format; $unit=~s/\$//g; }
+ if ($unit=~/\,/) { $format="\,".$format; $unit=~s/\,//g; }
+ my $formatted=&format_number($element,$format,$target,
+ $safeeval);
+ $answertxt.=' '.$formatted.',';
}
- $Apache::inputtags::answertxt{$id}=$answertxt;
+
}
+ chop($answertxt);
+ if ($target eq 'web') {
+ $answertxt.=" $unit ";
+ }
+
+ push(@answertxt,$answertxt)
}
- return $result;
+
+ my $id = $Apache::inputtags::response[-1];
+ $Apache::inputtags::answertxt{$id}=\@answertxt;
+}
+
+sub setup_capa_args {
+ my ($safeeval,$parstack,$args,$response) = @_;
+ my $args_ref= \%{$safeeval->varglob('LONCAPA::CAPAresponse_args')};
+ undef(%{ $args_ref });
+
+ foreach my $arg (@{$args}) {
+ $$args_ref{$arg}=
+ &Apache::lonxml::get_param($arg,$parstack,$safeeval);
+ }
+ foreach my $key (keys(%Apache::inputtags::params)) {
+ $$args_ref{$key}=$Apache::inputtags::params{$key};
+ }
+ &setup_capa_response($args_ref,$response);
+ return $args_ref;
+}
+
+sub setup_capa_response {
+ my ($args_ref,$response) = @_;
+
+ use Data::Dumper;
+ &Apache::lonxml::debug("response dump is ".&Dumper($response));
+
+ if (ref($response)) {
+ $$args_ref{'response'}=dclone($response);
+ } else {
+ $$args_ref{'response'}=dclone([$response]);
+ }
+}
+
+sub check_submission {
+ my ($response,$partid,$id,$tag,$parstack,$safeeval,$ignore_sig)=@_;
+ my @args = ('type','tol','sig','format','unit','calc','samples');
+ my $args_ref = &setup_capa_args($safeeval,$parstack,\@args,$response);
+
+ my $hideunit=
+ &Apache::lonnet::EXT('resource.'.$partid.'_'.$id.'.turnoffunit');
+ #no way to enter units, with radio buttons
+ if ($Apache::lonhomework::type eq 'exam' ||
+ lc($hideunit) eq "yes") {
+ delete($$args_ref{'unit'});
+ }
+ #sig fig don't make much sense either
+ if (($Apache::lonhomework::type eq 'exam' ||
+ &Apache::response::submitted('scantron') ||
+ $ignore_sig) &&
+ $tag eq 'numericalresponse') {
+ delete($$args_ref{'sig'});
+ }
+
+ if ($tag eq 'formularesponse') {
+ if ($$args_ref{'samples'}) {
+ $$args_ref{'type'}='fml';
+ } else {
+ $$args_ref{'type'}='math';
+ }
+ } elsif ($tag eq 'numericalresponse') {
+ $$args_ref{'type'}='float';
+ }
+
+ &add_in_tag_answer($parstack,$safeeval);
+
+ my (@final_awards,@final_msgs,@names);
+ foreach my $name (keys(%answer)) {
+ &Apache::lonxml::debug(" doing $name with ".join(':',@{ $answer{$name}{'answers'} }));
+
+ ${$safeeval->varglob('LONCAPA::CAPAresponse_answer')}=dclone($answer{$name});
+ &setup_capa_response($args_ref,$response);
+ use Time::HiRes;
+ my $t0 = [Time::HiRes::gettimeofday()];
+ my ($result,@msgs) =
+ &Apache::run::run("&caparesponse_check_list()",$safeeval);
+ &Apache::lonxml::debug("checking $name $result with $response took ".&Time::HiRes::tv_interval($t0));
+ &Apache::lonxml::debug('msgs are '.join(':',@msgs));
+ my ($awards)=split(/:/,$result);
+ my @awards= split(/,/,$awards);
+ my ($ad, $msg) = &Apache::inputtags::finalizeawards(\@awards,\@msgs);
+ push(@final_awards,$ad);
+ push(@final_msgs,$msg);
+ push(@names,$name);
+ }
+ my ($ad, $msg, $name) = &Apache::inputtags::finalizeawards(\@final_awards,
+ \@final_msgs,
+ \@names,1);
+ &Apache::lonxml::debug(" name of picked award is $name from ".join(', ',@names));
+ return($ad,$msg, $name);
+}
+
+sub add_in_tag_answer {
+ my ($parstack,$safeeval,$response_level) = @_;
+ my @answer=&Apache::lonxml::get_param_var('answer',$parstack,$safeeval,
+ $response_level);
+ &Apache::lonxml::debug('answer is'.join(':',@answer));
+ if (@answer && defined($answer[0])) {
+ $answer{$tag_internal_answer_name}= {'type' => 'ordered',
+ 'answers' => [\@answer] };
+ }
+}
+
+sub capa_formula_fix {
+ my ($expression)=@_;
+ return &Apache::response::implicit_multiplication($expression);
}
sub end_numericalresponse {
my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
+
+ &Apache::lonxml::deregister('Apache::caparesponse',
+ ('answer','answergroup','value','array','unit',
+ 'vector'));
+ pop(@Apache::lonxml::namespace);
+
my $increment=1;
my $result = '';
if (!$Apache::lonxml::default_homework_loaded) {
&Apache::lonxml::default_homework_load($safeeval);
}
+ my $partid = $Apache::inputtags::part;
+ my $id = $Apache::inputtags::response[-1];
my $tag;
+ my $safehole = new Safe::Hole;
+ $safeeval->share_from('capa',['&caparesponse_capa_check_answer']);
+
if (scalar(@$tagstack)) { $tag=$$tagstack[-1]; }
- if ( $target eq 'grade' && defined($ENV{'form.submitted'})) {
+ if ( $target eq 'grade' && &Apache::response::submitted() ) {
&Apache::response::setup_params($tag,$safeeval);
- $safeeval->share_from('capa',['&caparesponse_capa_check_answer']);
- my $partid = $Apache::inputtags::part;
- my $id = $Apache::inputtags::response['-1'];
if ($Apache::lonhomework::type eq 'exam' &&
- $tag eq 'formularesponse') {
+ (($tag eq 'formularesponse') || ($tag eq 'mathresponse'))) {
$increment=&Apache::response::scored_response($partid,$id);
} else {
my $response = &Apache::response::getresponse();
if ( $response =~ /[^\s]/) {
- my $ad;
my %previous = &Apache::response::check_for_previous($response,$partid,$id);
&Apache::lonxml::debug("submitted a $response
\n");
&Apache::lonxml::debug($$parstack[-1] . "\n
");
- if ($ENV{'form.submitted'} eq 'scantron') {
- my $number_of_bubbles = &Apache::lonnet::EXT('resource.'.$partid.'_'.$id.'.numbubbles');
- if (!$number_of_bubbles) { $number_of_bubbles=8; }
- my (@formats)=&Apache::lonxml::get_param_var('format',$parstack,$safeeval);
- my (@answers)=&Apache::lonxml::get_param_var('answer',$parstack,$safeeval);
- my (@incorrect)=&Apache::lonxml::get_param_var('incorrect',$parstack,$safeeval);
- my @values=&make_numerical_bubbles($number_of_bubbles,$target,$answers[0],$formats[0],\@incorrect);
- $response=$values[$response];
+ if ( &Apache::response::submitted('scantron')) {
+ &add_in_tag_answer($parstack,$safeeval);
+ my ($values,$display)=&make_numerical_bubbles($partid,$id,
+ $target,$parstack,$safeeval);
+ $response=$values->[$response];
}
$Apache::lonhomework::results{"resource.$partid.$id.submission"}=$response;
- my $args_ref= \%{$safeeval->varglob('LONCAPA::CAPAresponse_args')};
- $$args_ref{'response'}=$response;
- my $hideunit=&Apache::lonnet::EXT('resource.'.$partid.'_'.$id.'.turnoffunit');
-
- foreach my $arg ('type','tol','sig','ans_fmt','unit','calc',
- 'samples') {
- $$args_ref{$arg}=
- &Apache::lonxml::get_param($arg,$parstack,$safeeval);
- }
- foreach my $key (keys(%Apache::inputtags::params)) {
- $$args_ref{$key}=$Apache::inputtags::params{$key};
- }
-
- #no way to enter units, with radio buttons
- if ($Apache::lonhomework::type eq 'exam' ||
- lc($hideunit) eq "yes") {
- delete($$args_ref{'unit'});
- }
- #sig fig don't make much sense either
- if (($Apache::lonhomework::type eq 'exam' ||
- $ENV{'form.submitted'} eq 'scantron') &&
- $tag eq 'numericalresponse') {
- delete($$args_ref{'sig'});
- }
+ my ($ad,$msg,$name)=&check_submission($response,$partid,$id,
+ $tag,$parstack,
+ $safeeval);
- if ($tag eq 'formularesponse') {
- $$args_ref{'type'}='fml';
- } elsif ($tag eq 'numericalresponse') {
- $$args_ref{'type'}='float';
- }
- my @answer=&Apache::lonxml::get_param_var('answer',$parstack,$safeeval);
- &Apache::lonxml::debug('answer is'.join(':',@answer));
- @{$safeeval->varglob('LONCAPA::CAPAresponse_answer')}=@answer;
-
- ($result,my @msgs) =
- &Apache::run::run("&caparesponse_check_list()",$safeeval);
- &Apache::lonxml::debug('msgs are'.join(':',@msgs));
- my ($awards)=split(/:/,$result);
- my (@awards) = split(/,/,$awards);
- ($ad,my $msg) = &Apache::inputtags::finalizeawards(\@awards,\@msgs);
&Apache::lonxml::debug('ad is'.$ad);
if ($ad eq 'SIG_FAIL') {
my ($sig_u,$sig_l)=
@@ -207,34 +528,31 @@ sub end_numericalresponse {
$Apache::inputtags::params{'sig'});
}
&Apache::lonxml::debug("\n
result:$result:$Apache::lonxml::curdepth
\n");
+ if ($Apache::lonhomework::type eq 'survey' &&
+ ($ad eq 'INCORRECT' || $ad eq 'APPROX_ANS' ||
+ $ad eq 'EXACT_ANS')) {
+ $ad='SUBMITTED';
+ }
&Apache::response::handle_previous(\%previous,$ad);
$Apache::lonhomework::results{"resource.$partid.$id.awarddetail"}=$ad;
$Apache::lonhomework::results{"resource.$partid.$id.awardmsg"}=$msg;
+ $Apache::lonhomework::results{"resource.$partid.$id.answername"}=$name;
$result='';
}
}
} elsif ($target eq 'web' || $target eq 'tex') {
- my (@answers)=&Apache::lonxml::get_param_var('answer',$parstack,
- $safeeval);
+ &check_for_answer_errors($parstack,$safeeval);
my $award = $Apache::lonhomework::history{"resource.$Apache::inputtags::part.solved"};
my $status = $Apache::inputtags::status['-1'];
if ($Apache::lonhomework::type eq 'exam') {
- my $partid=$Apache::inputtags::part;
- my $id=$Apache::inputtags::response[-1];
- my $number_of_bubbles = &Apache::lonnet::EXT('resource.'.$partid.'_'.$id.'.numbubbles');
- if ($Apache::inputtags::params{'numbubbles'}) {
- $number_of_bubbles = $Apache::inputtags::params{'numbubbles'};
- }
- if (!$number_of_bubbles) { $number_of_bubbles=8; }
-
- my (@formats)=&Apache::lonxml::get_param_var('format',$parstack,
- $safeeval);
+ # FIXME support multi dimensional numerical problems
+ # in exam bubbles
+ my ($bubble_values,$bubble_display)=
+ &make_numerical_bubbles($partid,$id,$target,$parstack,
+ $safeeval);
+ my $number_of_bubbles = scalar(@{ $bubble_values });
my $unit=&Apache::lonxml::get_param_var('unit',$parstack,
$safeeval);
- my (@incorrect)=&Apache::lonxml::get_param_var('incorrect',$parstack,$safeeval);
- my @bubble_values=&make_numerical_bubbles($number_of_bubbles,
- $target,$answers[0],
- $formats[0],\@incorrect);
my @alphabet=('A'..'Z');
if ($target eq 'web') {
if ($tag eq 'numericalresponse') {
@@ -243,19 +561,15 @@ sub end_numericalresponse {
my $previous=$Apache::lonhomework::history{"resource.$Apache::inputtags::part.$id.submission"};
for (my $ind=0;$ind<$number_of_bubbles;$ind++) {
my $checked='';
- if ($previous eq $bubble_values[$ind]) {
+ if ($previous eq $bubble_values->[$ind]) {
$checked=" checked='on' ";
}
$result.='
'.&HTML::Entities::encode($Apache::lonhomework::history{$key}, + '"<>&').''; + } +} + +sub check_for_answer_errors { + my ($parstack,$safeeval) = @_; + &add_in_tag_answer($parstack,$safeeval); + my %counts; + foreach my $name (keys(%answer)) { + push(@{$counts{scalar(@{$answer{$name}{'answers'}})}},$name); + } + if (scalar(keys(%counts)) > 1) { + my $counts = join(' ',map { + my $count = $_; + &mt("Answers [_1] had [_2] components.", + ''.join(', ',@{$counts{$count}}).'', + $count); + } (sort(keys(%counts)))); + &Apache::lonxml::error(&mt("All answers must have the same number of components. Varying numbers of answers were seen. ").$counts); + } + use Data::Dumper; + &Apache::lonxml::debug("count dump is ".&Dumper(\%counts)); + my $expected_number_of_inputs = (keys(%counts))[0]; + if ( $expected_number_of_inputs != scalar(@Apache::inputtags::inputlist)) { + &Apache::lonxml::error(&mt("Expected [_1] input fields, but there were only [_2] seen.", + $expected_number_of_inputs, + scalar(@Apache::inputtags::inputlist))); + } +} + sub get_table_sizes { my ($number_of_bubbles,$rbubble_values)=@_; my $scale=2; #mm for one digit my $cell_width=0; foreach my $member (@$rbubble_values) { my $cell_width_real=0; - if ($member=~/(\+|-)?(\d*)\.?(\d*)\s*\$\\times\s*10\^{(\+|-)?(\d+)}\$/) { + if ($member=~/(\+|-)?(\d*)\.?(\d*)\s*\$?\\times\s*10\^{(\+|-)?(\d+)}\$?/) { $cell_width_real=(length($2)+length($3)+length($5)+7)*$scale; } elsif ($member=~/(\d*)\.?(\d*)(E|e)(\+|-)?(\d*)/) { $cell_width_real=(length($1)+length($2)+length($5)+9)*$scale; @@ -403,15 +850,17 @@ sub get_table_sizes { } $cell_width+=8; my $textwidth; - if ($ENV{'form.textwidth'} ne '') { - $ENV{'form.textwidth'}=~/(\d*)\.?(\d*)/; + if ($env{'form.textwidth'} ne '') { + $env{'form.textwidth'}=~/(\d*)\.?(\d*)/; $textwidth=$1.'.'.$2; } else { - $ENV{'textwidth'}=~/(\d+)\.?(\d*)/; + $env{'form.textwidth'}=~/(\d+)\.?(\d*)/; $textwidth=$1.'.'.$2; } my $bubbles_per_line=int($textwidth/$cell_width); - if (($bubbles_per_line > $number_of_bubbles/2) && ($number_of_bubbles % 2==0)) {$bubbles_per_line=$number_of_bubbles/2;} + if ($bubbles_per_line > $number_of_bubbles) { + $bubbles_per_line=$number_of_bubbles; + }elsif (($bubbles_per_line > $number_of_bubbles/2) && ($number_of_bubbles % 2==0)) {$bubbles_per_line=$number_of_bubbles/2;} my $number_of_tables = int($number_of_bubbles/$bubbles_per_line); my @table_range = (); for (my $i=0;$i<$number_of_tables;$i++) {push @table_range,$bubbles_per_line;} @@ -425,61 +874,87 @@ sub get_table_sizes { } sub format_number { - my ($number,$format,$target)=@_; + my ($number,$format,$target,$safeeval)=@_; my $ans; - if ($format ne '') { - $format=~s/e/E/g; - $ans = sprintf('%.'.$format,$number); - } else { - my $format = ''; + if ($format eq '') { #What is the number? (integer,decimal,floating point) - if ($number=~/^(\d*\.?\d*)(E|e)(\d*)$/) { + if ($number=~/^(\d*\.?\d*)(E|e)[+\-]?(\d*)$/) { $format = '3e'; } elsif ($number=~/^(\d*)\.(\d*)$/) { $format = '4f'; } elsif ($number=~/^(\d*)$/) { $format = 'd'; } - $ans = sprintf('%.'.$format,$number); } - if ($target eq 'tex') { - if ($ans =~ m/([0-9\.\-\+]+)E([0-9\-\+]+)/ ) { - my $number = $1; - my $power = $2; - $power=~s/^\+//; - $power=~s/^(-?)0+(\d+)/$1$2/; - $ans=$number.'$\times 10^{'.$power.'}$'; #'stupidemacs - } + if (!$Apache::lonxml::default_homework_loaded) { + &Apache::lonxml::default_homework_load($safeeval); } + $ans=&Apache::run::run("&prettyprint(q\0$number\0,q\0$format\0,q\0$target\0)",$safeeval); return $ans; } sub make_numerical_bubbles { - my ($number_of_bubbles,$target,$answer,$format,$incorrect) =@_; - my @bubble_values = (); - &Apache::lonxml::debug("answer is $answer incorrect is $incorrect"); + my ($part,$id,$target,$parstack,$safeeval) =@_; + + my $number_of_bubbles = + &Apache::response::get_response_param($part.'_'.$id,'numbubbles',8); + + my ($format)=&Apache::lonxml::get_param_var('format',$parstack,$safeeval); + my $name = (exists($answer{$tag_internal_answer_name}) + ? $tag_internal_answer_name + : (sort(keys(%answer)))[0]); + + if ( scalar(@{$answer{$name}{'answers'}}) > 1) { + &Apache::lonxml::error("Only answers with 1 component are supported in exam mode"); + } + if (scalar(@{$answer{$name}{'answers'}[0]}) > 1) { + &Apache::lonxml::error("Vector answers are unsupported in exam mode."); + } + + my $answer = $answer{$name}{'answers'}[0][0]; + my (@incorrect)=&Apache::lonxml::get_param_var('incorrect',$parstack, + $safeeval); + if ($#incorrect eq 0) { @incorrect=(split(/,/,$incorrect[0])); } + + my @bubble_values=(); + my @alphabet=('A'..'Z'); + + &Apache::lonxml::debug("answer is $answer incorrect is @incorrect"); my @oldseed=&Math::Random::random_get_seed(); - if (defined($incorrect) && ref($incorrect)) { - &Apache::lonxml::debug("inside ".(scalar(@$incorrect)+1 gt $number_of_bubbles)); - if (defined($$incorrect[0]) && - scalar(@$incorrect)+1 >= $number_of_bubbles) { - &Apache::lonxml::debug("inside ".(scalar(@$incorrect)+1).":$number_of_bubbles"); + if (@incorrect) { + &Apache::lonxml::debug("inside ".(scalar(@incorrect)+1 gt $number_of_bubbles)); + if (defined($incorrect[0]) && + scalar(@incorrect)+1 >= $number_of_bubbles) { + &Apache::lonxml::debug("inside ".(scalar(@incorrect)+1).":$number_of_bubbles"); &Apache::response::setrandomnumber(); - my @rand_inc=&Math::Random::random_permutation(@$incorrect); + my @rand_inc=&Math::Random::random_permutation(@incorrect); @bubble_values=@rand_inc[0..($number_of_bubbles-2)]; @bubble_values=sort {$a <=> $b} (@bubble_values,$answer); - &Apache::lonxml::debug("Answer was :$answer: returning :".$#bubble_values.": whih are :".join(':',@bubble_values)); + &Apache::lonxml::debug("Answer was :$answer: returning :".$#bubble_values.": which are :".join(':',@bubble_values)); &Math::Random::random_set_seed(@oldseed); + + my $correct; + for(my $i=0; $i<=$#bubble_values;$i++) { + if ($bubble_values[$i] eq $answer) { + $correct = $alphabet[$i]; + last; + } + } + if (defined($format) && $format ne '') { + my @bubble_display; foreach my $value (@bubble_values) { - $value=&format_number($value,$format,$target); + push(@bubble_display, + &format_number($value,$format,$target,$safeeval)); } + return (\@bubble_values,\@bubble_display,$correct); + } else { + return (\@bubble_values,\@bubble_values,$correct); } - return @bubble_values; } - if (defined($$incorrect[0]) && - scalar(@$incorrect)+1 < $number_of_bubbles) { - &Apache::lonxml::warning("Not enough incorrect answers were specified in the incorrect array, ignoring the specified incorrect answers and instead generating them."); + if (defined($incorrect[0]) && + scalar(@incorrect)+1 < $number_of_bubbles) { + &Apache::lonxml::warning("Not enough incorrect answers were specified in the incorrect array, ignoring the specified incorrect answers and instead generating them (".join(',',@incorrect).")."); } } my @factors = (1.13,1.17,1.25,1.33,1.45); #default values of factors @@ -489,14 +964,16 @@ sub make_numerical_bubbles { my $power = $powers[$ind]; $ind=&Math::Random::random_uniform_integer(1,0,$#factors); my $factor = $factors[$ind]; + my @bubble_display; for ($ind=0;$ind<$number_of_bubbles;$ind++) { $bubble_values[$ind] = $answer*($factor**($power-$powers[$#powers-$ind])); - $bubble_values[$ind] = &format_number($bubble_values[$ind], - $format,$target); + $bubble_display[$ind] = &format_number($bubble_values[$ind], + $format,$target,$safeeval); } + my $correct = $alphabet[$number_of_bubbles-$power]; &Math::Random::random_set_seed(@oldseed); - return @bubble_values; + return (\@bubble_values,\@bubble_display,$correct); } sub get_tolrange { @@ -516,7 +993,11 @@ sub get_tolrange { sub get_sigrange { my ($sig)=@_; - &Apache::lonxml::debug("Got a sig of :$sig:"); + #&Apache::lonxml::debug("Got a sig of :$sig:"); + my $courseid=$env{'request.course.id'}; + if (lc($env{"course.$courseid.disablesigfigs"}) eq 'yes') { + return (15,0); + } my $sig_lbound; my $sig_ubound; if ($sig eq '') { @@ -534,7 +1015,7 @@ sub get_sigrange { ($sig_lbound > 15) || ($sig =~/(\+|-)/ ) ) { my $errormsg=&mt("Invalid Significant figures detected")." ($sig)"; - if ($ENV{'request.state'} eq 'construct') { + if ($env{'request.state'} eq 'construct') { $errormsg.= &Apache::loncommon::help_open_topic('Significant_Figures'); } @@ -548,9 +1029,7 @@ sub start_stringresponse { my $result; my $id = &Apache::response::start_response($parstack,$safeeval); if ($target eq 'meta') { - &Apache::response::start_response($parstack,$safeeval); $result=&Apache::response::meta_package_write('stringresponse'); - &Apache::response::end_response(); } elsif ($target eq 'edit') { $result.=&Apache::edit::tag_start($target,$token); $result.=&Apache::edit::text_arg('Answer:','answer',$token); @@ -558,6 +1037,8 @@ sub start_stringresponse { [['cs','Case Sensitive'],['ci','Case Insensitive'], ['mc','Case Insensitive, Any Order'], ['re','Regular Expression']],$token); + $result.=&Apache::edit::text_arg('String to display for answer:', + 'answerdisplay',$token); $result.=&Apache::edit::end_row().&Apache::edit::start_spanning_row(); } elsif ($target eq 'modified') { my $constructtag; @@ -570,8 +1051,13 @@ sub start_stringresponse { } } elsif ($target eq 'web') { if ( &Apache::response::show_answer() ) { - $Apache::inputtags::answertxt{$id}= - &Apache::lonxml::get_param('answer',$parstack,$safeeval); + my $answer= + &Apache::lonxml::get_param('answerdisplay',$parstack,$safeeval); + if (!defined $answer || $answer eq '') { + $answer= + &Apache::lonxml::get_param('answer',$parstack,$safeeval); + } + $Apache::inputtags::answertxt{$id}=[$answer]; } } elsif ($target eq 'answer' || $target eq 'grade') { &Apache::response::reset_params(); @@ -581,7 +1067,7 @@ sub start_stringresponse { sub end_stringresponse { my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_; - my $increment=1; + my $result = ''; my $part=$Apache::inputtags::part; my $id=$Apache::inputtags::response[-1]; @@ -592,12 +1078,13 @@ sub end_stringresponse { if (!$Apache::lonxml::default_homework_loaded) { &Apache::lonxml::default_homework_load($safeeval); } - if ( $target eq 'grade' && defined($ENV{'form.submitted'})) { + if ( $target eq 'grade' && &Apache::response::submitted() ) { &Apache::response::setup_params('stringresponse',$safeeval); $safeeval->share_from('capa',['&caparesponse_capa_check_answer']); if ($Apache::lonhomework::type eq 'exam' || - $ENV{'form.submitted'} eq 'scantron') { - $increment=&Apache::response::scored_response($part,$id); + &Apache::response::submitted('scantron')) { + &Apache::response::scored_response($part,$id); + } else { my $response = &Apache::response::getresponse(); if ( $response =~ /[^\s]/) { @@ -616,65 +1103,77 @@ sub end_stringresponse { # $answer=$token->[2]->{'answer'}; # } ${$safeeval->varglob('LONCAPA::response')}=$response; - $result = &Apache::run::run('return $LONCAPA::response=~m'.$answer,$safeeval); + $result = &Apache::run::run('if ($LONCAPA::response=~m'.$answer.') { return 1; } else { return 0; }',$safeeval); &Apache::lonxml::debug("current $response"); &Apache::lonxml::debug("current $answer"); $ad = ($result) ? 'APPROX_ANS' : 'INCORRECT'; } else { - my $args_ref= - \%{$safeeval->varglob('LONCAPA::CAPAresponse_args')}; - - $$args_ref{'response'}=$response; - &Apache::lonxml::debug("current $response"); - $$args_ref{'type'}= - &Apache::lonxml::get_param('type',$parstack,$safeeval); - foreach my $key (keys(%Apache::inputtags::params)) { - $$args_ref{$key}=$Apache::inputtags::params{$key}; + my @args = ('type'); + my $args_ref = &setup_capa_args($safeeval,$parstack, + \@args,$response); + + &add_in_tag_answer($parstack,$safeeval); + my (@final_awards,@final_msgs,@names); + foreach my $name (keys(%answer)) { + &Apache::lonxml::debug(" doing $name with ".join(':',@{ $answer{$name}{'answers'} })); + ${$safeeval->varglob('LONCAPA::CAPAresponse_answer')}=dclone($answer{$name}); + my ($result, @msgs)=&Apache::run::run("&caparesponse_check_list()",$safeeval); + &Apache::lonxml::debug('msgs are'.join(':',@msgs)); + my ($awards)=split(/:/,$result); + my (@awards) = split(/,/,$awards); + ($ad,$msg) = + &Apache::inputtags::finalizeawards(\@awards,\@msgs); + push(@final_awards,$ad); + push(@final_msgs,$msg); + push(@names,$name); + &Apache::lonxml::debug("\n