--- loncom/homework/chemresponse.pm	2004/08/10 18:05:12	1.37
+++ loncom/homework/chemresponse.pm	2005/04/22 14:10:47	1.51
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # chemical equation style response
 #
-# $Id: chemresponse.pm,v 1.37 2004/08/10 18:05:12 albertel Exp $
+# $Id: chemresponse.pm,v 1.51 2005/04/22 14:10:47 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -32,7 +32,7 @@ use Apache::lonxml;
 use Apache::lonnet;
 
 BEGIN {
-    &Apache::lonxml::register('Apache::chemresponse',('organicresponse','organicstructure','reactionresponse'));
+    &Apache::lonxml::register('Apache::chemresponse',('organicresponse','organicstructure','reactionresponse','chem'));
 }
 
 sub chem_standard_order {
@@ -84,7 +84,7 @@ JMESECTION
 <html>
 <head>
 <title>Molecule Editor</title>
-<script language="JavaScript">
+<script type="text/javascript">
 function submitSmiles() {
     jmeFile = document.applets.JME.jmeFile();
     if (jmeFile == "") {
@@ -107,13 +107,13 @@ You have to enable Java and JavaScript o
 $molecule
 <param name="options" value="$options" />
 </applet><br />
-<font face="arial,helvetica,sans-serif" size=-1><a href="http://www.molinspiration.com/jme/index.html">JME Editor</a> courtesy of Peter Ertl, Novartis</font>
+<font face="arial,helvetica,sans-serif" size="-1"><a href="http://www.molinspiration.com/jme/index.html">JME Editor</a> courtesy of Peter Ertl, Novartis</font>
 <form>
-<input type="button" name="submit" value="Insert Answer" onClick = "submitSmiles();" />
+<input type="button" name="submit" value="Insert Answer" onclick = "submitSmiles();" />
 <br />
-<input type="button" value="  Close  " onClick = "window.close()" />
+<input type="button" value="  Close  " onclick = "window.close()" />
 &nbsp;&nbsp;
-<input type="button" value="  Help  " onClick = "openHelpWindow()" />
+<input type="button" value="  Help  " onclick = "openHelpWindow()" />
 </form>
 </center>
 </body>
@@ -121,8 +121,9 @@ $molecule
 CHEMPAGE
     $body=&HTML::Entities::encode($body,'<>&"');
     $body=~s/\n/ /g;
+    my $docopen=&Apache::lonhtmlcommon::javascript_docopen();
     my $result=<<CHEMINPUT;
-<input type="button" value="Draw Molecule" onClick="javascript:editor=window.open('','','width=500,height=500,scrollbars=no,resizable=yes');editor.document.open('text/html','replace');editor.document.writeln('$body')" />
+<input type="button" value="Draw Molecule" onclick="javascript:editor=window.open('/rat/adm/empty.html','jmeedit','width=500,height=500,menubar=yes,scrollbars=no,resizable=yes');editor.$docopen;editor.document.write('$body');editor.document.close();editor.focus()" />
 CHEMINPUT
     return $result;
 }
@@ -135,17 +136,34 @@ sub start_organicresponse {
     if ($target eq 'meta') {
 	$result=&Apache::response::meta_package_write('organicresponse');
     } elsif ($target eq 'web') {
-	my $molecule;
-	if (defined($Apache::lonhomework::history{"resource.$partid.$id.molecule"})) {
-	    $molecule=$Apache::lonhomework::history{"resource.$partid.$id.molecule"};
+	if (  &Apache::response::show_answer() ) {
+	    my $jmeanswer=&Apache::lonxml::get_param('jmeanswer',$parstack,
+						     $safeeval);
+	    my $options=&Apache::lonxml::get_param('options',$parstack,
+						   $safeeval);
+	    my $width=&Apache::lonxml::get_param('width',$parstack,
+						   $safeeval);
+	    my $id=&Apache::loncommon::get_cgi_id();
+	    $result="<img src='/cgi-bin/convertjme.pl?$id'";
+	    if ($options =~ /border/) { $result.= ' border="1"'; }
+	    $result.=' />';
+	    &Apache::lonnet::appenv('cgi.'.$id.'.JME'   =>
+				           &Apache::lonnet::escape($jmeanswer),
+				    'cgi.'.$id.'.PNG'   => 1,
+				    'cgi.'.$id.'.WIDTH' => $width);
 	} else {
-	    $molecule=&Apache::lonxml::get_param('molecule',$parstack,
-						 $safeeval);
+	    my $molecule;
+	    if (defined($Apache::lonhomework::history{"resource.$partid.$id.molecule"})) {
+		$molecule=$Apache::lonhomework::history{"resource.$partid.$id.molecule"};
+	    } else {
+		$molecule=&Apache::lonxml::get_param('molecule',$parstack,
+						     $safeeval);
+	    }
+	    my $options=&Apache::lonxml::get_param('options',$parstack,
+						   $safeeval);
+	    $result=&separate_jme_window("HWVAL_$id","MOLECULE_$id",$molecule,$options);
+	    $result.= '<input type="hidden" name="MOLECULE_'.$id.'" value="" />';
 	}
-	my $options=&Apache::lonxml::get_param('options',$parstack,
-					       $safeeval);
-	$result=&separate_jme_window("HWVAL_$id","MOLECULE_$id",$molecule,$options);
-	$result.= '<input type="hidden" name="MOLECULE_'.$id.'" value="" />';
     } elsif ($target eq 'edit') {
 	$result .=&Apache::edit::tag_start($target,$token);
 	my $options=&Apache::lonxml::get_param('options',$parstack,
@@ -177,12 +195,14 @@ sub start_organicresponse {
 				      ['reaction','Is a reaction'],
 				      ['number','Able to number atoms'] ],
 					     ,$token);
+	$result .=&Apache::edit::text_arg('Width of correct answer image:',
+					  'width',$token,10);
 	$result .=&Apache::edit::end_row().&Apache::edit::start_spanning_row();
     } elsif ($target eq 'modified') {
 	my $constructtag=&Apache::edit::get_new_args($token,$parstack,
 						     $safeeval,'molecule',
 						     'answer','jmeanswer',
-						     'options');
+						     'options','width');
 	if ($constructtag) { $result = &Apache::edit::rebuild_tag($token); }
     }
     return $result;
@@ -191,7 +211,7 @@ sub start_organicresponse {
 sub end_organicresponse {
     my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
     my $result;
-    if ($target eq 'grade' && defined($ENV{'form.submitted'})) {
+    if ($target eq 'grade' && &Apache::response::submitted()) {
 	&Apache::response::setup_params($$tagstack[-1],$safeeval);
 	my $response = &Apache::response::getresponse();
 	if ( $response =~ /[^\s]/) {
@@ -210,9 +230,12 @@ sub end_organicresponse {
 		    $ad='INCORRECT';
 		}
 	    }
+	    if ($ad && $Apache::lonhomework::type eq 'survey') {
+		$ad='SUBMITTED';
+	    }
 	    &Apache::response::handle_previous(\%previous,$ad);
 	    $Apache::lonhomework::results{"resource.$partid.$id.awarddetail"}=$ad;
-	    $Apache::lonhomework::results{"resource.$partid.$id.molecule"}=$ENV{"form.MOLECULE_$id"};
+	    $Apache::lonhomework::results{"resource.$partid.$id.molecule"}=$env{"form.MOLECULE_$id"};
 	}
     } elsif ($target eq "edit") {
 	$result.= &Apache::edit::tag_end($target,$token,'');
@@ -245,11 +268,11 @@ sub start_organicstructure {
 	    'cgi.'.$id.'.PNG' => 1,
 	    'cgi.'.$id.'.WIDTH' => $width );
     } elsif ($target eq 'tex') {
-	my $texwidth=&Apache::lonxml::get_param('texwidth',$parstack,$safeeval,1);
+	my $texwidth=&Apache::lonxml::get_param('texwidth',$parstack,$safeeval,undef,1);
 	if (!$texwidth) { $texwidth='90'; }
 	my $molecule=&Apache::lonxml::get_param('molecule',$parstack,$safeeval);
 	my $options=&Apache::lonxml::get_param('options',$parstack,$safeeval);
-	my $filename = $ENV{'user.name'}.'_'.$ENV{'user.domain'}.
+	my $filename = $env{'user.name'}.'_'.$env{'user.domain'}.
 	    '_'.time.'_'.$$.int(rand(1000)).'_organicstructure';
 	my $id=$filename;
 	&Apache::lonnet::appenv(
@@ -308,15 +331,18 @@ sub edit_reaction_button {
     my $id_es=&Apache::lonnet::escape($id);
     my $field_es=&Apache::lonnet::escape($field);
     my $reaction_es=&Apache::lonnet::escape($reaction);
+    my $docopen=&Apache::lonhtmlcommon::javascript_docopen();
     my $result=<<EDITREACTION;
 <script type="text/javascript">
+// <!--
     function create_reaction_window_${id}_${field} () {
 	editor=window.open('','','width=500,height=270,scrollbars=no,resizable=yes');
-	editor.document.open('text/html','replace');
+	editor.$docopen;
 	editor.document.writeln('<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"><html> <head><title>LON-CAPA Reaction Editor</title></head><frameset rows="30%,*" border="0">  <frame src="/res/adm/pages/reactionresponse/reaction_viewer.html?inhibitmenu=yes" name="viewer" scrolling="no" />  <frame src="/res/adm/pages/reactionresponse/reaction_editor.html?inhibitmenu=yes&reaction=$reaction_es&id=$id_es&field=$field_es" name="editor" scrolling="no" /> </frameset> </html>');
     }
+// -->
 </script>
-<input type='button' value='Edit Answer' onClick="javascript:create_reaction_window_${id}_${field}();void(0);" />
+<input type='button' value='Edit Answer' onclick="javascript:create_reaction_window_${id}_${field}();void(0);" />
 EDITREACTION
     return $result;
 }
@@ -338,8 +364,11 @@ sub start_reactionresponse {
 	}
 	if (  &Apache::response::show_answer() ) {
 	    my $ans=&Apache::lonxml::get_param('answer',$parstack,$safeeval);
-	    $ans=~s/(\\|\')/\\$1/g;
-	    $Apache::inputtags::answertxt{$id}=&Apache::run::run("return &chemparse('$ans');",$safeeval);
+	    if (!$Apache::lonxml::default_homework_loaded) {
+		&Apache::lonxml::default_homework_load($safeeval);
+	    }
+	    @Apache::scripttag::parser_env = @_;
+	    $Apache::inputtags::answertxt{$id}=&Apache::run::run("return &chemparse(q\0$ans\0);",$safeeval);
 	}
     } elsif ($target eq "edit") {
 	$result .=&Apache::edit::tag_start($target,$token);
@@ -350,7 +379,7 @@ sub start_reactionresponse {
 	$result .=&edit_reaction_button($id,&Apache::edit::html_element_name('answer'),$answer).'</nobr>';
 	my $initial=&Apache::lonxml::get_param('initial',$parstack,$safeeval);
 	$result.='<nobr>'.
-	    &Apache::edit::text_arg('Initial Reation:','initial',$token,40);
+	    &Apache::edit::text_arg('Initial Reaction:','initial',$token,40);
 	$result .=&edit_reaction_button($id,&Apache::edit::html_element_name('initial'),$initial).'</nobr>';
 	
 	$result .=&Apache::edit::end_row().&Apache::edit::start_spanning_row();
@@ -366,7 +395,7 @@ sub start_reactionresponse {
 sub end_reactionresponse {
     my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
     my $result;
-    if ($target eq 'grade' && defined($ENV{'form.submitted'})) {
+    if ($target eq 'grade' && &Apache::response::submitted()) {
 	&Apache::response::setup_params($$tagstack[-1],$safeeval);
 	my $response = &Apache::response::getresponse();
 	if ( $response =~ /[^\s]/) {
@@ -385,6 +414,9 @@ sub end_reactionresponse {
 		    $ad='INCORRECT';
 		}
 	    }
+	    if ($ad && $Apache::lonhomework::type eq 'survey') {
+		$ad='SUBMITTED';
+	    }
 	    &Apache::response::handle_previous(\%previous,$ad);
 	    $Apache::lonhomework::results{"resource.$partid.$id.awarddetail"}=$ad;
 	}
@@ -404,5 +436,26 @@ sub end_reactionresponse {
     return $result;
 }
 
+sub start_chem {
+    my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style) = @_;
+    my $result = '';
+    my $inside = &Apache::lonxml::get_all_text_unbalanced("/chem",$parser);
+    if ($target eq 'tex' || $target eq 'web') {
+	$inside=&Apache::run::evaluate($inside,$safeeval,$$parstack[-1]);
+	if (!$Apache::lonxml::default_homework_loaded) {
+	    &Apache::lonxml::default_homework_load($safeeval);
+	}
+	@Apache::scripttag::parser_env = @_;
+	$result=&Apache::run::run("return &chemparse(q\0$inside\0);",$safeeval);
+    }    
+    return $result;
+}
+
+sub end_chem {
+    my ($target,$token,$tagstack,$parstack,$parser,$safeeval,$style) = @_;
+    my $result = '';
+    return $result;
+}
+
 1;
 __END__