--- loncom/homework/chemresponse.pm 2008/09/05 16:09:39 1.79 +++ loncom/homework/chemresponse.pm 2014/02/13 18:13:22 1.93 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # chemical equation style response # -# $Id: chemresponse.pm,v 1.79 2008/09/05 16:09:39 riegler Exp $ +# $Id: chemresponse.pm,v 1.93 2014/02/13 18:13:22 bisitz Exp $ # # Copyright Michigan State University Board of Trustees # @@ -87,7 +87,7 @@ JMESECTION my $insert_answer; if ($shown_text eq '') { $insert_answer= - '<input type="button" name="submit" value="Insert Answer" onclick="javascript:submitSmiles();" />'; + '<input type="button" name="submit" value="'.&mt('Insert Answer').'" onclick="javascript:submitSmiles();" />'; } my $js = <<CHEMJS; @@ -116,16 +116,21 @@ CHEMJS 'bgcolor' => '#FFFFFF',}); my $end_page = &Apache::loncommon::end_page({'js_ready' => 1,}); - + my $java_not_enabled=&Apache::lonhtmlcommon::java_not_enabled(); + my %lt = &Apache::lonlocal::texthash( + 'seltext' => 'Select substituent...', + 'close' => 'Close', + 'help' => 'Help', + ); my $body=<<CHEMPAGE; $js <center> -<form> +<form action=""> <table width="440"><tr> <td></td> <td align="right"> <select onchange="javascript:substituent(options[selectedIndex].text)"> - <option>Select substituent</option> + <option>$lt{'seltext'}</option> <option>-C(=O)OH</option> <option>-C(=O)OMe</option> <option>-OC(=O)Me</option> @@ -143,7 +148,7 @@ $js </td></tr> </table> <applet code="JME.class" name="JME" archive="/adm/jme/JME.jar" width="440" height="390" mayscript> -You have to enable Java and JavaScript on your machine. +$java_not_enabled $molecule <param name="options" value="$options" /> </applet><br /> @@ -151,9 +156,9 @@ $molecule <br /> $insert_answer <br /> -<input type="button" value=" Close " onclick = "javascript:window.close()" /> +<input type="button" value="$lt{'close'}" onclick="javascript:window.close()" /> -<input type="button" value=" Help " onclick = "javascript:openHelpWindow()" /> +<input type="button" value="$lt{'help'}" onclick="javascript:openHelpWindow()" /> </form> </center> CHEMPAGE @@ -165,7 +170,7 @@ CHEMPAGE if (defined($shown_text)) { $display=&mt($shown_text); } my $iconpath=$Apache::lonnet::perlvar{'lonIconsURL'}; my $function = - 'LONCAPA_draw_molecule_'.&Apache::lonhtmlcommon::get_uniq_name(); + 'LONCAPA_draw_molecule_'.&get_uniq_name(); my $result=<<CHEMINPUT; <script type="text/javascript"> function $function() { @@ -176,8 +181,14 @@ CHEMPAGE editor.focus(); } </script> -<a href="javascript:$function();void(0);"><img class="stift" src='$iconpath/stift.gif' alt='$display' title='$display' /></a> CHEMINPUT + if ($shown_text eq '') { + $result .=<<PENCIL; +<a href="javascript:$function();void(0);"><img class="stift" src='$iconpath/stift.gif' alt='$display' title='$display' /></a> +PENCIL + } else { + $result .= '<input type="button" value="'.&mt($shown_text).'" onclick="javascript:'.$function.'();void(0);" />'; + } return $result; } sub jme_img { @@ -203,30 +214,19 @@ sub start_organicresponse { } elsif ($target eq 'web') { my $jmeanswer=&Apache::lonxml::get_param('jmeanswer',$parstack, $safeeval); - if ( &Apache::response::show_answer() && $jmeanswer ne '') { - my $options=&Apache::lonxml::get_param('options',$parstack, - $safeeval); - my $width=&Apache::lonxml::get_param('width',$parstack, - $safeeval); - my (@answers)=&Apache::lonxml::get_param_var('answer',$parstack, - $safeeval); - $result.=&jme_img($jmeanswer,$answers[0],$width,$options); - } else { - my $molecule; - if (defined($Apache::lonhomework::history{"resource.$partid.$id.molecule"})) { - $molecule=$Apache::lonhomework::history{"resource.$partid.$id.molecule"}; - } else { - $molecule=&Apache::lonxml::get_param('molecule',$parstack, + if (&Apache::response::show_answer()) { + my $jmeanswer=&Apache::lonxml::get_param('jmeanswer',$parstack, + $safeeval); + if ($jmeanswer ne '') { + my $options=&Apache::lonxml::get_param('options',$parstack, + $safeeval); + my $width=&Apache::lonxml::get_param('width',$parstack, $safeeval); - } - my $options=&Apache::lonxml::get_param('options',$parstack, - $safeeval); - my $shown_text; - if (&Apache::response::show_answer()) { - $shown_text="Show Your Last Answer"; - } - #stift $result=&separate_jme_window("HWVAL_$id","MOLECULE_$id",$molecule, -# $options,$shown_text); + my (@answers)=&Apache::lonxml::get_param_var('answer',$parstack, + $safeeval); + $result.=&jme_img($jmeanswer,$answers[0],$width,$options); + } + } else { $result.= '<input type="hidden" name="MOLECULE_'.$id.'" value="" />'; } } elsif ($target eq 'edit') { @@ -234,7 +234,7 @@ sub start_organicresponse { my $options=&Apache::lonxml::get_param('options',$parstack, $safeeval); if ($options !~ /multipart/) { $options.=',multipart'; } - $result .='<nobr>'. + $result .='<span class="LC_nobreak">'. &Apache::edit::text_arg('Starting Molecule:','molecule', $token,40); my $molecule=&Apache::lonxml::get_param('molecule',$parstack, @@ -242,11 +242,11 @@ sub start_organicresponse { $result .=&separate_jme_window(undef, &Apache::edit::html_element_name('molecule'), $molecule,$options); - $result .='</nobr><br /><nobr>'; + $result .='</span><br /><span class="LC_nobreak">'; $result .=&Apache::edit::text_arg('Correct Answer:','answer', $token,40); - $result .='</nobr><br /><nobr>'; - $result .=&Apache::edit::text_arg('JME string of the answer (automatically updated when using the Draw Molecule button):', + $result .='</span><br /><span class="LC_nobreak">'; + $result .=&Apache::edit::text_arg('JME string of the answer - automatically updated by "Insert Answer" in the JME pop-up (click pencil):', 'jmeanswer',$token); my $jmeanswer=&Apache::lonxml::get_param('jmeanswer',$parstack, $safeeval); @@ -254,7 +254,7 @@ sub start_organicresponse { &Apache::edit::html_element_name('answer'), &Apache::edit::html_element_name('jmeanswer'), $jmeanswer,$options); - $result .='</nobr><br />'; + $result .='</span><br />'; $result .=&Apache::edit::checked_arg('Options:','options', [ ['autoez','Auto E,Z stereochemistry'], ['multipart','Multipart Structures'], @@ -309,9 +309,17 @@ sub end_organicresponse { $ad='INCORRECT'; } } - if ($ad && $Apache::lonhomework::type eq 'survey') { - $ad='SUBMITTED'; - } + if ($ad) { + if ($Apache::lonhomework::type eq 'survey') { + $ad='SUBMITTED'; + } elsif ($Apache::lonhomework::type eq 'surveycred') { + $ad='SUBMITTED_CREDIT'; + } elsif ($Apache::lonhomework::type eq 'anonsurvey') { + $ad='ANONYMOUS'; + } elsif ($Apache::lonhomework::type eq 'anonsurveycred') { + $ad='ANONYMOUS_CREDIT'; + } + } &Apache::response::handle_previous(\%previous,$ad); $Apache::lonhomework::results{"resource.$partid.$id.awarddetail"}=$ad; $Apache::lonhomework::results{"resource.$partid.$id.molecule"}=$env{"form.MOLECULE_$id"}; @@ -334,21 +342,29 @@ sub end_organicresponse { if ($target eq 'grade' || $target eq 'web' || $target eq 'answer' || $target eq 'tex' || $target eq 'analyze') { - &Apache::lonxml::increment_counter(&Apache::response::repetition(), - "$partid.$id"); # part.response + my $repetition = &Apache::response::repetition(); + &Apache::lonxml::increment_counter($repetition,"$partid.$id"); # part.response if ($target eq 'analyze') { $Apache::lonhomework::analyze{"$partid.$id.type"} = 'organicresponse'; + push (@{ $Apache::lonhomework::analyze{"parts"} },"$partid.$id"); &Apache::lonhomework::set_bubble_lines(); } } - if (($target eq 'web' ) && ($Apache::lonhomework::type ne 'exam') && ($Apache::inputtags::status['-1'] eq 'CAN_ANSWER')){ -# hierher - my $options=&Apache::lonxml::get_param('options',$parstack, - $safeeval); - my $shown_text; - if (&Apache::response::show_answer()) { + if ($target eq 'web' ) { + my ($showpencil,$shown_text); + if ($Apache::inputtags::status['-1'] eq 'CAN_ANSWER') { + $showpencil = 1; + } elsif (&Apache::response::show_answer()) { + my $jmeanswer=&Apache::lonxml::get_param('jmeanswer',$parstack, $safeeval); + if ($jmeanswer eq '') { + $showpencil = 1; $shown_text="Show Your Last Answer"; } + } + if ($showpencil) { + my $options=&Apache::lonxml::get_param('options',$parstack, + $safeeval); + my $molecule; if (defined($Apache::lonhomework::history{"resource.$partid.$id.molecule"})) { $molecule=$Apache::lonhomework::history{"resource.$partid.$id.molecule"}; @@ -356,8 +372,9 @@ sub end_organicresponse { $molecule=&Apache::lonxml::get_param('molecule',$parstack, $safeeval); } - $result.=&separate_jme_window("HWVAL_$id","MOLECULE_$id",$molecule, - $options,$shown_text); + $result.=&separate_jme_window("HWVAL_$id","MOLECULE_$id",$molecule, + $options,$shown_text); + } } &Apache::response::end_response(); return $result; @@ -365,7 +382,7 @@ sub end_organicresponse { sub format_prior_answer_organic { my ($mode,$answer,$other_data) = @_; - my $result=&mt('Smile representation: "[_1]"','<tt>'.$answer.'</tt>'); + my $result=&mt('Smile representation: [_1]','"<tt>'.$answer.'</tt>"'); my $jme=$other_data->[0]; $result.=&jme_img($jme,$answer,400); return $result; @@ -405,13 +422,14 @@ sub start_organicstructure { $id=&escape($id); &Apache::lonxml::register_ssi("/cgi-bin/convertjme.pl?$id"); if ($options =~ /border/) { $result.= '\fbox{'; } - $result .= '\graphicspath{{/home/httpd/perl/tmp/}}\includegraphics[width='.$texwidth.' mm]{'.$filename.'.eps}'; + $result .= '\graphicspath{{'.LONCAPA::tempdir(). + '}}\includegraphics[width='.$texwidth.' mm]{'.$filename.'.eps}'; if ($options =~ /border/) { $result.= '} '; } } elsif ($target eq 'edit') { $result .=&Apache::edit::tag_start($target,$token); $result .=&Apache::edit::text_arg('Width (pixels):','width',$token,5); $result .=&Apache::edit::text_arg('TeXwidth (mm):','texwidth',$token,5); - $result .='<nobr>'; + $result .='<span class="LC_nobreak">'; $result .=&Apache::edit::text_arg('Molecule:','molecule',$token,40); my $molecule=&Apache::lonxml::get_param('molecule',$parstack, $safeeval); @@ -424,7 +442,7 @@ sub start_organicstructure { $result .=&separate_jme_window(undef, &Apache::edit::html_element_name('molecule'), $molecule,$options); - $result.="</nobr><br />"; + $result.="</span><br />"; $result .=&Apache::edit::checked_arg('Options:','options', [ ['reaction','Is a reaction'], ['border','Draw a border'] ], @@ -455,6 +473,8 @@ sub edit_reaction_button { my $field_es=&escape($field); my $reaction_es=&escape($reaction); my $docopen=&Apache::lonhtmlcommon::javascript_docopen(); + my $iconpath=$Apache::lonnet::perlvar{'lonIconsURL'}; + my $display=&mt('Edit Answer'); my $start_page = &Apache::loncommon::start_page('LON-CAPA Reaction Editor',undef, {'frameset' => 1, @@ -476,7 +496,7 @@ sub edit_reaction_button { } // --> </script> -<input type='button' value='Edit Answer' onclick="javascript:create_reaction_window_${id}_${field}();void(0);" /> +<a href="javascript:create_reaction_window_${id}_${field}();void(0);"><img class="stift" src='$iconpath/stift.gif' alt='$display' title='$display' /></a> EDITREACTION return $result; } @@ -490,12 +510,6 @@ sub start_reactionresponse { } elsif ($target eq 'web') { my $partid = $Apache::inputtags::part; my $id = $Apache::inputtags::response['-1']; - my $reaction=$Apache::lonhomework::history{"resource.$partid.$id.submission"}; - if ($reaction eq '') { $reaction=&Apache::lonxml::get_param('initial',$parstack,$safeeval); } - my $status=$Apache::inputtags::status['-1']; - if ($status eq 'CAN_ANSWER') { - $result.=&edit_reaction_button($id,"HWVAL_$id",$reaction); - } if ( &Apache::response::show_answer() ) { my $ans=&Apache::lonxml::get_param('answer',$parstack,$safeeval); if (!$Apache::lonxml::default_homework_loaded) { @@ -508,14 +522,13 @@ sub start_reactionresponse { $result .=&Apache::edit::tag_start($target,$token); my $answer=&Apache::lonxml::get_param('answer',$parstack, $safeeval); - $result .='<nobr>'. + $result .='<span class="LC_nobreak">'. &Apache::edit::text_arg('Answer:','answer',$token,40); - $result .=&edit_reaction_button($id,&Apache::edit::html_element_name('answer'),$answer).'</nobr>'; + $result .=&edit_reaction_button($id,&Apache::edit::html_element_name('answer'),$answer).'</span>'; my $initial=&Apache::lonxml::get_param('initial',$parstack,$safeeval); - $result.='<nobr>'. + $result.='<span class="LC_nobreak">'. &Apache::edit::text_arg('Initial Reaction:','initial',$token,40); - $result .=&edit_reaction_button($id,&Apache::edit::html_element_name('initial'),$initial).'</nobr>'; - + $result .=&edit_reaction_button($id,&Apache::edit::html_element_name('initial'),$initial).'</span>'; $result .=&Apache::edit::end_row().&Apache::edit::start_spanning_row(); } elsif ($target eq 'modified') { my $constructtag=&Apache::edit::get_new_args($token,$parstack, @@ -559,9 +572,17 @@ sub end_reactionresponse { $ad='INCORRECT'; } } - if ($ad && $Apache::lonhomework::type eq 'survey') { - $ad='SUBMITTED'; - } + if ($ad) { + if ($Apache::lonhomework::type eq 'survey') { + $ad='SUBMITTED'; + } elsif ($ad && $Apache::lonhomework::type eq 'surveycred') { + $ad='SUBMITTED_CREDIT'; + } elsif ($ad && $Apache::lonhomework::type eq 'anonsurvey') { + $ad='ANONYMOUS'; + } elsif ($ad && $Apache::lonhomework::type eq 'anonsurveycred') { + $ad='ANONYMOUS_CREDIT'; + } + } &Apache::response::handle_previous(\%previous,$ad); $Apache::lonhomework::results{"resource.$partid.$id.awarddetail"}=$ad; } @@ -583,12 +604,20 @@ sub end_reactionresponse { if ($target eq 'grade' || $target eq 'web' || $target eq 'answer' || $target eq 'tex' || $target eq 'analyze') { - &Apache::lonxml::increment_counter(&Apache::response::repetition(), "$partid.$id"); + my $repetition = &Apache::response::repetition(); + &Apache::lonxml::increment_counter($repetition,"$partid.$id"); if ($target eq 'analyze') { $Apache::lonhomework::analyze{"$partid.$id.type"} = 'reactionresponse'; + push (@{ $Apache::lonhomework::analyze{"parts"} },"$partid.$id"); &Apache::lonhomework::set_bubble_lines(); } } + my $status=$Apache::inputtags::status['-1']; + if (($target eq 'web') && ($Apache::lonhomework::type ne 'exam') && ($status eq 'CAN_ANSWER')) { + my $reaction=$Apache::lonhomework::history{"resource.$partid.$id.submission"}; + if ($reaction eq '') { $reaction=&Apache::lonxml::get_param('initial',$parstack,$safeeval); } + $result.=&edit_reaction_button($id,"HWVAL_$id",$reaction); + } &Apache::response::end_response(); return $result; } @@ -620,5 +649,11 @@ sub end_chem { return $result; } +my $uniq=0; +sub get_uniq_name { + $uniq++; + return 'uniquename'.$uniq; +} + 1; __END__