--- loncom/homework/edit.pm 2004/10/26 15:06:58 1.88
+++ loncom/homework/edit.pm 2005/08/30 15:36:07 1.94
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# edit mode helpers
#
-# $Id: edit.pm,v 1.88 2004/10/26 15:06:58 albertel Exp $
+# $Id: edit.pm,v 1.94 2005/08/30 15:36:07 albertel Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -29,7 +29,7 @@
package Apache::edit;
use strict;
-use Apache::lonnet();
+use Apache::lonnet;
use HTML::Entities();
use Apache::lonlocal;
@@ -109,7 +109,7 @@ sub start_table {
sub end_table {
$Apache::edit::colordepth--;
my $result='</table></div>';
- $result.="<table><tr><td>";
+ $result.='<div align="left"><table><tr><td>';
my ($tagname,$closingtag);
if (defined($Apache::edit::inserttag[-2])) {
@@ -119,7 +119,7 @@ sub end_table {
$closingtag=$Apache::edit::inserttag[-1];
}
$result.=&innerinsertlist('edit',$tagname,$closingtag).
- "</td></tr></table>";
+ "</td></tr></table></div>";
pop(@Apache::edit::inserttag);
return $result;
}
@@ -147,7 +147,7 @@ sub deletelist {
}
sub handle_delete {
- if (!$ENV{"form.delete_$Apache::lonxml::curdepth"}) { return ''; }
+ if (!$env{"form.delete_$Apache::lonxml::curdepth"}) { return ''; }
my ($space,$target,$token,$tagstack,$parstack,$parser,$safeeval,$style)=@_;
my $result=0;
if ($space) {
@@ -222,9 +222,9 @@ sub innerinsertlist {
}
sub handle_insert {
- if ($ENV{"form.insert_$Apache::lonxml::curdepth"} eq '') { return ''; }
+ if ($env{"form.insert_$Apache::lonxml::curdepth"} eq '') { return ''; }
my $result;
- my $tagnum = $ENV{"form.insert_$Apache::lonxml::curdepth"};
+ my $tagnum = $env{"form.insert_$Apache::lonxml::curdepth"};
my $func=$Apache::lonxml::insertlist{"$tagnum.function"};
if ($func eq 'default') {
my $newtag=$Apache::lonxml::insertlist{"$tagnum.tag"};
@@ -239,7 +239,7 @@ sub handle_insert {
}
} else {
my $newtag=$Apache::lonxml::insertlist{"$tagnum.tag"};
- &Apache::lonxml::error("Unable to insert tag $newtag, $func was not defined.");
+ &Apache::lonxml::error("Unable to insert tag ".$Apache::lonxml::curdepth." ($tagnum) $newtag, func was not defined.");
}
}
return $result;
@@ -247,10 +247,10 @@ sub handle_insert {
sub handle_insertafter {
my $tagname=shift;
- if ($ENV{"form.insert_after_$tagname\_$Apache::lonxml::curdepth"} eq '')
+ if ($env{"form.insert_after_$tagname\_$Apache::lonxml::curdepth"} eq '')
{ return ''; }
my $result;
- my $tagnum =$ENV{"form.insert_after_$tagname\_$Apache::lonxml::curdepth"};
+ my $tagnum =$env{"form.insert_after_$tagname\_$Apache::lonxml::curdepth"};
my $func=$Apache::lonxml::insertlist{"$tagnum.function"};
if ($func eq 'default') {
my $newtag=$Apache::lonxml::insertlist{"$tagnum.tag"};
@@ -300,6 +300,8 @@ sub insert_formularesponse {
sub insert_numericalresponse {
return '
<numericalresponse answer="">
+<responseparam type="tolerance" default="5%" name="tol" description="Numerical Tolerance" />
+<responseparam name="sig" type="int_range,0-16" default="0,15" description="Significant Figures" />
<textline />
<hintgroup>
<startouttext /><endouttext />
@@ -328,6 +330,8 @@ sub insert_imageresponse {
return '
<imageresponse max="1">
<foilgroup>
+ <foil>
+ </foil>
</foilgroup>
<hintgroup>
<startouttext /><endouttext />
@@ -339,6 +343,9 @@ sub insert_optionresponse {
return '
<optionresponse max="10">
<foilgroup options="">
+ <foil>
+ <startouttext /><endouttext />
+ </foil>
</foilgroup>
<hintgroup>
<startouttext /><endouttext />
@@ -366,6 +373,9 @@ sub insert_radiobuttonresponse {
return '
<radiobuttonresponse max="10">
<foilgroup>
+ <foil>
+ <startouttext /><endouttext />
+ </foil>
</foilgroup>
<hintgroup>
<startouttext /><endouttext />
@@ -387,6 +397,9 @@ sub insert_rankresponse {
return '
<rankresponse max="10">
<foilgroup options="">
+ <foil>
+ <startouttext /><endouttext />
+ </foil>
</foilgroup>
<hintgroup>
<startouttext /><endouttext />
@@ -400,6 +413,9 @@ sub insert_matchresponse {
<foilgroup options="">
<itemgroup>
</itemgroup>
+ <foil>
+ <startouttext /><endouttext />
+ </foil>
</foilgroup>
<hintgroup>
<startouttext /><endouttext />
@@ -412,8 +428,7 @@ sub insert_displaytitle { return '<dis
sub insert_hintpart {
return '
<hintpart on="default">
- <startouttext/>
- <endouttext />
+ <startouttext/><endouttext />
</hintpart>';
}
@@ -505,7 +520,7 @@ sub editfield {
push @Apache::lonxml::htmlareafields,'homework_edit_'.
$Apache::lonxml::curdepth;
}
- return $description."\n".' <textarea rows="'.$rows.
+ return $description."\n".' <textarea style="width:100%" rows="'.$rows.
'" cols="'.$cols.'" name="homework_edit_'.
$Apache::lonxml::curdepth.'" id="homework_edit_'.
$Apache::lonxml::curdepth.'">'.
@@ -517,12 +532,12 @@ sub editfield {
sub modifiedfield {
my ($endtag,$parser) = @_;
my $result;
-# foreach my $envkey (sort keys %ENV) {
-# &Apache::lonxml::debug("$envkey ---- $ENV{$envkey}");
+# foreach my $envkey (sort keys %env) {
+# &Apache::lonxml::debug("$envkey ---- $env{$envkey}");
# }
# &Apache::lonxml::debug("I want homework_edit_$Apache::lonxml::curdepth");
-# &Apache::lonxml::debug($ENV{"form.homework_edit_$Apache::lonxml::curdepth"});
- $result=$ENV{"form.homework_edit_$Apache::lonxml::curdepth"};
+# &Apache::lonxml::debug($env{"form.homework_edit_$Apache::lonxml::curdepth"});
+ $result=$env{"form.homework_edit_$Apache::lonxml::curdepth"};
my $bodytext=&Apache::lonxml::get_all_text($endtag,$parser);
# textareas throw away intial \n
if ($bodytext=~/^\n/) { $result="\n".$result; }
@@ -538,7 +553,7 @@ sub get_new_args {
#just want the string that it was set to
my $value=$token->[2]->{$arg};
my $element=&html_element_name($arg);
- my $newvalue=$ENV{"form.$element"};
+ my $newvalue=$env{"form.$element"};
&Apache::lonxml::debug("for:$arg: cur is :$value: new is :$newvalue:");
if (defined($newvalue) && $value ne $newvalue) {
if (ref($newvalue) eq 'ARRAY') {
@@ -639,12 +654,12 @@ sub select_arg {
foreach my $option (@$list) {
my ($text,$value);
if ( ref($option) eq 'ARRAY') {
- $value='value="'.$$option[0].'"';
+ $value='value="'.&HTML::Entities::encode($$option[0]).'"';
$text=$$option[1];
$option=$$option[0];
} else {
$text=$option;
- $value='value="'.$option.'"';
+ $value='value="'.&HTML::Entities::encode($option,'\'"&<>').'"';
}
if ( $selected eq $option ) {
$optionlist.="<option $value selected=\"selected\">$text</option>\n";
@@ -668,12 +683,12 @@ sub select_or_text_arg {
foreach my $option (@$list) {
my ($text,$value);
if ( ref($option) eq 'ARRAY') {
- $value='value="'.$$option[0].'"';
+ $value='value="'.&HTML::Entities::encode($$option[0]).'"';
$text=$$option[1];
$option=$$option[0];
} else {
$text=$option;
- $value='value="'.$option.'"';
+ $value='value="'.&HTML::Entities::encode($option,'\'"&<>').'"';
}
if ( $selected eq $option ) {
$optionlist.="<option $value selected=\"selected\">$text</option>\n";