--- loncom/homework/functionplotresponse.pm	2011/11/21 02:34:58	1.80
+++ loncom/homework/functionplotresponse.pm	2011/11/21 20:48:50	1.83
@@ -1,7 +1,7 @@
 # LearningOnline Network with CAPA
 # Functionplot responses
 #
-# $Id: functionplotresponse.pm,v 1.80 2011/11/21 02:34:58 www Exp $
+# $Id: functionplotresponse.pm,v 1.83 2011/11/21 20:48:50 www Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -654,10 +654,6 @@ sub start_functionplotrule {
    } else {
       $label='R'.$label;
    }
-   if ($Apache::functionplotresponse::splineorder{$label}) {
-       &Apache::lonxml::error(&mt('Rule indices must be unique.'));
-   }
-
 
    if ($target eq 'grade') {
 # Simply remember - in order - for later
@@ -772,9 +768,6 @@ sub start_functionplotvectorrule {
    } else {
       $label='R'.$label;
    }
-   if ($Apache::functionplotresponse::splineorder{$label}) {
-       &Apache::lonxml::error(&mt('Rule indices must be unique.'));
-   }
 
    if ($target eq 'grade') {
 # Simply remember - in order - for later
@@ -896,22 +889,17 @@ sub start_functionplotvectorsumrule {
    } else {
       $label='R'.$label;
    }
-   if ($Apache::functionplotresponse::splineorder{$label}) {
-       &Apache::lonxml::error(&mt('Rule indices must be unique.'));
-   }
    if ($target eq 'grade') {
 # Simply remember - in order - for later
       my $id=$Apache::inputtags::response[-1];
       my $partid=$Apache::inputtags::part;
       my $internalid = $partid.'_'.$id;
-      my $object=&Apache::lonxml::get_param('object',$parstack,$safeeval);
-      $object=~s/\W//gs;
-      $object=ucfirst($object);
+      my $vectors=&Apache::lonxml::get_param('vectors',$parstack,$safeeval);
       push(@Apache::functionplotresponse::functionplotvectorrules,join(':',(
            $label,
            'sum',
            $internalid,
-           $object,
+           $vectors,
            &Apache::lonxml::get_param('length',$parstack,$safeeval),
            &Apache::lonxml::get_param('angle',$parstack,$safeeval),
            &Apache::lonxml::get_param('lengtherror',$parstack,$safeeval),
@@ -921,8 +909,8 @@ sub start_functionplotvectorsumrule {
         $result=&Apache::edit::tag_start($target,$token,'Function Plot Vector Sum Rule').
              &Apache::edit::text_arg('Index/Name:','index',
                                      $token,'10').' '.
-             &Apache::edit::text_arg('Vectors attached to object:','object',
-                                      $token,'16').'<br />'.
+             &Apache::edit::text_arg('Comma-separated list of vectors:','vectors',
+                                      $token,'30').'<br />'.
              &Apache::edit::text_arg('Sum vector length:','length',
                                      $token,'16').
              &Apache::edit::text_arg('Sum vector angle:','angle',
@@ -935,7 +923,7 @@ sub start_functionplotvectorsumrule {
   } elsif ($target eq 'modified') {
     $env{'form.'.&Apache::edit::html_element_name('object')}=ucfirst($env{'form.'.&Apache::edit::html_element_name('object')});
     my $constructtag=&Apache::edit::get_new_args($token,$parstack,
-                                                 $safeeval,'index','object',
+                                                 $safeeval,'index','vectors',
                                                            'length','angle',
                                                            ,'lengtherror','angleerror');
     if ($constructtag) { $result=&Apache::edit::rebuild_tag($token); }
@@ -1382,6 +1370,22 @@ sub objectcoords {
    return ($env{'form.HWVAL_'.$id.'_'.$label.'_x'},
            $env{'form.HWVAL_'.$id.'_'.$label.'_y'});
 }
+
+sub attached {
+   my ($id,$vector,$object,$xmin,$xmax,$ymin,$ymax)=@_;
+   my ($xs,$xe,$ys,$ye)=&vectorcoords($id,$vector);
+   my ($xo,$yo)=&objectcoords($id,$object);
+   my $tolx=($xmax-$xmin)/100.;
+   my $toly=($ymax-$ymin)/100.;
+   my $tail=0;
+   my $tip=0;
+   &addlog("Proximity $vector ($xs,$xe,$ys,$ye) to $object ($xo,$yo)");
+   if ((abs($xs-$xo)<$tolx) && (abs($ys-$yo)<$toly)) { $tail=1; }
+   if ((abs($xe-$xo)<$tolx) && (abs($ye-$yo)<$toly)) { $tip=1; }
+   &addlog("Result tail:$tail tip:$tip");
+   return($tail,$tip);
+}
+
  
 sub vectorangle {
    my ($x,$y)=@_;
@@ -1459,15 +1463,99 @@ sub vectorcheck {
          return 0;
       }
    }
+   if ($attachpoint ne '') {
+      &addlog("Checking attached: ".$attachpoint);
+      my ($tail,$tip)=&attached($id,$vector,$attachpoint,$xmin,$xmax,$ymin,$ymax);
+      unless ($tail || $tip) {
+         &setfailed($label);
+         return 0;
+      }
+   }
+   if ($notattachpoint ne '') {
+      &addlog("Checking not attached: ".$notattachpoint);
+      my ($tail,$tip)=&attached($id,$vector,$notattachpoint,$xmin,$xmax,$ymin,$ymax);
+      if ($tail || $tip) {
+         &setfailed($label);
+         return 0;
+      }
+   }
+   if ($tailpoint ne '') {
+      &addlog("Checking tail: ".$tailpoint);
+      my ($tail,$tip)=&attached($id,$vector,$tailpoint,$xmin,$xmax,$ymin,$ymax);
+      unless ($tail) {
+         &setfailed($label);
+         return 0;
+      }
+   }
+   if ($nottailpoint ne '') {
+      &addlog("Checking not tail: ".$nottailpoint);
+      my ($tail,$tip)=&attached($id,$vector,$nottailpoint,$xmin,$xmax,$ymin,$ymax);
+      if ($tail) {
+         &setfailed($label);
+         return 0;
+      }
+   }
+   if ($tippoint ne '') {
+      &addlog("Checking tip: ".$tippoint);
+      my ($tail,$tip)=&attached($id,$vector,$tippoint,$xmin,$xmax,$ymin,$ymax);
+      unless ($tip) {
+         &setfailed($label);
+         return 0;
+      }
+   }
+   if ($nottippoint ne '') {
+      &addlog("Checking not tip: ".$nottippoint);
+      my ($tail,$tip)=&attached($id,$vector,$nottippoint,$xmin,$xmax,$ymin,$ymax);
+      if ($tip) {
+         &setfailed($label);
+         return 0;
+      }
+   }
+
    &addlog("Rule $label passed.");
    return 1;
 }
 
 sub sumcheck {
    my ($rule,$xmin,$xmax,$ymin,$ymax,$safeeval)=@_;
-   my ($label,$type,$id,$object,$length,$angle,$lengtherror,$angleerror)=split(/\:/,$rule);
-   &addlog("Vector Sum Rule $label for vectors attached to ".$object);
-
+   my ($label,$type,$id,$vectors,$length,$angle,$lengtherror,$angleerror)=split(/\:/,$rule);
+   &addlog("Vector Sum Rule $label for vectors ".$vectors);
+   my $sumx=0;
+   my $sumy=0;
+   foreach my $sv (split(/\s*\,\s*/,$vectors)) {
+      my ($rx,$ry)=&relvector(&vectorcoords($id,$sv));
+      $sumx+=$rx;
+      $sumy+=$ry;
+   }
+   &addlog("Sum vector ($sumx,$sumy)");
+   if ($length ne '') {
+      &addlog("Checking length $length with error $lengtherror");
+      $length=&Apache::run::run($length,$safeeval);
+      &addlog("Evaluated to $length");
+      my $thislength=&vectorlength($sumx,$sumy);
+      &addlog("Actual length $thislength");
+      if (abs($length-$thislength)>$lengtherror) {
+                  &setfailed($label);
+         return 0;
+      }
+   }
+   if ($angle ne '') {
+      &addlog("Checking angle $angle with error $angleerror");
+      $angle=&Apache::run::run($angle,$safeeval);
+      &addlog("Evaluated to $angle");
+      my $thisangle=&vectorangle($sumx,$sumy);
+      &addlog("Actual angle $thisangle");
+      my $anglediff=abs($thisangle-$angle);
+      &addlog("Angle difference: $anglediff");
+      if ($anglediff>360.-$anglediff) {
+         $anglediff=360.-$anglediff;
+      }
+      &addlog("Smallest angle difference: $anglediff");
+      if ($anglediff>$angleerror) {
+         &setfailed($label);
+         return 0;
+      }
+   }
    &addlog("Rule $label passed.");
    return 1;
 }