--- loncom/homework/grades.pm	2006/10/13 21:49:28	1.378
+++ loncom/homework/grades.pm	2006/10/23 22:32:09	1.381
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # The LON-CAPA Grading handler
 #
-# $Id: grades.pm,v 1.378 2006/10/13 21:49:28 albertel Exp $
+# $Id: grades.pm,v 1.381 2006/10/23 22:32:09 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1469,7 +1469,8 @@ sub get_increment {
 #--- displays the grading box, used in essay type problem and grading by page/sequence
 sub gradeBox {
     my ($request,$symb,$uname,$udom,$counter,$partid,$record) = @_;
-    my $checkIcon = '<img src="'.$request->dir_config('lonIconsURL').
+    my $checkIcon = '<img alt="'.&mt('Check Mark').
+	'" src="'.$request->dir_config('lonIconsURL').
 	'/check.gif" height="16" border="0" />';
     my $wgt    = &Apache::lonnet::EXT('resource.'.$partid.'.weight',$symb,$udom,$uname);
     my $wgtmsg = ($wgt > 0 ? '(problem weight)' : 
@@ -1492,10 +1493,10 @@ sub gradeBox {
     my $increment = &get_increment();
     $result.='<table border="0"><tr>'."\n";  # display radio buttons in a nice table 10 across
     while ($thisweight<=$wgt) {
-	$result.= '<td><nobr><label><input type="radio" name="RADVAL'.$counter.'_'.$partid.'" '.
+	$result.= '<td><span style="white-space: nowrap;"><label><input type="radio" name="RADVAL'.$counter.'_'.$partid.'" '.
 	    'onclick="javascript:writeBox(this.form,\''.$counter.'_'.$partid.'\','.
 	    $thisweight.')" value="'.$thisweight.'" '.
-	    ($score eq $thisweight ? 'checked':'').' /> '.$thisweight."</label></nobr></td>\n";
+	    ($score eq $thisweight ? 'checked':'').' /> '.$thisweight."</label></span></td>\n";
 	$result.=(($ctr+1)%10 == 0 ? '</tr><tr>' : '');
         $thisweight += $increment;
 	$ctr++;
@@ -1512,14 +1513,14 @@ sub gradeBox {
     $result.='<select name="GD_SEL'.$counter.'_'.$partid.'" '.
 	'onChange="javascript:clearRadBox(this.form,\''.$counter.'_'.$partid.'\')" >'."\n";
     if ($$record{'resource.'.$partid.'.solved'} eq 'excused') {
-	$result.='<option> </option>'.
+	$result.='<option>&nbsp;</option>'.
 	    '<option selected="on">excused</option>';
     } else {
-	$result.='<option selected="on"> </option>'.
+	$result.='<option selected="on">&nbsp;</option>'.
 	    '<option>excused</option>';
     }
     $result.='<option>reset status</option></select>'."\n";
-    $result.="&nbsp&nbsp\n";
+    $result.="&nbsp;&nbsp;\n";
     $result.='<input type="hidden" name="stores'.$counter.'_'.$partid.'" value="" />'."\n".
 	'<input type="hidden" name="oldpts'.$counter.'_'.$partid.'" value="'.$score.'" />'."\n".
 	'<input type="hidden" name="solved'.$counter.'_'.$partid.'" value="'.
@@ -1640,7 +1641,8 @@ sub submission {
     if (!$env{'form.vProb'}) { $env{'form.vProb'} = 'yes'; }
     if (!$env{'form.vAns'}) { $env{'form.vAns'} = 'yes'; }
     my $last = ($env{'form.lastSub'} eq 'last' ? 'last' : '');
-    my $checkIcon = '<img src="'.$request->dir_config('lonIconsURL').
+    my $checkIcon = '<img alt="'.&mt('Check Mark').
+	'" src="'.$request->dir_config('lonIconsURL').
 	'/check.gif" height="16" border="0" />';
 
     # header info
@@ -2420,17 +2422,8 @@ sub saveHandGrade {
         }
 	&Apache::lonnet::cstore(\%newrecord,$symb,
 				$env{'request.course.id'},$domain,$stuname);
-	my @ungraded_parts;
-	foreach my $part (@parts) {
-	    if ( !defined($record{'resource.'.$part.'.awarded'})
-		 && !defined($newrecord{'resource.'.$part.'.awarded'}) ) {
-		push(@ungraded_parts, $part);
-	    }
-	}
-	if ( !@ungraded_parts ) {
-	    &Apache::bridgetask::remove_from_queue('gradingqueue',$symb,$cdom,
-						   $cnum,$domain,$stuname);
-	}
+	&check_and_remove_from_queue(\@parts,\%record,\%newrecord,$symb,
+				     $cdom,$cnum,$domain,$stuname);
     }
     if ($aggregateflag) {
         &Apache::lonnet::cinc('nohist_resourcetracker',\%aggregate,
@@ -2439,6 +2432,24 @@ sub saveHandGrade {
     return ('',$pts,$wgt);
 }
 
+sub check_and_remove_from_queue {
+    my ($parts,$record,$newrecord,$symb,$cdom,$cnum,$domain,$stuname) = @_;
+    my @ungraded_parts;
+    foreach my $part (@{$parts}) {
+	if (    $record->{   'resource.'.$part.'.awarded'} eq ''
+	     && $record->{   'resource.'.$part.'.solved' } ne 'excused'
+	     && $newrecord->{'resource.'.$part.'.awarded'} eq ''
+	     && $newrecord->{'resource.'.$part.'.solved' } ne 'excused'
+		) {
+	    push(@ungraded_parts, $part);
+	}
+    }
+    if ( !@ungraded_parts ) {
+	&Apache::bridgetask::remove_from_queue('gradingqueue',$symb,$cdom,
+					       $cnum,$domain,$stuname);
+    }
+}
+
 sub handback_files {
     my ($request,$symb,$stuname,$domain,$newflg,$new_part,$newrecord) = @_;
     my $portfolio_root = &propath($domain,$stuname).'/userfiles/portfolio';
@@ -3797,8 +3808,8 @@ LISTJAVASCRIPT
 	$studentTable.=($ptr%2 == 0 ? '</td></tr>' : '');
 	$ptr++;
     }
-    $studentTable.='</td><td>&nbsp;</td><td>&nbsp;' if ($ptr%2 == 0);
-    $studentTable.='</td></tr></table></td></tr></table>'."\n";
+    $studentTable.='</td><td>&nbsp;</td><td>&nbsp;</td></tr>' if ($ptr%2 == 0);
+    $studentTable.='</table></td></tr></table>'."\n";
     $studentTable.='<input type="button" '.
 	'onClick="javascript:checkPickOne(this.form);"value="Next->" /></form>'."\n";
 
@@ -3821,9 +3832,10 @@ sub getSymbMap {
 					       1,0,1);
     for my $sequence ($navmap->getById('0.0'), @sequences) {
 	if ($navmap->hasResource($sequence, sub { shift->is_problem(); }, 0) ) {
-	    my $title = $minder.'.'.$sequence->compTitle();
-	    push @titles, $title; # minder in case two titles are identical
-	    $symbx{$title} = $sequence->symb();
+	    my $title = $minder.'.'.
+		&HTML::Entities::encode($sequence->compTitle(),'"\'&');
+	    push(@titles, $title); # minder in case two titles are identical
+	    $symbx{$title} = &HTML::Entities::encode($sequence->symb(),'"\'&');
 	    $minder++;
 	}
     }
@@ -3883,7 +3895,8 @@ sub displayPage {
 	'<input type="hidden" name="overRideScore" value="no" />'."\n".
 	'<input type="hidden" name="saveState" value="'.$env{'form.saveState'}.'" />'."\n";
 
-    my $checkIcon = '<img src="'.$request->dir_config('lonIconsURL').
+    my $checkIcon = '<img alt="'.&mt('Check Mark').
+	'" src="'.$request->dir_config('lonIconsURL').
 	'/check.gif" height="16" border="0" />';
 
     $studentTable.='&nbsp;<b>Note:</b> Problems graded correct by the computer are marked with a '.$checkIcon.
@@ -3963,9 +3976,9 @@ sub displayPage {
         $curRes = $iterator->next();
     }
 
-    $studentTable.='</td></tr></table></td></tr></table>'."\n".
+    $studentTable.='</table></td></tr></table>'."\n".
 	'<input type="button" value="Save" '.
-	'onClick="javascript:checkSubmitPage(this.form,'.$question.');" TARGET=_self />'.
+	'onClick="javascript:checkSubmitPage(this.form,'.$question.');" />'.
 	'</form>'."\n";
     $studentTable.=&show_grading_menu_form($symb);
     $request->print($studentTable);
@@ -4071,7 +4084,7 @@ sub displaySubByDates {
 	if ($displaySub[2]) {
 	    $studentTable.='Manually graded by '.$displaySub[2];
 	}
-	$studentTable.='&nbsp;</td></tr>';
+	$studentTable.='&nbsp;</td></tr>3';
     
     }
     $studentTable.='</table></td></tr></table>';
@@ -4180,9 +4193,8 @@ sub updateGradeByPage {
 		$displayPts[1].='&nbsp;<b>Part:</b> '.$display_part.' = '.
 		     (($score eq 'excused') ? 'excused' : $newpts).
 		    '&nbsp;<br />';
-
 		$question++;
-		next if ($dropMenu eq 'reset status' || ($newpts == $oldpts && $score ne 'excused'));
+		next if ($dropMenu eq 'reset status' || ($newpts eq $oldpts && $score ne 'excused'));
 
 		$newrecord{'resource.'.$partid.'.awarded'}  = $partial if $partial ne '';
 		$newrecord{'resource.'.$partid.'.solved'}   = $score if $score ne '';
@@ -4194,7 +4206,12 @@ sub updateGradeByPage {
 	    if (scalar(keys(%newrecord)) > 0) {
 		&Apache::lonnet::cstore(\%newrecord,$symbx,$env{'request.course.id'},
 					$udom,$uname);
+		my %record = &Apache::lonnet::restore($symbx,$env{'request.course.id'},
+						      $udom,$uname);
+		&check_and_remove_from_queue($parts,\%record,undef,$symbx,
+					     $cdom,$cnum,$udom,$uname);
 	    }
+	    
             if ($aggregateflag) {
                 &Apache::lonnet::cinc('nohist_resourcetracker',\%aggregate,
                       $env{'course.'.$env{'request.course.id'}.'.domain'},
@@ -4308,14 +4325,14 @@ sub scantron_CODElist {
 }
 
 sub scantron_CODEunique {
-    my $result='<nobr>
+    my $result='<span style="white-space: nowrap;">
                  <label><input type="radio" name="scantron_CODEunique"
                         value="yes" checked="checked" /> Yes </label>
-                </nobr>
-                <nobr>
+                </span>
+                <span style="white-space: nowrap;">
                  <label><input type="radio" name="scantron_CODEunique"
                         value="no" /> No </label>
-                </nobr>';
+                </span>';
     return $result;
 }
 
@@ -4434,6 +4451,7 @@ SCANTRONFORM
     <tr>
       <form action='/adm/grades' name='scantron_download'>
         <td bgcolor="#777777">
+	  $default_form_data
           <input type="hidden" name="command" value="scantron_download" />
           <table width="100%" border="0">
             <tr bgcolor="#e6ffff">