--- loncom/homework/grades.pm 2007/06/16 20:24:25 1.414 +++ loncom/homework/grades.pm 2007/06/22 22:50:30 1.417 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # The LON-CAPA Grading handler # -# $Id: grades.pm,v 1.414 2007/06/16 20:24:25 www Exp $ +# $Id: grades.pm,v 1.417 2007/06/22 22:50:30 albertel Exp $ # # Copyright Michigan State University Board of Trustees # @@ -617,7 +617,7 @@ sub verifyreceipt { if ($receipt eq &Apache::lonnet::ireceipt($uname,$udom,$courseid,$symb,$part)) { $contents.='<tr bgcolor="#ffffe6"><td> '."\n". '<a href="javascript:viewOneStudent(\''.$uname.'\',\''.$udom. - '\')"; TARGET=_self>'.$$fullname{$_}.'</a> </td>'."\n". + '\');" target="_self">'.$$fullname{$_}.'</a> </td>'."\n". '<td> '.$uname.' </td>'. '<td> '.$udom.' </td>'; if ($receiptparts) { @@ -1792,10 +1792,10 @@ sub submission { # $request->print(<<KEYWORDS); <b>Keyword Options:</b> -<a href="javascript:keywords(document.SCORE)"; TARGET=_self>List</a> +<a href="javascript:keywords(document.SCORE);" target="_self">List</a> <a href="#" onMouseDown="javascript:getSel(); return false" CLASS="page">Paste Selection to List</a> -<a href="javascript:kwhighlight()"; TARGET=_self>Highlight Attribute</a><br /><br /> +<a href="javascript:kwhighlight();" target="_self">Highlight Attribute</a><br /><br /> KEYWORDS # # Load the other essays for similarity check @@ -1921,7 +1921,7 @@ KEYWORDS ' <b>Collaborative submission by:</b> '. '<a href="javascript:viewSubmitter(\''. $env{"form.$uname:$udom:$partid:submitted_by"}. - '\')"; TARGET=_self>'. + '\');" target="_self">'. $$fullname{$env{"form.$uname:$udom:$partid:submitted_by"}}.'</a><br />'; $request->print($submitby); next; @@ -1999,7 +1999,7 @@ KEYWORDS if ($env{'form.showgrading'} eq '' || (!&canmodify($usec))) { my $toGrade.='<input type="button" value="Grade Student" '. 'onClick="javascript:checksubmit(this.form,\'Grade Student\',\'' - .$counter.'\');" TARGET=_self> '."\n" if (&canmodify($usec)); + .$counter.'\');" target="_self" /> '."\n" if (&canmodify($usec)); $toGrade.='</td></tr></table></td></tr></table>'."\n"; if (($env{'form.command'} eq 'submission') || ($env{'form.command'} eq 'processGroup' && $counter == $total)) { @@ -2023,7 +2023,7 @@ KEYWORDS $result='<input type="hidden" name="includemsg'.$counter.'" value="" />'."\n". '<input type="hidden" name="newmsg'.$counter.'" value="" />'."\n"; $result.=' <a href="javascript:msgCenter(document.SCORE,'.$counter. - ',\''.$msgfor.'\')"; TARGET=_self>'. + ',\''.$msgfor.'\');" target="_self">'. &mt('Compose message to student').(scalar(@col_fullnames) >= 1 ? 's' : '').'</a><label> ('. &mt('incl. grades').' <input type="checkbox" name="withgrades'.$counter.'" /></label>)'. '<img src="'.$request->dir_config('lonIconsURL'). @@ -2075,7 +2075,7 @@ KEYWORDS my $endform='<table border="0"><tr><td>'."\n"; $endform.='<input type="button" value="Save & Next" '. 'onClick="javascript:checksubmit(this.form,\'Save & Next\','. - $total.','.scalar(@partlist).');" TARGET=_self> '."\n"; + $total.','.scalar(@partlist).');" target="_self" /> '."\n"; my $ntstu ='<select name="NTSTU">'. '<option>1</option><option>2</option>'. '<option>3</option><option>5</option>'. @@ -2084,9 +2084,9 @@ KEYWORDS $ntstu =~ s/<option>$nsel</<option selected="selected">$nsel</; $endform.=$ntstu.'student(s) '; $endform.='<input type="button" value="Previous" '. - 'onClick="javascript:checksubmit(this.form,\'Previous\');" TARGET=_self> '."\n". + 'onClick="javascript:checksubmit(this.form,\'Previous\');" target="_self" /> '."\n". '<input type="button" value="Next" '. - 'onClick="javascript:checksubmit(this.form,\'Next\');" TARGET=_self> '; + 'onClick="javascript:checksubmit(this.form,\'Next\');" target="_self" /> '; $endform.='(Next and Previous (student) do not save the scores.)'."\n" ; $endform.="<input type='hidden' value='".&get_increment(). "' name='increment' />"; @@ -3036,7 +3036,7 @@ sub viewgrades { $result.='</table>'.'</td></tr></table>'.'</td></tr></table>'."\n". '<input type="hidden" name="totalparts" value="'.$ctsparts.'" />'; $result.='<input type="button" value="Revert to Default" '. - 'onClick="javascript:resetEntry('.$ctsparts.');" TARGET=_self>'; + 'onClick="javascript:resetEntry('.$ctsparts.');" target="_self" />'; #table listing all the students in a section/class #header of table @@ -3087,7 +3087,7 @@ sub viewgrades { $result.='</table></td></tr></table>'; $result.='<input type="hidden" name="total" value="'.$ctr.'" />'."\n"; $result.='<input type="button" value="Save" '. - 'onClick="javascript:submit();" TARGET=_self /></form>'."\n"; + 'onClick="javascript:submit();" target="_self" /></form>'."\n"; if (scalar(%$fullname) eq 0) { my $colspan=3+scalar(@parts); $result='<span class="LC_warning">There are no students in section "'.$env{'form.section'}. @@ -3107,7 +3107,7 @@ sub viewstudentgrade { '<input type="hidden" name="ctr'.($ctr-1).'" value="'.$student.'" />'. "\n".$ctr.' </td><td> '. '<a href="javascript:viewOneStudent(\''.$uname.'\',\''.$udom. - '\')"; TARGET=_self>'.$fullname.'</a> '. + '\');" target="_self">'.$fullname.'</a> '. '<span class="LC_internal_info">('.$uname.($env{'user.domain'} eq $udom ? '' : ':'.$udom).')</span></td>'."\n"; $student=~s/:/_/; # colon doen't work in javascript for names foreach my $apart (@$parts) { @@ -6453,7 +6453,13 @@ sub assign_clicker_grades { my ($r)=@_; my ($symb)=&get_symb($r); if (!$symb) {return '';} +# See which part we are saving to + my ($partlist,$handgrade,$responseType) = &response_type($symb); +# FIXME: This should probably look for the first handgradeable part + my $part=$$partlist[0]; +# Start screen output my ($result) = &showResourceInfo($symb,$env{'form.probTitle'}); + my $heading=&mt('Assigning grades based on clicker file'); $result.=(<<ENDHEADER); <br /><table width="100%" border="0"><tr><td bgcolor="#777777"> @@ -6463,7 +6469,9 @@ ENDHEADER # Get correct result # FIXME: Possibly need delimiter other than ":" my @correct=(); - if ($env{'form.gradingmechanism'} ne 'attendance') { + my $gradingmechanism=$env{'form.gradingmechanism'}; + my $number=$env{'form.number'}; + if ($gradingmechanism ne 'attendance') { foreach my $key (keys(%env)) { if ($key=~/^form\.correct\:/) { my @input=split(/\,/,$env{$key}); @@ -6479,7 +6487,7 @@ ENDHEADER } } } - for (my $i=0;$i<$env{'form.number'};$i++) { + for (my $i=0;$i<$number;$i++) { if (!$correct[$i]) { $result.='<br /><span class="LC_error">'. &mt('No correct result given for question "[_1]"!', @@ -6489,7 +6497,47 @@ ENDHEADER $result.='<br />'.&mt("Correct answer: [_1]",join(', ',map { ($_?$_:'-') } @correct)); } # Start grading - $result.='</td></tr></table>'."\n". + my $pcorrect=$env{'form.pcorrect'}; + my $pincorrect=$env{'form.pincorrect'}; + my $storecount=0; + foreach my $key (keys(%env)) { + if ($key=~/^form\.student\:(.*)$/) { + my $user=$1; + my @answer=split(/\,/,$env{$key}); + my $sum=0; + for (my $i=0;$i<$number;$i++) { + if ($answer[$i]) { + if ($gradingmechanism eq 'attendance') { + $sum+=$pcorrect; + } else { + if ($answer[$i] eq $correct[$i]) { + $sum+=$pcorrect; + } else { + $sum+=$pincorrect; + } + } + } + } + my $ave=$sum/(100*$number); +# Store + my ($username,$domain)=split(/\:/,$user); + my %grades=(); + $grades{"resource.$part.solved"}='correct_by_override'; + $grades{"resource.$part.awarded"}=$ave; + $grades{"resource.regrader"}="$env{'user.name'}:$env{'user.domain'}"; + my $returncode=&Apache::lonnet::cstore(\%grades,$symb, + $env{'request.course.id'}, + $domain,$username); + if ($returncode ne 'ok') { + $result.="<br /><span class=\"LC_error\">Failed to save student $username:$domain. Message when trying to save was ($returncode)</span>"; + } else { + $storecount++; + } + } + } +# We are done + $result.='<br />'.&mt('Successfully stored grades for [_1] student(s).',$storecount). + '</td></tr></table>'."\n". '</td></tr></table><br /><br />'."\n"; return $result.&show_grading_menu_form($symb); }