--- loncom/homework/grades.pm	2007/11/16 08:52:15	1.494
+++ loncom/homework/grades.pm	2007/11/19 10:57:23	1.496
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # The LON-CAPA Grading handler
 #
-# $Id: grades.pm,v 1.494 2007/11/16 08:52:15 albertel Exp $
+# $Id: grades.pm,v 1.496 2007/11/19 10:57:23 foxr Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -48,88 +48,6 @@ use POSIX qw(floor);
 
 
 my %perm=();
-my %bubble_lines_per_response = ();     # no. bubble lines for each response.
-                                   # index is "symb.part_id"
-
-my %first_bubble_line = ();	# First bubble line no. for each bubble.
-
-# Save and restore the bubble lines array to the form env.
-
-
-sub save_bubble_lines {
-    foreach my $line (keys(%bubble_lines_per_response)) {
-	$env{"form.scantron.bubblelines.$line"}  = $bubble_lines_per_response{$line};
-	$env{"form.scantron.first_bubble_line.$line"} =
-	    $first_bubble_line{$line};
-    }
-}
-
-
-sub restore_bubble_lines {
-    my $line = 0;
-    %bubble_lines_per_response = ();
-    while ($env{"form.scantron.bubblelines.$line"}) {
-	my $value = $env{"form.scantron.bubblelines.$line"};
-	$bubble_lines_per_response{$line} = $value;
-	$first_bubble_line{$line}  =
-	    $env{"form.scantron.first_bubble_line.$line"};
-	$line++;
-    }
-
-}
-
-#  Given the parsed scanline, get the response for 
-#  'answer' number n:
-
-sub get_response_bubbles {
-    my ($parsed_line, $response)  = @_;
-
-
-    my $bubble_line = $first_bubble_line{$response-1} +1;
-    my $bubble_lines= $bubble_lines_per_response{$response-1};
-    
-    my $selected = "";
-
-    for (my $bline = 0; $bline < $bubble_lines; $bline++) {
-	$selected .= $$parsed_line{"scantron.$bubble_line.answer"}.":";
-	$bubble_line++;
-    }
-    return $selected;
-}
-
-
-# ----- These first few routines are general use routines.----
-
-# Return the number of occurences of a pattern in a string.
-
-sub occurence_count {
-    my ($string, $pattern) = @_;
-
-    my @matches = ($string =~ /$pattern/g);
-
-    return scalar(@matches);
-}
-
-
-# Take a string known to have digits and convert all the
-# digits into letters in the range J,A..I.
-
-sub digits_to_letters {
-    my ($input) = @_;
-
-    my @alphabet = ('J', 'A'..'I');
-
-    my @input    = split(//, $input);
-    my $output ='';
-    for (my $i = 0; $i < scalar(@input); $i++) {
-	if ($input[$i] =~ /\d/) {
-	    $output .= $alphabet[$input[$i]];
-	} else {
-	    $output .= $input[$i];
-	}
-    }
-    return $output;
-}
 
 #
 # --- Retrieve the parts from the metadata file.---
@@ -4757,6 +4675,54 @@ sub getSequenceDropDown {
     return $result;
 }
 
+my %bubble_lines_per_response;     # no. bubble lines for each response.
+                                   # index is "symb.part_id"
+
+my %first_bubble_line;             # First bubble line no. for each bubble.
+
+# Save and restore the bubble lines array to the form env.
+
+
+sub save_bubble_lines {
+    foreach my $line (keys(%bubble_lines_per_response)) {
+	$env{"form.scantron.bubblelines.$line"}  = $bubble_lines_per_response{$line};
+	$env{"form.scantron.first_bubble_line.$line"} =
+	    $first_bubble_line{$line};
+    }
+}
+
+
+sub restore_bubble_lines {
+    my $line = 0;
+    %bubble_lines_per_response = ();
+    while ($env{"form.scantron.bubblelines.$line"}) {
+	my $value = $env{"form.scantron.bubblelines.$line"};
+	$bubble_lines_per_response{$line} = $value;
+	$first_bubble_line{$line}  =
+	    $env{"form.scantron.first_bubble_line.$line"};
+	$line++;
+    }
+
+}
+
+#  Given the parsed scanline, get the response for 
+#  'answer' number n:
+
+sub get_response_bubbles {
+    my ($parsed_line, $response)  = @_;
+
+
+    my $bubble_line = $first_bubble_line{$response-1} +1;
+    my $bubble_lines= $bubble_lines_per_response{$response-1};
+    
+    my $selected = "";
+
+    for (my $bline = 0; $bline < $bubble_lines; $bline++) {
+	$selected .= $$parsed_line{"scantron.$bubble_line.answer"}.":";
+	$bubble_line++;
+    }
+    return $selected;
+}
 
 =pod 
 
@@ -5301,6 +5267,39 @@ sub scan_data {
     return $scan_data->{$filename.'_'.$key};
 }
 
+# ----- These first few routines are general use routines.----
+
+# Return the number of occurences of a pattern in a string.
+
+sub occurence_count {
+    my ($string, $pattern) = @_;
+
+    my @matches = ($string =~ /$pattern/g);
+
+    return scalar(@matches);
+}
+
+
+# Take a string known to have digits and convert all the
+# digits into letters in the range J,A..I.
+
+sub digits_to_letters {
+    my ($input) = @_;
+
+    my @alphabet = ('J', 'A'..'I');
+
+    my @input    = split(//, $input);
+    my $output ='';
+    for (my $i = 0; $i < scalar(@input); $i++) {
+	if ($input[$i] =~ /\d/) {
+	    $output .= $alphabet[$input[$i]];
+	} else {
+	    $output .= $input[$i];
+	}
+    }
+    return $output;
+}
+
 =pod 
 
 =item scantron_parse_scanline
@@ -6670,17 +6669,16 @@ sub scantron_bubble_selector {
     if ($scmode eq 'number' || $scmode eq 'letter') { $max=10; }	     
 
     my $response = $quest-1;
-    my $lines = $bubble_lines_per_response{$response};
+    my $lines       = $bubble_lines_per_response{$response};
+    my $line_number = $first_bubble_line{$response} +1;
 
     my $total_lines = $lines*2;
     my @alphabet=('A'..'Z');
 
-    $r->print("<table border='1'><tr><td rowspan='".$total_lines."'>$quest</td>");
+    $r->print("<table border='1'>\n");
 
     for (my $l = 0; $l < $lines; $l++) {
-	if ($l != 0) {
-	    $r->print('<tr>');
-	}
+	$r->print("<tr><td></td>\n");
 	my @selected = split(//,$lines[$l]);
 	for (my $i=0;$i<$max;$i++) {
 	    $r->print("\n".'<td align="center">');
@@ -6702,11 +6700,10 @@ sub scantron_bubble_selector {
 	
 	}
 
-	$r->print('</tr><tr>');
+	$r->print("</tr><tr><td>$line_number</td>");
 
 	# FIXME: This may have to be a bit more clever for
 	#        multiline questions (different values e.g..).
-
 	for (my $i=0;$i<$max;$i++) {
 	    my $value = "$l:$i";	# Relative bubble line #: Bubble in line.
 	    $r->print("\n".
@@ -6714,7 +6711,7 @@ sub scantron_bubble_selector {
 		      $quest.'" value="'.$value.'" />'.$alphabet[$i]."</label></td>");
 	}
 	$r->print('</tr>');
-
+	$line_number++;
 	    
     }
     $r->print('</table>');