--- loncom/homework/grades.pm 2008/12/20 04:04:36 1.538 +++ loncom/homework/grades.pm 2008/12/21 22:01:35 1.539 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # The LON-CAPA Grading handler # -# $Id: grades.pm,v 1.538 2008/12/20 04:04:36 schulted Exp $ +# $Id: grades.pm,v 1.539 2008/12/21 22:01:35 riegler Exp $ # # Copyright Michigan State University Board of Trustees # @@ -217,9 +217,9 @@ sub showResourceInfo { $partsseen{$partID}=1; } my $display_part=&get_display_part($partID,$symb); - $result.='<td>'.&mt('<b>Part: </b>[_1]',$display_part).' <span class="LC_internal_info">'. - $resID.'</span></td>'. - '<td>'.&mt('<b>Type: </b>[_1]',$responsetype).'</td></tr>'; + $result.='<td><b>'.&mt('Part').': </b>'.$display_part. + ' <span class="LC_internal_info">'.$resID.'</span></td>'. + '<td><b>'.&mt('Type').': </b>'.$responsetype.'</td></tr>'; # '<td>'.&mt('<b>Handgrade: </b>[_1]',$handgrade).'</td></tr>'; } } @@ -779,20 +779,20 @@ sub listStudents { my $getsec = $env{'form.section'} eq '' ? 'all' : $env{'form.section'}; my $getgroup = $env{'form.group'} eq '' ? 'all' : $env{'form.group'}; my $submitonly= $env{'form.submitonly'} eq '' ? 'all' : $env{'form.submitonly'}; - my $viewgrade = $env{'form.showgrading'} eq 'yes' ? 'View/Grade/Regrade' : 'View'; + my $viewgrade = $env{'form.showgrading'} eq 'yes' ? &mt('View/Grade/Regrade') : &mt('View'); $env{'form.probTitle'} = $env{'form.probTitle'} eq '' ? &Apache::lonnet::gettitle($symb) : $env{'form.probTitle'}; - my $result='<h3><span class="LC_info"> '. - &mt($viewgrade.' Submissions for a Student or a Group of Students') + my $result='<h3><span class="LC_info"> '.$viewgrade. + &mt(' Submissions for a Student or a Group of Students') .'</span></h3>'; my ($table,undef,$hdgrade,$partlist,$handgrade) = &showResourceInfo($symb,$env{'form.probTitle'},($env{'form.showgrading'} eq 'yes')); my %lt = ( 'multiple' => - "Please select a student or group of students before clicking on the Next button.", + &mt("Please select a student or group of students before clicking on the Next button."), 'single' => - "Please select the student before clicking on the Next button.", + &mt("Please select the student before clicking on the Next button."), ); %lt = &Apache::lonlocal::texthash(%lt); $request->print(<<LISTJAVASCRIPT); @@ -837,17 +837,15 @@ LISTJAVASCRIPT "\n".$table; $gradeTable .= - ' '. - &mt('<b>View Problem Text: </b>[_1]', + ' <b>'.&mt('View Problem Text').': </b>'. '<label><input type="radio" name="vProb" value="no" checked="checked" /> '.&mt('no').' </label>'."\n". '<label><input type="radio" name="vProb" value="yes" /> '.&mt('one student').' </label>'."\n". - '<label><input type="radio" name="vProb" value="all" /> '.&mt('all students').' </label>').'<br />'."\n"; + '<label><input type="radio" name="vProb" value="all" /> '.&mt('all students').' </label><br />'."\n"; $gradeTable .= - ' '. - &mt('<b>View Answer: </b>[_1]', + ' <b>'.&mt('View Answer').': </b>'. '<label><input type="radio" name="vAns" value="no" /> '.&mt('no').' </label>'."\n". '<label><input type="radio" name="vAns" value="yes" /> '.&mt('one student').' </label>'."\n". - '<label><input type="radio" name="vAns" value="all" checked="checked" /> '.&mt('all students').' </label>').'<br />'."\n"; + '<label><input type="radio" name="vAns" value="all" checked="checked" /> '.&mt('all students').' </label><br />'."\n"; my $submission_options; if ($env{'form.handgrade'} eq 'yes' && scalar(@$partlist) > 1) { @@ -863,18 +861,16 @@ LISTJAVASCRIPT '<label><input type="radio" name="lastSub" value="datesub" /> '.&mt('by dates and submissions').' </label>'."\n". '<label><input type="radio" name="lastSub" value="all" /> '.&mt('all details').'</label>'; $gradeTable .= - ' '. - &mt('<b>Submissions: </b>[_1]',$submission_options).'<br />'."\n"; + ' <b>'.&mt('Submissions').': </b>'.$submission_options.'<br />'."\n"; $gradeTable .= - ' '. - &mt('<b>Grading Increments:</b> [_1]', + ' <b>'.&mt('Grading Increments').': </b>'. '<select name="increment">'. '<option value="1">'.&mt('Whole Points').'</option>'. '<option value=".5">'.&mt('Half Points').'</option>'. '<option value=".25">'.&mt('Quarter Points').'</option>'. '<option value=".1">'.&mt('Tenths of a Point').'</option>'. - '</select>'); + '</select>'; $gradeTable .= &build_section_inputs(). @@ -893,15 +889,14 @@ LISTJAVASCRIPT &Apache::lonhtmlcommon::StatusOptions($saveStatus,undef,1,'javascript:reLoadList(this.form);')).'<br />'; } - $gradeTable.=&mt('To '.lc($viewgrade).' a submission or a group of submissions, click on the check box(es) '. - 'next to the student\'s name(s). Then click on the Next button.').'<br />'."\n". + $gradeTable.=&mt('To [_1] a submission or a group of submissions, click on the check box(es) next to the student\'s name(s). Then click on the Next button.',lc($viewgrade)).'<br />'."\n". '<input type="hidden" name="command" value="processGroup" />'."\n"; # checkall buttons $gradeTable.=&check_script('gradesub', 'stuinfo'); $gradeTable.='<input type="button" '."\n". 'onClick="javascript:checkSelect(this.form.stuinfo);" '."\n". - 'value="'.&mt('Next->').'" /> <br />'."\n"; + 'value="'.&mt('Next').' →" /> <br />'."\n"; $gradeTable.=&check_buttons(); $gradeTable.='<label><input type="checkbox" name="checkPlag" checked="checked" />'.&mt('Check For Plagiarism').'</label>'; my ($classlist, undef, $fullname) = &getclasslist($getsec,'1',$getgroup); @@ -1021,7 +1016,7 @@ LISTJAVASCRIPT $gradeTable.=&Apache::loncommon::end_data_table()."\n". '<input type="button" '. 'onClick="javascript:checkSelect(this.form.stuinfo);" '. - 'value="'.&mt('Next->').'" /></form>'."\n"; + 'value="'.&mt('Next').' →" /></form>'."\n"; if ($ctr == 0) { my $num_students=(scalar(keys(%$fullname))); if ($num_students eq 0) { @@ -1117,6 +1112,7 @@ sub processGroup { #--- Javascript to handle the submission page functionality --- sub sub_page_js { my $request = shift; + my $alertmsg = &mt('A number equal or greater than 0 is expected. Entered value = '); $request->print(<<SUBJAVASCRIPT); <script type="text/javascript" language="javascript"> function updateRadio(formname,id,weight) { @@ -1127,7 +1123,7 @@ sub sub_page_js { gradeBox.value = pts; var resetbox = false; if (isNaN(pts) || pts < 0) { - alert("A number equal or greater than 0 is expected. Entered value = "+pts); + alert("$alertmsg"+pts); for (var i=0; i<radioButton.length; i++) { if (radioButton[i].checked) { gradeBox.value = i; @@ -1372,6 +1368,7 @@ INNERJS my $docopen=&Apache::lonhtmlcommon::javascript_docopen(); $docopen=~s/^document\.//; + my $alertmsg = &mt('Please select a word or group of words from document and then click this link.'); $request->print(<<SUBJAVASCRIPT); <script type="text/javascript" language="javascript"> @@ -1404,7 +1401,7 @@ INNERJS else return; var cleantxt = txt.replace(new RegExp('([\\f\\n\\r\\t\\v ])+', 'g')," "); if (cleantxt=="") { - alert("Please select a word or group of words from document and then click this link."); + alert("$alertmsg"); return; } var nret = prompt("Add selection to keyword list? Edit if desired.",cleantxt); @@ -2056,7 +2053,7 @@ KEYWORDS $lastsubonly.="\n".'<div class="LC_grade_submission_part"><b>Part:</b> '. $display_part.' <span class="LC_internal_info">( ID '.$respid. ' )</span> '. - '<span class="LC_warning">'.&mt('Nothing submitted - no attempts').'</span><br /><br /></div>'; + '<span class="LC_warning">'.&mt('Nothing submitted - no attempts.').'</span><br /><br /></div>'; next; } foreach my $submission (@$string) { @@ -2334,7 +2331,7 @@ sub get_last_submission { } if (!@string) { $string[0] = - '<span class="LC_warning">Nothing submitted - no attempts.</span>'; + '<span class="LC_warning">'.&mt('Nothing submitted - no attempts.').'</span>'; } return (\@string,\$timestamp); } @@ -2980,6 +2977,7 @@ sub file_name_version_ext { sub viewgrades_js { my ($request) = shift; + my $alertmsg = &mt('A number equal or greater than 0 is expected. Entered value = '); $request->print(<<VIEWJAVASCRIPT); <script type="text/javascript" language="javascript"> function writePoint(partid,weight,point) { @@ -2988,7 +2986,7 @@ sub viewgrades_js { if (point == "textval") { point = document.classgrade["TEXTVAL_"+partid].value; if (isNaN(point) || parseFloat(point) < 0) { - alert("A number equal or greater than 0 is expected. Entered value = "+parseFloat(point)); + alert("$alertmsg"+parseFloat(point)); var resetbox = false; for (var i=0; i<radioButton.length; i++) { if (radioButton[i].checked) { @@ -3086,7 +3084,7 @@ sub viewgrades_js { var weight = document.classgrade["weight_"+partid].value; if (isNaN(point) || parseFloat(point) < 0) { - alert("A number equal or greater than 0 is expected. Entered value = "+parseFloat(point)); + alert("$alertmsg"+parseFloat(point)); textbox.value = ""; return; } @@ -3178,15 +3176,15 @@ sub viewgrades { my $sectionClass; my $section_display = join (", ",&Apache::loncommon::get_env_multiple('form.section')); if ($env{'form.section'} eq 'all') { - $sectionClass='Class'; + $sectionClass=&mt('Class'); } elsif ($env{'form.section'} eq 'none') { - $sectionClass='Students in no Section'; + $sectionClass=&mt('Students in no Section'); } else { - $sectionClass='Students in Section(s) [_1]'; + $sectionClass=&mt('Students in Section(s) [_1]'); } $result.= '<h3>'. - &mt("Assign Common Grade To $sectionClass",$section_display).'</h3>'; + &mt("Assign Common Grade to [_1]",$sectionClass,$section_display).'</h3>'; $result.= &Apache::loncommon::start_data_table(); #radio buttons/text box for assigning points for a section or class. #handles different parts of a problem @@ -3218,8 +3216,8 @@ sub viewgrades { my $line = '<input type="text" name="TEXTVAL_'. $partid.'" size="4" '.'onChange="javascript:writePoint(\''. $partid.'\','.$weight{$partid}.',\'textval\')" /> /'. - $weight{$partid}.' (problem weight)</td>'."\n"; - $line.= '<td><select name="SELVAL_'.$partid.'"'. + $weight{$partid}.' '.&mt('(problem weight)').'</td>'."\n"; + $line.= '<td><b>'.&mt('Grade Status').':</b><select name="SELVAL_'.$partid.'"'. 'onChange="javascript:writeRadText(\''.$partid.'\','. $weight{$partid}.')"> '. '<option selected="selected"> </option>'. @@ -3232,9 +3230,10 @@ sub viewgrades { $line.='<input type="hidden" name="weight_'. $partid.'" value="'.$weight{$partid}.'" />'."\n"; + #&mt('<td><b>Part:</b></td><td>[_1]</td><td><b>Points:</b></td><td>[_2]</td><td>or</td><td>[_3]</td>',$display_part,$radio,$line). $result.= &Apache::loncommon::start_data_table_row()."\n". - &mt('<td><b>Part:</b></td><td>[_1]</td><td><b>Points:</b></td><td>[_2]</td><td>or</td><td>[_3]</td>',$display_part,$radio,$line). + '<td><b>'.&mt('Part').':</b></td><td>'.$display_part.'</td><td><b>'.&mt('Points').':</b></td><td>'.$radio.'</td><td>'.&mt('or').'</td><td>'.$line.'</td>'. &Apache::loncommon::end_data_table_row()."\n"; $ctsparts++; } @@ -3245,8 +3244,8 @@ sub viewgrades { #table listing all the students in a section/class #header of table - $result.= '<h3>'.&mt('Assign Grade to Specific Students in '.$sectionClass, - $section_display).'</h3>'; + $result.= '<h3>'.&mt('Assign Grade to Specific Students in ').$sectionClass, + $section_display.'</h3>'; $result.= &Apache::loncommon::start_data_table(). &Apache::loncommon::start_data_table_header_row(). '<th>'.&mt('No.').'</th>'. @@ -3256,7 +3255,8 @@ sub viewgrades { my @partids = (); foreach my $part (@parts) { my $display=&Apache::lonnet::metadata($url,$part.'.display'); - $display =~ s|^Number of Attempts|Tries<br />|; # makes the column narrower + my $narrowtext = &mt('Tries'); + $display =~ s|^Number of Attempts|$narrowtext <br />|; # makes the column narrower if (!$display) { $display = &Apache::lonnet::metadata($url,$part.'.name'); } my ($partid) = &split_part_type($part); push(@partids,$partid); @@ -3428,9 +3428,10 @@ sub editgrades { if ($type eq 'awarded' || $type eq 'solved') { next; } my $display=&Apache::lonnet::metadata($url,$stores.'.display'); $display =~ s/\[Part: (\w)+\]//; - $display =~ s/Number of Attempts/Tries/; - $header .= '<th align="center">'.&mt('Old '.$display).'</th>'. - '<th align="center">'.&mt('New '.$display).'</th>'; + my $narrowtext = &mt('Tries'); + $display =~ s/Number of Attempts/$narrowtext/; + $header .= '<th align="center">'.&mt('Old').' '.$display.'</th>'. + '<th align="center">'.&mt('New').' '.$display.'</th>'; $columns{$partid}+=2; } } @@ -3772,11 +3773,12 @@ ENDPICK } sub checkforfile_js { + my $alertmsg = &mt('Please use the browse button to select a file from your local directory.'); my $result =<<CSVFORMJS; <script type="text/javascript" language="javascript"> function checkUpload(formname) { if (formname.upfile.value == "") { - alert("Please use the browse button to select a file from your local directory."); + alert("$alertmsg"); return false; } formname.submit(); @@ -4050,12 +4052,13 @@ sub csvuploadassign { sub pickStudentPage { my ($request) = shift; + my $alertmsg = &mt('Please select the student you wish to grade.'); $request->print(<<LISTJAVASCRIPT); <script type="text/javascript" language="javascript"> function checkPickOne(formname) { if (radioSelection(formname.student) == null) { - alert("Please select the student you wish to grade."); + alert("$alertmsg"); return; } ptr = pullDownSelection(formname.selectpage); @@ -4090,7 +4093,7 @@ LISTJAVASCRIPT $ctr++; } $select.= '</select>'; - $result.=&mt(' <b>Problems from:</b> [_1]',$select)."<br />\n"; + $result.=' <b>'.&mt('Problems from').':</b> '.$select."<br />\n"; $ctr=0; foreach (@$titles) { @@ -4105,13 +4108,13 @@ LISTJAVASCRIPT my $options = '<label><input type="radio" name="vProb" value="no" checked="checked" /> '.&mt('no').' </label>'."\n". '<label><input type="radio" name="vProb" value="yes" /> '.&mt('yes').' </label>'."<br />\n"; - $result.=' '.&mt('<b>View Problems Text: </b> [_1]',$options); + $result.=' <b>'.&mt('View Problem Text').': </b>'.$options; $options = '<label><input type="radio" name="lastSub" value="none" /> '.&mt('none').' </label>'."\n". '<label><input type="radio" name="lastSub" value="datesub" checked="checked" /> '.&mt('by dates and submissions').'</label>'."\n". '<label><input type="radio" name="lastSub" value="all" /> '.&mt('all details').' </label>'."\n"; - $result.=' '.&mt('<b>Submission Details: </b>[_1]',$options); + $result.=' <b>'.&mt('Submissions').': </b>'.$options; $result.=&build_section_inputs(); my $stu_status = join(':',&Apache::loncommon::get_env_multiple('form.Status')); @@ -4120,12 +4123,10 @@ LISTJAVASCRIPT '<input type="hidden" name="symb" value="'.&Apache::lonenc::check_encrypt($symb).'" />'."\n". '<input type="hidden" name="saveState" value="'.$env{'form.saveState'}.'" />'."<br />\n"; - $result.=' '.&mt('<b>Use CODE: [_1] </b>', - '<input type="text" name="CODE" value="" />'). - '<br />'."\n"; + $result.=' <b>'.&mt('Use CODE').': </b> <input type="text" name="CODE" value="" /> <br />'."\n"; $result.=' <input type="button" '. - 'onClick="javascript:checkPickOne(this.form);" value="'.&mt('Next->').'" /><br />'."\n"; + 'onClick="javascript:checkPickOne(this.form);" value="'.&mt('Next').' →" /><br />'."\n"; $request->print($result); @@ -4164,7 +4165,7 @@ LISTJAVASCRIPT } $studentTable.=&Apache::loncommon::end_data_table()."\n"; $studentTable.='<input type="button" '. - 'onClick="javascript:checkPickOne(this.form);" value="'.&mt('Next->').'" /></form>'."\n"; + 'onClick="javascript:checkPickOne(this.form);" value="'.&mt('Next').' →" /></form>'."\n"; $studentTable.=&show_grading_menu_form($symb); $request->print($studentTable); @@ -4301,7 +4302,7 @@ sub displayPage { # $request->print('match='.$1."<br />\n"); # } # $companswer =~ s|<table border=\"1\">|<table border=\"0\">|g; - $studentTable.=' <b>'.$title.'</b> <br /> '.&mt('<b>Correct answer:</b><br />[_1]',$companswer); + $studentTable.=' <b>'.$title.'</b> <br /> <b>'.&mt('Correct answer').':</b><br />'.$companswer; } my %record = &Apache::lonnet::restore($symbx,$env{'request.course.id'},$udom,$uname); @@ -4371,7 +4372,7 @@ sub displaySubByDates { my %orders; $mark{'correct_by_student'} = $checkIcon; if (!exists($$record{'1:timestamp'})) { - return '<br /> <span class="LC_warning">'.&mt('Nothing submitted - no attempts').'</span><br />'; + return '<br /> <span class="LC_warning">'.&mt('Nothing submitted - no attempts.').'</span><br />'; } my $interaction; @@ -6189,15 +6190,15 @@ sub scantron_validate_file { } if ($stop) { if ($validate_phases[$currentphase] eq 'sequence') { - $r->print('<input type="submit" name="submit" value="'.&mt('Ignore ->').' " />'); + $r->print('<input type="submit" name="submit" value="'.&mt('Ignore').' → " />'); $r->print(' '.&mt('this error').' <br />'); $r->print(" <p>".&mt("Or click the 'Grading Menu' button to start over.")."</p>"); } else { if ($validate_phases[$currentphase] eq 'doublebubble' || $validate_phases[$currentphase] eq 'missingbubbles') { - $r->print('<input type="button" name="submitbutton" value="'.&mt('Continue ->').'" onclick="javascript:verify_bubble_radio(this.form)" />'); + $r->print('<input type="button" name="submitbutton" value="'.&mt('Continue').' →" onclick="javascript:verify_bubble_radio(this.form)" />'); } else { - $r->print('<input type="submit" name="submit" value="'.&mt('Continue ->').'" />'); + $r->print('<input type="submit" name="submit" value="'.&mt('Continue').' →" />'); } $r->print(' '.&mt('using corrected info').' <br />'); $r->print("<input type='submit' value='".&mt("Skip")."' name='scantron_skip_record' />"); @@ -7550,7 +7551,7 @@ sub scantron_upload_scantron_data { <script type="text/javascript" language="javascript"> function checkUpload(formname) { if (formname.upfile.value == "") { - alert("Please use the browse button to select a file from your local directory."); + alert("'.&mt('Please use the browse button to select a file from your local directory.').'"); return false; } formname.submit(); @@ -8055,13 +8056,13 @@ sub grading_menu { $Str .= Apache::lonhtmlcommon::generate_menu(@menu); #$menudata->{'jscript'} $Str .='<hr /><input type="button" value="'.&mt('Verify Receipt').'" '. - ''. ' onClick="javascript:checkChoice(document.forms.gradingMenu,\'5\',\'verify\')" '. ' /> '. &Apache::lonnet::recprefix($env{'request.course.id'}). '-<input type="text" name="receipt" size="4" onChange="javascript:checkReceiptNo(this.form,\'OK\')" />'; $Str .="</form>\n"; + my $receiptalert = &mt("Please enter a receipt number given by a student in the receipt box."); $request->print(<<GRADINGMENUJS); <script type="text/javascript" language="javascript"> function checkChoice(formname,val,cmdx) { @@ -8089,7 +8090,7 @@ sub grading_menu { if (nospace == "OK" && isNaN(receiptNo)) {checkOpt = true;} if (nospace == "notOK" && (isNaN(receiptNo) || receiptNo == "")) {checkOpt = true;} if (checkOpt) { - alert("Please enter a receipt number given by a student in the receipt box."); + alert("$receiptalert"); formname.receipt.value = ""; formname.receipt.focus(); return false; @@ -8110,6 +8111,7 @@ sub submit_options { if (!$symb) {return '';} my $probTitle = &Apache::lonnet::gettitle($symb); + my $receiptalert = &mt("Please enter a receipt number given by a student in the receipt box."); $request->print(<<GRADINGMENUJS); <script type="text/javascript" language="javascript"> function checkChoice(formname,val,cmdx) { @@ -8137,7 +8139,7 @@ sub submit_options { if (nospace == "OK" && isNaN(receiptNo)) {checkOpt = true;} if (nospace == "notOK" && (isNaN(receiptNo) || receiptNo == "")) {checkOpt = true;} if (checkOpt) { - alert("Please enter a receipt number given by a student in the receipt box."); + alert("$receiptalert"); formname.receipt.value = ""; formname.receipt.focus(); return false; @@ -8240,7 +8242,7 @@ GRADINGMENUJS </label> </div> <div> - <input type="button" onClick="javascript:checkChoice(this.form,\'2\');" value="'.&mt('Next->').'" /> + <input type="button" onClick="javascript:checkChoice(this.form,\'2\');" value="'.&mt('Next').' →" /> </div> </div> @@ -8257,7 +8259,7 @@ GRADINGMENUJS </label> </div> <div> - <input type="button" onClick="javascript:checkChoice(this.form,\'2\');" value="'.&mt('Next->').'" /> + <input type="button" onClick="javascript:checkChoice(this.form,\'2\');" value="'.&mt('Next').' →" /> </div> </div> </form>';