--- loncom/homework/grades.pm 2010/01/18 17:54:26 1.590 +++ loncom/homework/grades.pm 2010/02/08 01:09:36 1.593 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # The LON-CAPA Grading handler # -# $Id: grades.pm,v 1.590 2010/01/18 17:54:26 bisitz Exp $ +# $Id: grades.pm,v 1.593 2010/02/08 01:09:36 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -160,6 +160,10 @@ sub response_type { return; } my $res = $navmap->getBySymb($symb); + unless (ref($res)) { + $$response_error = 1; + return; + } my $partlist = $res->parts(); my %vPart = map { $_ => 1 } (&Apache::loncommon::get_env_multiple('form.vPart')); @@ -944,10 +948,18 @@ LISTJAVASCRIPT my $saveStatus = $stu_status eq '' ? 'Active' : $stu_status; $env{'form.Status'} = $saveStatus; $submission_options.= - '<label><input type="radio" name="lastSub" value="lastonly" '.$checklastsub.' /> '.&mt('last submission only').' </label>'."\n". - '<label><input type="radio" name="lastSub" value="last" /> '.&mt('last submission & parts info').' </label>'."\n". - '<label><input type="radio" name="lastSub" value="datesub" /> '.&mt('by dates and submissions').' </label>'."\n". - '<label><input type="radio" name="lastSub" value="all" /> '.&mt('all details').'</label>'; + '<span class="LC_nobreak">'. + '<label><input type="radio" name="lastSub" value="lastonly" '.$checklastsub.' /> '. + &mt('last submission only').' </label></span>'."\n". + '<span class="LC_nobreak">'. + '<label><input type="radio" name="lastSub" value="last" /> '. + &mt('last submission & parts info').' </label></span>'."\n". + '<span class="LC_nobreak">'. + '<label><input type="radio" name="lastSub" value="datesub" /> '. + &mt('by dates and submissions').'</label></span>'."\n". + '<span class="LC_nobreak">'. + '<label><input type="radio" name="lastSub" value="all" /> '. + &mt('all details').'</label></span>'; $gradeTable .= &Apache::lonhtmlcommon::row_title(&mt('Submissions')) .$submission_options .&Apache::lonhtmlcommon::row_closure(); @@ -2079,12 +2091,31 @@ KEYWORDS } # This is where output for one specific student would start - my $add_class = ($counter%2) ? 'LC_grade_show_user_odd_row' : ''; - $request->print("\n\n". - '<div class="LC_grade_show_user '.$add_class.'">'. - '<div class="LC_grade_user_name">'.&nameUserString(undef,$env{'form.fullname'},$uname,$udom).'</div>'. - '<div class="LC_grade_show_user_body">'."\n"); + my $add_class = ($counter%2) ? ' LC_grade_show_user_odd_row' : ''; + $request->print( + "\n\n" + .'<div class="LC_grade_show_user'.$add_class.'">' + .'<h2>'.&nameUserString(undef,$env{'form.fullname'},$uname,$udom).'</h2>' + ."\n" + ); + + # Show additional functions if allowed + if ($perm{'vgr'}) { + $request->print( + &Apache::loncommon::track_student_link( + &mt('View recent activity'), + $uname,$udom,'check') + .' ' + ); + } + if ($perm{'opa'}) { + $request->print( + &Apache::loncommon::pprmlink( + &mt('Set/Change parameters'), + $uname,$udom,$symb,'check')); + } + # Show Problem if ($env{'form.vProb'} eq 'all' or $env{'form.vAns'} eq 'all') { my $mode; if ($env{'form.vProb'} eq 'all' && $env{'form.vAns'} eq 'all') { @@ -2144,7 +2175,9 @@ KEYWORDS if ($$timestamp eq '') { $lastsubonly.='<div class="LC_grade_submissions_body">'.$$string[0].'</div>'; } else { - $lastsubonly = '<div class="LC_grade_submissions_body"> <b>Date Submitted:</b> '.$$timestamp."\n"; + $lastsubonly = + '<div class="LC_grade_submissions_body">' + .'<b>'.&mt('Date Submitted:').'</b> '.$$timestamp."\n"; my %seenparts; my @part_response_id = &flatten_responseType($responseType); @@ -2298,7 +2331,7 @@ KEYWORDS '<div class="LC_Box">' .'<h3 class="LC_hcell">'.&mt('Assign Grades').'</h3>' ); - $request->print(&gradeBox_start()); # <div class="LC_grade_assign_body"> + $request->print(&gradeBox_start()); foreach my $part_response_id (@part_response_id) { my ($partid,$respid) = @{ $part_response_id }; my $part_resp = join('_',@{ $part_response_id }); @@ -2314,16 +2347,6 @@ KEYWORDS $request->print('</div>'); $request->print('<div class="LC_grade_info_links">'); - if ($perm{'vgr'}) { - $request->print( - &Apache::loncommon::track_student_link(&mt('View recent activity'), - $uname,$udom,'check')); - } - if ($perm{'opa'}) { - $request->print( - &Apache::loncommon::pprmlink(&mt('Set/Change parameters'), - $uname,$udom,$symb,'check')); - } $request->print('</div>'); $result='<input type="hidden" name="partlist'.$counter. @@ -2340,13 +2363,12 @@ KEYWORDS # Done with printing info for one student - $request->print('</div>');#LC_grade_show_user_body $request->print('</div>');#LC_grade_show_user # print end of form if ($counter == $total) { - my $endform='<table border="0"><tr><td>'."\n"; + my $endform='<br /><hr /><table border="0"><tr><td>'."\n"; $endform.='<input type="button" value="'.&mt('Save & Next').'" '. 'onclick="javascript:checksubmit(this.form,\'Save & Next\','. $total.','.scalar(@partlist).');" target="_self" /> '."\n"; @@ -2361,7 +2383,9 @@ KEYWORDS 'onclick="javascript:checksubmit(this.form,\'Previous\');" target="_self" /> '."\n". '<input type="button" value="'.&mt('Next').'" '. 'onclick="javascript:checksubmit(this.form,\'Next\');" target="_self" /> '; - $endform.=&mt('(Next and Previous (student) do not save the scores.)')."\n" ; + $endform.='<span class="LC_warning">'. + &mt('(Next and Previous (student) do not save the scores.)'). + '</span>'."\n" ; $endform.="<input type='hidden' value='".&get_increment(). "' name='increment' />"; $endform.='</td></tr></table></form>'; @@ -7451,6 +7475,7 @@ sub scantron_get_maxbubble { if (ref($nav_error)) { $$nav_error = 1; } + return; } my $map=$navmap->getResourceByUrl($sequence); my @resources=$navmap->retrieveResources($map,\&scantron_filter,1,0);