--- loncom/homework/grades.pm 2012/12/18 17:13:55 1.679 +++ loncom/homework/grades.pm 2013/05/10 12:48:48 1.687 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # The LON-CAPA Grading handler # -# $Id: grades.pm,v 1.679 2012/12/18 17:13:55 raeburn Exp $ +# $Id: grades.pm,v 1.687 2013/05/10 12:48:48 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -3101,7 +3101,7 @@ sub handback_files { &Apache::lonnet::dirlist($portfolio_root.$portfolio_path, $domain,$stuname,$getpropath); my $version = &get_next_version($answer_name,$answer_ext,$dir_list); - # fix file name + # fix filename my ($save_file_name) = (($directory.$answer_name.".$version.".$answer_ext) =~ /^.+\/${stuname}\/(.*)/); my $result=&Apache::lonnet::finishuserfileupload($stuname,$domain, $newflg.'_'.$part_resp.'_returndoc'.$counter, @@ -3120,7 +3120,7 @@ sub handback_files { $$newrecord{"resource.$new_part.$resp_id.handback"} .= $save_file_name; $file_msg.= '<span class="LC_filename"><a href="/uploaded/'."$domain/$stuname/".$save_file_name.'">'.$save_file_name."</a></span> <br />"; } - $request->print('<br />'.&mt('[_1] will be the uploaded file name [_2]','<span class="LC_info">'.$fname.'</span>','<span class="LC_filename">'.$env{'form.'.$newflg.'_'.$part_resp.'_origdoc'.$counter}.'</span>')); + $request->print('<br />'.&mt('[_1] will be the uploaded filename [_2]','<span class="LC_info">'.$fname.'</span>','<span class="LC_filename">'.$env{'form.'.$newflg.'_'.$part_resp.'_origdoc'.$counter}.'</span>')); } } } @@ -4650,8 +4650,8 @@ sub displayPage { &Apache::loncommon::start_data_table_row(). '<td align="center" valign="top" >'.$prob. (scalar(@{$parts}) == 1 ? '' - : '<br />('.&mt('[_1]parts)', - scalar(@{$parts}).' ') + : '<br />('.&mt('[_1]parts', + scalar(@{$parts}).' ').')' ). '</td>'; $studentTable.='<td valign="top">'; @@ -6441,7 +6441,7 @@ sub scantron_warning_screen { <tr><td><b>'.&mt('Data File that will be used:').'</b></td><td><tt>'.$env{'form.scantron_selectfile'}.'</tt></td></tr> '.$CODElist.$lastbubblepoints.' </table> -<p> '.&mt("If this information is correct, please click on '[_1]".',&mt($button_text)).'<br /> +<p> '.&mt("If this information is correct, please click on '[_1]'.",&mt($button_text)).'<br /> '.&mt('If something is incorrect, please return to [_1]Grade/Manage/Review Bubblesheets[_2] to start over.','<a href="/adm/grades?symb='.$symb.'&command=scantron_selectphase" class="LC_info">','</a>').'</p> <br /> @@ -7006,7 +7006,7 @@ sub scantron_validate_sequence { $r->print( '<p class="LC_warning">' .&mt('Some resources in the sequence currently are not set to' - .' exam mode. Grading these resources currently may not' + .' bubblesheet exam mode. Grading these resources currently may not' .' work correctly.') .'</p>' ); @@ -7140,7 +7140,7 @@ sub scantron_get_correction { $r->print(&Apache::loncommon::selectstudent_link('scantronupload', 'scantron_username','scantron_domain')); $r->print(": <input type='text' name='scantron_username' value='' />"); - $r->print("\n@". + $r->print("\n:\n". &Apache::loncommon::select_dom_form($env{'request.role.domain'},'scantron_domain')); $r->print('</li>'); @@ -7400,7 +7400,16 @@ sub prompt_for_corrections { ($responsetype_per_response{$question-1} eq 'imageresponse') || ($responsetype_per_response{$question-1} eq 'reactionresponse') || ($responsetype_per_response{$question-1} eq 'organicresponse')) { - $r->print(&mt("Although this particular question type requires handgrading, the instructions for this question in the exam directed students to leave [quant,_1,line] blank on their bubblesheets.",$lines).'<br /><br />'.&mt('A non-zero score can be assigned to the student during bubblesheet grading by selecting a bubble in at least one line.').'<br />'.&mt('The score for this question will be a sum of the numeric values for the selected bubbles from each line, where A=1 point, B=2 points etc.').'<br />'.&mt("To assign a score of zero for this question, mark all lines as 'No bubble'.").'<br /><br />'); + $r->print( + &mt("Although this particular question type requires handgrading, the instructions for this question in the bubblesheet exam directed students to leave [quant,_1,line] blank on their bubblesheets.",$lines) + .'<br /><br />' + .&mt('A non-zero score can be assigned to the student during bubblesheet grading by selecting a bubble in at least one line.') + .'<br />' + .&mt('The score for this question will be a sum of the numeric values for the selected bubbles from each line, where A=1 point, B=2 points etc.') + .'<br />' + .&mt("To assign a score of zero for this question, mark all lines as 'No bubble'.") + .'<br /><br />' + ); } else { $r->print(&mt("Select at most one bubble in a single line and select 'No Bubble' in all the other lines. ")."<br />"); } @@ -8480,7 +8489,7 @@ sub scantron_download_scantron_data { if (! &valid_file($file)) { $r->print(' <p> - '.&mt('The requested file name was invalid.').' + '.&mt('The requested filename was invalid.').' </p> '); return; @@ -8678,7 +8687,12 @@ sub checkscantron_results { $env{'form.scantron_maxbubble'}) .'</p>' ); - $r->print('<p>'.&mt('Exact matches for <b>[quant,_1,student]</b>.',$passed).'<br />'.&mt('Discrepancies detected for <b>[quant,_1,student]</b>.',$failed).'</p>'); + $r->print('<p>' + .&mt('Exact matches for [_1][quant,_2,student][_3].','<b>',$passed,'</b>') + .'<br />' + .&mt('Discrepancies detected for [_1][quant,_2,student][_3].','<b>',$failed,'</b>') + .'</p>' + ); if ($passed) { $r->print(&mt('Students with exact correspondence between bubblesheet data and submissions are as follows:').'<br /><br />'); $r->print(&Apache::loncommon::start_data_table()."\n". @@ -9743,6 +9757,7 @@ sub handler { } } elsif (!%perm) { $request->internal_redirect('/adm/quickgrades'); + return OK; } &Apache::loncommon::content_type($request,'text/html'); $request->send_http_header;