--- loncom/homework/grades.pm 2013/07/15 16:13:12 1.694 +++ loncom/homework/grades.pm 2013/07/24 15:12:33 1.698 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # The LON-CAPA Grading handler # -# $Id: grades.pm,v 1.694 2013/07/15 16:13:12 bisitz Exp $ +# $Id: grades.pm,v 1.698 2013/07/24 15:12:33 kruse Exp $ # # Copyright Michigan State University Board of Trustees # @@ -1702,7 +1702,7 @@ sub gradeBox { $wgt = ($wgt > 0 ? $wgt : '1'); my $score = ($$record{'resource.'.$partid.'.awarded'} eq '' ? '' : &compute_points($$record{'resource.'.$partid.'.awarded'},$wgt)); - my $result='<input type="hidden" name="WGT'.$counter.'_'.$partid.'" value="'.$wgt.'" />'."\n"; + my $data_WGT='<input type="hidden" name="WGT'.$counter.'_'.$partid.'" value="'.$wgt.'" />'."\n"; my $display_part= &get_display_part($partid,$symb); my %last_resets = &get_last_resets($symb,$env{'request.course.id'}, [$partid]); @@ -1710,7 +1710,7 @@ sub gradeBox { if ($last_resets{$partid}) { $aggtries = &get_num_tries($record,$last_resets{$partid},$partid); } - $result.=&Apache::loncommon::start_data_table_row(); + my $result=&Apache::loncommon::start_data_table_row(); my $ctr = 0; my $thisweight = 0; my $increment = &get_increment(); @@ -1747,8 +1747,9 @@ sub gradeBox { $result .= - '<td>'.$display_part.'</td><td>'.$radio.'</td><td>'.&mt('or').'</td><td>'.$line.'</td>'; + '<td>'.$data_WGT.$display_part.'</td><td>'.$radio.'</td><td>'.&mt('or').'</td><td>'.$line.'</td>'; $result.=&Apache::loncommon::end_data_table_row(); + $result.=&Apache::loncommon::start_data_table_row().'<td colspan="6">'; $result.='<input type="hidden" name="stores'.$counter.'_'.$partid.'" value="" />'."\n". '<input type="hidden" name="oldpts'.$counter.'_'.$partid.'" value="'.$score.'" />'."\n". '<input type="hidden" name="solved'.$counter.'_'.$partid.'" value="'. @@ -1759,6 +1760,7 @@ sub gradeBox { $aggtries.'" />'."\n"; my $res_error; $result.=&handback_box($symb,$uname,$udom,$counter,$partid,$record,\$res_error); + $result.='</td>'.&Apache::loncommon::end_data_table_row(); if ($res_error) { return &navmap_errormsg(); } @@ -2051,7 +2053,7 @@ sub submission { <br /><b>$lt{'keyw'}:</b> <a href="javascript:keywords(document.SCORE);" target="_self">$lt{'list'}</a> <a href="#" onmousedown="javascript:getSel(); return false" - CLASS="page">$lt{'past'}</a> + class="page">$lt{'past'}</a> <a href="javascript:kwhighlight();" target="_self">$lt{'high'}</a><br /><br /> KEYWORDS # @@ -2167,13 +2169,14 @@ KEYWORDS if ($env{"form.$uname:$udom:$partid:submitted_by"}) { if (exists($seenparts{$partid})) { next; } $seenparts{$partid}=1; - my $submitby='<b>Part:</b> '.$display_part. - ' <b>Collaborative submission by:</b> '. - '<a href="javascript:viewSubmitter(\''. - $env{"form.$uname:$udom:$partid:submitted_by"}. - '\');" target="_self">'. - $$fullname{$env{"form.$uname:$udom:$partid:submitted_by"}}.'</a><br />'; - $request->print($submitby); + $request->print( + '<b>'.&mt('Part: [_1]',$display_part).'</b>'. + ' <b>'.&mt('Collaborative submission by: [_1]', + '<a href="javascript:viewSubmitter(\''. + $env{"form.$uname:$udom:$partid:submitted_by"}. + '\');" target="_self">'. + $$fullname{$env{"form.$uname:$udom:$partid:submitted_by"}}.'</a>'). + '<br />'); next; } my $responsetype = $responseType->{$partid}->{$respid}; @@ -2236,22 +2239,30 @@ KEYWORDS '('.&mt('Response ID: [_1]',$respid).')'. '</span> '; my $files=&get_submitted_files($udom,$uname,$partid,$respid,\%record); + if (@$files) { if ($hide eq 'anon') { $lastsubonly.='<br />'.&mt('[quant,_1,file] uploaded to this anonymous survey',scalar(@{$files})); } else { - $lastsubonly.='<br /><span class="LC_warning">'.&mt('Like all files provided by users, this file may contain viruses').'</span><br />'; + $lastsubonly.='<br /><br />'.'<b>'.&mt('Submitted Files:').'</b>' + .'<br /><span class="LC_warning">'; + if(@$files == 1) { + $lastsubonly .= &mt('Like all files provided by users, this file may contain viruses!'); + } else { + $lastsubonly .= &mt('Like all files provided by users, these files may contain viruses!'); + } + $lastsubonly .= '</span>'; foreach my $file (@$files) { &Apache::lonnet::allowuploaded('/adm/grades',$file); - $lastsubonly.='<br /><a href="'.$file.'?rawmode=1" target="lonGRDs"><img src="'.&Apache::loncommon::icon($file).'" border="0" /> '.$file.'</a>'; + $lastsubonly.='<br /><a href="'.$file.'?rawmode=1" target="lonGRDs"><img src="'.&Apache::loncommon::icon($file).'" border="0" alt="" /> '.$file.'</a>'; } } $lastsubonly.='<br />'; } if ($hide eq 'anon') { - $lastsubonly.='<b>'.&mt('Anonymous Survey').'</b>'; + $lastsubonly.='<br /><b>'.&mt('Anonymous Survey').'</b>'; } else { - $lastsubonly.='<b>'.&mt('Submitted Answer:').' </b>'. + $lastsubonly.='<br /><b>'.&mt('Submitted Answer:').' </b>'. &cleanRecord($subval,$responsetype,$symb,$partid, $respid,\%record,$order,undef,$uname,$udom,$type,$trial,$rndseed); } @@ -2300,10 +2311,10 @@ KEYWORDS '<input type="hidden" name="newmsg'.$counter.'" value="" />'."\n"; $result.=' <a href="javascript:msgCenter(document.SCORE,'.$counter. ',\''.$msgfor.'\');" target="_self">'. - &mt('Compose message to student').(scalar(@$col_fullnames) >= 1 ? 's' : '').'</a><label> ('. + &mt('Compose message to student'.(scalar(@$col_fullnames) >= 1 ? 's' : '')).'</a><label> ('. &mt('incl. grades').' <input type="checkbox" name="withgrades'.$counter.'" /></label>)'. - '<img src="'.$request->dir_config('lonIconsURL'). - '/mailbkgrd.gif" width="14" height="10" name="mailicon'.$counter.'" />'."\n". + ' <img src="'.$request->dir_config('lonIconsURL'). + '/mailbkgrd.gif" width="14" height="10" alt="" name="mailicon'.$counter.'" />'."\n". '<br /> ('. &mt('Message will be sent when you click on Save & Next below.').")\n"; $result.='</div></div>'; @@ -3635,8 +3646,8 @@ sub viewgrades { my $display_part=&get_display_part($partid,$symb); if ($display =~ /^Partial Credit Factor/) { $result.='<th>'. - &mt('Score Part: [_1]<br /> (weight = [_2])', - $display_part,$weight{$partid}).'</th>'."\n"; + &mt('Score Part: [_1][_2](weight = [_3])', + $display_part,'<br />',$weight{$partid}).'</th>'."\n"; next; } else { @@ -9779,7 +9790,7 @@ ENDHEADER &mt('Found [_1] registered and [_2] unregistered clickers.',$student_count,$unknown_count); if (($env{'form.gradingmechanism'} ne 'attendance') && ($env{'form.gradingmechanism'} ne 'given')) { if ($correct_count==0) { - $errormsg.="Found no correct answers answers for grading!"; + $errormsg.="Found no correct answers for grading!"; } elsif ($correct_count>1) { $result.='<br /><span class="LC_warning">'.&mt("Found [_1] entries for grading!",$correct_count).'</span>'; } @@ -9951,7 +9962,7 @@ sub assign_clicker_grades { if ($user) { if ($users{$user}) { $result.='<br /><span class="LC_warning">'. - &mt("More than one entry found for <tt>[_1]</tt>!",$user). + &mt('More than one entry found for [_1]!','<tt>'.$user.'</tt>'). '</span><br />'; } $users{$user}=1;