--- loncom/homework/grades.pm 2013/07/22 18:06:54 1.697 +++ loncom/homework/grades.pm 2013/08/09 14:56:17 1.700 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # The LON-CAPA Grading handler # -# $Id: grades.pm,v 1.697 2013/07/22 18:06:54 bisitz Exp $ +# $Id: grades.pm,v 1.700 2013/08/09 14:56:17 bisitz Exp $ # # Copyright Michigan State University Board of Trustees # @@ -908,17 +908,17 @@ LISTJAVASCRIPT $submission_options.= '<span class="LC_nobreak">'. '<label><input type="radio" name="lastSub" value="lastonly" /> '. - &mt('last submission only').' </label></span>'."\n". + &mt('last submission').' </label></span>'."\n". '<span class="LC_nobreak">'. '<label><input type="radio" name="lastSub" value="last" /> '. - &mt('last submission & parts info').' </label></span>'."\n". + &mt('last submission with details').' </label></span>'."\n". '<span class="LC_nobreak">'. '<label><input type="radio" name="lastSub" value="datesub" checked="checked" /> '. - &mt('by dates and submissions').'</label></span>'."\n". + &mt('all submissions').'</label></span>'."\n". '<span class="LC_nobreak">'. '<label><input type="radio" name="lastSub" value="all" /> '. - &mt('all details').'</label></span>'; - $gradeTable .= &Apache::lonhtmlcommon::row_title(&mt('Submissions')) + &mt('all submissions with details').'</label></span>'; + $gradeTable .= &Apache::lonhtmlcommon::row_title(&mt('View Submissions')) .$submission_options .&Apache::lonhtmlcommon::row_closure(); @@ -2239,11 +2239,19 @@ KEYWORDS '('.&mt('Response ID: [_1]',$respid).')'. '</span> '; my $files=&get_submitted_files($udom,$uname,$partid,$respid,\%record); + if (@$files) { if ($hide eq 'anon') { $lastsubonly.='<br />'.&mt('[quant,_1,file] uploaded to this anonymous survey',scalar(@{$files})); } else { - $lastsubonly.='<br /><span class="LC_warning">'.&mt('Like all files provided by users, this file may contain viruses').'</span><br />'; + $lastsubonly.='<br /><br />'.'<b>'.&mt('Submitted Files:').'</b>' + .'<br /><span class="LC_warning">'; + if(@$files == 1) { + $lastsubonly .= &mt('Like all files provided by users, this file may contain viruses!'); + } else { + $lastsubonly .= &mt('Like all files provided by users, these files may contain viruses!'); + } + $lastsubonly .= '</span>'; foreach my $file (@$files) { &Apache::lonnet::allowuploaded('/adm/grades',$file); $lastsubonly.='<br /><a href="'.$file.'?rawmode=1" target="lonGRDs"><img src="'.&Apache::loncommon::icon($file).'" border="0" alt="" /> '.$file.'</a>'; @@ -2252,9 +2260,9 @@ KEYWORDS $lastsubonly.='<br />'; } if ($hide eq 'anon') { - $lastsubonly.='<b>'.&mt('Anonymous Survey').'</b>'; + $lastsubonly.='<br /><b>'.&mt('Anonymous Survey').'</b>'; } else { - $lastsubonly.='<b>'.&mt('Submitted Answer:').' </b>'. + $lastsubonly.='<br /><b>'.&mt('Submitted Answer:').' </b>'. &cleanRecord($subval,$responsetype,$symb,$partid, $respid,\%record,$order,undef,$uname,$udom,$type,$trial,$rndseed); } @@ -4447,48 +4455,68 @@ LISTJAVASCRIPT my ($curpage) =&Apache::lonnet::decode_symb($symb); # my ($curpage,$mapId) =&Apache::lonnet::decode_symb($symb); # my $type=($curpage =~ /\.(page|sequence)/); - my $select = '<select name="selectpage">'."\n"; + + # Collection of hidden fields my $ctr=0; foreach (@$titles) { - my ($minder,$showtitle) = ($_ =~ /(\d+)\.(.*)/); - $select.='<option value="'.$ctr.'" '. - ($$symbx{$_} =~ /$curpage$/ ? 'selected="selected"' : ''). - '>'.$showtitle.'</option>'."\n"; - $ctr++; + my ($minder,$showtitle) = ($_ =~ /(\d+)\.(.*)/); + $result.='<input type="hidden" name="page'.$ctr.'" value="'.$$symbx{$_}.'" />'."\n"; + $result.='<input type="hidden" name="title'.$ctr.'" value="'.$showtitle.'" />'."\n"; + $ctr++; } - $select.= '</select>'; - $result.=' <b>'.&mt('Problems from').':</b> '.$select."<br />\n"; + $result.='<input type="hidden" name="page" />'."\n". + '<input type="hidden" name="title" />'."\n"; + $result.=&build_section_inputs(); + my $stu_status = join(':',&Apache::loncommon::get_env_multiple('form.Status')); + $result.='<input type="hidden" name="Status" value="'.$stu_status.'" />'."\n". + '<input type="hidden" name="command" value="displayPage" />'."\n". + '<input type="hidden" name="symb" value="'.&Apache::lonenc::check_encrypt($symb).'" />'."\n"; + + # Show grading options + $result.=&Apache::lonhtmlcommon::start_pick_box(); + my $select = '<select name="selectpage">'."\n"; $ctr=0; foreach (@$titles) { my ($minder,$showtitle) = ($_ =~ /(\d+)\.(.*)/); - $result.='<input type="hidden" name="page'.$ctr.'" value="'.$$symbx{$_}.'" />'."\n"; - $result.='<input type="hidden" name="title'.$ctr.'" value="'.$showtitle.'" />'."\n"; + $select.='<option value="'.$ctr.'"'. + ($$symbx{$_} =~ /$curpage$/ ? ' selected="selected"' : ''). + '>'.$showtitle.'</option>'."\n"; $ctr++; } - $result.='<input type="hidden" name="page" />'."\n". - '<input type="hidden" name="title" />'."\n"; + $select.= '</select>'; - my $options = - '<label><input type="radio" name="vProb" value="no" checked="checked" /> '.&mt('no').' </label>'."\n". - '<label><input type="radio" name="vProb" value="yes" /> '.&mt('yes').' </label>'."<br />\n"; - $result.=' <b>'.&mt('View Problem Text').': </b>'.$options; - - $options = - '<label><input type="radio" name="lastSub" value="none" /> '.&mt('none').' </label>'."\n". - '<label><input type="radio" name="lastSub" value="datesub" checked="checked" /> '.&mt('by dates and submissions').'</label>'."\n". - '<label><input type="radio" name="lastSub" value="all" /> '.&mt('all details').' </label>'."\n"; - $result.=' <b>'.&mt('Submissions').': </b>'.$options; + $result.= + &Apache::lonhtmlcommon::row_title(&mt('Problems from')) + .$select + .&Apache::lonhtmlcommon::row_closure(); + + $result.= + &Apache::lonhtmlcommon::row_title(&mt('View Problem Text')) + .'<label><input type="radio" name="vProb" value="no"' + .' checked="checked" /> '.&mt('no').' </label>'."\n" + .'<label><input type="radio" name="vProb" value="yes" />' + .&mt('yes').'</label>'."\n" + .&Apache::lonhtmlcommon::row_closure(); + + $result.= + &Apache::lonhtmlcommon::row_title(&mt('View Submissions')) + .'<label><input type="radio" name="lastSub" value="none" /> ' + .&mt('none').' </label>'."\n" + .'<label><input type="radio" name="lastSub" value="datesub"' + .' checked="checked" /> '.&mt('all submissions').'</label>'."\n" + .'<label><input type="radio" name="lastSub" value="all" /> ' + .&mt('all submissions with details').' </label>' + .&Apache::lonhtmlcommon::row_closure(); - $result.=&build_section_inputs(); - my $stu_status = join(':',&Apache::loncommon::get_env_multiple('form.Status')); - $result.='<input type="hidden" name="Status" value="'.$stu_status.'" />'."\n". - '<input type="hidden" name="command" value="displayPage" />'."\n". - '<input type="hidden" name="symb" value="'.&Apache::lonenc::check_encrypt($symb).'" />'."<br />\n"; - - $result.=' <b>'.&mt('Use CODE').': </b> <input type="text" name="CODE" value="" /> <br />'."\n"; + $result.= + &Apache::lonhtmlcommon::row_title(&mt('Use CODE')) + .'<input type="text" name="CODE" value="" />' + .&Apache::lonhtmlcommon::row_closure(1) + .&Apache::lonhtmlcommon::end_pick_box(); - $result.=' <input type="button" '. + # Show list of students to select for grading + $result.='<br /><input type="button" '. 'onclick="javascript:checkPickOne(this.form);" value="'.&mt('Next').' →" /><br />'."\n"; $request->print($result); @@ -4633,7 +4661,7 @@ sub displayPage { '</span>'."\n". &Apache::loncommon::start_data_table(). &Apache::loncommon::start_data_table_header_row(). - '<th align="center"> Prob. </th>'. + '<th>'.&mt('Prob.').'</th>'. '<th> '.($env{'form.vProb'} eq 'no' ? &mt('Title') : &mt('Problem Text')).'/'.&mt('Grade').'</th>'. &Apache::loncommon::end_data_table_header_row();