--- loncom/homework/grades.pm 2003/05/30 21:42:36 1.93 +++ loncom/homework/grades.pm 2003/06/18 17:37:10 1.99 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # The LON-CAPA Grading handler # -# $Id: grades.pm,v 1.93 2003/05/30 21:42:36 albertel Exp $ +# $Id: grades.pm,v 1.99 2003/06/18 17:37:10 albertel Exp $ # # Copyright Michigan State University Board of Trustees # @@ -466,8 +466,13 @@ LISTJAVASCRIPT 'onClick="javascript:checkSelect(this.form.stuinfo);" '. 'value="'.$viewgrade.'" /></form>'."\n"; if ($ctr == 0) { - $gradeTable='<br /> <font color="red">'. - 'No submission found for this resource.</font><br />'; + my $num_students=(scalar(keys(%$fullname))); + if ($num_students eq 0) { + $gradeTable='<br /> <font color="red">There are no students currently enrolled.</font>'; + } else { + $gradeTable='<br /> <font color="red">'. + 'No submissions found for this resource for any students. ('.$num_students.' checked for submissions</font><br />'; + } } elsif ($ctr == 1) { $gradeTable =~ s/type=checkbox/type=checkbox checked/; } @@ -1924,6 +1929,10 @@ sub viewgrades { $result.='<input type="hidden" name="total" value="'.$ctr.'" />'."\n"; $result.='<input type="button" value="Submit Changes" '. 'onClick="javascript:submit();" TARGET=_self /></form>'."\n"; + if (scalar(%$fullname) eq 0) { + my $colspan=3+scalar(@parts); + $result='<font color="red">There are no students in section "'.$ENV{'form.section'}.'" with enrollment status "'.$ENV{'form.status'}.'" to modify or grade.</font>'; + } $result.=&show_grading_menu_form($symb,$url); return $result; } @@ -2386,7 +2395,7 @@ sub csvuploadassign { } $request->print('<h3>Assigning Grades</h3>'); my $courseid=$ENV{'request.course.id'}; - my ($classlist) = &getclasslist('all','1'); + my ($classlist) = &getclasslist('all',0); my @skipped; my $countdone=0; foreach my $grade (@gradedata) { @@ -2418,7 +2427,6 @@ sub csvuploadassign { $request->print('<br /><font size="+1"><b>Skipped Students</b></font><br />'); foreach my $student (@skipped) { $request->print("<br />$student"); } } - $request->print(&view_edit_entire_class_form($symb,$url)); $request->print(&show_grading_menu_form($symb,$url)); return ''; } @@ -2590,14 +2598,14 @@ sub getSymbMap { $mapiterator->next(); # skip the first BEGIN_MAP my $mapcurRes = $mapiterator->next(); # for "current resource" my $ctr=0; - while ($mapdepth > 0 && $ctr < 100) { + while ($mapdepth > 0) { if($mapcurRes == $mapiterator->BEGIN_MAP) { $mapdepth++; } if($mapcurRes == $mapiterator->END_MAP) { $mapdepth++; } if (ref($mapcurRes) && $mapcurRes->is_problem() && !$mapcurRes->randomout) { $countProblems++; } - $ctr++; + $mapcurRes = $mapiterator->next(); } if ($countProblems > 0) { my $title = $curRes->compTitle(); @@ -2751,6 +2759,8 @@ sub displayPage { $ctr++; } + $navmap->untieHashes(); + $studentTable.='</td></tr></table></td></tr></table>'."\n". ' <input type="button" value="Save" '. 'onClick="javascript:checkSubmitPage(this.form,'.$question.');" TARGET=_self />'. @@ -2860,6 +2870,8 @@ sub updateGradeByPage { $ctr++; } + $navmap->untieHashes(); + $studentTable.='</td></tr></table></td></tr></table>'; $studentTable.=&show_grading_menu_form($ENV{'form.symb'},$ENV{'form.url'}); my $grademsg=($changeflag == 0 ? 'No score was changed or updated.' : @@ -3416,15 +3428,14 @@ sub handler { if ($tsymb) { my ($map,$id,$url)=split(/\_\_\_/,$tsymb); if (&Apache::lonnet::allowed('mgr',$tcrsid)) { - $request->print( - &Apache::lonnet::ssi('/res/'.$url, - ('grade_username' => $tuname, - 'grade_domain' => $tudom, - 'grade_courseid' => $tcrsid, - 'grade_symb' => $tsymb))); + $request->print(&Apache::lonnet::ssi_body('/res/'.$url, + ('grade_username' => $tuname, + 'grade_domain' => $tudom, + 'grade_courseid' => $tcrsid, + 'grade_symb' => $tsymb))); } else { $request->print('<h3>Not authorized: '.$token.'</h3>'); - } + } } else { $request->print('<h3>Not a valid DocID: '.$token.'</h3>'); }