--- loncom/homework/lonhomework.pm 2005/01/28 09:48:53 1.193
+++ loncom/homework/lonhomework.pm 2007/08/18 00:01:45 1.269
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# The LON-CAPA Homework handler
#
-# $Id: lonhomework.pm,v 1.193 2005/01/28 09:48:53 albertel Exp $
+# $Id: lonhomework.pm,v 1.269 2007/08/18 00:01:45 albertel Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -30,7 +30,7 @@ package Apache::lonhomework;
use strict;
use Apache::style();
use Apache::lonxml();
-use Apache::lonnet();
+use Apache::lonnet;
use Apache::lonplot();
use Apache::inputtags();
use Apache::structuretags();
@@ -72,59 +72,68 @@ BEGIN {
# contruct - is a /priv/ resource
# form.grade_target - a form parameter requesting a specific target
sub get_target {
- &Apache::lonxml::debug("request.state = $ENV{'request.state'}");
- if( defined($ENV{'form.grade_target'})) {
- &Apache::lonxml::debug("form.grade_target= $ENV{'form.grade_target'}");
+ &Apache::lonxml::debug("request.state = $env{'request.state'}");
+ if( defined($env{'form.grade_target'})) {
+ &Apache::lonxml::debug("form.grade_target= $env{'form.grade_target'}");
} else {
&Apache::lonxml::debug("form.grade_target ");
}
- if (($ENV{'request.state'} eq "published") ||
- ($ENV{'request.state'} eq "uploaded")) {
- if ( defined($ENV{'form.grade_target'} )
- && ($ENV{'form.grade_target'} eq 'tex')) {
- return ($ENV{'form.grade_target'});
- } elsif ( defined($ENV{'form.grade_target'} )
+ if (($env{'request.state'} eq "published") ||
+ ($env{'request.state'} eq "uploaded")) {
+ if ( defined($env{'form.grade_target'} )
+ && ($env{'form.grade_target'} eq 'tex')) {
+ return ($env{'form.grade_target'});
+ } elsif ( defined($env{'form.grade_target'} )
&& ($Apache::lonhomework::viewgrades eq 'F' )) {
- return ($ENV{'form.grade_target'});
+ return ($env{'form.grade_target'});
+ } elsif ( $env{'form.grade_target'} eq 'webgrade'
+ && ($Apache::lonhomework::queuegrade eq 'F' )) {
+ return ($env{'form.grade_target'});
+ }
+ if ($env{'form.webgrade'} &&
+ ($Apache::lonhomework::modifygrades eq 'F'
+ || $Apache::lonhomework::queuegrade eq 'F' )) {
+ return ('grade','webgrade');
}
-
- if ( defined($ENV{'form.submitted'}) &&
- ( !defined($ENV{'form.resetdata'})) &&
- ( !defined($ENV{'form.newrandomization'}))) {
+ if ( defined($env{'form.submitted'}) &&
+ ( !defined($env{'form.newrandomization'}))) {
return ('grade', 'web');
} else {
return ('web');
}
- } elsif ($ENV{'request.state'} eq "construct") {
- if ( defined($ENV{'form.grade_target'}) ) {
- return ($ENV{'form.grade_target'});
+ } elsif ($env{'request.state'} eq "construct") {
+ if ( defined($env{'form.grade_target'}) ) {
+ return ($env{'form.grade_target'});
}
- if ( defined($ENV{'form.preview'})) {
- if ( defined($ENV{'form.submitted'})) {
+ if ( defined($env{'form.preview'})) {
+ if ( defined($env{'form.submitted'})) {
return ('grade', 'web');
} else {
return ('web');
}
} else {
- if ( $ENV{'form.problemmode'} eq &mt('View') ||
- $ENV{'form.problemmode'} eq &mt('Discard Edits and View')) {
- if ( defined($ENV{'form.submitted'}) &&
- (!defined($ENV{'form.resetdata'})) &&
- (!defined($ENV{'form.newrandomization'}))) {
+ if ($env{'form.problemstate'} eq 'WEB_GRADE') {
+ #$env{'form.webgrade'} = 'yes';
+ return ('grade','webgrade','answer');
+ } elsif ( $env{'form.problemmode'} eq &mt('View') ||
+ $env{'form.problemmode'} eq &mt('Discard Edits and View')) {
+ if ( defined($env{'form.submitted'}) &&
+ (!defined($env{'form.resetdata'})) &&
+ (!defined($env{'form.newrandomization'}))) {
return ('grade', 'web','answer');
} else {
return ('web','answer');
}
- } elsif ( $ENV{'form.problemmode'} eq &mt('Edit') ||
- $ENV{'form.problemmode'} eq 'Edit') {
- if ( $ENV{'form.submitted'} eq 'edit' ) {
- if ( $ENV{'form.submit'} eq &mt('Submit Changes and View') ) {
+ } elsif ( $env{'form.problemmode'} eq &mt('Edit') ||
+ $env{'form.problemmode'} eq 'Edit') {
+ if ( $env{'form.submitted'} eq 'edit' ) {
+ if ( $env{'form.submit'} eq &mt('Submit Changes and View') ) {
return ('modified','web','answer');
} else {
- return ('modified','edit');
+ return ('modified','no_output_web','edit');
}
} else {
- return ('edit');
+ return ('no_output_web','edit');
}
} else {
return ('web');
@@ -140,12 +149,6 @@ sub setup_vars {
# return ';$external::target='.$target.';';
}
-sub send_header {
- my ($request)= @_;
- $request->print(&Apache::lontexconvert::header());
-# $request->print('');
- $request->print(&Apache::lontexconvert::footer());
+sub proctor_checked_in {
+ my ($slot_name,$slot,$type)=@_;
+ my @possible_proctors=split(",",$slot->{'proctor'});
+
+ return 1 if (!@possible_proctors);
+
+ my $key;
+ if ($type eq 'Task') {
+ my $version=$Apache::lonhomework::history{'resource.0.version'};
+ $key ="resource.$version.0.checkedin";
+ } elsif ($type eq 'problem') {
+ $key ='resource.0.checkedin';
+ }
+ # backward compatability, used to be username@domain,
+ # now is username:domain
+ my $who = $Apache::lonhomework::history{$key};
+ if ($who !~ /:/) {
+ $who =~ tr/@/:/;
+ }
+ foreach my $possible (@possible_proctors) {
+ if ($who eq $possible
+ && $Apache::lonhomework::history{$key.'.slot'} eq $slot_name) {
+ return 1;
+ }
+ }
+
+ return 0;
}
$Apache::lonxml::browse='';
-
sub check_ip_acc {
my ($acc)=@_;
- if (!defined($acc) || $acc =~ /^\s*$/) { return 1; }
+ &Apache::lonxml::debug("acc is $acc");
+ if (!defined($acc) || $acc =~ /^\s*$/ || $acc =~/^\s*no\s*$/i) {
+ return 1;
+ }
my $allowed=0;
my $ip=$ENV{'REMOTE_ADDR'};
my $name;
foreach my $pattern (split(',',$acc)) {
+ $pattern =~ s/^\s*//;
+ $pattern =~ s/\s*$//;
if ($pattern =~ /\*$/) {
#35.8.*
$pattern=~s/\*//;
@@ -209,6 +239,129 @@ sub check_ip_acc {
}
return $allowed;
}
+
+sub check_slot_access {
+ my ($id,$type)=@_;
+
+ # does it pass normal muster
+ my ($status,$datemsg)=&check_access($id);
+
+ my $useslots = &Apache::lonnet::EXT("resource.0.useslots");
+ if ($useslots ne 'resource' && $useslots ne 'map'
+ && $useslots ne 'map_map') {
+ return ($status,$datemsg);
+ }
+
+ if ($status eq 'SHOW_ANSWER' ||
+ $status eq 'CLOSED' ||
+ $status eq 'INVALID_ACCESS' ||
+ $status eq 'UNAVAILABLE') {
+ return ($status,$datemsg);
+ }
+ if ($env{'request.state'} eq "construct") {
+ return ($status,$datemsg);
+ }
+
+ if ($type eq 'Task') {
+ my $version=$Apache::lonhomework::history{'resource.version'};
+ if ($Apache::lonhomework::history{"resource.$version.0.checkedin"} &&
+ $Apache::lonhomework::history{"resource.$version.0.status"} eq 'pass') {
+ return ('SHOW_ANSWER');
+ }
+ }
+
+ my @slots=
+ (split(':',&Apache::lonnet::EXT("resource.0.availablestudent")),
+ split(':',&Apache::lonnet::EXT("resource.0.available")));
+
+# if (!@slots) {
+# return ($status,$datemsg);
+# }
+ my $slotstatus='NOT_IN_A_SLOT';
+ my ($returned_slot,$slot_name);
+ foreach my $slot (@slots) {
+ $slot =~ s/(^\s*|\s*$)//g;
+ &Apache::lonxml::debug("getting $slot");
+ my %slot=&Apache::lonnet::get_slot($slot);
+ &Apache::lonhomework::showhash(%slot);
+ if ($slot{'starttime'} < time &&
+ $slot{'endtime'} > time &&
+ &check_ip_acc($slot{'ip'})) {
+ &Apache::lonxml::debug("$slot is good");
+ $slotstatus='NEEDS_CHECKIN';
+ $returned_slot=\%slot;
+ $slot_name=$slot;
+ last;
+ }
+ }
+ if ($slotstatus eq 'NEEDS_CHECKIN' &&
+ &proctor_checked_in($slot_name,$returned_slot,$type)) {
+ &Apache::lonxml::debug("protoctor checked in");
+ $slotstatus='CAN_ANSWER';
+ }
+
+ my ($is_correct,$got_grade,$checkedin);
+ if ($type eq 'Task') {
+ my $version=$Apache::lonhomework::history{'resource.0.version'};
+ $got_grade =
+ ($Apache::lonhomework::history{"resource.$version.0.status"}
+ =~ /^(?:pass|fail)$/);
+ $is_correct =
+ ($Apache::lonhomework::history{"resource.$version.0.status"} eq 'pass'
+ || $Apache::lonhomework::history{"resource.0.solved"} =~ /^correct_/ );
+ $checkedin =
+ $Apache::lonhomework::history{"resource.$version.0.checkedin"};
+ } elsif ($type eq 'problem') {
+ $got_grade = 1;
+ $checkedin = $Apache::lonhomework::history{"resource.0.checkedin"};
+ $is_correct =
+ ($Apache::lonhomework::history{"resource.0.solved"} =~/^correct_/);
+ }
+
+ &Apache::lonxml::debug(" slot is $slotstatus checkedin ($checkedin) got_grade ($got_grade) is_correct ($is_correct)");
+
+ # no slot is currently open, and has been checked in for this version
+ # but hasn't got a grade, therefore must be awaiting a grade
+ if (!defined($slot_name)
+ && $checkedin
+ && !$got_grade) {
+ return ('WAITING_FOR_GRADE');
+ }
+
+ # no slot is currently open, and has been checked in for this version
+ # previous slot is therefore CLOSED, so therefore the problem is
+ if (!defined($slot_name)
+ && $checkedin
+ && $type eq 'problem') {
+ return ('CLOSED',$datemsg);
+ }
+
+ if ($slotstatus eq 'NOT_IN_A_SLOT'
+ && $checkedin ) {
+
+ if ($got_grade) {
+ return ('SHOW_ANSWER');
+ } else {
+ return ('WAITING_FOR_GRADE');
+ }
+
+ }
+
+ if ( $is_correct) {
+ if ($type eq 'problem') {
+ return ($status);
+ }
+ return ('SHOW_ANSWER');
+ }
+
+ if ( $status eq 'CANNOT_ANSWER' &&
+ ($slotstatus ne 'NEEDS_CHECKIN' && $slotstatus ne 'NOT_IN_A_SLOT')) {
+ return ($status,$datemsg);
+ }
+
+ return ($slotstatus,$datemsg,$slot_name,$returned_slot);
+}
+
# JB, 9/24/2002: Any changes in this function may require a change
# in lonnavmaps::resource::getDateStatus.
sub check_access {
@@ -217,20 +370,19 @@ sub check_access {
my $status;
my $datemsg = '';
my $lastdate = '';
- my $temp;
my $type;
my $passed;
- if ($ENV{'request.state'} eq "construct") {
- if ($ENV{'form.problemstate'}) {
- if ($ENV{'form.problemstate'} =~ /^CANNOT_ANSWER/) {
- if ( ! ($ENV{'form.problemstate'} eq 'CANNOT_ANSWER_correct' &&
+ if ($env{'request.state'} eq "construct") {
+ if ($env{'form.problemstate'}) {
+ if ($env{'form.problemstate'} =~ /^CANNOT_ANSWER/) {
+ if ( ! ($env{'form.problemstate'} eq 'CANNOT_ANSWER_correct' &&
lc($Apache::lonhomework::problemstatus) eq 'no')) {
return ('CANNOT_ANSWER',
&mt('is in this state due to author settings.'));
}
} else {
- return ($ENV{'form.problemstate'},
+ return ($env{'form.problemstate'},
&mt('is in this state due to author settings.'));
}
}
@@ -243,7 +395,10 @@ sub check_access {
&Apache::lonxml::debug("checking for part :$id:");
&Apache::lonxml::debug("time:".time);
- if ($ENV{'request.state'} ne "construct") {
+ my ($symb)=&Apache::lonnet::whichuser();
+ &Apache::lonxml::debug("symb:".$symb);
+ #if ($env{'request.state'} ne "construct" && $symb ne '') {
+ if ($env{'request.state'} ne "construct") {
my $allowed=&check_ip_acc(&Apache::lonnet::EXT("resource.$id.acc"));
if (!$allowed && ($Apache::lonhomework::browse ne 'F')) {
$status='INVALID_ACCESS';
@@ -251,9 +406,14 @@ sub check_access {
return($status,$date);
}
- foreach $temp ("opendate","duedate","answerdate") {
+ foreach my $temp ("opendate","duedate","answerdate") {
$lastdate = $date;
- $date = &Apache::lonnet::EXT("resource.$id.$temp");
+ if ($temp eq 'duedate') {
+ $date = &due_date($id);
+ } else {
+ $date = &Apache::lonnet::EXT("resource.$id.$temp");
+ }
+
my $thistype = &Apache::lonnet::EXT("resource.$id.$temp.type");
if ($thistype =~ /^(con_lost|no_such_host)/ ||
$date =~ /^(con_lost|no_such_host)/) {
@@ -295,13 +455,14 @@ sub check_access {
$datemsg = &mt("was due on")." $lastdate".&mt(", and answers will be available on")." $date";
}
}
- if ($status eq 'CAN_ANSWER') {
+ if ($status eq 'CAN_ANSWER' ||
+ (($Apache::lonhomework::browse eq 'F') && ($status eq 'CLOSED'))) {
#check #tries, and if correct.
my $tries = $Apache::lonhomework::history{"resource.$id.tries"};
my $maxtries = &Apache::lonnet::EXT("resource.$id.maxtries");
if ( $tries eq '' ) { $tries = '0'; }
if ( $maxtries eq '' &&
- $ENV{'request.state'} ne 'construct') { $maxtries = '2'; }
+ $env{'request.state'} ne 'construct') { $maxtries = '2'; }
if ($maxtries && $tries >= $maxtries) { $status = 'CANNOT_ANSWER'; }
# if (correct and show prob status) or excused then CANNOT_ANSWER
if(($Apache::lonhomework::history{"resource.$id.solved"}=~/^correct/
@@ -320,18 +481,16 @@ sub check_access {
&Apache::lonxml::debug("looking for accesstime $first_access");
if (!$first_access) {
$status='NOT_YET_VIEWED';
- $datemsg=&seconds_to_human_length($interval);
- } else {
- my $newdate=localtime($first_access+$interval);
- if (time > ($first_access+$interval)) {
- $status='CLOSED';
- $datemsg = &mt("was due on")." $newdate".&mt(", and answers will be available on")." $date";
- } else {
- $datemsg = &mt("is due at")." $newdate";
+ my $due_date = &due_date($id);
+ my $seconds_left = $due_date - time;
+ if ($seconds_left > $interval || $due_date eq '') {
+ $seconds_left = $interval;
}
+ $datemsg=&seconds_to_human_length($seconds_left);
}
}
}
+
#if (($status ne 'CLOSED') && ($Apache::lonhomework::type eq 'exam') &&
# (!$Apache::lonhomework::history{"resource.0.outtoken"})) {
# return ('UNCHECKEDOUT','needs to be checked out');
@@ -347,6 +506,30 @@ sub check_access {
return ($status,$datemsg);
}
+# this should work exactly like the copy in lonnavmaps.pm
+sub due_date {
+ my ($part_id,$symb,$udom,$uname)=@_;
+ my $date;
+ my $interval= &Apache::lonnet::EXT("resource.$part_id.interval",$symb,
+ $udom,$uname);
+ &Apache::lonxml::debug("looking for interval $part_id $symb $interval");
+ my $due_date= &Apache::lonnet::EXT("resource.$part_id.duedate",$symb,
+ $udom,$uname);
+ &Apache::lonxml::debug("looking for due_date $part_id $symb $due_date");
+ if ($interval =~ /\d+/) {
+ my $first_access=&Apache::lonnet::get_first_access('map',$symb);
+ &Apache::lonxml::debug("looking for first_access $first_access");
+ if (defined($first_access)) {
+ $interval = $first_access+$interval;
+ $date = ($interval < $due_date)? $interval : $due_date;
+ } else {
+ $date = $due_date;
+ }
+ } else {
+ $date = $due_date;
+ }
+ return $date
+}
sub seconds_to_human_length {
my ($length)=@_;
@@ -411,34 +594,60 @@ sub showhashsubset {
}
sub setuppermissions {
- $Apache::lonhomework::browse= &Apache::lonnet::allowed('bre',$ENV{'request.filename'});
- my $viewgrades = &Apache::lonnet::allowed('vgr',$ENV{'request.course.id'});
+ $Apache::lonhomework::browse= &Apache::lonnet::allowed('bre',$env{'request.filename'});
+ my $viewgrades = &Apache::lonnet::allowed('vgr',$env{'request.course.id'});
if (! $viewgrades &&
- exists($ENV{'request.course.sec'}) &&
- $ENV{'request.course.sec'} !~ /^\s*$/) {
- $viewgrades = &Apache::lonnet::allowed('vgr',$ENV{'request.course.id'}.
- '/'.$ENV{'request.course.sec'});
+ exists($env{'request.course.sec'}) &&
+ $env{'request.course.sec'} !~ /^\s*$/) {
+ $viewgrades = &Apache::lonnet::allowed('vgr',$env{'request.course.id'}.
+ '/'.$env{'request.course.sec'});
}
- $Apache::lonhomework::viewgrades = $viewgrades; # File global variable...dirt.
+ $Apache::lonhomework::viewgrades = $viewgrades;
+
if ($Apache::lonhomework::browse eq 'F' &&
- $ENV{'form.devalidatecourseresdata'} eq 'on') {
- my (undef,$courseid) = &Apache::lonxml::whichuser();
- &Apache::lonnet::devalidatecourseresdata($ENV{"course.$courseid.num"},
- $ENV{"course.$courseid.domain"});
+ $env{'form.devalidatecourseresdata'} eq 'on') {
+ my (undef,$courseid) = &Apache::lonnet::whichuser();
+ &Apache::lonnet::devalidatecourseresdata($env{"course.$courseid.num"},
+ $env{"course.$courseid.domain"});
+ }
+
+ my $modifygrades = &Apache::lonnet::allowed('mgr',$env{'request.course.id'});
+ if (! $modifygrades &&
+ exists($env{'request.course.sec'}) &&
+ $env{'request.course.sec'} !~ /^\s*$/) {
+ $modifygrades =
+ &Apache::lonnet::allowed('mgr',$env{'request.course.id'}.
+ '/'.$env{'request.course.sec'});
+ }
+ $Apache::lonhomework::modifygrades = $modifygrades;
+
+ my $queuegrade = &Apache::lonnet::allowed('mqg',$env{'request.course.id'});
+ if (! $queuegrade &&
+ exists($env{'request.course.sec'}) &&
+ $env{'request.course.sec'} !~ /^\s*$/) {
+ $queuegrade =
+ &Apache::lonnet::allowed('qgr',$env{'request.course.id'}.
+ '/'.$env{'request.course.sec'});
}
- return ''
+ $Apache::lonhomework::queuegrade = $queuegrade;
+ return '';
+}
+
+sub unset_permissions {
+ undef($Apache::lonhomework::queuegrade);
+ undef($Apache::lonhomework::modifygrades);
+ undef($Apache::lonhomework::viewgrades);
+ undef($Apache::lonhomework::browse);
}
sub setupheader {
my $request=$_[0];
- if ($ENV{'browser.mathml'}) {
- &Apache::loncommon::content_type($request,'text/xml');
- } else {
- &Apache::loncommon::content_type($request,'text/html');
- }
+ &Apache::loncommon::content_type($request,'text/html');
if (!$Apache::lonxml::debug && ($ENV{'REQUEST_METHOD'} eq 'GET')) {
&Apache::loncommon::no_cache($request);
}
+# $request->set_last_modified(&Apache::lonnet::metadata($request->uri,
+# 'lastrevisiondate'));
$request->send_http_header;
return OK if $request->header_only;
return ''
@@ -450,38 +659,55 @@ sub handle_save_or_undo {
my $filebak =$file.".bak";
my $filetmp =$file.".tmp";
my $error=0;
-
- &Apache::lonnet::correct_line_ends($result);
-
- if ($ENV{'form.Undo'} eq &mt('undo')) {
+ if ($env{'form.Undo'} eq &mt('undo')) {
my $error=0;
if (!copy($file,$filetmp)) { $error=1; }
if ((!$error) && (!copy($filebak,$file))) { $error=1; }
if ((!$error) && (!move($filetmp,$filebak))) { $error=1; }
if (!$error) {
- &Apache::lonxml::info("".&mt("Undid changes, Switched")." $filebak ".&mt("and")." $file
");
+ &Apache::lonxml::info("".
+ &mt("Undid changes, Switched [_1] and [_2]",
+ ''.$filebak.
+ '',
+ ''.$file.
+ '')."
");
} else {
- &Apache::lonxml::info("".&mt("Unable to undo, unable to switch")." $filebak ".&mt("and")." $file
");
+ &Apache::lonxml::info("".
+ &mt("Unable to undo, unable to switch [_1] and [_2]",
+ ''.
+ $filebak.'',
+ ''.
+ $file.'')."
");
$error=1;
}
} else {
+ &Apache::lonnet::correct_line_ends($result);
my $fs=Apache::File->new(">$filebak");
if (defined($fs)) {
print $fs $$problem;
- &Apache::lonxml::info("".&mt("Making Backup to").
- " $filebak");
+ &Apache::lonxml::info("".&mt("Making Backup to [_1]",
+ ''.
+ $filebak.'').
+ "");
} else {
- &Apache::lonxml::info("".&mt("Unable to make backup")." $filebak");
+ &Apache::lonxml::info("".
+ &mt("Unable to make backup [_1]",
+ ''.
+ $filebak.'')."");
$error=2;
}
my $fh=Apache::File->new(">$file");
if (defined($fh)) {
print $fh $$result;
- &Apache::lonxml::info("".&mt("Saving Modifications to").
- " $file");
+ &Apache::lonxml::info("".&mt("Saving Modifications to [_1]",
+ ''.
+ $file.'' )."");
} else {
- &Apache::lonxml::info("".
- &mt("Unable to write to")." $file");
+ &Apache::lonxml::info(''.
+ &mt("Unable to write to [_1]",
+ ''.
+ $file.'').
+ '');
$error|=4;
}
}
@@ -490,15 +716,13 @@ sub handle_save_or_undo {
sub analyze_header {
my ($request) = @_;
- my $bodytag='';
- if ($ENV{'environment.remote'} eq 'off') {
- $bodytag=&Apache::loncommon::bodytag();
- }
- my $result.='
- '.&mt("Analyzing a problem").'
- '.$bodytag.&Apache::lonxml::message_location().'
+ my $result =
+ &Apache::loncommon::start_page('Analyzing a problem',undef);
+
+ $result .=
+ &Apache::lonxml::message_location().'
';
+
+
+
+
+
+ '.&Apache::loncommon::end_page();
&Apache::lonxml::add_messages(\$result);
$request->print($result);
}
@@ -647,11 +907,12 @@ sub editxmlmode {
# Render the page in whatever target desired.
#
sub renderpage {
- my ($request,$file) = @_;
+ my ($request,$file,$targets,$return_string) = @_;
- my (@targets) = &get_target();
- &Apache::lonhomework::showhashsubset(\%ENV,'form.');
+ my @targets = @{$targets || [&get_target()]};
+ &Apache::lonhomework::showhashsubset(\%env,'form.');
&Apache::lonxml::debug("Running targets ".join(':',@targets));
+
my $overall_result;
foreach my $target (@targets) {
# FIXME need to do something intelligent when a problem goes
@@ -662,22 +923,35 @@ sub renderpage {
# $request->print(" You most likely shouldn't see me.");
#}
#my $t0 = [&gettimeofday()];
+ my $output=1;
+ if ($target eq 'no_output_web') {
+ $target = 'web'; $output=0;
+ }
my $problem=&Apache::lonnet::getfile($file);
+ my $result;
if ($problem eq -1) {
- &Apache::lonxml::error(" ".&mt('Unable to find')." $file");
$problem='';
+ my $filename=(split('/',$file))[-1];
+ my $error =
+ " ".&mt('Unable to find [_1]',
+ ' '.$filename.'')
+ ."";
+ $result.=
+ &Apache::loncommon::simple_error_page($request,'Not available',
+ $error);
+ return;
}
my %mystyle;
- my $result = '';
if ($target eq 'analyze') { %Apache::lonhomework::analyze=(); }
if ($target eq 'answer') { &showhash(%Apache::lonhomework::history); }
- if ($target eq 'web') {&Apache::lonhomework::showhashsubset(\%ENV,'^form');}
+ if ($target eq 'web') {&Apache::lonhomework::showhashsubset(\%env,'^form');}
&Apache::lonxml::debug("Should be parsing now");
- $result = &Apache::lonxml::xmlparse($request, $target, $problem,
- &setup_vars($target),%mystyle);
+ $result .= &Apache::lonxml::xmlparse($request, $target, $problem,
+ &setup_vars($target),%mystyle);
undef($Apache::lonhomework::parsing_a_problem);
+ if (!$output) { $result = ''; }
#$request->print("Result follows:");
if ($target eq 'modified') {
&handle_save_or_undo($request,\$problem,\$result);
@@ -698,9 +972,13 @@ sub renderpage {
#$request->print(":Result ends");
#my $td=&tv_interval($t0);
}
- &Apache::lonxml::add_messages(\$overall_result);
- $request->print($overall_result);
- $request->rflush();
+ if (!$return_string) {
+ &Apache::lonxml::add_messages(\$overall_result);
+ $request->print($overall_result);
+ $request->rflush();
+ } else {
+ return $overall_result;
+ }
}
# with no arg it returns a HTML