--- loncom/homework/lonmaxima.pm 2007/05/26 15:51:08 1.14 +++ loncom/homework/lonmaxima.pm 2007/08/14 21:54:54 1.21 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # Interface routines to MAXIMA CAS # -# $Id: lonmaxima.pm,v 1.14 2007/05/26 15:51:08 www Exp $ +# $Id: lonmaxima.pm,v 1.21 2007/08/14 21:54:54 riegler Exp $ # # Copyright Michigan State University Board of Trustees # @@ -60,7 +60,11 @@ sub maximareply { sub blacklisted { my ($cmd)=@_; - foreach my $forbidden ('save','load','plot','lisp','includ','compil','file','batch','stringout','translat','stout','stin','block','system') { + foreach my $forbidden ('save','load','plot','lisp','includ','compil', + 'file','batch','stringout','translat','stout', + 'stin','block','system','concat','read','inchar', + 'outchar','ttyoff','with_stdout','writefile', + 'reset') { if ($cmd=~/$forbidden/s) { return 1; } } return 0; @@ -77,6 +81,7 @@ sub runscript { } $reply=~s/^\s*//gs; $reply=~s/\s*$//gs; + &Apache::lonxml::debug("maxima $fullscript \n reply $reply"); return $reply; } @@ -118,7 +123,7 @@ sub maxima_eval { sub compareterms { my ($socket,$terma,$termb)=@_; - my $difference=$terma.'-'.$termb; + my $difference=$terma.'-('.$termb.')'; if (&blacklisted($difference)) { return 'Error: blacklisted'; } my $reply=&maximareply($socket,'trigsimp(trigreduce('.$difference.'));'); if ($reply=~/^\s*0\s*$/) { return 'true'; } @@ -131,7 +136,10 @@ sub maxima_check { my $socket=&connect(); my $reply=&compareterms($socket,$response,$answer); &disconnect($socket); + # integer to string mappings come from capaParser.h + # 1 maps to 'EXACT_ANS' if ($reply eq 'true') { return 1; } + # 7 maps to 'INCORRECT' return 7; }