CVS log for loncom/homework/optionresponse.pm

Up to [LON-CAPA] / loncom / homework

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- For 2.11
  - Backport 1.201

- Eliminate javascript error in composite page conatining optionresponse.
  - Regular expression in lonpage.pm which is used to append prefix argument
    in call to setSubmittedPart() expects string javascript:setSubmittedPart

- For 2.11
  - Backport 1.196, 1.197

- Bug 2802
 - Lenient (partial credit) parameter for optionresponse supports relative
   weights when checkboxes are in use.
 -  Different numbers of points (either positive or negative) can be specified
    for correct foils (checked or unchecked) and incorrect foils (checked or
    unchecked).
    - Overview modes for parameter setting include textboxes for each of the
      four types if "weighted" is selected.
- Overview modes for parameter setting for Client IP/Name Access Control
  also include individual textboxes for each IP or Name, with separate
  boxes for "allow from" and "deny from".
Work in progress.

- For 2.11
  Backport 1.198,  1.199.

- Bug 2802
  If at least one response item in a problem part is set to lenient, then
  if the award for that item is ASSIGNED_SCORE, that should trump award(s)
  of INCORRECT for other response items in the same problem part, when
  finalizing the award, so "You are partially correct" will be shown,
  unless feedback is suppressed.

- Bug 2802
  Support different settings for the lenient parameter for each part in a
  multi-part problem.

Show/hide button now appears at the intended location.

authoring space overhaul
this update tries to improve the user experience of the authoring space.

added codemirror for xml editor and script tags in colorful editor
added possibility to deactivate codemirror in author settings
added dropdown menu to insert problem templates into xml editor (thanks to tobias reinhardt)
added feature of saving current scrollposition on save when editing problems
added possibility to fold blocks in colorful editor, this state will be saved and restored
added shortcuts to create empty problems, html files and directories

and other smaller features and bugfixes

- Optionresponse in "checkbox" mode:
  - Additional (optional) attributes: maxcheck and mincheck available to enforce
    requirement on number of checkboxes which may be checked.
  - Intended use case is polling with optionresponse used in survey mode,
    and maximum number of selections voter may make is to be limited.

- Bug 6597
  - Attributes for foilgroup in optionresponse now include checkbox for
    omit "Select all that are ..." in colorful editor (displayed by default
    when reponse uses checkboxes for binary options instead of dropdown lists).

Internationalization of colorful editor - added missing &mt() calls

Do not translate twice

Exclude HTML tags from translation phrases.
Update corresponding German translation file phrases and translations.

- Can view own submissions in anonymous surveys.

- Sanity checking.

BZ 6626 - Don't strip variable optinos for foilgroups.

- For perl 5.16 use of deprecated defined(@array) generates warnings.
  - eliminate use.

BZ 6597 - support noprompt attribute in <foilgroup> tag.  When present and
having a value of '1' supresses the prompt to select all that are true.

- Do a better job of preventing bubble and letter (A etc.) bleeding from
  left column to adjacent right column (or being truncated, if in right
  column) when creating 2-column printout for optionresponse in exam mode.

- Bug 2802.
  - Separate decision on leniency in grading from logic on whether additional
    new submission is possible for partially correct problem parts.
  - new parameter: retrypartial set to "yes" if part is to be answerable
    when partially correct.
  - custompartial.problem template incorporates retrypartial parameter in
    place of lenient parameter.
  - points awarded > 1 no longer considered 'partially correct'.
  - &grading_is_nonlenient() moved from inputtags.pm back to optionresponse.pm

- Bug 2802.
  - optionresponse::is_nonlenient() moved to inputtags::grading_is_nonlenient()
    to facilitate re-use.
  - where solved is "correct", awarded value < 1 permits new submission,
    only if lenient grading applies.
  - add lenient parameter to custompartial.problem template.

- Backport 1.182.

- Bug 5817.

- Backport 1.180.

- Bug 2802.
  Move determination of lenient vs non-lenient to subroutine to facilitate reuse
.
  - Support lenient parameter for matchresponse as well as optionresponse.
  - Use response::get_param_response() to retrieve lenient parm.

- Bug 6513, 6515.
- Add 0 to options for optionresponse using colorful editor.

- Bug 5771
  - Fix underlying cause in lonnet::hashref2str().
  - Preferred to earlier fix (now reverted).
    - Revert earlier changes in *response.pm to report foil name of 0
      as an error.

- Fix change in 1.177.
  - also retrieve response where this is not multiline bubblesheet grading.

- Additional (eighteenth field) BubblesPerRow in Bubblesheet Format file.
  - specify bubbles available for each question row (default is 10).
- Support case where question (or subquestion for optionresponse,
    matchresponse, or rankresponse) requires more bubbles than in one line.
  - Students prompted to bubble once in multiple lines.
  - Numbering recognizes multiple lines per question.
  - Also supports: imageresponse, stringresponse, formularesponse where
    students leave link(s) blank if weight assigned is greater than
    bubbles per line -- multiple lines also supported in this case.

For example:
- 15-bubble MSU Art History exams now supported on standard 10-bubble
    bubblesheets used at MSU.

Bug #5771: foil name 0 does not work

Saving my work: lenient grading. Still problems with saving input after
first try.

Work in progress on lenient option response grading

- New Question Type - randomizetry
  - Only set dropdown lists to selections last try when displaying options
    for new try, if rndseed for last try is the same as for current try.

Bug #6329: can switch off checkbox choices

- Bug 6354.
  - Modifying changes in rev. 1.165 (to address bug 3268).
  - Prevent text in multi line options list generated in exam mode from
    overlapping with each other or with foil text.

- Don't display bullet if there is only one foil.

Argh.

Undoing 6329: Choices could also be "Red", "Green"
or "Increase" - "Stay the Same"

- Bug 6324.
 - reversing change in rev 1.109 (bug 2966), and replacing enumeration with bullets.

- Bug 6329.

BZ3268 - make various problem types look better when multiple answers appear in
a single part connected by text (<startouttext /> stuff <endouttext />

Removes PDF-forms fracments in printouts from problems in exam-mode.

- New awards for surveys:
 ANONYMOUS ANONYMOUS_CREDIT SUBMITTED_CREDIT
  - given for question types: anonsurvey, anonsurvey_cred, survey_cred.
    - anonsurvey -- course personnel can not view both identity of submitter
                    and submission details.
    - anonsurveycred -- same anonymity, but submitter receives 'awarded' for
                        submission
    - surveycred - submitter receives 'awarded' for submission to survey.
- Do not display submission information in grading view for anonymous surveys.

Bug #2294: checkboxes for simple two-option optionresponses

Bug #2294: now only needs editing interface

More work on 2294: provide list of choices

Saving my work: bug #2294 true/false as checkbox
Still needs XML structure and editor interface, otherwise works.

Disable printing PDF-Forms-Comboboxes in optionresponse if a problem is not answerable for students.
and
Correct/simpliefy a RegEx which parse Answers of options.

- Backport 1.153, 1.157.

- Avoid &mt(&mt()).
  - No need to &mt() the array items to be displayed as text -- edit::select_arg() does this anyway.

Moved POD comments to bottom of file

Added/updated/converted POD. Many files had their POD redone to new standards.

Added POD documentation

Localization, wording, nobreaks for Colorful Editor
- Added missing &mt() calls at several places (more to be done)
- Same wording "Delete?" for all Delete options
- Same wording style, e.g. added ":" after text and before optionlist
- Added nobreak style for some elements which need to stay together, e.g. help_open_topic in loncommon.pm
- Added/updated some related German translations

Add optionresponse problems to PDF-Forms

Localization:
- Added missing &mt() call to "Foils without names" warning
- Optimized &mt() call for "Foil name ... appears more than once" warning
- Added some other missing &mt() calls

Localisation:
Added missing &mt() call (-> Choices)

When the target is 'analyze', include the responsetype of the current item in the lonhomework::analyze hash, for use later on, e.g., for scantron grading.

Typo.

BZ 4074  Ensure the bubble lines chunk of the analysis hash gets
keyed by the concatenation of partid.resopnseid.

bz4074 - Use lonxml subs to maintain the number of bubble lines required
for responses to these types of problems.

Make anaylze target produce a bubble_lines entry that describes how many
lines on an answer bubble sheet the problem requires for its answer.

- <drawoptionlist ?. insertable, and works correctly when outside
  of a text block (BUG#5302)

- 2622, refactoring out some code, essay response also works now

- bug#2622
   - color extended across whole row
   - make the try count stand out more
   - correct message updated
   - option response display vertically
   - coverted response messages to be css rather than staitic colros

- style police
- change the logthis to a debug

bgz4657 - Make the bubble layout a bit more compact
so that if the user has chosen a left/right
positioning of the foil (2 columns) in 2 col printout
in exam mode for matchresponse, nothing will spill over
into the column gutter etc.

- BUG#4244 enter works correctly now also with ption/radio/rank/match response

- previous submission display mode of optionresponse

- BUG#5206, <foil>s were posibly getting 2 eauation passes

Don't pass through <displayoptionlist> tags to output if the target
is 'answer'.

- Ron has convinced me that this is a bad idea

Defect 3340 - Allow <display></display> to operate
within the options of a <foilgroup> tag...to inhibit
latex fixups.  I need to test some edge cases still, but
the 'main' case appears to work fine now.

- xhtml

- add texoptions 'nochoice' to Edit interface

- need to explicitly set \tabcolsep so it is consistanent for us

- add correct bubble to exam printout
- optionrepsonse prints multiple answer lines for exam printout

- 0 is a valid name for a foil

- BIG#4142 ratche foil unamedness downn to warning

- slapping a <b> arond the correct value for option/rank/match responses BUG#4139

- BUG#4065 make it so html entities work inside of <oprtionresponse> values
(for instance &ne;)

- ENV -> env

- Part of #636, Submit Answer now only submits for a single part. The logic for detecting a submission has been broken out to a subroutine if future tweaks are needed.

- BUG#3757, <foil>s without names throw errors

- BUG#3637, printing was different if in using conceptgroups versus not using concept groups

- Bug#1 <or> handles survey mode

- unbubbled scantron responses in optionresponse were treated as if the user had bubbled A BUG#3508

- spelling

Possible (suggested today by Ed) quick fixing for rankresponce problem in exam mode. I still work on more elegant (Gerd's) solution.

- sigh fixes bug with pulishing <or> that use <drawoptionlist />

- it is good to actually run the code before you commit it.

Added a space after comma in option list to give LaTeX more flexibility in printing.

Part of bug 3103 is fixed. LaTeX does not allow use \\ command inside if some list environment si I implemented \vskip 0 mm.

Corrected my ows error. Sorry.

Bug about <drawoptionlist /> is fixed.

- more fixes for crappy matchresponse BUG#3094

- fixes for randnumber generation
   - due to a error in coding the 64bit and 64bit2 rnd seeds were throwing away the second half of the seed, we now preserve this functionality and make it explicit
   - additionally 64bit3 now uses all 64bits of the seed
   - also added new function pushrandomnumber poprandomnumber to be called instead of setrandomnumber before we were crunching the Safe space random number generator state, as this function is used bu thing the <optionresponse> and <radoibuttonresponse> this meant changes in the internal randomization code could screw up later Safe space random calls the old method is preserved for blank 64bit and 64bit2 randomiztion env.

BUG#2966

- Make TeXlayout Editable
- move TeXlayout to <optionreponse> from <foilgroup>
- remove some debug messages

Added additional attribute TeXlayout to print complicated problems with a few
<foilgroups> in text. See e-mail that I've sent you (copy e-mail to Ed).

- BUG#2284, optionresponse now complains if the correct option for a question isn't available for selection for the student to choose

- Start on BUG#2730, annotate in the analyze data structure whether an answer is computed or not.

- BUG#2835, Error either always or never showed up.

- BUG#2551, foil names need to be unique otherwise things go wonky, throw errors if we see repeated names.

Small but important change to print bubbles with only one letter more correctly.

- backport < > in option list in exam mode print fix from 1.101

- backport 1.99 and 1.100

- options with > < in them didn't print correct in exam mode
- removed dead tex print posisbility from showanswer mode
- option list in tex homwork mode uses latex_special_symbols now
- removed redundant code from exam/homeworkj print mode
- <drawoptionlist> didn't work properly in exam mode web and tex
- some small amounts of retabination

I've found my own error (actually not error but I did not consider yesterday printing for the selected students) and fixed it.

Algorithm for printing bubbles content in the exams was changed. It's capable to render more options with more accurate calculation of the width for every option. I really want to have as many responces about this as possible from people using exams printing. The same has to work without changes for radiobuttonresponce, rankresponce, ...

Help!

 Bug 2547 (option response choices: m/s^2 breaks printing) is fixed.

- stop spamming attempts (Only log a response if there was a response)

- BUG#1458

- took a look at all of the analyze outputs and corrected the buglets

- fixing up analyze mode for radiobutton/option/rank/match/image to all use the smae code

Removed last commit.

Bug 2323 (problem numbering when printing exam with answers) fixed for optionresponse problems.

- backport 1.90

- match/option/rank/numerical responses now restore last state of bubbles
  in online exam mode
- match/rank getting closer to working in scantron mode

- cleaining up some code

- whoops

Some additional cleanup is done - removed some stupid chuncks of code for 'tex' target output.

- backport changes to make problemstatus work better

- added &Apache::response::show_answer() to better check for if problemstatus inhibiting should be occuring or not

Bug (it's not really a bug - just a very small correction) 2132 (Changing text in option response choices when printing) is fixed.

Bug 756 ("possible answers" in option resp printouts) is fixed.

Corrections to print optionresponse problems with or without list of options.

Bug 1743 (tex needs to NOT add unnecessary list indices) is fixed.

Lingvistic changes are done.

An attempt tofix bug 1744 (Need a way of supressing the list of optionresponse choices from the printout). Subject to Guy's approval.

Bug 1667 is fixed. Internal counter (works only for bubblesheet LaTeX exams) is implemented.

Bug 1466 (optionresponse in .exam shows tex in web mode) is fixed.

- consolidates the whichfoil functions and fixes BUG#1439

- added number of foils to the data stored by <optionresponse> in scantron mode

- optionresponse now supports partially correct problems in scantron mode

- better handling of counters
- always increment the counters for modes with output

- option/radiobutton responses now use new method for getting current response
  supporting scantron mode

 Corrected radioresponse inside of webbubbles function.

 First steps to implement radiobuttonresponse inside of optionresponse for the exam mode.

Corrected printing for problem mode partly destroed yesterday when I was in hurry doing exam mode for Ed.

- removing lame global

Changes were done according to Ed's desires: 1. Added righttriangle symbol yo any foil in the exam LaTeX mode (lines before bubbles). 2. Spacing adjustment of the text and bubbles is done. 3. Separation of problems with respect to foils (questions) is more clear now.

 Corrected enumeration of bubble's lines for exam mode - now all numbers appear on the same line as bubbles themself.

- preventing more possible bombs on incomplete problems

Small changes to print exams (mainly cosmetic).

- correct answers are no longer shown for target tex

- just doing a reindent

Bug 771 is fixed. The reason of bad bechavior was my attempts to play
with Guy's optionresponse problems which I have not finished Monday.

- doesn't generate <br /> when the question consits of foils with only whitespace

Changed according to Ed's desire.

TeX version of Guy's <drawoptionlist /> tag is implemented. This is very
preliminary implementation and I have to return to it after finishing work
with two types of exam - bubble and online.

- Implements BUG#40

- <drawoptionlist /> inside of a foil will be where the drop list is placed.

Result of on-line exam can be printed and seen on the screen correctly
now both before and after openning answer date.

- BUG#34, <optionhint> now fucntional for both foils and concepts
- edit mode non intuitive

 Changes for the better printing in the list environment (Ed's desire).

1. Removed misprint (absense of });
2. Font for printing correct answers was changed to separate them from
questions.

Corrected output for printing problems with open answers.

- Rewrite counter code

For the exam 1. correctly adjust the size of bubbles to the text width;
2. use correct enumeration through the environment variable;

Exam printing is done.

Corrections + cleanuo.

Changes were done to print exams. Needs in additional cleanup.

- supports all of the randomization that rbr does BUG#542

- removed use of Perl's internal rand operator, now all randomiztaion depends upon the external Math::Random library

 Corrected printing for answered problems: both correct and uncorrect answers are possible.

- removed global, and renamed a variable

- incorrect initializtions

Correctly prints problems in both possibilities: without answers and with ones.

Can print both problems without answers and problems with answers.

- closing BUG#541

small late corrections for math symbils in the option list

- implements BUG#238 - New radio button showallfoils, optionresponse shows
   all foils irrespective of the max parm and any conceptgroups, rbr and
   ir still need the functionality

itemize was changed on enumerate

change itemize to enumerate for uniform description

- if some parts of the <optionresponse> are not submitted don't count a try
  fixes BUG#191

- undef the hash when done
- now reports back the possible options, and the shown foil order
- <foil> outside of <conceptgroup> also reported

- added new target anaylze addresses BUG#189
- need to support more response types

- English update

now works for tex mode, at least for some kinds of problems

changing "sub BEGIN" to "BEGIN"

Update to use edit::end_row() and edit::start_spanning_row() as a cleanup
for edit::select_arg and edit::select_or_text_arg.

- makes use of the new deregister mechanism
- radiobutton response handles previous in survey mode now.

- restores previous submission
- notes blank answers and doesn't grade them
- notes previous submissions and doesn't charge for them

- GPL headers

- Broken version, attempitng to improve the structture of the submissions data stored.

- prints out correct answers for answer mode parsing

- better handle 'SHOW_ANSWER' situation

-added package notation for all remaining response styles

-re asserting my indent style

beautify/optimize

- now allows hand crafted or variable arguments as the truth values to foils

- deleting unused redundant code

- more tolerant of non-complete problems (missing foils, all foils unused etc)

- edit mode is now pretty
- hanlper functions in edit.pm make it easy to query and set tag arg

- added easy way to get and set options for a tag

- edit interface added ability to tweak more options for option response
  style questions

- added color to edit mode <table>
- added start_table function to coordinate the color assignment and other attributes for <table>.

- improving the look of the edit interface
- can add options now

- stupid buglet

- added new arg $tagstack to all start_ or end_ routines

- modified to use get_param

- added calls to get_param to clean up how one accesses data
- fixed the concetpgropu code to actually work
- fixed the off by one errors in selecting and displaying foils.

- bug allowed blank answers to be bounted as correct

- changes to allow tag namespaces

- redid random number generator for <i/rb/o/response> tags
     - should be unstable in preview mode and more random in normal mode

- <conceptgroup>

- changed redirection, and output stack to work more intelligently, checkount radiobuttonresponse for a good example, should have to muck with @Apache::lonxml::outputstack and $Apache::lonxml::redirection directly use startredirection and enredirection

- <br> -> <br /> cleanup

- need to do somethings only during the web version

- new response type <optionresponse>