CVS log for loncom/homework/radiobuttonresponse.pm

Up to [LON-CAPA] / loncom / homework

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- For 2.11
  - Backport 1.161, 1.162.

- Bug 6724.

- Bug 6724

- For 2.11
  - Backport 1.158

using a div and CSS instead of br to better control spaces around foils, especially when a div or p is used before the response

- For 2.11
  Backport 1.159

- Satisfy w3c xhtml validation.

authoring space overhaul
this update tries to improve the user experience of the authoring space.

added codemirror for xml editor and script tags in colorful editor
added possibility to deactivate codemirror in author settings
added dropdown menu to insert problem templates into xml editor (thanks to tobias reinhardt)
added feature of saving current scrollposition on save when editing problems
added possibility to fold blocks in colorful editor, this state will be saved and restored
added shortcuts to create empty problems, html files and directories

and other smaller features and bugfixes

- Can view own submissions in anonymous surveys.

Improved spacing in colorful editor:
- More and consistent spacing between options
- Minimize missunderstanding to which element a help icon belongs to
- Less needed total window width in editor

bz4492 - Honor horizontal rendering of bubbles and do a bit of tuning of exam
mode rendering to make stuff look nicer in vert. mode.

BZ4492 - Code cleanup and more refactoring.

BZ 4492 - Get survey printing to honor the $direction.

BZ4492
- Factor out foil filtering in displayallfoils
- Factor out display_survey_htmlfrom displayallfoils.

Clean up errors in survey rendeing..still need to support horiztonal rendering
in survey mode which will be preceded by radical refactoring of displayallfoils.

BZ4492 - Get regular problems to honor 'direction' in 'tex' mode.

BZ 4492 - Get exam mode printing to understand 'horizontal' orientation.

BZ 4492 More refactoring prior to implementing latex direction rendering
        selection.

BZ4492 - continued refactoring of how this is rendered so this can be done
sensibly.

BZ4492 Complete refactoring of html rendition of radiobuttonresponses.

- Revert to 1.152. (white space changes reversed).

BZ 4492 Start refactorying the rendition code so that it's tractable
for modification

Reformat using perltidy so I can actually read it.

- Backport 1.150.

- Bug 5771
  - Fix underlying cause in lonnet::hashref2str().
  - Preferred to earlier fix (now reverted).
    - Revert earlier changes in *response.pm to report foil name of 0
      as an error.

- Additional (eighteenth field) BubblesPerRow in Bubblesheet Format file.
  - specify bubbles available for each question row (default is 10).
- Support case where question (or subquestion for optionresponse,
    matchresponse, or rankresponse) requires more bubbles than in one line.
  - Students prompted to bubble once in multiple lines.
  - Numbering recognizes multiple lines per question.
  - Also supports: imageresponse, stringresponse, formularesponse where
    students leave link(s) blank if weight assigned is greater than
    bubbles per line -- multiple lines also supported in this case.

For example:
- 15-bubble MSU Art History exams now supported on standard 10-bubble
    bubblesheets used at MSU.

- Bug 6489.
  - radiobuttonresponse containing foil with location="bottom" and value="false"
    can now include "true" foil in next to bottom position.
  - legacy behavior (that position inaccessible to "true" foil) retained for
    questiontype of "exam", in case bubblesheet exam is printed on a server running
    pre-rev 1.150 version of radiobuttonresponse, and graded on a server
    running rev 1.150 or later.

Bug #5771: foil name 0 does not work

- Duplicate declaration.

- New Question Type - randomizetry
  - Only check radiobutton checked in last try when displaying new try
    if rndseed for last try is the same as for current try.

- Correction to award name.

- remove metadate PDF-Formfield (finding a better place for it)
- printing radiobutton-PDF-Formfields in a itemize-environment

see also changes in lonxml::print_pdf_radiobutton(v1.507 to v1.508)

- New awards for surveys:
 ANONYMOUS ANONYMOUS_CREDIT SUBMITTED_CREDIT
  - given for question types: anonsurvey, anonsurvey_cred, survey_cred.
    - anonsurvey -- course personnel can not view both identity of submitter
                    and submission details.
    - anonsurveycred -- same anonymity, but submitter receives 'awarded' for
                        submission
    - surveycred - submitter receives 'awarded' for submission to survey.
- Do not display submission details on grading screens for anonymous surveys.

- do not print pdf-forms when radiobutton problem is not answerable

- XHTML conform checked attributes in input tags
- Optimized white spaces usage

- Backport 1.136, 1.140, 1.141.

- Add : for consistency.
- Add som additional spaces.

Typo.

Moved POD comments to bottom of file

Added/updated/converted POD. Many files had their POD redone to new standards.

Added/converted comments to POD style

Localization, wording, nobreaks for Colorful Editor
- Added missing &mt() calls at several places (more to be done)
- Same wording "Delete?" for all Delete options
- Same wording style, e.g. added ":" after text and before optionlist
- Added nobreak style for some elements which need to stay together, e.g. help_open_topic in loncommon.pm
- Added/updated some related German translations

Adds PDF-formfields function to radiobutton-problems (not to exams)

Localization:
- Added missing &mt() call to "Foils without names" warning
- Optimized &mt() call for "Foil name ... appears more than once" warning
- Added some other missing &mt() calls

- remove line commented out in 1.132

Localization:
Added missing &mt() to after solved messages "Correct:" and "Incorrect:"

When the target is 'analyze', include the responsetype of the current item in the lonhomework::analyze hash, for use later on, e.g., for scantron grading.

remove some log spew.

BZ 4074  Ensure the bubble lines chunk of the analysis hash gets
keyed by the concatenation of partid.resopnseid.

bz4074 - Use lonxml subs to maintain the number of bubble lines required
for responses to these types of problems.

- removing unneeded line

Make anaylze target produce a bubble_lines entry that describes how many
lines on an answer bubble sheet the problem requires for its answer.

- remove debug spew

- BUG#4074,
  - correct line numbers in print
  - correct the display of the correct answer to point to the correct line /bubble letter

- making sure that whichfoils is called only once per target so randomness
  doesn't change

- document &whichfoils
- correct usage of whichfoils

BZ4704 - Factor all the bubble line computations out into
end_foilgroup ... eliminating globals for
bubbles_per_line and bubble_lines.

BZ 4074:
  - Centralize the increment of the line counter.
  - Honor the bubbles per line parameter.
  - Centralize the line increment counter.

Style police.

Factor the multi-line bubble stuff out of radiobuttonresponse.pm and put
it into response.pm

Remove bogus /misleading comments

Support more than 10 radio responses in exam mode. Note that
grades.pm must still be taught to deal with more than one line
of bubbled responses as a multibubble.

:q!

- 2622, refactoring out some code, essay response also works now

- BUG#4244 enter works correctly now also with ption/radio/rank/match response

- mroe bug#2622 add code for fixing uyp displays of numerical/formula/radio responses to make more sense to users

- BUG#5206, <foil>s were posibly getting 2 eauation passes

BUG 4795 - Survey printing fails 'cause displayallfoils has no
conditional branches for $target eq 'tex'.  Put in a first crack at this.
NOTE: are the opportunities for a refactoriziation of the display of a single
foil between displayallfoils and display foil?

- backing out half done patch for now

- xhtml

BUG 4074 - If there are more than 10 foils displayed,
 in exam mode, break this up into two problems so that
 bubble sheets can be created.  Note that 10 is tunable
using exam_max_bubbles at the top of the module.

- BUG#4716

- add correct bubble to exam printout
- optionrepsonse prints multiple answer lines for exam printout

- if max is not specified, use all the foils

- BUG#4176

- 0 is a valid name for a foil

- BIG#4142 ratche foil unamedness downn to warning

- ENV -> env

- Part of #636, Submit Answer now only submits for a single part. The logic for detecting a submission has been broken out to a subroutine if future tweaks are needed.

- BUG#3757, <foil>s without names throw errors

- fixes BUG#3748

- propely do previous cheiking or rbr survey responses

- bug#2730, answeriscomputed attribute now exists for match,rank,radiobutton,string,formula,numercial responses

<label>s around input fields and foil text.  Does not appear to have any
effect on printing.

- making horizontal work in survey mode

- removing the <br/> in horizontal mode

- BUG#3194, removing unneded newlines

 - BUG#3194, radiobutton can be marked as horizontal now

- fixes for randnumber generation
   - due to a error in coding the 64bit and 64bit2 rnd seeds were throwing away the second half of the seed, we now preserve this functionality and make it explicit
   - additionally 64bit3 now uses all 64bits of the seed
   - also added new function pushrandomnumber poprandomnumber to be called instead of setrandomnumber before we were crunching the Safe space random number generator state, as this function is used bu thing the <optionresponse> and <radoibuttonresponse> this meant changes in the internal randomization code could screw up later Safe space random calls the old method is preserved for blank 64bit and 64bit2 randomiztion env.

- deafult to Alpha mode for numbering, looks better

- trying to be UTF8 transparent

- BUG#2835, Error either always or never showed up.

- BUG#2551, foil names need to be unique otherwise things go wonky, throw errors if we see repeated names.

- in survey mode don't show the correctness of the foil just higlight their selection

- retabination

- BUG#2776, rbr doesn't complain about a lack of true statments if it is a survey

- BUG#2754, surveys rendered incorrectly in answer mode

Help!

- took a look at all of the analyze outputs and corrected the buglets

- fixing up analyze mode for radiobutton/option/rank/match/image to all use the smae code

- does analyze target now

Removed last commit.

Bug 2323 (problem numbering when printing exam with answers) is fixed for radiobuttonresponse problems.

- cleaining up some code

- backport changes to make problemstatus work better

- added &Apache::response::show_answer() to better check for if problemstatus inhibiting should be occuring or not

- Bug #35, RBR now complains if no true foils available

- Fixes BUG#1439 for rbr

Bug 908 is fixed (this is not a bug - rather enhancement). I've introduced a
TeXtype attribute in <radioresponse> tag which allows you to customise the labelling.

- uses response::getresponse now

- brining consitancy to the homework input fields

- better handling of counters
- always increment the counters for modes with output

- option/radiobutton responses now use new method for getting current response
  supporting scantron mode

- baking out alex's change, that I said I wanted but it turned out I was lying, sorry about that alex

- actually submitting scantron results now, I have gottne 1 question for one studnet marked incorrect

- radiobutton now understands a scantron submission,
- radiobuton increments the counter in end_foild group, that way it can be used to acquire the scantron submissions

 Start to work on radiobutton response mode for the online exam.

- Fixes BUG#1132 not respecting max in radiobutton response.

- correct answers are no longer shown for target tex

Now prints proble after passing answer date correctly.

On-line exam with passed answer date can be printed correctly with answers.

 Changes to print list environment a little bit better (Ed's desire).

- working <radiobuttonhint>, edit mode is non-intuitive but functional

- Rewrite counter code

For the exam 1. correctly adjust the size of bubbles to the text width;
2. use correct enumeration through the environment variable;

- should only create the table in exam mode
- fixes problem with random numbers changing in grade target

Prints exams now.

- hide and show locations properly

- location attribute shown/hidden better

- removed use of Perl's internal rand operator, now all randomiztaion depends upon the external Math::Random library

- silly masking error

- all the possible ways one might derandomize are in here now, and athe answer is correct.
- BUG#542

- this allows one to turn randomiztion back on. :-)
- start of being able to specify where a particular foil should show up in the order

- allows one to turn off randomization, as a side effect it will
   1) ignore the max parameter
   2) always pick the first true foil it sees

Corrections to show the answer.

- show answer after answer date (was reverting to default display)

Changed to make as close to optionresponse as possible.

- incorrect initializtions

- supports variables in the possible args to a foil for a rbr type question BUG#584

- implementing BUG#238 fro radiobuttonresponse

- radiobuttonresponse was showing max+1 foils

- cleaning

can be printed now

- english update

changing "sub BEGIN" to "BEGIN"

Update to use edit::end_row() and edit::start_spanning_row() as a cleanup
for edit::select_arg and edit::select_or_text_arg.

- stop bombing on incomplete problems

- makes use of the new deregister mechanism
- radiobutton response handles previous in survey mode now.

- detects previous submissions
- detects blank submissions

- GPL headers

- Broken version, attempitng to improve the structture of the submissions data stored.

- survey mode now triggered by being a .survey file or resource.0.type being
    set to "survey"

- <radiobuttonresponse> display answers now

- edit mode works on rbresponse

- adding edit mode stuff

-added package notation for all remaining response styles

- <radiobuttonresponse> at least renders properly in edit mode, not pretty and modifications won't work well.

- <radiobuttonresponse> wasn't checking target properly

-re asserting my indent style

beautify/optimize

- added new arg $tagstack to all start_ or end_ routines

- added get_param

- added calls to get_param to clean up how one accesses data
- fixed the concetpgropu code to actually work
- fixed the off by one errors in selecting and displaying foils.

- redid random number generator for <i/rb/o/response> tags
     - should be unstable in preview mode and more random in normal mode

- fixed auto-checking of first radio button

- add survey option

- <conceptgroup>

- changed redirection, and output stack to work more intelligently, checkount radiobuttonresponse for a good example, should have to muck with @Apache::lonxml::outputstack and $Apache::lonxml::redirection directly use startredirection and enredirection

- <br> -> <br /> cleanup

- output correct/incorrect rather than true/false

- displays which answer was correct after you have it right

- updating comments

- look for the hidden submission "submitted" rather then the buttonpress

- need to detect meat and do nothing of interest

- max might be larger than the possible number of foils, need to count the foils

- should be fully fuctional now

- radiobuttons appear

- moving along <foil> looks good foilgroup> is now picking proper items

- nolonger cause ISE

- renaming
- first go at <foil>