--- loncom/homework/rankresponse.pm 2011/09/13 21:42:58 1.66
+++ loncom/homework/rankresponse.pm 2016/01/22 22:42:51 1.73
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# rank style response
#
-# $Id: rankresponse.pm,v 1.66 2011/09/13 21:42:58 raeburn Exp $
+# $Id: rankresponse.pm,v 1.73 2016/01/22 22:42:51 damieng Exp $
# Copyright Michigan State University Board of Trustees
#
# This file is part of the LearningOnline Network with CAPA (LON-CAPA).
@@ -51,7 +51,8 @@ sub start_rankresponse {
$result=&Apache::response::meta_package_write('rankresponse');
} elsif ($target eq 'edit' ) {
$result.=&Apache::edit::start_table($token)
- .'
'.&Apache::lonxml::description($token).' | '
+ .'
'.&Apache::loncommon::insert_folding_button()
+ .&Apache::lonxml::description($token).' | '
.''.&mt('Delete?').' '
.&Apache::edit::deletelist($target,$token)
.' | '
@@ -186,8 +187,11 @@ sub get_correct_order {
sub displayanswers {
my ($max,$randomize,$tol,@opt)=@_;
- if (!defined(@{ $Apache::response::foilgroup{'names'} })) { return; }
- my @names = @{ $Apache::response::foilgroup{'names'} };
+ my @names;
+ if (ref($Apache::response::foilgroup{'names'}) eq 'ARRAY') {
+ @names = @{ $Apache::response::foilgroup{'names'} };
+ }
+ return if (!@names);
my @whichfoils = &whichfoils($max,$randomize);
my @correctorder=&get_correct_order($tol,@whichfoils);
my $result;
@@ -332,8 +336,11 @@ sub format_prior_answer {
my %grading =&Apache::lonnet::str2hash($other_data->[1]);
my $output;
foreach my $name (@{ $foil_order }) {
- next if (!defined($lastresponse{$name}));
- $output .= '
'.$lastresponse{$name}.' |
';
+ if (defined($lastresponse{$name})) {
+ $output .= ''.&HTML::Entities::encode($lastresponse{$name},'<>&"').' |
';
+ } else {
+ $output .= ' |
';
+ }
}
return if (!defined($output));
$output =
@@ -355,7 +362,7 @@ sub displayfoils {
my $text=$Apache::response::foilgroup{$name.'.text'};
my $value=shift(@correctorder);
if ($target eq 'web') {
- $result.='
'.$value.': '.$text;
+ $result.=''.$value.': '.$text.'
';
} else {
$result.=' \strut\\\\\strut '.$value.':'.$text;
}
@@ -374,8 +381,17 @@ sub displayfoils {
$newvariation = 1;
}
}
- unless (((($Apache::lonhomework::history{"resource.$part.type"} eq 'anonsurvey') || ($Apache::lonhomework::history{"resource.$part.type"} eq 'anonsurveycred')) && (defined($env{'form.grade_symb'}))) || $newvariation) {
- $lastresponse=$Apache::lonhomework::history{"resource.$part.$id.submission"};
+ unless ($newvariation) {
+ if ((($env{'form.grade_username'} eq '') && ($env{'form.grade_domain'} eq '')) ||
+ (($env{'form.grade_username'} eq $env{'user.name'}) &&
+ ($env{'form.grade_domain'} eq $env{'user.domain'}))) {
+ $lastresponse=$Apache::lonhomework::history{"resource.$part.$id.submission"};
+ } else {
+ unless (($Apache::lonhomework::history{"resource.$part.type"} eq 'anonsurvey') ||
+ ($Apache::lonhomework::history{"resource.$part.type"} eq 'anonsurveycred')) {
+ $lastresponse=$Apache::lonhomework::history{"resource.$part.$id.submission"};
+ }
+ }
}
my %lastresponse=&Apache::lonnet::str2hash($lastresponse);
my @alp = splice @alphabet, 0, $#whichopt + 1;
@@ -428,15 +444,17 @@ sub displayfoils {
}
my $text=$Apache::response::foilgroup{$name.'.text'};
if ($target ne 'tex') {
+ $result .= '';
if ($Apache::lonhomework::type ne 'exam') {
- $result.='
'.$optionlist.$text."\n";
+ $result.=$optionlist.$text."\n";
} else {
- $result.='
'.$text."\n";
+ $result.=$text."\n";
}
if ($Apache::lonhomework::type eq 'exam') {
my @values=(1..scalar(@whichopt));
$result.=&Apache::optionresponse::webbubbles(\@values,\@whichopt,$temp,$lastopt);
}
+ $result .= '
';
} else {
if ($Apache::lonhomework::type eq 'exam') {
my $itemlabel;
@@ -593,9 +611,6 @@ sub end_foil {
$name=$Apache::lonxml::curdepth;
}
&Apache::lonxml::debug("Using a name of :$name:");
- if ($name eq "0") {
- &Apache::lonxml::error(&mt('Foil name [_1] is not supported. Please choose another name.',''.$name.''));
- }
if (defined($Apache::response::foilnames{$name})) {
&Apache::lonxml::error(&mt('Foil name [_1] appears more than once. Foil names need to be unique.',''.$name.''));
}