--- loncom/interface/Attic/lonchart.pm	2001/11/28 16:36:08	1.16
+++ loncom/interface/Attic/lonchart.pm	2001/11/28 18:48:33	1.22
@@ -15,7 +15,7 @@
 # 7/10/01 Behrouz Minaei
 # 9/8 Gerd Kortemeyer
 # 10/18/01, 10/19/01 Behrouz Minaei
-# 11/17/01, 11/22/01, 11/24/01 Behrouz Minaei
+# 11/17/01, 11/22/01, 11/24/01, 11/28/01 Behrouz Minaei
 
 package Apache::lonchart;
 
@@ -30,7 +30,6 @@ my %hash;
 my @cols;
 my @rowlabels;
 my @students;
-my $r;
 
 # ------------------------------------------------------------- Find out status
 
@@ -48,11 +47,7 @@ sub ExtractStudentData {
     my $Version;
     my $ProbNo;
     my $PrTotal;
-    my $LatestVersion;            
-
-    my $test = $ENV{'request.course.fn'};
-    my $comp = '/home/httpd/perl/tmp/minaeibi_msu_12679c3ed543a25msul1'; 
-               
+    my $LatestVersion;                     
     my $Str=substr($students[$index].
             '                                                        ',0,14).' ! '.
             substr($rowlabels[$index].
@@ -106,8 +101,7 @@ sub ExtractStudentData {
 			if (($Key=~/\.(\w+)\.solved$/) && ($Key!~/^\d+\:/)) {
 			    my $Part = $1;
 			    $Tries = $result{"$Version:$Prob:resource.$Part.tries"};
-			    if ($Tries) {$TempHash{"$Part.Tries"}=$Tries;}
-			    #my $Val = $result{"$Version:$Prob:$Key"};
+			    $TempHash{"$Part.Tries"}=($Tries) ? $Tries : 0;
 			    my $Val = $result{"$Version:$Prob:resource.$Part.solved"};
 			    if ($Val eq 'correct_by_student'){$Code='*';} 
 			    elsif ($Val eq 'correct_by_override'){$Code = '+';}                        
@@ -116,22 +110,19 @@ sub ExtractStudentData {
 			    elsif ($Val eq 'excused'){$Code = 'x';}
 			    else {$Code = ' ';}
 			    $TempHash{"$Part.Code"} = $Code;
-#            if ($test=~/*minaeibi*/) {
-#		$r->print($Key." ,,, ".$Val."<br>$Version:$Prob:resource.$Part.tries".' = '.$result{"$Version:$Prob:resource.$Part.tries"}."  $Val "."($Code)".'<br>');
-#	    }
 			}
       		    }
                 } 
-
 		for ( my $n = 0; $n < $PartNo; $n++ ) {		  
 		    my $part = $TempHash{$n};
-                    if ($TempHash{$part.'.Code'} eq '*') {
+                    if ($TempHash{"$part.Code"} eq '*') {
 			$ProbNo++;
-                        if ($TempHash{$part.'.Tries'}<10) {
-			    $TempHash{$part.'.Code'}=$Tries;
+                        if (($TempHash{"$part.Tries"}<10) ||
+                            ($TempHash{"$part.Tries"} eq '')) {
+			    $TempHash{"$part.Code"}=$TempHash{"$part.Tries"};
 			}
                     }
-		    $Str .= $TempHash{$part.'.Code'};
+		    $Str .= $TempHash{"$part.Code"};
 		}
             }   
 	    else {for(my $n=0; $n<$PartNo; $n++) {$Str.=' ';}}
@@ -190,7 +181,7 @@ sub tracetable {
 # ================================================================ Main Handler
 
 sub handler {
-  $r=shift;
+  my $r=shift;
 
   if (&Apache::lonnet::allowed('vgr',$ENV{'request.course.id'})) {
 # ------------------------------------------- Set document type for header only