--- loncom/interface/Attic/londropadd.pm	2002/04/29 14:36:23	1.33
+++ loncom/interface/Attic/londropadd.pm	2002/05/03 20:38:13	1.40
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to drop and add students in courses 
 #
-# $Id: londropadd.pm,v 1.33 2002/04/29 14:36:23 matthew Exp $
+# $Id: londropadd.pm,v 1.40 2002/05/03 20:38:13 matthew Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -62,14 +62,14 @@ sub header {
     return(<<ENDHEAD);
 <html>
 <head>
-<title>LON-CAPA Student Drop/Add</title>
+<title>LON-CAPA Enrollment Manager</title>
 </head>
 <body bgcolor="#FFFFFF">
 <img align=right src=/adm/lonIcons/lonlogos.gif>
-<h1>Drop/Add Students</h1>
-<form method="post" enctype="multipart/form-data"
-action="/adm/dropadd" name="studentform">
-<h2>Course: $ENV{'course.'.$ENV{'request.course.id'}.'.description'}</h2>
+<h1>$ENV{'course.'.$ENV{'request.course.id'}.'.description'}</h1>
+<h2>Enrollment Manager</h2>
+<form method="post" enctype="multipart/form-data"  
+      action="/adm/dropadd" name="studentform">
 ENDHEAD
 }
 
@@ -84,25 +84,32 @@ sub modifystudent {
     my %roles = &Apache::lonnet::dump('roles',$udom,$unam);
     my ($tmp) = keys(%roles);
     # Bail out if we were unable to get the students roles
-    return if ($tmp =~ /^(con_lost|error|no_such_host)/i);
+    return "$1" if ($tmp =~ /^(con_lost|error|no_such_host)/i);
     # Go through the roles looking for enrollment in this course
+    my $result = '';
     foreach my $course (keys(%roles)) {
-        my $value = $roles{$course};
-        if ($course=~/^$courseid(?:\/)*(\w+)*\_st$/) {
+        if ($course=~/^$courseid(?:\/)*(?:\s+)*(\w+)*\_st$/) {
             # We are in this course
             my $section=$1;
             $section='' if ($course eq $courseid.'_st');
-            if (((!$section) && (!$csec)) || ($section ne $csec)) {
+            if ( ((!$section) && (!$csec)) || ($section ne $csec) ) {
                 my (undef,$end,$start)=split(/\_/,$roles{$course});
                 my $now=time;
                 if (!($start && ($now<$start)) || !($end && ($now>$end))) {
                     my $reply=&Apache::lonnet::modifystudent
                         ($udom,$unam,'','','','','','','',
                          $section,time,undef,undef,$desiredhost);
+                    $result .= $reply.':';
                 }
             }
         }
     }
+    if ($result eq '') {
+        $result eq 'Unable to find section for this student';
+    } else {
+        $result =~ s/(ok:)+/ok/g;
+    }
+    return $result;
 }
 
 # ============ build a domain and server selection form
@@ -143,13 +150,16 @@ sub menu_phase_one {
 <hr>
 <h3>Upload a courselist</h3>
 $upfile_select
-<p><input type=submit name=fileupload value="Upload Courselist">
-<hr>
+<p><input type=submit name="fileupload" value="Upload Courselist">
+<hr />
 <h3>Enroll a single student</h3>
-<p><input type=submit name=enroll value="Enroll Student">
-<hr>
+<p><input type=submit name="enroll" value="Enroll Student"></p>
+<hr />
+<h3>Classlist</h3>
+<p><input type=submit name="view" value="View Class List"></p>
+<hr />
 <h3>Drop students</h3>
-<p><input type=submit name=drop value="Selection List">
+<p><input type=submit name="drop" value="Selection List"></p>
 ENDUPFORM
 }
 
@@ -163,12 +173,14 @@ sub phase_two_header {
     }
     my $javascript_validations=&javascript_validations($krbdefdom);
     $r->print(<<ENDPICK);
+<h3>Uploading Class List</h3>
 <hr>
 <h3>Identify fields</h3>
 Total number of records found in file: $distotal <hr />
 Enter as many fields as you can. The system will inform you and bring you back
 to this page if the data selected is insufficient to run your class.<hr />
-<input type="submit" name="associate"  value="Reverse Association" />
+<input type="button" value="Reverse Association" onClick="javascript:this.form.associate.value='Reverse Association';submit(this.form);" />
+<input type="hidden" name="associate"  value="" />
 <input type="hidden" name="phase"      value="three" />
 <input type="hidden" name="datatoken"  value="$datatoken" />
 <input type="hidden" name="fileupload" value="$ENV{'form.fileupload'}" />
@@ -450,7 +462,7 @@ LON-CAPA domain: $domform <p>
 <input type=checkbox name=forceid value=yes> 
 Disable ID/Student Number Safeguard and Force Change of Conflicting IDs
 (only do if you know what you are doing)<p>
-<input type="button" onClick="verify(this.form)" value="Update Courselist"><br>
+<input type="button" onClick="javascript:verify(this.form)" value="Update Courselist" /><br />
 Note: for large courses, this operation might be time consuming.
 ENDPICK
 }
@@ -503,7 +515,8 @@ sub menu_phase_two_upload {
 sub enroll_single_student {
     my $r=shift;
     $r->print('<h3>Enrolling Student</h3>');
-    $r->print($ENV{'form.cuname'}." in domain ".$ENV{'form.lcdomain'});
+    $r->print('<p>Enrolling '.$ENV{'form.cuname'}." in domain ".
+              $ENV{'form.lcdomain'}.'</p>');
     if (($ENV{'form.cuname'})&&($ENV{'form.cuname'}!~/\W/)&&
         ($ENV{'form.lcdomain'})&&($ENV{'form.lcdomain'}!~/\W/)) {
         # Deal with home server selection
@@ -519,7 +532,7 @@ sub enroll_single_student {
                 return;
             }
         }
-        $r->print(" with server $desiredhost :");
+        $r->print(" with server $desiredhost :") if (defined($desiredhost));
         # End of home server selection logic
 	my $amode='';
         my $genpwd='';
@@ -534,7 +547,9 @@ sub enroll_single_student {
 	    $genpwd=$ENV{'form.locarg'};
 	    if (!$genpwd) { $genpwd=" "; }
 	}
-        if (($amode) && ($genpwd)) {
+        my $home = &Apache::lonnet::homeserver($ENV{'form.cuname'},
+                                                   $ENV{'form.lcdomain'});
+        if ((($amode) && ($genpwd)) || ($home ne 'no_host')) {
             &modifystudent($ENV{'form.lcdomain'},$ENV{'form.cuname'},
                            $ENV{'request.course.id'},$ENV{'form.csec'},
                             $desiredhost);
@@ -547,7 +562,9 @@ sub enroll_single_student {
                       $ENV{'form.startdate'},$ENV{'form.forceid'},
                     $desiredhost));
 	} else {
-           $r->print('Invalid login mode or password');    
+            $r->print('<p><font color="#ff0000">ERROR</font>&nbsp;'.
+                      'Invalid login mode or password.  '.
+                      'Unable to enroll '.$ENV{'form.cuname'}.'.</p>');
         }          
     } else {
         $r->print('Invalid username or domain');
@@ -557,6 +574,7 @@ sub enroll_single_student {
 # ======================================================= Menu Phase Two Enroll
 sub menu_phase_two_enroll {
     my $r=shift;
+    $r->print("<h3>Enroll One Student</h3>");
     my ($krbdefdom) = $ENV{'SERVER_NAME'}=~/(\w+\.\w+)$/;
     $krbdefdom=~tr/a-z/A-Z/;
     my $today    = time;
@@ -674,6 +692,7 @@ sub get_current_classlist {
         }
         return (undef,%currentlist);
     } else {
+        $tmp =~ s/^error://;
         return ($tmp,undef);
     }
 }
@@ -681,13 +700,17 @@ sub get_current_classlist {
 # ========================================================= Menu Phase Two Drop
 sub menu_phase_two_drop {
     my $r=shift;
+    $r->print("<h3>Drop Students</h3>");
     my $cid=$ENV{'request.course.id'};
-    my ($error,%currentlist)=&get_current_classlist($ENV{'course.'.$cid.'.domain'},
-                                           $ENV{'course.'.$cid.'.num'});
+    my ($error,%currentlist)=&get_current_classlist
+        ($ENV{'course.'.$cid.'.domain'},$ENV{'course.'.$cid.'.num'});
     if (defined($error)) {
-        $r->print('<pre>ERROR:$error</pre>');
-    }
-    if (!defined(%currentlist)) { 
+        if ($error =~ /^No such file or directory/) {
+            $r->print("There are no students currently enrolled.\n");
+        } else {
+            $r->print("<pre>ERROR:$error</pre>");
+        }
+    } elsif (!defined(%currentlist)) { 
         $r->print("There are no students currently enrolled.\n");
     } else {
         # Print out the available choices
@@ -695,6 +718,66 @@ sub menu_phase_two_drop {
     }
 }
 
+# ============================================== view classlist
+sub menu_phase_two_view {
+    my $r=shift;
+    $r->print("<h3>Current Classlist</h3>");
+    my $cid=$ENV{'request.course.id'};
+    my ($error,%currentlist)=&get_current_classlist
+        ($ENV{'course.'.$cid.'.domain'},$ENV{'course.'.$cid.'.num'});
+    if (defined($error)) {
+        if ($error =~ /^No such file or directory/) {
+            $r->print("There are no students currently enrolled.\n");
+        } else {
+            $r->print("<pre>ERROR:$error</pre>");
+        }
+    } elsif (!defined(%currentlist)) { 
+        $r->print("There are no students currently enrolled.\n");
+    } else {
+        # Print out the available choices
+        &show_class_list($r,%currentlist);
+    }
+}
+
+# =================================================== Show student list to drop
+sub show_class_list {
+    my ($r,%currentlist)=@_;
+    my $cid=$ENV{'request.course.id'};
+    $r->print(<<END);
+<p>
+<table border=2>
+<tr><th>username</th><th>domain</th><th>ID</th>
+    <th>student name</th><th>generation</th><th>section</th></tr>
+END
+    foreach (sort keys %currentlist) {
+        my ($sname,$sdom)=split(/\:/,$_);
+        my %reply=&Apache::lonnet::idrget($sdom,$sname);
+        my $ssec=&Apache::lonnet::usection($sdom,$sname,$cid);
+        my %info=&Apache::lonnet::get('environment',
+                                      ['firstname','middlename',
+                                       'lastname','generation'],
+                                      $sdom, $sname);
+        my ($tmp) = keys(%info);
+        if ($tmp =~ /^(con_lost|error|no_such_host)/i) {
+            $r->print('<tr><td colspan="6"><font color="red">'.
+                      'Internal error: unable to get environment '.
+                      'for '.$sname.' in domain '.$sdom.'</font></td></tr>');
+        } else {
+            $r->print(<<"END");
+<tr>
+    <td>$sname</td>
+    <td>$sdom</td>
+    <td>$reply{$sname}</td>
+    <td>$info{'lastname'}, $info{'firstname'} $info{'middlename'}</td>
+    <td>$info{'generation'}</td>
+    <td>$ssec</td>
+</tr>
+END
+        }
+    }
+    $r->print('</table><br>');
+}
+
 # =================================================== Show student list to drop
 sub show_drop_list {
     my ($r,%currentlist)=@_;
@@ -934,10 +1017,21 @@ sub upfile_drop_add {
 sub drop_student_list {
     my $r=shift;
     my $count=0;
-    foreach (@{$ENV{'form.droplist'}}) {
+    my @droplist;
+    if (ref($ENV{'form.droplist'})) {
+        @droplist = @{$ENV{'form.droplist'}};
+    } else {
+        @droplist = ($ENV{'form.droplist'});
+    }
+    foreach (@droplist) {
         my ($uname,$udom)=split(/\:/,$_);
-        &modifystudent($udom,$uname,$ENV{'request.course.id'});
-        $r->print('Dropped '.$uname.' at '.$udom.'<br>');
+        my $result = &modifystudent($udom,$uname,$ENV{'request.course.id'});
+        if ($result eq 'ok' || $result eq 'ok:') {
+            $r->print('Dropped '.$uname.' at '.$udom.'<br>');
+        } else {
+            $r->print('Error dropping '.$uname.' at '.$udom.': '.$result.
+                      '<br />');
+        }
         $count++;
     }
     $r->print('<p><b>Dropped '.$count.' student(s).</b>');
@@ -979,6 +1073,8 @@ sub handler {
                 &menu_phase_two_enroll($r);
             } elsif ($ENV{'form.drop'}) {
                 &menu_phase_two_drop($r);
+            } elsif ($ENV{'form.view'}) {
+                &menu_phase_two_view($r);
             }
         }
         # Phase three