CVS log for loncom/interface/Attic/londropadd.pm

Up to [LON-CAPA] / loncom / interface

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- londropadd.pm was superceded by lonuserutils.pm in LON-CAPA 2.6.0
  - moving londropadd.pm to the Attic so it no longer gets worked on.

Removed londropadd::modifystudent. It is not used anymore and has been
superseded by lonuserutils::modifystudent.

added quant-calls in the source and edited them in de.pm, because they were not used elsewhere

consistent notation of e-mail in sentences and E-mail in titles.

Added/updated/converted POD. Many files had their POD redone to new standards.

Added/modified POD comments

Past tense of "occur" is "occurred" (rr!)
Also added some missing &mt() calls and corrected some other little typos

Bug 2593 csv file upload by DC to change passwords
- DCs can change authentication, add a domain or course role for uploaded users, and/or change user information (names, ID, e-mail address etc.)
- Authors can add co-authors
- Course Coordinators can add course roles.
- Some subroutines in londropdd.pm moved to lonuserutils.pm.  Some routines in loncreateuser.pm moved to lonuserutils.pm
- &process_pick() moved from lonroles.pm to lonpickcourse.pm
- Work in progress.  Ultimate goal is to provide user listing functionality in different contexts and eliminate separate ENRL button.

- remember last selections on user creations screens

- Selectable authentication types displayed controlled by domain prefs
   - some fix-ups.
   - mappings between form element names and stored auth types (int -> internal: etc.)
   - verification of auth selections (verify_message() javascript used more widely).

- More code re-use for adding newuser, and modifying existing user in loncreateuser.pm

- Moving code in loncreateuser.pm out to more subroutines
- Use of <div>s with float for a more compact display
- Added some div classes to standard_css

Work in progress. Towards greater amalgamation of ENRL/CUSR functionality.

Bug #5437: show clicker IDs in classlist

Display the response from the user search.

- xhtml
- only display permanentemail in classlist (a student's other e-mail addresses are set privately by student).
- flush email cache on change
- add ability to change permanentemail from modify student page
- CSS in data tables used to display outcome of modification

- remove debugging line
- calls to &header() were missing froe three blocks in &handler().

"Enroll a single student" in Enrollment Manager now uses the same user search interface as "Set Individual User Roles" in Create Users, Change User Privileges.

loncommon.pm
- &user_picker() takes an additional argument ($caller) to indicate the name of the form which will contain the user search - either: document.crtuser for CUSR or document.studentform for ENRL.
- javascript function: validateEntry() now takes an argument - callingForm, which similarly contains the name of the form (document.crtuser or document.studentform.

loncreateuser.pm
- &print_user_selection_page() takes two additional arguments: $context,$srcharray.
  - $context is 'createuser' or 'enrollstudent', depending on caller of form.   - $srcharray is a reference to an array of search items - ('srchterm','srchby','srchin','srchtype','srchdomain').
  - The call to lonhtmlcommon::echo_form_input() in print_user_selection_page() is replaced with printing of form input for elements in @{$srcharray} because of the possibility that this page could be reached coming back from the user modification page.
  - form element: 'state' renamed 'currstate' to avoid collision with 'state' which is already used in ENRL.
  - entry for studentform added to &crumb_utilities() so setFormElements() works for ENRL usage.

londropadd.pm
- &single_user_entry_form() added to display user search in "Enroll a single student" interface.
- user information fields filled in for new username is data available in institutional search.
- breadcrumbs code allows return to intermediate steps in multi-screen single student enrollment.

- remove debug

- BUG#5335 - instructors should be allowed to clas lists (and sectioned instructors limited to the one section)

- BUG#5311 add email address to class list display

- some @ -> : updates

Putting back the values from the enrollee's environment in the form fields for an existing user (they were deleted in rev 1.160).

- fix css for exisitg user enroll table

* Labels
* Internationalization

* increase character contrast by default (white background)
* labels
* fix some &mt()s
* css on roles screen

- switch to lonnet for get the library server for a domain

- reduce usage of libserv and host dom,
- mode the domain fetching routines to lonnet

Create-Another links

ISE due to missing subroutine.

Links for "Delete group" and "Re-enable deleted group".

- add in missing dependency

- correcting env lookups

- switch to username helpers
- stop splitting $cid on _
- stop trying to turn course id is nto role decriptiors using re

- xhtml

	Bug 5087. Make "ignore first line" checkbox sticky.

- BUG#4954 - adding future to the coursedata view of students status

- hiding delete BUG#4876

-last of BUG#4908 (unhide groups for 2.2)

- temp. hide of groups

&coursegroups() and &get_group_settings() moved to longroup.pm, which contains general utility functions for asking about groups.  Also contains &group_changes() which is used to add/drop group memberships as a result of role changes, as determined by group settings for auto-add and auto-drop. 'none' and 'all' are now reserved words which may not be used as section or group names, so they can be used instead of _all and _none  when specifying auto-add and auto-drop settings for all sections or no section roles.

Include display of active groups in classlist as a column which can be used as a sort key.  Replace reference to Section/Group with Section.  Include protection against section naming with reserved words 'none' or 'all' and also with the name of a course group.

- upadte breadcrumbs calls

- update calls to coursedescription where they want the cached data updated

-adding a LC_data_table that has the CC color in the th row and alternates the row colors

- start_page

Re-enable groups links in ENRL page. Add interface to allow group creator to specify mapping of different roles/sections to a group to support auto-add and auto-drop changes in group membership based on role changes of course participants. Implement ability to modify group settings, and to add new members. Changes to loncommon.pm to accommodate extraction of mapping options (roles & sections) when parsing group record in coursegroups.db file. Still working on ability to change functions/privileges/status of existing members.

$env{'internal.studentphotos'} -> $env{'internal.studentphoto'} Previous settings will now be ignored and course owners will have to indicate agreement to conditions of use of student photos, before being able to use them in a course.

- style police

Add support for student photo import from an institutional repository. Availability of photos of registered students in a course controlled by course environment parameter: 'internal.studentphoto'.  This may be configured to require initial acceptance of conditions of use by course owner.  View classlist in ENRL, and Automated Enrollment Manager now includes option to display thumbnails of student photos.  Nightly enrollment update can import student photos for students added to a course.  Student photos can be updated via the Automated Enrollment Manager.

- remivng course groups links

Add links to londropadd.pm to allow creation and display of groups. (not all functions implemented yet).

- <label>

Bug #3805: explain authentication mechanisms

use 'none' in excel output instead of unixtime 0.

- increasing the use of loncommon::get_env_multiple

- ENV -> env

Updated to use loncommon::create_workbook.  Spreadsheets were slightly
modified to use formats.

- <html> -> &Apache::lonxml::xmlbegin, thus valid doctypes are now getting output, Yeah! StandardsCmpliance

- backing out the encoding changes for now

- some xhtml cleanups
- one icon -> lonhttpd

Saving my work towards aspects of bugs 1290 and 3442.

- fixes so that usenrames with _ work again

Upload is not spelled with an 'e'.

Added 'vcl' permission.
londropadd.pm: rewrote &print_main_menu to only show actions the user has
the ability to perfrom.  Modified &handler to restrict access to functions
based on vcl & cst permissions.

- focus the username field

 BUG#3541

Fix bug #3371. Also in londropadd::show_class_list() prevent line break between checkbox and label.

- fixing BUG#3218 as per gerd's desire
- also updating preferences and dropadd use of bread crumbs to make better use of the existing help

- _ seems to be bad in usernames
- enroll single student wasn't protecting the username from bad caharacters

AUtomated Enrollment Manager now provides automatic switching from 'manual' to 'auto' enrollment type when a manually enrolled student is detected in the institution's classlist.  Auto switching can be prevented on a per-student basis by 'locking' the type to 'manual'. Also changes to Enrollment.pm to make it more modular.

Calls to functions in localenroll.pm mediated by lonc/lond now include domain
in the set of passed parameters to support domain-specific variants in a single
localenroll.pm file housed on a multi-domain library server.

Automated enrollment now sets first access and last access dates for student
roles based on defaults set on course creation, and modifiable via a number
of mechanisms in the Enrollment Manager, and Automated Enrollment Manager.

The Automated Enrollment Manager now provides a utility to allow enrollment type
to be toggled between 'auto' and 'manual', so that students added via CSV file
or singly can become liable for automated update (dropping, section switching
etc.).

Check if auto-enrollment is enabled on the course's homeserver. If yes, display link to Automated Enrollment Manager.

Removed debugging code.

Bug 3015.

Bug 2976: Add start and end dates to view and drop classlist pages.
Required modifying the inputs to &show_class_list.  Dates are formatted
with lonlocal::locallocaltime or Excel, as the need arises.  Now
depend on lonstathelpers for the excel time handling routine.
Cleaned up some bad html on the classlist view page.  Modified the input
parameters for the classlist view page to use form.output instead of the
much overused form.state.  All of this is not as nice as it should be but
I don't have time to eviscerate it properly.

Bug 3006: Crappy <form> made it impossible to modify students.

Added count column to classlist output.

Typos: "separate"

Modify to use new cascading faq/help links feature in breadcrumbs.

&print_html_classlist: Changed wording from "Refresh Display" to
"Update Display".

Fixed: &print_html_classlist now properly indicates the currently selected
output format.
Added Excel formatting to output.

Interface tweaks for html/csv/excel generation of classlist view.  Needs
to be tested more....

Added breadcrumbs to 'action' state.

londropadd.pm: Added display of role start and end times to "modify single
student" display, mostly to show when the start and end dates are not set.
Made the 'section' input box a little bigger, too.

Add course personnel to class list.

- backport 1.96 and 1.97

- adding code to hide Automated Enrollmanet manger link if not enabled on the machine

Bug 2140: Classlist upload should remember field choices.

Help buttons

Modifications to &javascript_validations() to simplify code for use by loncreatecourse and lonmodifycourse.

Modifications to javascript_validations(), to support use by loncreatecourse.pm and lonmodifycourse.pm. For loncreatecourse.pm: Javascript function verify_message() now only requires an authentication type, if automated adds set to "Yes" (fix to bug #2468). Same function now requires a Kerberos domain if authtype is set to "krb" when called from loncreatecourse.pm and lonmodifycourse.pm.

Existing javascript code for use of javascript_validations() by other modules (e.g., londropadd.pm -directly) left unchanged, although it should be modified in the future if checking of the autharg field is desired - as written it will always deliver the default, i.e., no alert, regardless of the contents of the autharg field.

-BUG#2509, one place used Course list, every where else uses classlist

Localization is finished (some words could be missed).

- type

Some localization is added.

Added link to "Automated enrollment manager".  Modified following functions:
javascript_validations and date_setting_table to support calls for customized versions of their output from loncreatecourse.pm - used by domain controller to create new courses.

Lots of localization of enrollment forms and authentications forms.
Minor comment/POD changes to loncommon.pm in addition to localization.

Further londropadd.pm localization.  This time, localizing the javascript
which alerts the user of missing fields.

First stab a localization of londropadd.pm.
Note: Using parameters in localization.  Let me know if this is okay.
Also needed to add comments to newphrases.txt.  Again, let me know.

Fixed bug which made it impossible to revoke the role of student for a
student who had previously had a section but later did not have a section.
Some better error reporting was added as well (returning '666' on error
doesn't seem like a bright idea now).

Various small internationalization bugfixes.

Attempt at bug 2142 - domains should default to course domain.

- BUG #2097, localauth should not require a password when doing CSV uploads

- backport 1.83

Going by the domain of the server makes no sense, users should be default be
enrolled into the domain of the course. Already caused some confusion, should
probably go into 1.0.1.

Bug #1542 more correctly.

Bug #1542: ignore first line from uploaded courselists, e.g. column titles
Jay Ihry

Trap non-alphanumeric values in the Section instead of just whitespace and
colons.

Bug 1608: More coherent error messages for missing kerberos domain data.

Disallow :'s in sections as well - the classlist.db is colon deliminated.

For inclusion in 1.0.  Section names with spaces in them cause problems,
so trap and silently remove them.

- bug 1911, Classlist is really Class List

&print_single_student_enroll_form():
    Fix bug where londropadd.pm was not picking up the proper kerberos
    domain.  Modified formatting of authentication table.

Bug 1475
Added &get_student_username_domain_form which, when enrolling a single student,
uses a seperate page to get the username & domain.  If the user exists the
enrollment page is simplified and pre-filled out.  If not, the enrollment
page is pretty much as before (minor cosmetic changes).
Added &javascript_validiations_without_auth
Reworked much of &print_enroll_single_student_form()

Have very limited connectivity, need to do big commit while online.
Will call this JULYone in Bugzilla. Fixes several small bugs.

Cleanup of error reporting in bulk enrollment.

Bugs 1084 and 1832 - spurious error message about changing section.

Fix bug where users were prevented from removing name fields from the students
environment.

Automatic refreshing of the course environment after setting the enrollment
dates as default for the course.

Bug 844:
All enrollment pages (classlist upload, enroll single student, and
    modify single student) now use the new date_setter which lets you set the
    date right in the page.
The date setters respect the course default start and end dates.
An instructor can set the dates he/she/it chooses as the default for future
    enrollments.
Added a 'no ending date' checkbox so the person enrolling can hit it instead
    of setting the date to Dec 31st, 1969, 7pm or whatever the unixtime start
    date is for their time zone.

Part of Bug:884.  Enroll single student now uses the default dates from
the course environment.  Additionally it uses the more pleasant 'date_setter'
method of getting date info from the user.

Remove useless parameter to get_date_from_form.

Added &Apache::lonhtmlcommon::pjump_javascript_definition() because the
javascript function pjump was cut and pasted five times in the source
code and I just could not sleep at night if I had made it six.

- Mark Lucas' code to add a domain.tab file it controls
   - domain description,
   - default authentication type
   - default argument for that auth type

- I think this will break the install hopefully I'll get this jury rigged up to work today

Fix two bugs:
1. &modify_single_student did not expire old student roles in the course.
   This has been implemented by calling &londropadd::modifystudent.
2. &modify_single_student handled the 'override student id change' stuff
   improperly.  Now a check is made to determine the the student has an
   id before bitching about attempts to change the users id.

Another attempt to make it shut the hell up.

Minor formatting changes.

Added excel spreadsheet as format for viewing classlist.

Many changes to deal well with the new status field.
The routine &show_class_list was modified to use javascript to set a few
hidden parameter values and submit the form in order to take you to the next
page when modifying a students information.  This is in contrast to the
previous method which passed parameters in a link.
&show_drop_list is now a little brighter about the 'sortby' parameter, for
what it's worth (not much, really).
&drop_student_list acts more intelligent on errors - the errors are still
reported and other information is now suppressed if it is not relevant.
Specifically, if no students were successfully dropped you needn't tell
the user about re-enrollment.

Fixed a bug which did not allow attempts to modify students if the list had
been sorted.
CSV printout of classlist now includes an extra column specifying the users
status if the status mode is set to 'any'.  If it is set to 'expired' a
brief message stating such will be printed out at the top of the sheet.

Added a status selection box to the routines which display the classlist.
This is mainly for debugging as many of our test classes have few active
students.

Modifications to use &Apache::loncoursedata::get_classlist().
Removed londropadd::get_current_classlist.
Modified other routines to use get_classlist
Added code to remove heading and trailing whitespace for data in csv uploads.
Removed &drop_students because it was neven used and called a function that
did not exist.
Occasional POD & comment updates.

Bug 674 - remind the course coordinator the role will not become active
until the student next logs in to LON-CAPA.
Fixed idiocy in &handler regarding subroutine to call in bad 'drop' state.
It is always helpful to call subroutines that exist.

Added sorting of classlist on 'drop students' page.  This was done by
cut and paste of code from the other view classlist routine, which shames
me to no end.  But not enough to find a better way of doing it right now.

Sorting of classlist (case insensitive) implemented for all but drop classlist.

Can now modify a single students data.  Woo!

Rewrote &get_current_classlist to call routines in loncoursedata.
Renamed &menu_phase_two_drop to &print_drop_menu and modified to use new
data from &get_current_classlist.
Modified &print_html_classlist and &print_csv_classlist to deal with new
&get_current_classlist.
Rewrote &show_classlist to take data from &get_current_classlist.

Not all of the error detecting code is reimplemented yet.
Modifying a single students status is not working yet.
Sorting of students by various fields (table headings) needs to be implemented.

Highlights:
Now have 'modify student data' options, although you cannot actually modify
any student data yet.
Selecting a students name in the classlist display will take you to their
'aboutme' page.

Gory details:
Many internal changes to state keeping.
The current page displayed is determined by two parameters, 'action' and
'state'.
Changed subroutine names to describe what they do.
Reformatted single student enrollment form.
Added input variable to &show_class_list to determine what sort of link
to place around user names.
Modified &print_html_classlist to take advantage of new &show_class_list
Added &print_modify_student_form, which works wonderfully.
Added &modify_single_student, which tells you what it wants to do but
cannot actually do it.
Added &get_enrollment_data, which will probably be removed soon.
Added &drop_students to do just that.
Modified &handler to implement state keeping changes and document it.

Backport of fix for bug 742.

Fixing earlier tag funkiness.

Backport of bugfix for bug 742.

Fixes bug 742.  The code used to clear out the settings for certain columns
if the label for the second column was set.  The offending for loop has been
removed and comments have been added to confuse and enlighten the unwary.

Interface cleanups.  Instead of an ugly page with forms and buttons it now
displays an ugly page with links.  Working towards adding a
'modify one student' page, bug 264.

- krb5 stuff backport to version 0.5

- adding krb5 support

Starting to implement common header and color scheme for LON-CAPA handlers
(non-content pages).

Instead of <body bgcolor="#...."><h1>... call

   &Apache::loncommon::bodytag(title,[role],[add_body_parms]);

title: what it says in the header
role (OPTIONAL): override role choice
                 ('admin','coordinator','student','author')
add_body_parms: additional parameters to be put into the body tag, for
                example 'onLoad="init();" or stuff

Colors and layout will likely change in the future, including domain
customization, help function calls, (css?)

Changed loncommon::get_home_servers to get_library_servers.

Fixes bug #620, and adds the ability to pass text to help_open_topic to
also be linked, along with the graphic.

Added some more help, fixed some tex typos.

Comma Seperated Values function added to loncommon (along with a little
documentation on get_unprocessed_cgi() ), and londropadd now uses the new
csv function.  I forgot which bug this is for and I can't find it now.

Added csv classlist option.

Added course list viewing capability.  BUG 205.
Rewrote web page header information.

Fixes BUG 330.  If the enrollment database file does not exist we take this
to mean the course does not have any students enrolled.

Fixes BUG 329.
Changed 'ERROR: $error' to "ERROR: $error".
Previously the check for an error was independent of the display of the list
of students to drop.  Now any error in retrieving the list of students will
prevent the drop list from being displayed.

Fixed bogus error reporting.

- fixed BUG#311

Fixed bug which prevented dropping of single students.
Fixed bug which prevented dropping of students whose section begins with
whitespace.

Better reports to user if things go wrong.  No longer need to enter password
for a user who already exists.

Fix for users not really being enrolled in courses.

Added 'check all' and 'uncheck all' to drop screen.

More cleanups - added call to loncommon::linked_select_forms to enable the
instructor to specify a machine to create the users on.  This required some
reworking of the logic involved in adding/dropping users.

Remove debugging flag.

Javascript bugfix and added calls to &Apache::loncommon::select_dom_form().

New javascript to handle authentication forms.

Fixed bug in modifystudent introduced in last commit, changed return value
for get_current_classlist so that we detect when the classlist is empty
instead of assuming it is an error.

Many cleanups to the code.  Added &get_current_classlist, renamed
&dropstudent to &modifystudent because I cannot imagine why you would
call &dropstudent if you wanted to *add* a student to a class.  Cleaned
up forms for dropping students.  Added comments here and there.
More work remains to be done.

Reindentation in preparation for larger changes.

- moved much of the CSV handling code into loncommon in preparation for grades.pm to accept uploads
- addressed BUG#71 (both original and reverse mode now work)
- did some cleanup and common code removal

- refactoring

- adds helpful message (BUG#234)

Missing parenthesis added.

map to foreach

Force ID interface - seems to work, but not very well tested

Force ID check screen menu (does not work yet)

- Finished GPLing the code

Dropping students who are not in sections

- added the localauth authentication mech

fix IE bug

Bug fix sample display

Now also enrolls single students

Can now drop students - add single student in progress

Large changes, can drop students from sections. Drop not done yet, not
completely tested.

Mac and PC linebreak, formfeed, etc, compatible (hopefully)

Start and end separated by ":" rather then "_"

Flush output and evaluate classlist for dropping

Seems to do the enrollment correct

Calls modifystudent, does seem to do everything right, but gets 'refused'
as answer.

Finds fields, sets start and end time

Verifies field selection choices

Now uploads files and is able to separate them

Handler to drop and add students - doesn't do anything yet.