--- loncom/interface/coursecatalog.pm	2019/07/19 13:18:27	1.88.2.4
+++ loncom/interface/coursecatalog.pm	2017/02/18 23:39:15	1.91
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler for displaying the course catalog interface
 #
-# $Id: coursecatalog.pm,v 1.88.2.4 2019/07/19 13:18:27 raeburn Exp $
+# $Id: coursecatalog.pm,v 1.91 2017/02/18 23:39:15 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -176,8 +176,12 @@ sub handler {
                                       $courseinfo{$codedom.'_'.$cnum}{$item});
                             if ($item eq 'title') {
                                 if ($courseinfo{$codedom.'_'.$cnum}{'showsyllabus'}) {
+                                    my $usehttp = 0;
+                                    if (($ENV{'SERVER_PORT'} == 443) && ($courseinfo{$codedom.'_'.$cnum}{'extsyllplain'})) {
+                                        $usehttp = 1;
+                                    }
                                     $r->print('&nbsp;<font size="-2">'.
-                                              '<a href="javascript:ToSyllabus('."'$codedom','$cnum'".')">'.
+                                              '<a href="javascript:ToSyllabus('."'$codedom','$cnum','$usehttp'".')">'.
                                               &mt('Syllabus').'</a></font>');
                                 }
                             }
@@ -207,31 +211,21 @@ sub handler {
         $r->print('<br />'.&Apache::loncommon::end_page());
         return OK;
     } else {
-        if ($env{'form.coursenum'} ne '') {
-            if ($env{'form.coursenum'} =~ /^$LONCAPA::match_courseid$/) {
-                $cnum = $env{'form.coursenum'};
-            } else {
-                delete($env{'form.coursenum'});
-            }
+        if ($env{'form.coursenum'}) {
+            $cnum = $env{'form.coursenum'};
         }
     }
 
-    my (@cats,@trails,%allitems,%idx,@jsarray,%subcathash,$subcats,%maxd,
-        $toplevelstr,$maxdepthstr);
+    if ($env{'form.catalog_maxdepth'} ne '') {
+        $env{'form.catalog_maxdepth'} =~ s{\D}{}g;
+    }
+
+    my (@cats,@trails,%allitems,%idx,@jsarray,%subcathash,$subcats);
     if ($env{'form.withsubcats'}) {
         $subcats = \%subcathash;
     }
     &Apache::loncommon::extract_categories($cathash,\@cats,\@trails,\%allitems,
-                                           \%idx,\@jsarray,$subcats,\%maxd);
-    if (ref($cats[0]) eq 'ARRAY') {
-        foreach my $item (@{$cats[0]}) {
-            $toplevelstr .= "'".&js_escape($item)."::0',";
-            $maxdepthstr .= "'$maxd{$item}',";
-        }
-        $toplevelstr =~ s/,$//;
-        $maxdepthstr =~ s/,$//;
-    }
-    &validate_input(\@cats,\%maxd);
+                                           \%idx,\@jsarray,$subcats);
     my ($numtitles,@codetitles);
     if (($env{'form.coursenum'} ne '') && ($knownuser)) {
         &course_details($r,$codedom,$formname,$domdesc,\@trails,\%allitems,\@codetitles);
@@ -241,29 +235,9 @@ sub handler {
         my $catjs = <<"ENDSCRIPT";
 
 function setCatDepth(depth) {
-    var depth = parseInt(depth);
-    if (depth !== NaN) {
-        if (depth > 0) {
-            var possmaxd = 0;
-            var toplevel = new Array($toplevelstr);
-            var maxdepths = new Array($maxdepthstr);
-            if (toplevel.length) {
-                for (var i=0; i<toplevel.length; i++) {
-                    var item = unescape(toplevel[i]);
-                    if (item == document.coursecats.currcat_0.value) {
-                        possmaxd = maxdepths[i];
-                        break;
-                    }
-                }
-            }
-            if (depth > possmaxd) {
-                depth = possmaxd;
-            }
-        }
-        document.coursecats.catalog_maxdepth.value = depth;
-    } else {
+    document.coursecats.catalog_maxdepth.value = depth;
+    if (depth == '') {
         document.coursecats.currcat_0.value = '';
-        document.coursecats.catalog_maxdepth.value = '';
     }
     document.coursecats.submit();
     return;
@@ -349,6 +323,8 @@ ENDJS
                 my $display_button;
                 if ($env{'form.currcat_0'} eq 'communities::0') {
                     $display_button = &mt('Display communities');
+                } elsif ($env{'form.currcat_0'} eq 'placement::0') {
+                    $display_button = &mt('Display placement tests');
                 } else {
                     $display_button = &mt('Display courses');
                 }
@@ -370,67 +346,6 @@ ENDJS
     return OK;
 }
 
-sub validate_input {
-    my ($cats,$maxd) = @_;
-    my $currcat = '';
-    my $depth = 0;
-    if ($env{'form.catalog_maxdepth'} ne '') {
-        $env{'form.catalog_maxdepth'} =~ s{\D}{}g;
-    }
-    if ((ref($cats) eq 'ARRAY') && (ref($maxd) eq 'HASH')) {
-        if (ref($cats->[0]) eq 'ARRAY') {
-            if (@{$cats->[0]} == 1) {
-                if ($cats->[0][0] eq 'instcode') {
-                    $currcat = 'instcode::0';
-                } elsif ($cats->[0][0] eq 'communities') {
-                    $currcat = 'communities::0';
-                } elsif ($cats->[0][0] eq 'placement') {
-                    $currcat = 'placement::0';
-                } else {
-                    my $name = $cats->[0][0];
-                    $currcat = &escape($name).'::0';
-                }
-                if (exists($maxd->{$cats->[0][0]})) {
-                    if ($env{'form.catalog_maxdepth'} <= $maxd->{$cats->[0][0]}) {
-                        $depth = $env{'form.catalog_maxdepth'};
-                    } else {
-                        $depth = $maxd->{$cats->[0][0]};
-                    }
-                }
-            } elsif ((@{$cats->[0]} > 1) && ($env{'form.currcat_0'} ne '')) {
-                my ($escname) = ($env{'form.currcat_0'} =~ /^([^:]+)\:\:0$/);
-                if ($escname =~ /^instcode|communities|placement$/) {
-                    $currcat = $env{'form.currcat_0'};
-                    if (exists($maxd->{$escname})) {
-                        if ($env{'form.catalog_maxdepth'} <= $maxd->{$escname}) {
-                            $depth = $env{'form.catalog_maxdepth'};
-                        } else {
-                            $depth = $maxd->{$escname};
-                        }
-                    } else {
-                        $depth = 1;
-                    }
-                } elsif ($escname ne '') {
-                    my $name = &unescape($escname);
-                    if (grep(/^\Q$name\E$/,@{$cats->[0]})) {
-                        $currcat = $env{'form.currcat_0'};
-                        if (exists($maxd->{$name})) {
-                            if ($env{'form.catalog_maxdepth'} <= $maxd->{$name}) {
-                                $depth = $env{'form.catalog_maxdepth'};
-                            } else {
-                                $depth = $maxd->{$name};
-                            }
-                        }
-                    }
-                }
-            }
-        }
-    }
-    $env{'form.currcat_0'} = $currcat;
-    $env{'form.catalog_maxdepth'} = $depth;
-    return;
-}
-
 sub course_details {
     my ($r,$codedom,$formname,$domdesc,$trails,$allitems,$codetitles) = @_;
     my $output;
@@ -449,9 +364,18 @@ sub course_details {
     }
     my $brtextone = 'Course listing';
     my $brtexttwo = 'Course details';
+    my $textthree = &mt('Detailed course information:');
+    my $textfour = &mt('Back to course listing');
     if ($env{'form.currcat_0'} eq 'communities::0') {
         $brtextone = 'Community listing';
         $brtexttwo = 'Community details';
+        $textthree = &mt('Detailed community information:');
+        $textfour = &mt('Back to community listing');
+    } elsif ($env{'form.currcat_0'} eq 'placement::0') {
+        $brtextone = 'Placement test listing';
+        $brtexttwo = 'Placement test details';
+        $textthree = &mt('Detailed placement test information:');
+        $textfour = &mt('Back to placement test listing');
     }
     &Apache::lonhtmlcommon::add_breadcrumb
              ({href=>"javascript:document.$formname.submit()",
@@ -459,20 +383,12 @@ sub course_details {
              {text=>$brtexttwo});
     $r->print(
         &Apache::lonhtmlcommon::breadcrumbs('Course/Community Catalog').
-        '<h2>'.
-        (($env{'form.currcat_0'} eq 'communities::0') ?
-            &mt('Detailed community information:') :
-            &mt('Detailed course information:')).
-        '</h2>'.
+        '<h2>'.$textthree.'</h2>'.
         &print_course_listing($codedom,undef,$trails,$allitems,undef,$codetitles).
         '<br />'.
         '<form name="'.$formname.'" method="post" action="/adm/coursecatalog">'.
         &Apache::lonhtmlcommon::actionbox([
-            '<a href = "javascript:document.coursecatalog.submit()">'.
-            (($env{'form.currcat_0'} eq 'communities::0') ?
-                &mt('Back to community listing') : &mt('Back to course listing')).
-            '</a>'
-        ]).
+            '<a href = "javascript:document.coursecatalog.submit()">'.$textfour.'</a>']).
         &Apache::lonhtmlcommon::echo_form_input(['coursenum','catalogfilter',
                                                  'showdetails','courseid']).
         '</form>');
@@ -502,7 +418,7 @@ END
 sub courselink_javascript {
     return <<"END";
 
-function ToSyllabus(cdom,cnum) {
+function ToSyllabus(cdom,cnum,usehttp) {
     if (cdom == '' || cdom == null) {
         return;
     }
@@ -510,6 +426,9 @@ function ToSyllabus(cdom,cnum) {
         return;
     }
     document.linklaunch.action = "/public/"+cdom+"/"+cnum+"/syllabus";
+    if (usehttp == 1) {
+        document.linklaunch.action += '?usehttp=1';
+    }
     document.linklaunch.submit();
 }
 
@@ -596,6 +515,8 @@ sub cat_header {
     my $brtext = 'Course listing';
     if ($env{'form.currcat_0'} eq 'communities::0') {
         $brtext = 'Community listing';
+    } elsif ($env{'form.currcat_0'} eq 'placement::0') {
+        $brtext = 'Placement test listing';
     }
     if ($env{'form.state'} eq 'listing') {
         if ($numtitles > 0) {
@@ -649,6 +570,9 @@ sub category_breadcrumbs {
             } elsif ($cats[0][0] eq 'communities') {
                 $catlinks .= &mt('Communities');
                 $env{'form.currcat_0'} = 'communities::0';
+            } elsif ($cats[0][0] eq 'placement') {
+                $catlinks .= &mt('Placement Tests');
+                $env{'form.currcat_0'} = 'placement::0';
             } else {
                 my $name = $cats[0][0];
                 my $item = &escape($name).'::0';
@@ -753,6 +677,8 @@ sub main_category_selector {
                 $maincatlinks .= &mt('Official courses (with institutional codes)');
             } elsif ($name eq 'communities') {
                 $maincatlinks .= &mt('Communities');
+            } elsif ($name eq 'placement') {
+                $maincatlinks .= &mt('Placement Tests');
             } else {
                 $maincatlinks .= $name;
             }
@@ -815,6 +741,8 @@ sub additional_filters {
     my $selfenroll_text;
     if ($env{'form.currcat_0'} eq 'communities::0') {
         $selfenroll_text = &mt('Only show communities which currently allow self-enrollment (or will allow it in the future)');
+    } elsif ($env{'form.currcat_0'} eq 'placement::0') {
+        $selfenroll_text = &mt('Only show placement tests which currently allow self-enrollment (or will allow it in the future)');
     } else {
         $selfenroll_text = &mt('Only show courses which currently allow self-enrollment (or will allow it in the future)');
     }
@@ -848,6 +776,9 @@ sub additional_filters {
         if ($env{'form.currcat_0'} eq 'communities::0') {
             $details_text = &mt('Show full details for each community (domain staff only)');
             $hidden_text = &mt('Include communities set to be hidden from catalog (domain staff only)');
+        } elsif ($env{'form.currcat_0'} eq 'placement::0') {
+            $details_text = &mt('Show full details for each placement test (domain staff only)');
+            $hidden_text = &mt('Include placement tests set to be hidden from catalog (domain staff only)');
         } else {
             $details_text = &mt('Show full details for each course (domain staff only)');
             $hidden_text = &mt('Include courses set to be hidden from catalog (domain staff only)');
@@ -1061,6 +992,8 @@ sub search_courselist {
         }
         if ($env{'form.currcat_0'} eq 'communities::0') {
             $typefilter = 'Community';
+        } elsif ($env{'form.currcat_0'} eq 'placement::0') {
+            $typefilter = 'Placement';
         } else {
             $typefilter = '.';
         }
@@ -1092,7 +1025,9 @@ sub print_course_listing {
             $output = '<p class="LC_error">';
             if ($env{'form.currcat_0'} eq 'communities::0') {
                 $output .= &mt('The courseID provided does not match a community in this domain.');
-            } else { 
+            } elsif ($env{'form.currcat_0'} eq 'placement::0') {
+                $output .= &mt('The courseID provided does not match a placement test in this domain.');
+            } else {
                 $output .= &mt('The courseID provided does not match a course in this domain.');
             }
             $output .= '</p>';
@@ -1108,6 +1043,8 @@ sub print_course_listing {
             $output = '<p class="LC_info">';
             if ($env{'form.currcat_0'} eq 'communities::0') {
                 $output .= &mt('No communities match the criteria you selected.');
+            } elsif ($env{'form.currcat_0'} eq 'placement::0') {
+                $output .= &mt('No placement tests match the criteria you selected.');
             } else {
                 $output .= &mt('No courses match the criteria you selected.');
             }
@@ -1168,6 +1105,10 @@ sub construct_data_table {
             if ($env{'form.currcat_0'} eq 'communities::0') {
                 $output .= '<th>'.&mt('Default Access Dates for Members').'</th>'.
                            '<th>'.&mt('Member Counts').'</th>';
+            } elsif ($env{'form.currcat_0'} eq 'placement::0') {
+                $output .=
+                    '<th>'.&mt('Default Access Dates for Students').'</th>'.
+                    '<th>'.&mt('Student Counts').'</th>';               
             } else {
                 $output .=
                     '<th>'.&mt('Default Access Dates for Students').'</th>'.
@@ -1215,7 +1156,7 @@ sub construct_data_table {
     my (%numbers,%creditsum);
     my ($showcredits,$defofficial,$defunofficial,$deftextbook);
     my %domdefaults = &Apache::lonnet::get_domain_defaults($domain);
-    unless ($env{'form.currcat_0'} eq 'communities::0') {
+    unless (($env{'form.currcat_0'} eq 'communities::0') || ($env{'form.currcat_0'} eq 'placement::0')) {
         if ($domdefaults{'officialcredits'} || $domdefaults{'unofficialcredits'} || $domdefaults{'textbookcredits'}) {
             $showcredits = 1;
             $defofficial = $domdefaults{'officialcredits'};
@@ -1281,6 +1222,8 @@ sub construct_data_table {
                 $lt{'Active'} = &mt('Total current members'); 
                 $lt{'Future'} = &mt('Total future members');
                 $lt{'Previous'} = &mt('Total previous members');
+            } elsif ($env{'form.currcat_0'} eq 'placement::0') {
+                $lt{'courses'} = &mt('Total placement tests');
             }
             my $colspan = 8;
             if ($showcredits) {
@@ -1339,7 +1282,7 @@ sub build_courseinfo_hash {
         $cleandesc=~s/'/\\'/g;
         $cleandesc =~ s/^\s+//;
         my ($cdom,$cnum)=split(/\_/,$course);
-        my ($instcode,$singleowner,$ttype,$selfenroll_types,
+        my ($instcode,$singleowner,$ttype,$selfenroll_types,$extsyllplain,
             $selfenroll_start,$selfenroll_end,@owners,%ownernames,$categories);
         if (ref($courses->{$course}) eq 'HASH') {
             $descr = $courses->{$course}{'description'};
@@ -1350,6 +1293,7 @@ sub build_courseinfo_hash {
             $selfenroll_start = $courses->{$course}{'selfenroll_start_date'};
             $selfenroll_end = $courses->{$course}{'selfenroll_end_date'};
             $categories = $courses->{$course}{'categories'};
+            $extsyllplain = $courses->{$course}{'extsyllplain'};
             push(@owners,$singleowner);
             if ($courses->{$course}{'co-owners'} ne '') {
                 foreach my $item (split(/,/,$courses->{$course}{'co-owners'})) {
@@ -1393,6 +1337,7 @@ sub build_courseinfo_hash {
         $courseinfo{$course}{'selfenroll_start'} = $selfenroll_start;
         $courseinfo{$course}{'selfenroll_end'} = $selfenroll_end;
         $courseinfo{$course}{'categories'} = $categories;
+        $courseinfo{$course}{'extsyllplain'} = $extsyllplain;
 
         my %coursehash = &Apache::lonnet::dump('environment',$cdom,$cnum);
         my @classids;
@@ -1577,7 +1522,8 @@ sub count_students {
 sub courseinfo_row {
     my ($info,$knownuser,$details,$countref,$now,$course,$trails,$allitems,$numbers,$canviewall) = @_;
     my ($cdom,$cnum,$title,$ownerlast,$code,$owner,$seclist,$xlist_items,
-        $accessdates,$showsyllabus,$counts,$autoenrollment,$output,$categories);
+        $accessdates,$showsyllabus,$counts,$autoenrollment,$output,$categories,
+        $extsyllplain);
     if (ref($info) eq 'HASH') {
         $cdom = $info->{'cdom'};
         $cnum = $info->{'cnum'};
@@ -1591,6 +1537,7 @@ sub courseinfo_row {
         $counts = $info->{'counts'};
         $autoenrollment = $info->{'autoenrollment'};
         $showsyllabus = $info->{'showsyllabus'};
+        $extsyllplain = $info->{'extsyllplain'};
         $categories = $info->{'categories'};
     } else {
         $output = '<td colspan="8">'.&mt('No information available for [_1].',
@@ -1618,7 +1565,11 @@ sub courseinfo_row {
                '<td>'.$xlist_items.'</td>'.
                '<td>'.$title.'&nbsp;<font size="-2">';
     if ($showsyllabus) {
-        $output .= '<a href="javascript:ToSyllabus('."'$cdom','$cnum'".')">'.&mt('Syllabus').'</a>';
+        my $usehttp = 0;
+        if (($ENV{'SERVER_PORT'} == 443) && ($extsyllplain)) {
+            $usehttp = 1;
+        }
+        $output .= '<a href="javascript:ToSyllabus('."'$cdom','$cnum','$usehttp'".')">'.&mt('Syllabus').'</a>';
     } else {
         $output .= '&nbsp;';
     }
@@ -1629,7 +1580,7 @@ sub courseinfo_row {
             $output .=
                 '<td>'.$accessdates.'</td>'.
                 '<td>'.$counts.'</td>';
-            unless ($env{'form.currcat_0'} eq 'communities::0') {
+            unless (($env{'form.currcat_0'} eq 'communities::0') || ($env{'form.currcat_0'} eq 'placement::0')) {
                 $output .= '<td>'.$autoenrollment.'</td>';
             }
         } else {
@@ -1698,32 +1649,27 @@ sub identify_sections {
 sub get_valid_classes {
     my ($seclist,$xlist_items,$crscode,$owners,$cdom,$cnum) = @_;
     my $response;
-    my (@sections,@xlists,%possclasses,%okclasses,%validations);
+    my %validations;
     @{$validations{'sections'}} = ();
     @{$validations{'xlists'}} = ();
     my $totalitems = 0;
     if ($seclist) {
-        @sections = split(/,\s+/,$seclist);
-        map { $possclasses{$crscode.$_} = 1; } @sections;
-    }
-    if ($xlist_items) {
-        @xlists = split(/,\s+/,$xlist_items);
-        map { $possclasses{$_} = 1; } @xlists;
-    }
-    my %okclasses = &Apache::lonnet::auto_validate_instclasses($cdom,$cnum,$owners,
-                                                               \%possclasses);
-    if (keys(%okclasses)) {
-        foreach my $sec (@sections) {
-            if ($okclasses{$crscode.$sec}) {
+        foreach my $sec (split(/, /,$seclist)) {
+            my $class = $crscode.$sec;
+            if (&Apache::lonnet::auto_validate_class_sec($cdom,$cnum,$owners,
+							 $class) eq 'ok') {
                 if (!grep(/^\Q$sec$\E/,@{$validations{'sections'}})) {
                     push(@{$validations{'sections'}},$sec);
                     $totalitems ++;
                 }
             }
         }
-        foreach my $item (@xlists) {
-            if ($okclasses{$item}) {
-                if (!grep(/^\Q$item\E$/,@{$validations{'xlists'}})) {
+    }
+    if ($xlist_items) {
+        foreach my $item (split(/, /,$xlist_items)) {
+            if (&Apache::lonnet::auto_validate_class_sec($cdom,$cnum,$owners,
+							 $item) eq 'ok') {
+                if (!grep(/^\Q$item$\E/,@{$validations{'xlists'}})) {
                     push(@{$validations{'xlists'}},$item);
                     $totalitems ++;
                 }