--- loncom/interface/coursecatalog.pm 2019/07/23 01:30:35 1.101 +++ loncom/interface/coursecatalog.pm 2025/02/24 23:20:17 1.108 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # Handler for displaying the course catalog interface # -# $Id: coursecatalog.pm,v 1.101 2019/07/23 01:30:35 raeburn Exp $ +# $Id: coursecatalog.pm,v 1.108 2025/02/24 23:20:17 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -37,6 +37,7 @@ use Apache::lonnet; use Apache::lonlocal; use Apache::courseclassifier; use Apache::lonacc; +use HTML::Entities(); use LONCAPA; use LONCAPA::lonauthcgi; @@ -59,6 +60,7 @@ sub handler { my $serverdefdom = &Apache::lonnet::default_login_domain(); my $codedom = $serverdefdom; + my $hostname = $r->hostname(); if (($env{'user.domain'} ne '') && ($env{'user.domain'} ne 'public')) { $codedom = $env{'user.domain'}; @@ -86,7 +88,7 @@ sub handler { ({href=>"/adm/coursecatalog", text=>"Course/Community Catalog"}); $r->print(&Apache::lonhtmlcommon::breadcrumbs('Course/Community Catalog')); - $r->print('
'.&mt('Access to catalog LON-CAPA courses/communities unavailable for: "[_1]" on servers run by: "[_2]".', + $r->print('
'.&mt('Access to catalog LON-CAPA courses/communities unavailable for: "[_1]" on servers run by: "[_2]".', $domdesc,$serverdomdesc).'
'); $r->print(&Apache::loncommon::end_page()); return OK; @@ -117,18 +119,30 @@ sub handler { text=>"Course/Community Catalog"}); $r->print(&Apache::lonhtmlcommon::breadcrumbs('Course/Community Catalog')); if ($knownuser || $canviewall) { - $r->print('
'.&mt('No catalog of LON-CAPA courses/communities is provided for: [_1]',$domdesc).'
'); + $r->print('
'.&mt('No catalog of LON-CAPA courses/communities is provided for: [_1]',$domdesc).'
'); } else { if ($domdefaults{'catauth'} eq 'none') { - $r->print('
'.&mt('No catalog of LON-CAPA courses/communities is provided for: [_1]',$domdesc).'
'); + $r->print('
'.&mt('No catalog of LON-CAPA courses/communities is provided for: [_1]',$domdesc).'
'); } else { - $r->print('
'.&mt('The catalog of LON-CAPA courses/communities provided for: "[_1]" is only available to users who are logged in.',$domdesc).'
'); + $r->print('
'.&mt('The catalog of LON-CAPA courses/communities provided for: "[_1]" is only available to users who are logged in.',$domdesc).'
'); } } $r->print(&Apache::loncommon::end_page()); return OK; } + for (my $i=0; $i<=$env{'form.catalog_maxdepth'}; $i++) { + if ($env{'form.currcat_'.$i} eq '-1') { + $env{'form.currcat_'.$i} = ''; + } + if (exists($env{'form.initialcurrcat_'.$i})) { + if ($env{'form.currcat_'.$i} ne $env{'form.initialcurrcat_'.$i}) { + $env{'form.catalog_maxdepth'} = $i; + last; + } + } + } + my $cnum; if ($cattype eq 'codesrch') { my ($uniquecode,$codemsg,$brtext); @@ -138,7 +152,7 @@ sub handler { } my $js = ''."\n"; $r->print(&Apache::loncommon::start_page('Search for a Course/Community',$js)); @@ -191,7 +205,8 @@ sub handler { if ($courseinfo{$codedom.'_'.$cnum}{'showsyllabus'}) { my $usehttp = 0; if (($ENV{'SERVER_PORT'} == 443) && ($courseinfo{$codedom.'_'.$cnum}{'extsyllplain'})) { - unless (&Apache::lonnet::uses_sts()) { + unless ((&Apache::lonnet::uses_sts()) || + (&Apache::lonnet::waf_allssl($hostname))) { $usehttp = 1; } } @@ -253,41 +268,19 @@ sub handler { &validate_input($codedom,\@cats,\%maxd,$cathash); my ($numtitles,@codetitles); if (($env{'form.coursenum'} ne '') && ($knownuser)) { - &course_details($r,$codedom,$formname,$domdesc,\@trails,\%allitems,\@codetitles); + &course_details($r,$codedom,$formname,$domdesc,$hostname,\@trails, + \%allitems,\@codetitles); } else { my ($catlinks,$has_subcats,$selitem) = &category_breadcrumbs($codedom,@cats); my $wasacctext = &get_wasactive_text(); + my %js_lt = &Apache::lonlocal::texthash( + 'noch' => 'No changes made in drop-down lists', + 'chsu' => 'Choose a subcategory to display', + 'chca' => 'Choose a category to display', + ); + &js_escape(\%js_lt); my $catjs = <<"ENDSCRIPT"; -function setCatDepth(depth) { - var depth = parseInt(depth); - if (depth !== NaN) { - if (depth > 0) { - var possmaxd = 0; - var toplevel = new Array($toplevelstr); - var maxdepths = new Array($maxdepthstr); - if (toplevel.length) { - for (var i=0; i possmaxd) { - depth = possmaxd; - } - } - document.coursecats.catalog_maxdepth.value = depth; - } else { - document.coursecats.currcat_0.value = ''; - document.coursecats.catalog_maxdepth.value = ''; - } - document.coursecats.submit(); - return; -} - function changeSort(caller) { document.$formname.sortby.value = caller; document.$formname.submit(); @@ -299,7 +292,7 @@ function setCourseId(caller) { } ENDSCRIPT - $catjs .= &courselink_javascript($r); + $catjs .= &courselink_javascript($hostname); if (&user_is_dc($codedom) || $canviewall) { $catjs .= <print(&print_course_listing($codedom,$numtitles,undef,undef,undef, - \@codetitles,$canviewall)); + \@codetitles,$canviewall,$hostname)); } } else { my (%add_entries); my ($currdepth,$deeper) = &get_depth_values(); - if ($selitem) { - my $alert = &mt('Choose a subcategory to display'); - if (!$deeper) { - $alert = &mt('Choose a category to display'); - } - &js_escape(\$alert); - $catjs .= <'; - &cat_header($r,$codedom,$catjs,\%add_entries,$catlinks,undef,$cattype); + my $js = ''; + &cat_header($r,$codedom,$js,\%add_entries,$catlinks,undef,$cattype); if ($env{'form.currcat_0'} ne '') { $r->print('
'. @@ -383,11 +398,12 @@ ENDJS } if ($env{'form.state'} eq 'listing') { $r->print(&print_course_listing($codedom,undef,\@trails,\%allitems,$subcats,\@codetitles, - $canviewall)); + $canviewall,$hostname)); } } + $r->print('
'); } - $r->print('
'.&Apache::loncommon::end_page()); + $r->print(&Apache::loncommon::end_page()); return OK; } @@ -485,8 +501,8 @@ sub validate_input { } foreach my $key (sort(keys(%env))) { - if ($key =~ /^form\.(.+)$/) { - unless ($possibles{$1}) { + if ($key =~ /^form\.currcat_(.+)$/) { + unless ($possibles{'currcat_'.$1}) { delete($env{$key}); } } @@ -623,8 +639,6 @@ sub validate_input { } elsif (ref($crscatsref) eq 'HASH') { unless (exists($crscatsref->{$env{'form.'.$key}})) { delete($env{'form.'.$key}); - } else { - delete($env{'form.'.$key}); } } else { delete($env{'form.'.$key}); @@ -637,16 +651,11 @@ sub validate_input { sub get_instcode_allowable { my ($codedom,$possvalref) = @_; return 1 unless (ref($possvalref) eq 'HASH'); - my $caller = 'global'; - my %coursecodes = (); - my %codes = (); - my @codetitles = (); - my %cat_titles = (); - my %cat_order = (); - my $totcodes = &Apache::courseclassifier::retrieve_instcodes(\%coursecodes,$codedom); - if ($totcodes > 0) { - if (&Apache::lonnet::auto_instcode_format($caller,$codedom,\%coursecodes, - \%codes,\@codetitles,\%cat_titles,\%cat_order) eq 'ok') { + my $instcats = &Apache::lonnet::get_dom_instcats($codedom); + if (ref($instcats) eq 'HASH') { + if ((ref($instcats->{'codetitles'}) eq 'ARRAY') && (ref($instcats->{'codes'}) eq 'HASH')) { + my %codes = %{$instcats->{'codes'}}; + my @codetitles = @{$instcats->{'codetitles'}}; my @standardnames = &Apache::loncommon::get_standard_codeitems(); my %local_to_standard; for (my $i=0; $i<@codetitles; $i++) { @@ -666,12 +675,12 @@ sub get_instcode_allowable { } sub course_details { - my ($r,$codedom,$formname,$domdesc,$trails,$allitems,$codetitles) = @_; + my ($r,$codedom,$formname,$domdesc,$hostname,$trails,$allitems,$codetitles) = @_; my $output; my %add_entries = (topmargin => "0", marginheight => "0",); my $js = ''."\n"; + &courselink_javascript($hostname).''."\n"; my $start_page = &Apache::loncommon::start_page('Course/Community Catalog',$js, {'add_entries' => \%add_entries, }); @@ -702,15 +711,16 @@ sub course_details { {text=>$brtexttwo}); $r->print( &Apache::lonhtmlcommon::breadcrumbs('Course/Community Catalog'). + '
'. '

'.$textthree.'

'. - &print_course_listing($codedom,undef,$trails,$allitems,undef,$codetitles). + &print_course_listing($codedom,undef,$trails,$allitems,undef,$codetitles,undef,$hostname). '
'. ''. &Apache::lonhtmlcommon::actionbox([ ''.$textfour.'']). &Apache::lonhtmlcommon::echo_form_input(['coursenum','catalogfilter', 'showdetails','courseid']). - ''); + '
'); return; } @@ -735,8 +745,7 @@ END } sub courselink_javascript { - my ($r) = @_; - my $hostname = $r->hostname(); + my ($hostname) = @_; return <<"END"; function ToSyllabus(cdom,cnum,usehttp) { @@ -771,13 +780,9 @@ END sub instcode_course_selector { my ($r,$codedom,$formname,$domdesc,$catlinks,$catjs,$codetitles,$cattype,$canviewall) = @_; - my %coursecodes = (); - my %codes = (); my %cat_titles = (); my %cat_order = (); - my %cat_items; - my $caller = 'global'; - my $format_reply; + my %cat_items = (); my %add_entries = (topmargin => "0", marginheight => "0",); my ($jscript,$totcodes,$numtitles,$lasttitle) = @@ -858,19 +863,21 @@ sub cat_header { ({href=>"/adm/coursecatalog", text=>"Course/Community Catalog"}); } - $r->print(&Apache::lonhtmlcommon::breadcrumbs('Course/Community Catalog')); + $r->print(&Apache::lonhtmlcommon::breadcrumbs('Course/Community Catalog'). + '
'); if ($cattype eq 'std') { - my $onchange = 'this.form.submit()'; $r->print('
'. - '
'.&mt('Domain:').''. - &Apache::loncommon::select_dom_form($codedom,'showdom','',1,$onchange)); - if (!$onchange) { - $r->print(' '); - } - $r->print('
'); + '
'. + &Apache::loncommon::select_dom_form($codedom,'showdom','',1,'','','','','showdom'). + ' '."\n". + ''."\n". + '
'); + } + my $onsubmit; + unless ($env{'form.currcat_0'} eq 'instcode::0') { + $onsubmit = ' onsubmit="return check_selected();"'; } - $r->print('
'. + $r->print(''. ''.$catlinks.'
'); return; } @@ -882,9 +889,10 @@ sub category_breadcrumbs { my $currcat_str = ''. ''; - my $catlinks = ''.&mt('Catalog:').'
'; + my $catlinks = ''.&mt('Catalog:').'
'; my $has_subcats; my $selitem; + my $update_button; if (ref($cats[0]) eq 'ARRAY') { if (@{$cats[0]} == 0) { $catlinks .= &mt('No categories defined in this domain'); @@ -906,6 +914,7 @@ sub category_breadcrumbs { } $currcat_str .= ''; } else { + $update_button = 1; $catlinks .= &main_category_selector(@cats); if (($env{'form.currcat_0'} ne '') && ($env{'form.currcat_0'} ne 'instcode::0')) { @@ -915,7 +924,7 @@ sub category_breadcrumbs { } else { $catlinks .= &mt('Official courses (with institutional codes)'); $env{'form.currcat_0'} = 'instcode::0'; - $currcat_str .= ''; + $currcat_str .= ''; } if ($deeper) { for (my $i=1; $i<=$deeper; $i++) { @@ -923,11 +932,10 @@ sub category_breadcrumbs { next if ($shallower == 0); my ($cat,$container,$depth) = map { &unescape($_); } split(/:/,$env{'form.currcat_'.$shallower}); if ($cat ne '') { - $catlinks .= '
'. - ''; if (ref($cats[$shallower]{$container}) eq 'ARRAY') { - $catlinks .= ''; + $catlinks .= ''; for (my $j=0; $j<@{$cats[$shallower]{$container}}; $j++) { my $name = $cats[$shallower]{$container}[$j]; my $item = &escape($name).':'.&escape($container).':'.$shallower; @@ -939,7 +947,8 @@ sub category_breadcrumbs { ''; } } - $catlinks .= ''; + $catlinks .= ''. + ''; } unless ($i == $deeper) { $catlinks .= $crumbsymbol; @@ -957,7 +966,8 @@ sub category_breadcrumbs { $has_subcats = 1; my $buttontext = &mt('Show subcategories'); my $selitem = 'currcat_'.$deeperlevel; - $catlinks .= ' '; if (@{$cats[$deeperlevel]{$cat}}) { $catlinks .= ''; @@ -974,13 +984,18 @@ sub category_breadcrumbs { } else { $selitem = 'currcat_0'; } - $catlinks .= $currcat_str.'
'; + $catlinks .= $currcat_str; + if ($update_button) { + $catlinks .= ' '."\n"; + } + $catlinks .= '
'; return ($catlinks,$has_subcats,$selitem); } sub main_category_selector { my (@cats) = @_; - my $maincatlinks = ''."\n"; if (ref($cats[0]) eq 'ARRAY') { if (@{$cats[0]} > 1) { my $selected = ''; @@ -1009,7 +1024,8 @@ sub main_category_selector { } $maincatlinks .= ''."\n"; } - $maincatlinks .= ''."\n"; + $maincatlinks .= ''."\n". + ''."\n"; } return $maincatlinks; } @@ -1035,7 +1051,7 @@ sub additional_filters { if ($is_dc || $canviewall) { $output .= '
'.&mt('Options').''; } - $output .= ''."\n". - ''; + $output .= ''; } else { - $output .= ''; + $output .= ''; } - $output .= '
'; + $output .= '
'; if (($env{'form.currcat_0'} ne 'instcode::0') && ($env{'form.currcat_0'} ne '') && ($has_subcats)) { my $include_subcat_status; @@ -1096,8 +1112,9 @@ sub additional_filters { } } else { $statusdisplay = 'none'; - $cellborder = 'border-left: 0px'; + $cellborder = 'border-left: 0px;'; } + $cellborder .= ' vertical-align: top;'; if ($env{'form.currcat_0'} eq 'communities::0') { $details_text = &mt('Show full details for each community (domain staff only)'); $hidden_text = &mt('Include communities set to be hidden from catalog (domain staff only)'); @@ -1117,9 +1134,9 @@ sub additional_filters { $output .= ''. '
'. - '
'; + $details_text.'
'."\n". + '
'. + '
'; if (ref($orderref) eq 'ARRAY') { if (@{$orderref} > 0) { foreach my $type (@{$orderref}) { @@ -1149,13 +1166,14 @@ sub additional_filters { date => 'immediately prior to specific date:', ); my @statuses = &Apache::loncommon::get_env_multiple('form.showcounts'); - $output .= ''; + my $wasactivetext; if ($checked) { - $output .= &get_wasactive_text(); + $wasactivetext = &get_wasactive_text(); } - $output .= ''. - '
'. - ''; + $output .= '
'."\n". + '
'."\n". + ''."\n". + $wasactivetext.''."\n"; my @milestones = ('accessend'); if (&Apache::lonnet::auto_run(undef,$codedom)) { push(@milestones,'enrollend'); @@ -1171,8 +1189,7 @@ sub additional_filters { $checked = ' checked="checked"'; } $output .= - '
'; + $output .= '
'; } - $output .= '
 '. - '
'; + $output .= '
'; } $output .= '
'; } } } - $output .= '
'. + $output .= ''. '
'; return $output; } @@ -1261,11 +1278,11 @@ sub get_statustitles { } sub get_wasactive_text { - my $wasacctext = ' -- '; + my $wasacctext; if ($env{'form.currcat_0'} eq 'communities::0') { - $wasacctext .= &mt('where member access status was current ...'); + $wasacctext .= &mt('count where member access status was current ...'); } else { - $wasacctext .= &mt('where student access status was current ...'); + $wasacctext .= &mt('count where student access status was current ...'); } return $wasacctext; } @@ -1331,7 +1348,7 @@ sub search_courselist { } sub print_course_listing { - my ($domain,$numtitles,$trails,$allitems,$subcats,$codetitles,$canviewall) = @_; + my ($domain,$numtitles,$trails,$allitems,$subcats,$codetitles,$canviewall,$hostname) = @_; my $output; my %courses; my $knownuser = &user_is_known(); @@ -1384,7 +1401,7 @@ sub print_course_listing { } my $now = time; $output .= &construct_data_table($knownuser,$domain,\%courses,$details,undef, - $now,$trails,$allitems,$canviewall); + $now,$trails,$allitems,$canviewall,$hostname); $output .= "\n".'
'. ''. ''. @@ -1393,7 +1410,8 @@ sub print_course_listing { } sub construct_data_table { - my ($knownuser,$domain,$courses,$details,$usersections,$now,$trails,$allitems,$canviewall) = @_; + my ($knownuser,$domain,$courses,$details,$usersections,$now, + $trails,$allitems,$canviewall,$hostname) = @_; my %sortname; if (($details eq '') || ($env{'form.showdetails'})) { $sortname{'Code'} = 'code'; @@ -1418,7 +1436,7 @@ sub construct_data_table { if (defined($sortname{$item})) { $output .= ''.&mt($item).''; } elsif ($item eq 'Count') { - $output .= '  '; + $output .= '#'; } else { $output .= &mt($item); } @@ -1519,11 +1537,31 @@ sub construct_data_table { } my $count = 1; my $totalsec = 0; + my %clutteredxlists; + foreach my $course (keys(%courseinfo)) { + if (ref($courseinfo{$course}) eq 'HASH') { + if ($courseinfo{$course}{'xlist'} ne '') { + my $crskey = $courseinfo{$course}{'cnum'}.':'.$courseinfo{$course}{'code'}; + my @xlists = split(/,\s/,$courseinfo{$course}{'xlist'}); + $clutteredxlists{$crskey} = \@xlists; + } + } + } + if (keys(%clutteredxlists)) { + my %reformattedxlists = &Apache::lonnet::auto_instsec_reformat($domain,'declutter',\%clutteredxlists); + foreach my $crskey (keys(%reformattedxlists)) { + if (ref($reformattedxlists{$crskey}) eq 'ARRAY') { + my $course = $domain.'_'.(split(/:/,$crskey))[0]; + $courseinfo{$course}{'xlist'} = join(', ',@{$reformattedxlists{$crskey}}); + } + } + } foreach my $item (@sorted_courses) { foreach my $course (@{$Sortby{$item}}) { $output.=&Apache::loncommon::start_data_table_row(); $output.=&courseinfo_row($courseinfo{$course},$knownuser,$details, - \$count,$now,$course,$trails,$allitems,\%numbers,$canviewall); + \$count,$now,$course,$trails,$allitems, + \%numbers,$canviewall,$hostname); $output.=&Apache::loncommon::end_data_table_row(); } } @@ -1845,7 +1883,8 @@ sub count_students { } sub courseinfo_row { - my ($info,$knownuser,$details,$countref,$now,$course,$trails,$allitems,$numbers,$canviewall) = @_; + my ($info,$knownuser,$details,$countref,$now,$course,$trails,$allitems, + $numbers,$canviewall,$hostname) = @_; my ($cdom,$cnum,$title,$ownerlast,$code,$owner,$seclist,$xlist_items, $accessdates,$showsyllabus,$counts,$autoenrollment,$output,$categories, $extsyllplain); @@ -1878,7 +1917,13 @@ sub courseinfo_row { @cats = split('&',$categories); } if ((ref($trails) eq 'ARRAY') && (ref($allitems) eq 'HASH')) { - my @categories = map { $trails->[$allitems->{$_}]; } @cats; + my @categories; + foreach my $cat (@cats) { + next if ($cat eq ''); + if (($allitems->{$cat} ne '') && ($trails->[$allitems->{$cat}] ne '')) { + push(@categories,$trails->[$allitems->{$cat}]); + } + } $categorylist = join('
',@categories); } if ($categorylist eq '') { @@ -1892,7 +1937,8 @@ sub courseinfo_row { if ($showsyllabus) { my $usehttp = 0; if (($ENV{'SERVER_PORT'} == 443) && ($extsyllplain)) { - unless (&Apache::lonnet::uses_sts()) { + unless ((&Apache::lonnet::uses_sts()) || + (&Apache::lonnet::waf_allssl($hostname))) { $usehttp = 1; } } @@ -1976,13 +2022,19 @@ sub identify_sections { sub get_valid_classes { my ($seclist,$xlist_items,$crscode,$owners,$cdom,$cnum) = @_; my $response; - my (@sections,@xlists,%possclasses,%okclasses,%validations); + my (@sections,@format_sections,@xlists,%possclasses,%okclasses,%validations); @{$validations{'sections'}} = (); @{$validations{'xlists'}} = (); my $totalitems = 0; if ($seclist) { @sections = split(/,\s+/,$seclist); - map { $possclasses{$crscode.$_} = 1; } @sections; + my $crskey = $cnum.':'.$crscode; + my %formattedsec = &Apache::lonnet::auto_instsec_reformat($cdom,'clutter', + {$crskey => \@sections}); + if (ref($formattedsec{$crskey}) eq 'ARRAY') { + @format_sections = @{$formattedsec{$crskey}}; + map { $possclasses{$crscode.$_} = 1; } @format_sections; + } } if ($xlist_items) { @xlists = split(/,\s+/,$xlist_items); @@ -1991,9 +2043,10 @@ sub get_valid_classes { my %okclasses = &Apache::lonnet::auto_validate_instclasses($cdom,$cnum,$owners, \%possclasses); if (keys(%okclasses)) { - foreach my $sec (@sections) { - if ($okclasses{$crscode.$sec}) { - if (!grep(/^\Q$sec$\E/,@{$validations{'sections'}})) { + for (my $i=0; $i<@sections; $i++) { + if ($okclasses{$crscode.$format_sections[$i]}) { + my $sec = $sections[$i]; + if (!grep(/^\Q$sec\E$/,@{$validations{'sections'}})) { push(@{$validations{'sections'}},$sec); $totalitems ++; } @@ -2014,6 +2067,13 @@ sub get_valid_classes { join(', ',@{$validations{'sections'}}).'
'; } if (@{$validations{'xlists'}}) { + my $crskey = $cnum.':'.$crscode; + my %reformattedxlists = + &Apache::lonnet::auto_instsec_reformat($cdom,'declutter', + {$crskey => $validations{'xlists'}}); + if (ref($reformattedxlists{$crskey}) eq 'ARRAY') { + $validations{'xlists'} = $reformattedxlists{$crskey}; + } $response .= &mt('Courses:').' '. join(', ',@{$validations{'xlists'}}); }