CVS log for loncom/interface/coursecatalog.pm

Up to [LON-CAPA] / loncom / interface

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- For 2.11
  Backport 1.103, 1.104

- For 2.11
  Backport 1.105

- Support customization in localenroll.pm to eliminate ambiguity in extraction
  of institutional section from institutional course section for automated
  enrollment.

- Bug 6914
  Make $hostname available for passing to &Apache::lonnet::waf_allssl() to
  check whether access was via WAF alias, and WAF forwards both http + https
  requests to https (if so, skip usehttp=1 for 'http' externalsyllabus).

- Bug 6914
  Update domain config UI to support settings documented in
  Domain_Configuration_WAF_Proxy.tex

- For 2.11
  Correction to 1.88.2.5 backport of 1.101

- For 2.11
  Backport 1.91, 1.92, 1.98

- For 2.11
  Backport 1.99, 1.100, 1.101, 1.102

- Self-cataloging of courses based on institutional code is cached for 1 hour.

- Course categories defined in a domain are cached for 1 hour.
- Devalidate cats cache for domain if categories changed by DC.

- Typo

- Input validation.

- For 2.11
  Backport 1.96

- For servers using Apache/SSL where External Resource points at http:// URL
  or syllabus is configured to use an external http:// URL, query string for
  links contains usehttp=1, unless server has Strict-Transport-Security set
  for Apache with max-age > 0.

- For 2.11
  - Backport 1.97

- Unused after changes in rev. 1.95

- Ensure catalog_maxdepth form element has an appropriate (integer) value.

- For 2.11
  Backport 1.95

- Checking if enrollment data can be accessed for a course uses a single
  call to localenroll::check_instclasses(), mediated via lonnet/lond.

- Trust settings.
 - Use more versatile lonnet::will_trust() to determine if session-hosting
   server has catalalog access, according to domain's trust settings.
 - Eliminate lonnet::notcallable() -- no longer used.

- Trust Settings
  Check if action is permissible based on trust settings for:
  catalog, domroles, enroll, reqcrs, msg, othcoau, or coaurem for current context.

- For servers using Apache/SSL, and LON-CAPA syllabus requested is configured
  to use an external http:// URL, links to display of syllabus page use http://
  to avoid mixed active content issue, unless editing the syllabus (in which
  case https:// is used).

- Append ?usehttp=1 to link to syllabus where LON-CAPA syllabus is configured
  to use external http:// URL, but LON-CAPA server uses https:// to avoid
  mixed active content issue (see also bug 6662).
- Preview of external http:// URL displayed in separate pop-up window
  instead of in modal window on https:// server.

- For 2.11
  Backport 1.90

- Detailed course catalog view available to domain helpdesk staff

- Bug 6808. New course container -- "Placement" for Placement Tests.

fixed bug 6782, and escaped most localized messages used in Javascript blocks to make sure bugs like that do not happen again

- xhtml

- Display of Course/Community Catalog with enrollment data added to "server
  status" pages for which access can be IP-based or available to specified
  authenticated users (DC role not required).

- Catalog type defaults to 'std' if not set yet in domain configuration.

- wording change.

- Fix typo.

- Domain configuration to determine course catalog style
  - Type of catalog can be different for authenticated and unauthenticated
    contexts.
  - Options are: No catalog, Look-up of six character code, Standard catalog
                 (with/without domain selector to switch to different domain
                 in cluster).
  - Default is standard course catalog with domain domain selector.

- satisfy w3c validation.

Fixed typos (rev. 1.1, 1.45)

- satisfy w3c validation.

- Improved and consistent navigation and layout by using actionbox
- Error style for error message
- Simplified code for "no match" message

- Do not split ellipsis from preceding text.

- New course request type -- textbook.
  - Can assign rights to request this type of course.
  - "textbook" can have different uploaded content quota, default credits etc.
    from official or unofficial course types.
  - Domain Coordinators can specify subject, tile, authors(s) and upload an
    image of the textbook cover.
- Work-in-progress.

- For 2.10
  - Backport 1.75.

- validation

- Wording changes.
  - Clarify what "count for past access" means for student counts and totals.

- Include totals for student credit hours, in DC view when "Show full details"
  checked, if credits enabled for official or unofficial courses.

- More granular control over what is shown to Domain Coordinator in
  Course Catalog.
- Display totals for unique courses, sections, counts for current,
  future, and past students.
- Counts of "past" students can be based on: (a) default end access date,
  (b) auto-enrollment end date, or (c) active status on a specific date.

Use standard styles (info/warning/error)

- Change wording for course catalog headers - only ever one owner, but
  could be multiple co-owners.

- Customization for MITrelate
  - No domain selector for catalog if default domain is "relate".

- Bug 6470. Wording change.

- Backport 1.68.

- Remove hidden form element that is never used.

- Backport 1.67.

- Eventual implementation of storage of co-owners in nohist_courseids.db
  (LON-CAPA 2.9.0) was to store as comma separated list, not as anonymous array.

- Backport 1.66.

- Bug 5558 (comment 12).
  - Display end date for self-enrollment once self-enrollment is available.

- Backport 1.65.

- Backport 1.65.

- Bug 6381.

- Fix to 1.58.4.3 backport.
 - Delete one more line.

- Backport 1.64.

- Eliminate duplicate inline menu when showing course details for official course.

- Backport 1.61.

- Backport 1.63.

- Bug 6333.
  Ensure that form element names for select boxes for institutional codes
  are always named Year, Semester, Department, Number, for consistency with
  names used in javascript to update select box items dynamically.
  - Names of categories in domain from localenroll::instcode_format():
    codetitles array can differ from these form element names.

Removed leftovers of already removed alternative login mode (accessibility).

- Backport 1.60, 1.61.

- Second declaration for $brtextone should be for $brtexttwo.

- Backport 1.60.

- C(c)ourse -> C(c)ommunity if listing Communities in Catalog.

In process of removing remote control, remote navmap and different icon modes code
- removed no_inline_link argument from loncommon::start_page, loncommon::bodytag
- removed subs
    o loncommon::head: it wasn't used
    o loncommon::endheadtag: functionality now covered by loncommon::headtag
    o lonmenu::registerurl: functionality moved to loncommon::headtag, because it was the only function that called registerurl
- removed remote control related translations in de.pm
- refactoring and cleanup

- Change in rev 1.49 not in 2.9.

- Backport 1.57, 1.58.

- Backport 1.54, 1.55, 1.56.

- Replace links in catalog trail of categories/sub-categories with select boxes to
  facilitate changing (sub-)category at higher level in hierarchy.

- Accommodate Communities
  - Top Level Category: "Communities" defined in system
    (Domain control to hide/unhide).
    - Can only assign communities to this category (and its subcategories).
- Domain Coordinator definition of new top level categories:
   instcode and communities are reserved for system use
   (may not be used for names of additional top level categories).

- Backport 1.53.

Consistent wording "Course Catalog" -> "Course/Community Catalog"

- Part of bug 6078.
- Use "Course/Community Catalog" universally on right side of breadcrumbs for course catalog.

- @_ not relevant here.

- Reverse change in 1.52 (not in 2.9.X).

loncommon.pm
- Rename fifth arg to &select_dom_form() from $autosubmit to $onchange;
- More flexibility - $onchange arg now includes the javascript call executed following an
  onchange event.

coursecatalog.pm
- Replace $nochange arg in loncommon::select_dom_form() with function to execute.

Redesign: no separate accessibility interface, cleaning up a bit

Code reuse.
- Following routines: &recurse_options(), &build_javascript(),
                      &javascript_select_filler()
     moved from coursecatalog.pm to courseclassifier.pm for re-use.

- New routines: &instcode_selectors_data(), &build_instcode_selectors
    added to courseclassifier.pm to include code previously in
    coursecatalog::instcode_course_selector() --

- New routine:  &instcode_search_str() added to courseclassifier.pm to include
    code previously in coursecatalog::search_official_courselist().

- Backport 1.50.

- Missing &mt() on text displayed by JS alert.
- Alert to display depends on current depth in category hierarchy.

Box title is now the main title of the next page and the link text or the former page title will be set to the subtitle in the near future.
Group: consistent wording

- needs "return check_selected();" to prevent form submission.

loncommon.pm:
&select_dom_form() takes a fifth argument - $autosubmit.  If this is true, the domain selector includes an onchange action which will submit the form containing it.

coursecatalog.pm:
Fifth argument (set to 1) passed to &Apache::loncommon::select_dom_form() unless
 textual interface mode ("Change" button displayed in this case).

Streamline the interface for category selection.
- If there is only one category at the top level, automatically pick it (both instcode and custom category cases).
- Text "Main Categories" eliminated in all but one case.
- Button text: "Change" replaced with "Pick main category", Pick subcategory, or  "Show subcategories" as appropriate.
- "Select" option in select box eliminated when there is only one available option.
- "Javascript function: "check_selected" displays alert if "Pick subcategory" button was pushed but not subcategory had been selected.

- Corner case: Main Categories set to include both "official courses" and one or more custom categories, but there are no courses with institutional codes.
  - Javascript function setCatDepth() needed for Main Categories link was absent in this one case.

Change the category breadcrumbs symbol from -> to a unicode arrow.

Optimized output in course catalog for 'Student Counts' column:
  - Optimized output for no sections and changed German translation correspondingly
  - Corrected German translations for access output

Localization - Optimized &mt() calls:
  - Excluded HTML tags and white spaces with separator function from &mt() calls
  - Included parameters
  - Re-use already existing translations

- Change link to "Enroll in course" to javascript:ToSelfenroll() which submits linklaunch form.
- Filters used in coursecatalog display passed to selfenroll to allow breadcrumbs there.
- syllabuslaunch form renamed linklaunch form (no longer used for just syllabus).
- &syllabus_javascript() renamed courselink_javascript() - broader use.
- 'courseid' added as another element to exclude from echo of form input to avoid duplicate
   when coming from breadcrumb trail link in self-enroll.

Provide syllabus page with means to construct breadcrumbs to facilitate return to Catalog after viewing syllabus.
- new subroutine: &syllabus_javascript() includes javascrript to dynamically set form action to URL for syllabus page and to submit form (includes catalog search parameters as hidden input).
- Replace call to &Apache::loncommon::syllabuswrapper() for syllabus link with link including call to javascript:ToSyllabus(cdom,cnum).

- eliminate duplicate decalarations.

- Add form action.
- showdom could be passed as an argument in a query string
- unescape() category in subcategories? prompt

- Add some white space after "Display courses" button.
- setCourseId() and changeSort() javascript functions always available on course listing page

- Include extra checkbox "Include subcategories within ", if current category contains subcategories.
- Display of checkboxes used for filter modifiers suppressed when jumping back to "Main Categories" level.
- Category filter sent to lonnet::courseiddump() includes concatenation of current category with contained subcategories (if include subcat. checked), with & separator.
- Form input only echoed with echo_form_input() when displaying details for a single course, to avoid duplicate form elements.

- Course listings for searches based on categories include categories for each course instead of institutional code.

- xhtml
- &mt()
- Show access dates for self-enrollers on "details" page if different from general defaults for student access.

- New subroutine: &additional_filters() generates checkboxes to apply in course
  search (self-enroll only, DC only: display hidden & show all details).
- "Go" buttons for updating domain used for coursecatalog and category to search
  replaced with "Change"
- "Display course" button displayed for both searches for official courses and
  for manually assigned categories.
- Some javascript changes so changeSort() and setCourseId() are available for
  both types of search. copy_filters() function no longer needed.

- Checkboxes:
  - Show full details for each course (DC only)
  - Include courses set to be hidden from catalog (DC only)
  - Only show courses which allow self-enrollment
 moved to be available for both display of courses auto-catalogued by institutional code and display of courses catalogued manually.
- Some &mt().

Localization:
Optimized &mt() calls for "Note for students"

Display catalog header in case where official classes catalog is being displayed, but there are no courses within this category.

- Construct category breadcrumbs trail, and set appropriate filter in cases where "Go" button is clicked when category selection is set to "Select".

Display available course categories.
- Either self-cataloguing scheme for "official courses" based on course code
  (up to four coupled dynamic select boxes available,e.g., Year, Semester, Department,
  Number - if localenroll::instcode_format() customized
- or categories defined by Domain Coordination in Domain Configuration Menu
- or both.

Can specify course display limited to courses which permit self enrollment.
- link provided if self-enrollment is active
- dates self-enrollment available if start date is in the future

- courseclassifier.pm
  - support cases where displayed values differ from corresponding keys in oursenumber options. (Useful if institutional code uses specific characters to separate components).
    e.g., for code: ACCT-202-2007Fall, cousenumber 202 maps to -202-

- coursecatalog.pm
  - check for array reference to avoid an ISE in the case where no coursecodes are defined even though categories exist in a customized localenroll::instcode_format().

Bug 5569.  Eliminate non-word characters from the key to sort on, when courses are sorted by title.

Include row count as fits column in course catalog.

Bug 5191.  Decouple storage of last access time for a course in nohist_courseids.db from storage of course information.
- Retain backwards compatibility with legacy lonnet::courseiddump()

Other general change: uniform use of 'inst_code' as key in frozen hash instead of 'instcode'.

lond
&put_course_id_handler()
- last access stored in escaped lasttime:courseid key = value hash item
  if legacy lonnet::courseiddump() updates courseinfo.
&put_course_id_hash_handler()
- additional argument - $mode ('timeonly', 'notime' or 'all')
  - determines whether last access, or courseinfo (description,inst_code,owner,type) or both are stored
&dump_course_id_handler()
- documentation updated
- style (replacing unless)
- change location of unescaping when checking filters so double escaping no longer needed for courseinfo stored in frozen hash
- return courseinfo in hash form, if requested as hash, when record has yet to be converted to a frozen hash
&validate_class_access_handler()
- eliminate extra unescaping of $ownerlist

lonnet.pm
&flushcourselogs() includes 'timeonly' argument in call to courseidput().
&courseidput() - if in 'timeonly' mode only courseids are sent to lond in courseidputhash call.
&createcourse()
- courseinfo values in hash no longer escaped (freeze_hash handles this)
- call to flushcourselogs() replaced by call to courseidput()

lonmodifycourse.pm
- courseinfo values in hash no longer escaped
- call to courseidput() includes 'notime' as fourth arg.

coursecatalog.pm
- remove unneeded code, since entry for each course in %courses hash will now be a hash ref.

courseclassifier.pm
- remove unneeded code, since entry for each course in %courses hash will now be a hash ref.

lonpickcourse.pm
- Entry for each course in %courses hash should be a hash ref, when constructing for onlyown courses case.
- instcode to inst_code
- no need to unescape courseinfo value (thaw_hash in lonnet::courseiddump does it)

lonparmset.pm
- call to flushcourselogs() replaced by call to courseidput() after updating course description.
- appenv user's session with new course description.

Store data in nohist_courseids.db as a hash.  Maintain backwards compatibility with writes to the db from legacy lonnet.pm, and also reads from the db from legacy lonnet.pm.

Start towards inclusion of co-owners as well as a single owner, for the purposes of verifying access to official classlist data.

lond
- &put_course_id_hash_handler() added to handle storage of data in nohist_courseids.db as a frozen hash.
- &put_course_id_handler() will add to an existing hash if update is from a legacy lonnet which supplies : separated data.
- &dump_course_id_handler() $as_hash flag extracted from tail. If set, data are returned as a hash.
- validate_class_access_handler() will extract comma-separated owner and co-owners from ownerlist passed to it, and send array ref to localenroll::check_section() to determine if at least one on the owners is authorized to view classlist list data for the institutional section.

lonnet.pm
- storage of hash via call to courseidputhash in lond.  If command is unrecognized on the lond side, subset of the data sent as : separated values
- retrieval of data from nohist_courseids.db - additional $as_hash argument included in courseiddump call to indicate that data should be returned as a frozen hash.
- auto_validate_class_sec() - if third argument is an array ref, then an owner list is built from the supplied owners and co-owners.
- lasttime set on lonnet side (FIXME) - to be changed to lond side.

lomodifycourse.pm
- updated course settings sent as a ref to a hash to lonnet::courseidput()
- include LC_error in span for error messages
- eliminate duplicate error message
- display error if storage of changes fails
- form name corrected to cmod.

coursecatalog.pm
- eliminate unused arg from call to courseclassifier::retrieve_instcodes
- display owner and co-owners (sort by lastname)
- institutional section access for multiple owners

courseclassifier.pm
- course codes from course data if hash, or if : separated string.

lonpickcourse.pm
- course info extracted from hash
- owner info displayed in a list if owner and co-owners exist.

- convert exisiting cookie reads/validations to use
   lonnet::check_for_valid_session

- eliminating the domain hash globals in favor of functional access

Move &additional_machine_domains() to lonnet.pm so it is more widely available

Move determination of default domain based on $ENV{'HTTP_HOST'} from lonlogin.pm to &default_login_domain() in lonnet.pm so it is more widely available

Default domain in coursecatalog now uses lonnet::default_login_domain() to display catlog for appropriate domain on a server with multiple domains, based on URL.

Bug 5136. If course catalog is displayed by a logged in user (other than public), catalog is shown for the domain of the current user's role, unless no role is selected, in which case catalog is shown for user's domain.

Non-logged in user and public users see course catalog of the domain of the machine, as determined from lonnet:::default_login_domain().

bug 5135.  Addresses case where a domain has assigned institutional codes to at least one course, but has not customized the instcode_format() subroutine in localenroll.pm (provided as a stub).

If no category titles have been defined in localenroll::instcode_format(), coursecatalog now displays a listing of all courses in the domain which have
institutional codes.

In the absence of defined categories, there is no "Choose which course(s) to list.", no select boxes and no "Display courses" button.  Sorting by code, title or owner no longer generates javascript errors in this case.

The prior behavior - display of "No official courses to display for <Domain Name>" - when there are no courses with institutional codes, is still the same.

- missing parts of the full header

Make life easier for Domain Coordinators by allowing display of full details for several courses at once, if user has an active DC role in the domain.

If SSO user is authenticated but has no LON-CAPA account provide information, including results of query of RO's LONCAPA_ClassList table for the user.

Some routines in coursecatalog modified to support use by sentinelonly.pm

Display is better for large number of sections if a line break can occur.

Split list of sections and crosslistings on /, / instead of just /,/

scope

- lots of \w -> probper regexp replacements

Remove leading spaces from course titles.

Don't display 'No courses' unless a specific department has been selected, and there are no courses for the selected year and/or semester.

Only display "Show more details" link and allow retrieval of access dates, student counts and auto-enrollment status if user has authenticated. For the future: &user_is_known() should also return true if user has SSO session, but no LON-CAPA session.

Refactored so access dates, student counts and auto-enrollment status are additional details which are shown on a second page, and only for a single courseID. Search based on select box choices uses lonnet::auto_instcode_defaults() to construct appropriate regular expressions to pass to courseiddump() from selections made.  Breadcrumbs added, now there are multiple pages.

Using routines from courseclassifier instead of lonsupportreq. All ipossible values are now displayed in select boxes for Year, Semester and Department.  Options available in "Number" select box are set dynamically if a specific Department is selected.  Choices will vary depending on current selections for Year and Semester.

Need to return status code from the handler.  Also provide appropriate message when no courses have been assigned institutional codes.

- style

- making the sub routines agree with each other

Some wording changes.  Column added for crosslistings. Syllabus link now hidden by default.  Auto-enrollment display modified to include check for valid sections and crosslistings. (Distillation of code shared with lonsupportreq.pm is next).

Display information about courses which have associated institutional codes, filtered by year, semester, department and course number.  Refactoring of this script and lonsupportreq.pm to follow (shared utility functions to move to a new module).