CVS log for loncom/interface/courseclassifier.pm

Up to [LON-CAPA] / loncom / interface

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- Remove debugging line

- Add missing linefeed and remove some trailing whitespace.

- In cases where course codes have been assigned to course(s) in a domain,
  but instcode_format() routine in localenroll.pm has not been customized,
  totcodes item (value is number of courses with codes) must be present
  in the instcats hash ref.
- Without this the text: "No official courses to display" will be shown above
  a listing of official courses, and clicking the "Show more details" link
  for a course will do nothing.

- Self-cataloging of courses based on institutional code is cached for 1 hour.

- Helpdesk web form
  - Domain configuration to specify which form fields besides E-mail address,
    Subject, and Description should be shown (some can be required fields).
  - Domain configuration to send submitted form to specified e-mail address(es)
    for user from other domains -- if no recipient set in user's domain for help).
  - Domain configuration to automatically include a specified string in the e-mail
    sent -- either prepended to the subject, or to the body.
  - If form is visited by a logged-in user with a role selected in an official
    course, the user can change the course code in the linked select boxes,
    in order to ask about a different course.

- Second arg in courseclassifier::javascript_code_selections() changed to ref
  to array.

- vpa priv allows Course Settings to be viewed, but not modified.
- users with vpa priv in a course receive "View parameter settings
  (due dates, etc) for resources and the course" item in the Main Menu,
  and a Settings item in the inline menu.

- Last dropdown list element in linked institutional code dropdowns needs
  to include the class, if one was passed to &build_instcode_selectors().

- General course settings: users allowed to clone course.
  - Show if domain default is set.
  - Adding any course-specific setting will cause domain default to
    be ignored.
  - For official courses, where localenroll::instcode_defaults()
    has been customized, can also allow cloning by specific
    partial institutional codes (e.g., department + number: such as
    phy184 for example).

- coding style.

- Coding style:
  keys() sort()

Making drop-down selections persistent after search

- Course/Community search in domains where institutional codes are defined:
  clicking radio buttons for official or unofficial courses will show/hide
  linked select boxes for filtering by institutional code.

- Whitespace changes only.

- Moving &instcode_selectors() from lonpickcourse.pm to courseclassifier.pm
  to facilitate re-use.

XHTML: JavaScript event handlers in lower case

- Institutional code compiled from selections in linked select boxes does
  not need regular expressions used in search of nohist_courseids.db when
  usd for helpdesk e-mail.

- Localization missing for text set dynamically by javascript.

- Bug 6333.

- Customization for GCI_3.
  - Backport 1.11.

- Eliminate javascript error on loading of help request form where all
  institutional codes are null.

- Bug 6333.
  Ensure that form element names for select boxes for institutional codes
  are always named Year, Semester, Department, Number, for consistency with
  names used in javascript to update select box items dynamically.

- Bug 5848.
  Assembly of institutional code from components conforms to order defined in
  localenroll::instcode_defaults().

- Bug 6333.
  Ensure that form element names for select boxes for institutional codes
  are always named Year, Semester, Department, Number, for consistency with
  names used in javascript to update select box items dynamically.
  - Names of categories in domain from localenroll::instcode_format():
    codetitles array can differ from these form element names.

lonpickcourse.pm
- Wording change.  "Course Type" changed to "Type".
- course filter form now sets a form element named "command" to 'gosearch' on submit.
- course filter form will automatically reload, but not search,
  if either Domain or Type are changed.

courseclassifier.pm
 Javascript function "setOfficial() checks if caller arg is defined

lond
&dump_course_id_handler() change.
 - change to the effect regexp_ok arg.
 - now if arg has a value of -1, a course will be excluded from the resturned list,
   if the instcode matches the RE.
   This excludes "official" courses (i.e., those with an instcode matching the expected pattern for the domain) from the list returned in a search for "unofficial" courses.

Case where there are linked select boxes for Year, Semester etc. to generate instcode filter.
  - Add radio button to toggle between "official" and unofficial" courses.
  - Appropriate instcodefilter now set when "unofficial" is selected.
  - Javascript to keep select boxes and radio buttons in consistent state.

Code reuse.
- Following routines: &recurse_options(), &build_javascript(),
                      &javascript_select_filler()
     moved from coursecatalog.pm to courseclassifier.pm for re-use.

- New routines: &instcode_selectors_data(), &build_instcode_selectors
    added to courseclassifier.pm to include code previously in
    coursecatalog::instcode_course_selector() --

- New routine:  &instcode_search_str() added to courseclassifier.pm to include
    code previously in coursecatalog::search_official_courselist().

- Add version string.

- courseclassifier.pm
  - support cases where displayed values differ from corresponding keys in oursenumber options. (Useful if institutional code uses specific characters to separate components).
    e.g., for code: ACCT-202-2007Fall, cousenumber 202 maps to -202-

- coursecatalog.pm
  - check for array reference to avoid an ISE in the case where no coursecodes are defined even though categories exist in a customized localenroll::instcode_format().

Bug 5191.  Decouple storage of last access time for a course in nohist_courseids.db from storage of course information.
- Retain backwards compatibility with legacy lonnet::courseiddump()

Other general change: uniform use of 'inst_code' as key in frozen hash instead of 'instcode'.

lond
&put_course_id_handler()
- last access stored in escaped lasttime:courseid key = value hash item
  if legacy lonnet::courseiddump() updates courseinfo.
&put_course_id_hash_handler()
- additional argument - $mode ('timeonly', 'notime' or 'all')
  - determines whether last access, or courseinfo (description,inst_code,owner,type) or both are stored
&dump_course_id_handler()
- documentation updated
- style (replacing unless)
- change location of unescaping when checking filters so double escaping no longer needed for courseinfo stored in frozen hash
- return courseinfo in hash form, if requested as hash, when record has yet to be converted to a frozen hash
&validate_class_access_handler()
- eliminate extra unescaping of $ownerlist

lonnet.pm
&flushcourselogs() includes 'timeonly' argument in call to courseidput().
&courseidput() - if in 'timeonly' mode only courseids are sent to lond in courseidputhash call.
&createcourse()
- courseinfo values in hash no longer escaped (freeze_hash handles this)
- call to flushcourselogs() replaced by call to courseidput()

lonmodifycourse.pm
- courseinfo values in hash no longer escaped
- call to courseidput() includes 'notime' as fourth arg.

coursecatalog.pm
- remove unneeded code, since entry for each course in %courses hash will now be a hash ref.

courseclassifier.pm
- remove unneeded code, since entry for each course in %courses hash will now be a hash ref.

lonpickcourse.pm
- Entry for each course in %courses hash should be a hash ref, when constructing for onlyown courses case.
- instcode to inst_code
- no need to unescape courseinfo value (thaw_hash in lonnet::courseiddump does it)

lonparmset.pm
- call to flushcourselogs() replaced by call to courseidput() after updating course description.
- appenv user's session with new course description.

Store data in nohist_courseids.db as a hash.  Maintain backwards compatibility with writes to the db from legacy lonnet.pm, and also reads from the db from legacy lonnet.pm.

Start towards inclusion of co-owners as well as a single owner, for the purposes of verifying access to official classlist data.

lond
- &put_course_id_hash_handler() added to handle storage of data in nohist_courseids.db as a frozen hash.
- &put_course_id_handler() will add to an existing hash if update is from a legacy lonnet which supplies : separated data.
- &dump_course_id_handler() $as_hash flag extracted from tail. If set, data are returned as a hash.
- validate_class_access_handler() will extract comma-separated owner and co-owners from ownerlist passed to it, and send array ref to localenroll::check_section() to determine if at least one on the owners is authorized to view classlist list data for the institutional section.

lonnet.pm
- storage of hash via call to courseidputhash in lond.  If command is unrecognized on the lond side, subset of the data sent as : separated values
- retrieval of data from nohist_courseids.db - additional $as_hash argument included in courseiddump call to indicate that data should be returned as a frozen hash.
- auto_validate_class_sec() - if third argument is an array ref, then an owner list is built from the supplied owners and co-owners.
- lasttime set on lonnet side (FIXME) - to be changed to lond side.

lomodifycourse.pm
- updated course settings sent as a ref to a hash to lonnet::courseidput()
- include LC_error in span for error messages
- eliminate duplicate error message
- display error if storage of changes fails
- form name corrected to cmod.

coursecatalog.pm
- eliminate unused arg from call to courseclassifier::retrieve_instcodes
- display owner and co-owners (sort by lastname)
- institutional section access for multiple owners

courseclassifier.pm
- course codes from course data if hash, or if : separated string.

lonpickcourse.pm
- course info extracted from hash
- owner info displayed in a list if owner and co-owners exist.

Moving routines used by lonsupportreq.pm, lonnotify.pm and coursecatalog.pm to courseclassifier.pm