--- loncom/interface/courseprefs.pm 2020/02/12 17:27:40 1.49.2.25
+++ loncom/interface/courseprefs.pm 2012/12/31 14:43:09 1.52
@@ -1,7 +1,7 @@
# The LearningOnline Network with CAPA
# Handler to set configuration settings for a course
#
-# $Id: courseprefs.pm,v 1.49.2.25 2020/02/12 17:27:40 raeburn Exp $
+# $Id: courseprefs.pm,v 1.52 2012/12/31 14:43:09 raeburn Exp $
#
# Copyright Michigan State University Board of Trustees
#
@@ -137,7 +137,7 @@ whether Domain coordinators who are curr
advanced course user .db file for a course are to be hidden (e.g.,
in syllabus, or from course user lists).
-Inputs: $cdom,$item,$settings,$crstype,$noedit
+Inputs: $cdom,$item,$settings,$crstype
where $cdom is course domain, item is nothideprivileged, $settings is
HASH ref of the current values for nothideprivileged, $crstype is
course type (Course or Community).
@@ -215,15 +215,10 @@ use Apache::lonnet;
use Apache::loncommon();
use Apache::lonhtmlcommon();
use Apache::lonconfigsettings;
-use Apache::lonrelrequtils;
use Apache::lonparmset;
-use Apache::courseclassifier;
use Apache::lonlocal;
use LONCAPA qw(:DEFAULT :match);
-my $registered_cleanup;
-my $modified_courses;
-
sub handler {
my $r=shift;
if ($r->header_only) {
@@ -233,11 +228,11 @@ sub handler {
}
my $context = 'course';
my $cid = $env{'request.course.id'};
- my ($cnum,$cdom,$chome) = &get_course($cid);
+ my ($cnum,$cdom) = &get_course($cid);
my $crstype = &Apache::loncommon::course_type();
- my ($parm_permission,$allowed) = &get_permission($cid);
+ my $parm_permission = &Apache::lonnet::allowed('opa',$cid);
my $navmap = Apache::lonnavmaps::navmap->new();
- if ($allowed && $navmap) {
+ if ($parm_permission && $navmap) {
&Apache::loncommon::content_type($r,'text/html');
$r->send_http_header;
} else {
@@ -262,9 +257,6 @@ sub handler {
return HTTP_NOT_ACCEPTABLE;
}
- $registered_cleanup=0;
- @{$modified_courses}=();
-
&Apache::loncommon::get_unprocessed_cgi($ENV{'QUERY_STRING'},
['phase','actions','origin']);
&Apache::lonhtmlcommon::clear_breadcrumbs();
@@ -280,7 +272,6 @@ sub handler {
edit => 'Edit Community Settings',
gens => 'General community settings',
idnu => 'Community ID or number',
- unco => 'Unique code',
desc => 'Community Description',
ownr => 'Community Owner',
cown => 'Community Co-owners',
@@ -297,7 +288,7 @@ sub handler {
stuv => 'Member-viewable membership list options',
stul => 'Member agreement needed to be listed',
clas => 'Membership and facilitator listing',
- prus => 'Privileged users (Domain Coordinators) in facilitator listing',
+ priv => 'Privileged users (Domain Coordinators) in facilitator listing',
defc => 'Default Community Spreadsheet',
defs => 'Default User Spreadsheet',
seme => 'Send message to member when clicking Done on Tasks'
@@ -308,9 +299,7 @@ sub handler {
edit => 'Edit Course Settings',
gens => 'General course settings',
idnu => 'Course ID or number',
- unco => 'Unique code',
desc => 'Course Description',
- cred => 'Student credits',
ownr => 'Course Owner',
cown => 'Course Co-owners',
catg => 'Categorize course',
@@ -326,8 +315,7 @@ sub handler {
stuv => 'Student-viewable classlist options',
stul => 'Student agreement needed to be listed',
clas => 'Classlists and staff listing',
- prus => 'Privileged users (Domain Coordinators) in staff listing',
- prdo => "Domains to check for privileged users (besides course's domain)",
+ priv => 'Privileged users (Domain Coordinators) in staff listing',
defc => 'Default Course Spreadsheet',
defs => 'Default Student Spreadsheet',
seme => 'Send message to student when clicking Done on Tasks',
@@ -344,22 +332,15 @@ sub handler {
$phase = $env{'form.phase'};
}
- if (($phase eq 'categorizecourse') && ($parm_permission->{'categorizecourse'})) {
+ if ($phase eq 'categorizecourse') {
&assign_course_categories($r,$crstype);
return OK;
}
- if (($phase eq 'releaseinfo') && ($parm_permission->{'releaseinfo'})) {
+ if ($phase eq 'releaseinfo') {
my $loncaparev = $env{'course.'.$cid.'.internal.releaserequired'};
if ($loncaparev) {
- if (&display_loncaparev_constraints($r,$navmap,$loncaparev,$crstype)) {
- push(@{$modified_courses},[$cdom,$cnum,$chome,$crstype]);
- unless ($registered_cleanup) {
- my $handlers = $r->get_handlers('PerlCleanupHandler');
- $r->set_handlers('PerlCleanupHandler' => [\&update_releasereq,@{$handlers}]);
- $registered_cleanup=1;
- }
- }
+ &display_loncaparev_constraints($r,$navmap,$loncaparev,$crstype);
return OK;
}
}
@@ -374,23 +355,20 @@ sub handler {
{ text => $lt{'gens'},
help => 'Course_Prefs_General',
ordered => ['owner','co-owners','loncaparev','description',
- 'clonedfrom','courseid','uniquecode','categories',
- 'hidefromcat','syllabus','cloners','url',
- 'rolenames'],
+ 'courseid','categories','hidefromcat',
+ 'externalsyllabus','cloners','url','rolenames'],
itemtext => {
'owner' => $lt{'ownr'},
'co-owners' => $lt{'cown'},
'description' => $lt{'desc'},
'courseid' => $lt{'idnu'},
- 'uniquecode' => $lt{'unco'},
'categories' => $lt{'catg'},
'hidefromcat' => $lt{'excc'},
'cloners' => $lt{'clon'},
- 'syllabus' => 'Syllabus status',
+ 'externalsyllabus' => 'URL of Syllabus',
'url' => 'Top Level Map',
'rolenames' => $lt{'rept'},
'loncaparev' => $lt{'lcrv'},
- 'clonedfrom' => 'Cloned from',
},
},
'localization' =>
@@ -444,19 +422,15 @@ sub handler {
col2 => $lt{'stuv'}}],
ordered => ['default_enrollment_start_date',
'default_enrollment_end_date',
- 'defaultcredits',
- 'nothideprivileged','checkforpriv',
- 'student_classlist_view',
+ 'nothideprivileged','student_classlist_view',
'student_classlist_opt_in','student_classlist_portfiles'],
itemtext => {
default_enrollment_start_date => 'Start date',
default_enrollment_end_date => 'End date',
- nothideprivileged => $lt{'prus'},
- checkforpriv => $lt{'prdo'},
+ nothideprivileged => $lt{'priv'},
student_classlist_view => $lt{'stuv'},
student_classlist_opt_in => $lt{'stul'},
student_classlist_portfiles => 'Include link to accessible portfolio files',
- defaultcredits => $lt{'cred'},
},
},
'appearance' =>
@@ -464,15 +438,13 @@ sub handler {
help => 'Course_Prefs_Display',
ordered => ['default_xml_style','pageseparators',
'disable_receipt_display','texengine',
- 'tthoptions','uselcmath','usejsme'],
+ 'tthoptions'],
itemtext => {
default_xml_style => 'Default XML style file',
pageseparators => 'Visibly Separate Items on Pages',
disable_receipt_display => 'Disable display of problem receipts',
texengine => 'Force use of a specific math rendering engine',
tthoptions => 'Default set of options to pass to tth/m when converting TeX',
- uselcmath => 'Student formula entry uses inline preview, not DragMath pop-up',
- usejsme => 'Molecule editor uses JSME (HTML5) in place of JME (Java)',
},
},
'grading' =>
@@ -493,7 +465,7 @@ sub handler {
help => 'Course_Prefs_Printouts',
ordered => ['problem_stream_switch','suppress_tries',
'default_paper_size','print_header_format',
- 'disableexampointprint'],
+ 'disableexampointprint','canuse_pdfforms'],
itemtext => {
problem_stream_switch => 'Allow problems to be split over pages',
suppress_tries => 'Suppress number of tries in printing',
@@ -535,52 +507,23 @@ sub handler {
}],
},
);
- if (($phase eq 'process') && ($parm_permission->{'process'})) {
+ if ($phase eq 'process') {
my @allitems = &get_allitems(%prefs);
&Apache::lonconfigsettings::make_changes($r,$cdom,$phase,$context,
\@prefs_order,\%prefs,\%values,
- $cnum,undef,\@allitems,
- 'coursepref',$parm_permission);
- } elsif (($phase eq 'display') && ($parm_permission->{'display'})) {
- my $jscript = &get_jscript($cid,$cdom,$phase,$crstype,\%values);
+ $cnum,undef,\@allitems,'coursepref');
+ } elsif ($phase eq 'display') {
+ my $jscript = &get_jscript($cid,$cdom,$phase,$crstype);
my @allitems = &get_allitems(%prefs);
&Apache::lonconfigsettings::display_settings($r,$cdom,$phase,$context,
- \@prefs_order,\%prefs,\%values,undef,$jscript,\@allitems,$crstype,
- 'coursepref',$parm_permission);
+ \@prefs_order,\%prefs,\%values,undef,$jscript,\@allitems,$crstype,'coursepref');
} else {
&Apache::lonconfigsettings::display_choices($r,$phase,$context,
- \@prefs_order,\%prefs,
- 'coursepref',$parm_permission);
+ \@prefs_order,\%prefs,'coursepref');
}
return OK;
}
-sub get_permission {
- my ($cid) = @_;
- my %permission;
- my $allowed = 0;
- return (\%permission,$allowed) unless ($cid);
- if (&Apache::lonnet::allowed('opa',$cid)) {
- %permission= (
- 'pickactions' => 1,
- 'categorizecourse' => 1,
- 'releaseinfo' => 1,
- 'process' => 1,
- 'display' => 1,
- );
- } elsif (&Apache::lonnet::allowed('vpa',$env{'request.course.id'})) {
- %permission = (
- 'pickactions' => 1,
- 'releaseinfo' => 1,
- 'display' => 1,
- );
- }
- foreach my $perm (values(%permission)) {
- if ($perm) { $allowed=1; last; }
- }
- return (\%permission,$allowed);
-}
-
sub get_allitems {
my (%prefs) = @_;
my @allitems;
@@ -598,15 +541,9 @@ sub get_allitems {
}
sub print_config_box {
- my ($r,$cdom,$phase,$action,$item,$settings,$allitems,$crstype,$parm_permission) = @_;
+ my ($r,$cdom,$phase,$action,$item,$settings,$allitems,$crstype) = @_;
my $ordered = $item->{'ordered'};
my $itemtext = $item->{'itemtext'};
- my $noedit;
- if (ref($parm_permission) eq 'HASH') {
- unless ($parm_permission->{'process'}) {
- $noedit = 1;
- }
- }
my $rowtotal = 0;
my $output =
'
'."\n".
- '// '."\n".
- ''."\n".$stubrowse_js."\n";
+ $cloners_js."\n".''."\n".$stubrowse_js."\n";
return $jscript;
}
@@ -1917,7 +1689,7 @@ function update_cloners(caller,num) {
if (document.$formname.cloners_activate[i].value == '0') {
document.$formname.cloners_activate[i].checked = false;
}
- if (document.$formname.cloners_activate[i].value == '-1') {
+ if (document.$formname.cloners_activate[i].value == '') {
document.$formname.cloners_activate[i].checked = true;
}
}
@@ -1970,82 +1742,29 @@ ENDSCRIPT
sub print_courseinfo {
- my ($cdom,$settings,$ordered,$itemtext,$rowtotal,$crstype,$noedit) = @_;
+ my ($cdom,$settings,$ordered,$itemtext,$rowtotal,$crstype) = @_;
unless ((ref($settings) eq 'HASH') && (ref($ordered) eq 'ARRAY') && (ref($itemtext) eq 'HASH')) {
return;
}
- my ($cathash,$categoriesform,$autocoowner,$clonedefaults,$disabled);
- if ($noedit) {
- $disabled = ' disabled="disabled"';
- }
+ my ($cathash,$categoriesform,$autocoowner);
my %domconf =
- &Apache::lonnet::get_dom('configuration',
- ['coursecategories','autoenroll','coursedefaults'],$cdom);
+ &Apache::lonnet::get_dom('configuration',['coursecategories','autoenroll'],$cdom);
if (ref($domconf{'coursecategories'}) eq 'HASH') {
$cathash = $domconf{'coursecategories'}{'cats'};
if (ref($cathash) eq 'HASH') {
$categoriesform =
&Apache::loncommon::assign_categories_table($cathash,
- $settings->{'categories'},$crstype,$disabled)."\n";
+ $settings->{'categories'},$crstype)."\n";
}
}
if (ref($domconf{'autoenroll'}) eq 'HASH') {
$autocoowner = $domconf{'autoenroll'}{'co-owners'};
}
- my ($currcanclone,@code_order,$cloner_instcode);
- my %codedefaults;
- &Apache::lonnet::auto_instcode_defaults($cdom,\%codedefaults,
- \@code_order);
- if ($settings->{'cloners'}) {
- unless ($settings->{'cloners'} eq '*') {
- my @currclone = split(/,/,$settings->{'cloners'});
- foreach my $item (@currclone) {
- unless ($item eq '*') {
- if (($item !~ /\:/) && ($item =~ /=/)) {
- $cloner_instcode = 1;
- }
- }
- }
- }
- }
- if (ref($domconf{'coursedefaults'}) eq 'HASH') {
- my $canclone = $domconf{'coursedefaults'}{'canclone'};
- if (ref($canclone) eq 'HASH') {
- if (ref($canclone->{'instcode'}) eq 'ARRAY') {
- if ($settings->{'internal.coursecode'}) {
- my @posscodes;
- if (@code_order > 0) {
- $currcanclone = 'instcode';
- foreach my $item (@{$canclone->{'instcode'}}) {
- if (grep(/^\Q$item\E$/,@code_order)) {
- push(@posscodes,$item);
- }
- }
- my $codestr = join(' + ',@posscodes);
- $clonedefaults = &mt('Default for official courses is to also allow cloning if [_1] match in cloner and cloned.',
- '"'.$codestr.'"').'
';
- }
- }
- }
- } elsif ($canclone eq 'domain') {
- $clonedefaults = &mt('Default is for any course requester in [_1] domain to be able to clone.',
- ''.$cdom.'').'
';
- $currcanclone = 'domain';
- }
- if ($clonedefaults) {
- if ($settings->{'cloners'} ne '') {
- $clonedefaults .= '
'.&mt('Default does [_1]not[_2] currently apply because values have been set in the course.','','');
- } else {
- $clonedefaults .= &mt('Default is disregarded if [_1]any[_2] values are set here in the course.','','');
- }
- $clonedefaults = '
'.$clonedefaults;
- }
- }
if (!defined($categoriesform)) {
$categoriesform = &mt('No categories defined in this domain.');
}
+
my ($can_toggle_cat,$can_categorize) = &can_modify_catsettings($cdom,$crstype);
- my $cnum = $env{'course.'.$env{'request.course.id'}.'.num'};
my $replace;
if ($crstype eq 'Community') {
@@ -2053,28 +1772,22 @@ sub print_courseinfo {
} else {
$replace = &mt('To replace the standard title for a course role, enter a title, otherwise leave blank');
}
- my ($editmap,$editsyllabus);
- unless ($noedit) {
- $editmap = (' 'x2).
- '".
- &mt('Select Map').'
'.
- &mt('Modification may make assessment data inaccessible!').
- '';
- $editsyllabus = &mt('[_1]Edit[_2]','',
- '');
- }
my %items = (
'url' => {
- text => ''.&mt($itemtext->{'url'}).''.$editmap,
+ text => ''.&mt($itemtext->{'url'}).''.(' 'x2).
+ '".
+ &mt('Select Map').'
'.
+ &mt('Modification may make assessment data inaccessible!').
+ '',
input => 'textbox',
- size => '55',
+ size => '40',
advanced => 1
},
'description' => {
text => ''.&mt($itemtext->{'description'}).'',
input => 'textbox',
- size => '55',
+ size => '25',
},
'owner' => {
text => ''.&mt($itemtext->{'owner'}).'',
@@ -2082,22 +1795,15 @@ sub print_courseinfo {
'co-owners' => {
text => ''.&mt($itemtext->{'co-owners'}).'',
},
- 'clonedfrom' => {
- text => ''.&mt($itemtext->{'clonedfrom'}).'',
- },
'courseid' => {
text => ''.&mt($itemtext->{'courseid'}).'
'.'('.
&mt('internal, optional').')',
input => 'textbox',
size => '25',
},
- 'uniquecode' => {
- text => ''.&mt($itemtext->{'uniquecode'}).'',
- },
'cloners' => {
text => ''.&mt($itemtext->{'cloners'}).'
'.
- &mt('Owner and Coordinators included automatically').
- $clonedefaults,
+ &mt('Owner and Coordinators included automatically'),
input => 'textbox',
size => '40'
},
@@ -2108,10 +1814,11 @@ sub print_courseinfo {
size => '20',
advanced => 1
},
- 'syllabus' => {
- text => ''.&mt($itemtext->{'syllabus'}).'
'.
- &mt('(Syllabus type in use)').(' ' x2).
- $editsyllabus,
+ 'externalsyllabus' => {
+ text => ''.&mt($itemtext->{'externalsyllabus'}).'
('.
+ &mt('not using syllabus template)'),
+ input => 'textbox',
+ size => '40',
},
'hidefromcat' => {
text => ''.&mt($itemtext->{'hidefromcat'}).'
'.
@@ -2127,37 +1834,27 @@ sub print_courseinfo {
'loncaparev' => {
text => ''.&mt($itemtext->{'loncaparev'}).'',
},
- 'defaultcredits' => {
- text => ''.&mt($itemtext->{'defaultcredits'}).'',
- },
);
my $datatable;
my $count = 0;
foreach my $item (@{$ordered}) {
- my $colspan;
if ($item eq 'hidefromcat') {
next if (!$can_toggle_cat);
} elsif ($item eq 'categories') {
next if (!$can_categorize);
- } elsif ($item eq 'uniquecode') {
- next if (!$env{'course.'.$env{'request.course.id'}.'.internal.uniquecode'});
- }
- unless (($item eq 'cloners') || ($item eq 'rolenames')) {
- $colspan = 2;
}
$count ++;
if (exists $items{$item}{advanced} && $items{$item}{advanced} == 1) {
- $datatable .= &item_table_row_start($items{$item}{text},$count,"advanced",$colspan);
+ $datatable .= &item_table_row_start($items{$item}{text},$count,"advanced");
} else {
- $datatable .= &item_table_row_start($items{$item}{text},$count,undef,$colspan);
+ $datatable .= &item_table_row_start($items{$item}{text},$count);
}
if ($items{$item}{input} eq 'radio') {
- $datatable .= &yesno_radio($item,$settings,undef,undef,undef,$noedit);
+ $datatable .= &yesno_radio($item,$settings);
} elsif ($item eq 'cloners') {
my $includeempty = 1;
my $num = 0;
- $datatable .= ''.
- &Apache::loncommon::start_data_table().
+ $datatable .= &Apache::loncommon::start_data_table().
&Apache::loncommon::start_data_table_row().
' | '.
- (' 'x2).''.
+ (' 'x2).'{$item} ne '*') {
$datatable .= ' checked="checked" ';
}
$datatable .= ' onchange="javascript:update_cloners('.
- "'cloners_all'".');"'.$disabled.' />'.&mt('No').' | '.
+ "'cloners_all'".');"/>'.&mt('No').''.
&Apache::loncommon::end_data_table_row().
&Apache::loncommon::end_data_table().
- ''.
+ ''.
&Apache::loncommon::start_data_table();
my @cloners;
if ($settings->{$item} eq '') {
- unless ($noedit) {
- my $default;
- if ($currcanclone eq 'domain') {
- $default = '0';
- }
- $datatable .= &new_cloners_dom_row($cdom,'0',$default);
- }
+ $datatable .= &new_cloners_dom_row($cdom,'0');
} elsif ($settings->{$item} ne '*') {
my @entries = split(/,/,$settings->{$item});
if (@entries > 0) {
@@ -2208,7 +1898,7 @@ sub print_courseinfo {
'
'.
''.
&Apache::loncommon::end_data_table_row();
$num ++;
@@ -2231,56 +1921,23 @@ sub print_courseinfo {
''.
$add_domtitle.' '.
&Apache::loncommon::select_dom_form('','cloners_newdom',
- $includeempty,undef,undef,
- undef,undef,$noedit).
+ $includeempty).
''.
' | '.&Apache::loncommon::end_data_table_row().
&Apache::loncommon::end_data_table().
- ''.
+ ''.
&Apache::loncommon::start_data_table().
&Apache::loncommon::start_data_table_row().
''.
&mt('Specific users').' ('.
&mt('user:domain,user:domain').') '.
&Apache::lonhtmlcommon::textbox($item,$cloners_str,
- $items{$item}{'size'},$disabled).
+ $items{$item}{'size'}).
' | '.&Apache::loncommon::end_data_table_row().
&Apache::loncommon::end_data_table();
- if (@code_order > 0) {
- my (%cat_items,@codetitles,%cat_titles,%cat_order);
- my ($jscript,$totcodes,$numtitles,$lasttitle) =
- &Apache::courseclassifier::instcode_selectors_data($cdom,'display',
- \%cat_items,\@codetitles,
- \%cat_titles,\%cat_order);
- my $showncodes = 'off';
- my $checkedoff = ' checked="checked"';
- my $checkedon = '';
- if ($cloner_instcode) {
- $checkedon = $checkedoff;
- $checkedoff = '';
- $showncodes = 'on';
- }
- $datatable .= ''.
- &Apache::loncommon::start_data_table().
- &Apache::loncommon::start_data_table_row().
- ''.
- &mt('Cloning by official course(s) based on course category').(' 'x2).
- ''.
- (' ').
- ''.
- &Apache::courseclassifier::build_instcode_selectors($numtitles,
- $lasttitle,\%cat_items,\@codetitles,\%cat_titles,\%cat_order,
- $showncodes,'LC_cloners_instcodes','LC_cloners_instcode',$noedit).
- ' | '.&Apache::loncommon::end_data_table_row().
- &Apache::loncommon::end_data_table();
- }
} elsif ($item eq 'rolenames') {
- $datatable .= ''.
- &Apache::loncommon::start_data_table();
+ $datatable .= &Apache::loncommon::start_data_table();
my @roles;
if ($crstype eq 'Community') {
@roles = ('co');
@@ -2295,17 +1952,12 @@ sub print_courseinfo {
' | '.
&Apache::lonhtmlcommon::textbox('rolenames_'.$role,
$settings->{$role.'.plaintext'},
- $items{$item}{size},$disabled).' | '.
+ $items{$item}{size}).''.
&Apache::loncommon::end_data_table_row();
}
$datatable .= &Apache::loncommon::end_data_table().'';
} elsif ($item eq 'categories') {
- my $launcher;
- if ($noedit) {
- $launcher = $disabled;
- } else {
- $launcher = 'onfocus="this.blur();javascript:catsbrowser();"';
- }
+ my $launcher = 'onFocus="this.blur();javascript:catsbrowser();";';
$datatable .= ''.
&Apache::lonhtmlcommon::textbox($item.'_display',$settings->{$item},
$items{$item}{size},$launcher);
@@ -2320,22 +1972,8 @@ sub print_courseinfo {
$owner = &mt('None specified');
}
$datatable .= $owner;
- } elsif ($item eq 'clonedfrom') {
- my $clonesrc = $env{'course.'.$env{'request.course.id'}.'.clonedfrom'};
- my $clonedfrom = &mt('None');
- if ($clonesrc =~ m{/$match_domain/$match_courseid}) {
- my %clonesrcinfo = &Apache::lonnet::coursedescription($clonesrc);
- if ($clonesrcinfo{'description'}) {
- $clonedfrom = $clonesrcinfo{'description'}.' '.($clonesrc);
- }
- }
- $datatable .= $clonedfrom;
- } elsif ($item eq 'uniquecode') {
- my $code = $env{'course.'.$env{'request.course.id'}.'.internal.uniquecode'};
- if ($code) {
- $datatable .= $code;
- }
} elsif ($item eq 'co-owners') {
+ my $cnum = $env{'course.'.$env{'request.course.id'}.'.num'};
my $coowners = $env{'course.'.$env{'request.course.id'}.'.internal.co-owners'};
my @currcoown;
if ($coowners) {
@@ -2345,45 +1983,15 @@ sub print_courseinfo {
if (($crstype eq 'Course') && ($env{'course.'.$env{'request.course.id'}.'.internal.coursecode'}) && ($autocoowner)) {
$datatable .= &show_autocoowners(@currcoown);
} else {
- $datatable .= &coowner_invitations($cnum,$cdom,\@currcoown,$noedit);
+ $datatable .= &coowner_invitations($cnum,$cdom,@currcoown);
}
} else {
if (($crstype eq 'Course') && ($env{'course.'.$env{'request.course.id'}.'.internal.coursecode'}) && ($autocoowner)) {
$datatable .= &show_autocoowners(@currcoown);
} else {
- $datatable .= &manage_coownership($cnum,$cdom,\@currcoown,$noedit);
+ $datatable .= &manage_coownership($cnum,$cdom,@currcoown);
}
}
- } elsif ($item eq 'syllabus') {
- my $external = $env{'course.'.$env{'request.course.id'}.'.externalsyllabus'};
- my $uploaded = $env{'course.'.$env{'request.course.id'}.'.uploadedsyllabus'};
- my $minimal = $env{'course.'.$env{'request.course.id'}.'.minimalsyllabus'};
- if (($minimal =~/\w/) || ($uploaded =~/\w/)) {
- if ($minimal =~/\w/) {
- if ($external =~ m{\Q$minimal\E$}) {
- undef($external);
- }
- } elsif ($uploaded =~/\w/) {
- if ($external =~ m{\Q$uploaded\E$}) {
- undef($external);
- }
- }
- } elsif ($external!~/\w/) {
- undef($external);
- }
- if ($external) {
- $datatable .= &mt('External URL');
- } elsif ($minimal) {
- $datatable .= &mt('Minimal template');
- } elsif ($uploaded) {
- $datatable .= &mt('Uploaded file');
- } else {
- $datatable .= &mt('Standard template');
- }
- $datatable .= (' ' x 2).
- &mt('[_1]View[_2]',
- '',
- '');
} elsif ($item eq 'loncaparev') {
my $loncaparev = $env{'course.'.$env{'request.course.id'}.'.internal.releaserequired'};
my $showreqd;
@@ -2395,7 +2003,7 @@ sub print_courseinfo {
}
$datatable .= $showreqd;
} else {
- $datatable .= &Apache::lonhtmlcommon::textbox($item,$settings->{$item},$items{$item}{size},$disabled);
+ $datatable .= &Apache::lonhtmlcommon::textbox($item,$settings->{$item},$items{$item}{size});
}
$datatable .= &item_table_row_end();
}
@@ -2404,24 +2012,19 @@ sub print_courseinfo {
}
sub new_cloners_dom_row {
- my ($newdom,$num,$default) = @_;
- my ($output,$checkedon,$checkedoff);
+ my ($newdom,$num) = @_;
+ my $output;
if ($newdom ne '') {
- if ($num eq $default) {
- $checkedon = 'checked="checked" ';
- } else {
- $checkedoff = 'checked="checked" ';
- }
$output .= &Apache::loncommon::start_data_table_row().
''.
&mt('Any user in domain:').' '.$newdom.''.
(' 'x2).''.(' 'x2).
'
@@ -2559,7 +2161,6 @@ ENDSCRIPT
sub display_loncaparev_constraints {
my ($r,$navmap,$loncaparev,$crstype) = @_;
- my ($reqdmajor,$reqdminor);
my $cid = $env{'request.course.id'};
my $cdom = $env{'course.'.$cid.'.domain'};
my $cnum = $env{'course.'.$cid.'.num'};
@@ -2569,45 +2170,25 @@ sub display_loncaparev_constraints {
'section/group' => 'section/group',
'user' => 'user',
);
- &Apache::lonrelrequtils::init_global_hashes();
- if (defined($Apache::lonrelrequtils::checkcrstypes{$crstype})) {
- ($reqdmajor,$reqdminor) = split(/\./,$Apache::lonrelrequtils::checkcrstypes{$crstype});
+ my (%checkparms,%checkresponsetypes,%checkcrstypes,%anonsurvey,%randomizetry);
+ &Apache::loncommon::build_release_hashes(\%checkparms,\%checkresponsetypes,
+ \%checkcrstypes,\%anonsurvey,\%randomizetry);
+ if (defined($checkcrstypes{$crstype})) {
$output .= ''.&mt('Course type: [_1] requires [_2] or newer',$crstype,
- $Apache::lonrelrequtils::checkcrstypes{$crstype}).'';
+ $checkcrstypes{$crstype}).'';
}
my (%fromparam,%rowspan,%bymap,%byresource,@scopeorder,%toshow,%allmaps,
- %byresponsetype,%bysubmission,%fromblocks);
+ %byresponsetype,%bysubmission);
@scopeorder = ('all','section/group','user');
- my $now = time;
my $resourcedata = &Apache::lonparmset::readdata($cnum,$cdom);
if (ref($resourcedata) eq 'HASH') {
foreach my $key (keys(%{$resourcedata})) {
- foreach my $item (keys(%Apache::lonrelrequtils::checkparms)) {
+ foreach my $item (keys(%checkparms)) {
if ($key =~ /(\Q$item\E)$/) {
- if (ref($Apache::lonrelrequtils::checkparms{$item}) eq 'ARRAY') {
+ if (ref($checkparms{$item}) eq 'ARRAY') {
my $value = $resourcedata->{$key};
- if ($item eq 'examcode') {
- if (&Apache::lonnet::validCODE($value)) {
- $value = 'valid';
- } else {
- $value = '';
- }
- } elsif ($item eq 'printstartdate') {
- if ($value =~ /^\d+$/) {
- if ($value > $now) {
- $value = 'future';
- }
- }
- } elsif ($item eq 'printenddate') {
- if ($value =~ /^\d+$/) {
- if ($value < $now) {
- $value = 'past';
- }
- }
-
- }
my ($middle,$scope,$which,$level,$map,$resource);
- if (grep(/^\Q$value\E$/,@{$Apache::lonrelrequtils::checkparms{$item}})) {
+ if (grep(/^\Q$value\E$/,@{$checkparms{$item}})) {
my $stdtype = &Apache::lonparmset::standard_parameter_types($item);
my $stdname = &Apache::lonparmset::standard_parameter_names($item);
my $valname = &get_param_description($stdtype,$value);
@@ -2699,9 +2280,6 @@ sub display_loncaparev_constraints {
' | '.&mt('Extent').' | '.&mt('Setting').' | '.
&Apache::loncommon::end_data_table_header_row();
foreach my $rev (keys(%fromparam)) {
- my ($major,$minor) = split(/\./,$rev);
- ($reqdmajor,$reqdminor) =
- &Apache::lonrelrequtils::update_reqd_loncaparev($major,$minor,$reqdmajor,$reqdminor);
$output .= &Apache::loncommon::start_data_table_row().
''.$rev.' | ';
my $newrow;
@@ -2732,75 +2310,6 @@ sub display_loncaparev_constraints {
}
}
- my %comm_blocks = &Apache::lonnet::dump('comm_block',$cdom,$cnum);
- my $now = time;
- if (keys(%comm_blocks) > 0) {
- foreach my $block (keys(%comm_blocks)) {
- if ($block =~ /^firstaccess____(.+)$/) {
- my $rev = $Apache::lonnet::needsrelease{'course:commblock:timer'};
- if (ref($comm_blocks{$block}) eq 'HASH') {
- push(@{$fromblocks{'timer'}{$rev}},&unescape($comm_blocks{$block}{'event'}).
- ' '.&mt('set by [_1]',
- &Apache::loncommon::plainname(split(/:/,$comm_blocks{$block}{'setter'}))));
- }
- next;
- } elsif ($block =~ /^(\d+)____(\d+)$/) {
- my ($start,$end) = ($1,$2);
- next if ($end < $now);
- }
- if (ref($comm_blocks{$block}) eq 'HASH') {
- if (ref($comm_blocks{$block}{'blocks'}) eq 'HASH') {
- if (ref($comm_blocks{$block}{'blocks'}{'docs'}) eq 'HASH') {
- if (keys(%{$comm_blocks{$block}{'blocks'}{'docs'}}) > 0) {
- my $rev = $Apache::lonnet::needsrelease{'course:commblock:docs'};
- push(@{$fromblocks{'docs'}{$rev}},&unescape($comm_blocks{$block}{'event'}).
- ' '.
- &mt('set by [_1]',
- &Apache::loncommon::plainname(split(/:/,$comm_blocks{$block}{'setter'}))));
- }
- } elsif ($comm_blocks{$block}{'blocks'}{'printout'} eq 'on') {
- my $rev = $Apache::lonnet::needsrelease{'course:commblock:printout'};
- push(@{$fromblocks{'printout'}{$rev}},&unescape($comm_blocks{$block}{'event'}).
- ' '.
- &mt('set by [_1]',
- &Apache::loncommon::plainname(split(/:/,$comm_blocks{$block}{'setter'}))));
-
- }
- }
- }
- }
- if (keys(%fromblocks)) {
- my %lt = (
- docs => 'Content blocking',
- printout => 'Printout generation',
- timer => 'Timed quiz trigger',
- );
- $output .= ''.&mt('Requirements from exam blocking').'
'.
- &Apache::loncommon::start_data_table().
- &Apache::loncommon::start_data_table_header_row().
- ''.&mt('Release').' | '.&mt('Setting').' | '.
- ''.&mt('Event(s)').' | '.
- &Apache::loncommon::end_data_table_header_row();
- foreach my $type ('docs','printout','timer') {
- if (ref($fromblocks{$type}) eq 'HASH') {
- foreach my $rev (keys(%{$fromblocks{$type}})) {
- my ($major,$minor) = split(/\./,$rev);
- ($reqdmajor,$reqdminor) =
- &Apache::lonrelrequtils::update_reqd_loncaparev($major,$minor,$reqdmajor,$reqdminor);
- $output .= &Apache::loncommon::start_data_table_row().
- ''.$rev.' | '.$lt{$type}.' | ';
- foreach my $event (sort(@{$fromblocks{$type}{$rev}})) {
- $output .= $event.' ';
- }
- $output =~ s{\Q \E$}{};
- $output .= ' | '.&Apache::loncommon::end_data_table_row();
- }
- }
- }
- $output .= &Apache::loncommon::end_data_table().'
';
- }
- }
-
if (defined($navmap)) {
my %anonsubms=&Apache::lonnet::dump('nohist_anonsurveys',$cdom,$cnum);
my $rev_anonsurv=$Apache::lonnet::needsrelease{'parameter:type:anonsurvey'};
@@ -2810,7 +2319,7 @@ sub display_loncaparev_constraints {
my $stdname=&Apache::lonparmset::standard_parameter_names('type');
my $valanon=&get_param_description($stdtype,'anonsurvey');
my $valrandtry=&get_param_description($stdtype,'randomizetry');
- my %checkedrev;
+
foreach my $res ($navmap->retrieveResources(undef,sub { $_[0]->is_problem() },1,0)) {
my @parts = @{$res->parts()};
my $symb = $res->symb();
@@ -2827,13 +2336,6 @@ sub display_loncaparev_constraints {
push(@{$bysubmission{$symb}{$rev}},$what);
}
$allmaps{$enclosing_map} = 1;
- unless ($checkedrev{'anonsurvey'}) {
- my ($major,$minor) = split(/\./,$rev);
- ($reqdmajor,$reqdminor) =
- &Apache::lonrelrequtils::update_reqd_loncaparev($major,$minor,
- $reqdmajor,$reqdminor);
- $checkedrev{'anonsurvey'} = 1;
- }
}
if (exists($randtrysubms{$symb."\0".$part})) {
my $rev = $rev_randtry;
@@ -2846,27 +2348,12 @@ sub display_loncaparev_constraints {
push(@{$bysubmission{$symb}{$rev}},$what);
}
$allmaps{$enclosing_map} = 1;
- unless ($checkedrev{'randomizetry'}) {
- my ($major,$minor) = split(/\./,$rev);
- ($reqdmajor,$reqdminor) =
- &Apache::lonrelrequtils::update_reqd_loncaparev($major,$minor,
- $reqdmajor,$reqdminor);
- $checkedrev{'randomizetry'} = 1;
- }
}
}
my %responses = $res->responseTypes();
foreach my $key (keys(%responses)) {
- if (exists($Apache::lonrelrequtils::checkresponsetypes{$key})) {
- my $rev = $Apache::lonrelrequtils::checkresponsetypes{$key};
- unless ($checkedrev{$key}) {
- my ($major,$minor) = split(/\./,$rev);
- ($reqdmajor,$reqdminor) =
- &Apache::lonrelrequtils::update_reqd_loncaparev($major,$minor,
- $reqdmajor,$reqdminor);
- $checkedrev{$key} = 1;
- }
- push(@{$byresponsetype{$symb}{$rev}},$key);
+ if (exists($checkresponsetypes{$key})) {
+ push(@{$byresponsetype{$symb}{$checkresponsetypes{$key}}},$key);
$allmaps{$enclosing_map} = 1;
}
}
@@ -2884,9 +2371,9 @@ sub display_loncaparev_constraints {
}
foreach my $map (keys(%allmaps)) {
my $mapres = $navmap->getResourceByUrl($map);
+ my $mapsymb = $mapres->symb();
+ $toshow{$mapsymb} = 1;
if (ref($mapres)) {
- my $mapsymb = $mapres->symb();
- $toshow{$mapsymb} = 1;
my $pcslist = $mapres->map_hierarchy();
if ($pcslist ne '') {
foreach my $pc (split(/,/,$pcslist)) {
@@ -2927,10 +2414,6 @@ sub display_loncaparev_constraints {
'');
}
$r->print(&Apache::loncommon::end_page());
- my ($currmajor,$currminor) = split(/\./,$loncaparev);
- if (($currmajor != $reqdmajor) || ($currminor != $reqdminor)) {
- return 1;
- }
return;
}
@@ -2949,7 +2432,7 @@ sub show_contents_view {
''.&mt('Attribute/Setting').' | '.
&Apache::loncommon::end_data_table_header_row().
&Apache::loncommon::start_data_table_row().
- ' '.$icon.' '.&mt('Main Content').' | ');
+ ' '.$icon.' '.&mt('Main Course Documents').' | ');
&releases_by_map($r,$bymap,$topmap,$scopeorder,$lt);
$r->print(&Apache::loncommon::end_data_table_row());
my $it=$navmap->getIterator(undef,undef,undef,1,1,undef);
@@ -3072,19 +2555,13 @@ sub show_contents_view {
}
$r->print(&Apache::loncommon::end_data_table());
}
- return;
}
sub releases_by_map {
my ($r,$bymap,$url,$scopeorder,$lt) = @_;
return unless ((ref($bymap) eq 'HASH') && (ref($scopeorder) eq 'ARRAY'));
- my $newrow = 0;
if (ref($bymap->{$url}) eq 'HASH') {
foreach my $rev (sort(keys(%{$bymap->{$url}}))) {
- if ($newrow) {
- $r->print(&Apache::loncommon::end_data_table_row().
- &Apache::loncommon::continue_data_table_row());
- }
$r->print(''.$rev.' | ');
if (ref($bymap->{$url}{$rev}) eq 'HASH') {
$r->print('');
@@ -3106,7 +2583,6 @@ sub releases_by_map {
$r->print(' ');
}
$r->print(' | ');
- $newrow = 1;
}
} else {
$r->print(' | ');
@@ -3132,27 +2608,9 @@ sub get_param_description {
return $name;
}
-sub update_releasereq {
- my $readmap = 1;
- my $getrelreq = 1;
- if (ref($modified_courses) eq 'ARRAY') {
- foreach my $item (@{$modified_courses}) {
- if (ref($item) eq 'ARRAY') {
- my ($cdom,$cnum,$chome,$crstype) = @{$item};
- &Apache::lonrelrequtils::modify_course_relreq(undef,undef,$cnum,$cdom,
- $chome,$crstype,$cdom.'_'.$cnum,
- $readmap,$getrelreq);
- }
- }
- $modified_courses = [];
- }
- undef($registered_cleanup);
- return;
-}
-
sub show_autocoowners {
my (@currcoown) = @_;
- my $output = ''.&mt('Co-ownership is set automatically when a Course Coordinator role[_1] is assigned to official course personnel (from institutional data).','
').'';
+ my $output = ''.&mt('Co-ownership is set automatically when a Course Coordinator role is assigned to official course personnel (from institutional data).').'';
if (@currcoown > 0) {
$output .= '
'.&mt('Current co-owners are:').' '.
join(', ',map { &Apache::loncommon::plainname(split(':',$_)); } (@currcoown));
@@ -3163,20 +2621,13 @@ sub show_autocoowners {
}
sub coowner_invitations {
- my ($cnum,$cdom,$currcoownref,$noedit) = @_;
- my ($output,@pendingcoown,@othercoords,@currcoown);
+ my ($cnum,$cdom,@currcoown) = @_;
+ my ($output,@pendingcoown,@othercoords);
my $pendingcoowners =
$env{'course.'.$env{'request.course.id'}.'.internal.pendingco-owners'};
if ($pendingcoowners) {
@pendingcoown = split(',',$pendingcoowners);
}
- if (ref($currcoownref) eq 'ARRAY') {
- @currcoown == @{$currcoownref};
- }
- my $disabled;
- if ($noedit) {
- $disabled = ' disabled="disabled"';
- }
my $ccrole = 'cc';
my %ccroles = &Apache::lonnet::get_my_roles($cnum,$cdom,undef,undef,[$ccrole]);
foreach my $key (sort(keys(%ccroles))) {
@@ -3194,7 +2645,7 @@ sub coowner_invitations {
''.&mt('Current co-owners').' | ';
foreach my $person (@currcoown) {
my ($co_uname,$co_dom) = split(':',$person);
- $output .= ''.(' 'x2).' ';
+ $output .= ''.(' 'x2).' ';
}
$output .= ' | '.
&Apache::loncommon::end_data_table_row();
@@ -3204,7 +2655,7 @@ sub coowner_invitations {
''.&mt('Invited as co-owners [_1](agreement pending)',' ').' | ';
foreach my $person (@pendingcoown) {
my ($co_uname,$co_dom) = split(':',$person);
- $output .= ''.(' 'x2).' ';
+ $output .= ''.(' 'x2).' ';
}
$output .= ' | '.
&Apache::loncommon::end_data_table_row();
@@ -3214,7 +2665,7 @@ sub coowner_invitations {
''.&mt('Invite other Coordinators [_1]to become co-owners',' ').' | ';
foreach my $person (@othercoords) {
my ($co_uname,$co_dom) = split(':',$person);
- $output .= ''.(' 'x2).' ';
+ $output .= ''.(' 'x2).' ';
}
$output .= ' | '.
&Apache::loncommon::end_data_table_row();
@@ -3227,20 +2678,13 @@ sub coowner_invitations {
}
sub manage_coownership {
- my ($cnum,$cdom,$currcoownref,$noedit) = @_;
- my (@pendingcoown,@currcoown);
+ my ($cnum,$cdom,@currcoown) = @_;
+ my (@pendingcoown);
my $pendingcoowners =
$env{'course.'.$env{'request.course.id'}.'.internal.pendingco-owners'};
if ($pendingcoowners) {
@pendingcoown = split(',',$pendingcoowners);
}
- if (ref($currcoownref) eq 'ARRAY') {
- @currcoown == @{$currcoownref};
- }
- my $disabled;
- if ($noedit) {
- $disabled = ' disabled="disabled"';
- }
my ($is_coowner,$is_pending,$output);
my $uname = $env{'user.name'};
my $udom = $env{'user.domain'};
@@ -3272,8 +2716,8 @@ sub manage_coownership {
if ($is_coowner) {
$output .= &mt('You are currently a co-owner:').' ';
} else {
- $output .= &mt('The course owner has invited you to become a co-owner:').' '.(' 'x2).
- '';
+ $output .= &mt('The course owner has invited you to become a co-owner:').' '.(' 'x2).
+ '';
}
$output .= '';
if (@currcoown) {
@@ -3287,7 +2731,7 @@ sub manage_coownership {
}
sub print_localization {
- my ($cdom,$settings,$ordered,$itemtext,$rowtotal,$noedit) = @_;
+ my ($cdom,$settings,$ordered,$itemtext,$rowtotal) = @_;
unless ((ref($settings) eq 'HASH') && (ref($ordered) eq 'ARRAY') && (ref($itemtext) eq 'HASH')) {
return;
}
@@ -3306,24 +2750,17 @@ sub print_localization {
input => 'selectbox',
},
);
- my ($datatable,$disabled);
+ my $datatable;
my $count = 0;
- if ($noedit) {
- $disabled = ' disabled="disabled"';
- }
foreach my $item (@{$ordered}) {
$count ++;
- my $colspan;
- unless ($item eq 'languages') {
- $colspan = 2;
- }
- $datatable .= &item_table_row_start($items{$item}{text},$count,undef,$colspan);
+ $datatable .= &item_table_row_start($items{$item}{text},$count);
if ($item eq 'timezone') {
my $includeempty = 1;
my $timezone = &Apache::lonlocal::gettimezone();
$datatable .=
&Apache::loncommon::select_timezone($item,$timezone,undef,
- $includeempty,$disabled);
+ $includeempty);
} elsif ($item eq 'datelocale') {
my $includeempty = 1;
my $locale_obj = &Apache::lonlocal::getdatelocale();
@@ -3333,18 +2770,15 @@ sub print_localization {
}
$datatable .=
&Apache::loncommon::select_datelocale($item,$currdatelocale,
- undef,$includeempty,$disabled);
+ undef,$includeempty);
} else {
if ($settings->{$item} eq '') {
- unless ($noedit) {
- $datatable .= ''.
- &Apache::loncommon::select_language('languages_0','',1);
- }
+ $datatable .=
+ &Apache::loncommon::select_language('languages_0','',1);
} else {
my $num = 0;
my @languages = split(/\s*[,;:]\s*/,$settings->{$item});
- $datatable .= ' | '.
- &Apache::loncommon::start_data_table();
+ $datatable .= &Apache::loncommon::start_data_table();
if (@languages > 0) {
my %langchoices = &get_lang_choices();
foreach my $lang (@languages) {
@@ -3359,22 +2793,19 @@ sub print_localization {
' '.
' | '.
&Apache::loncommon::end_data_table_row();
$num ++;
}
}
- unless ($noedit) {
- $datatable .=
- &Apache::loncommon::start_data_table_row().
+ $datatable .= &Apache::loncommon::start_data_table_row().
''.
&mt('Additional language:'). ' '.
&Apache::loncommon::select_language('languages_'.$num,'',1).
''.
- ' | '.&Apache::loncommon::end_data_table_row();
- }
- $datatable .= &Apache::loncommon::end_data_table().'
';
+ ''.&Apache::loncommon::end_data_table_row().
+ &Apache::loncommon::end_data_table();
}
}
$datatable .= &item_table_row_end();
@@ -3395,7 +2826,7 @@ sub get_lang_choices {
}
sub print_feedback {
- my ($position,$cdom,$settings,$ordered,$itemtext,$rowtotal,$noedit) = @_;
+ my ($position,$cdom,$settings,$ordered,$itemtext,$rowtotal) = @_;
unless ((ref($settings) eq 'HASH') && (ref($ordered) eq 'ARRAY') && (ref($itemtext) eq 'HASH')) {
return;
}
@@ -3430,25 +2861,21 @@ sub print_feedback {
del => 'Delete?',
sec => 'Sections:',
);
- my $disabled;
- if ($noedit) {
- $disabled = ' disabled="disabled"';
- }
+
foreach my $item (@{$ordered}) {
$count ++;
if ($position eq 'top') {
$datatable .= &item_table_row_start($items{$item}{text},$count);
} else {
- $datatable .= &item_table_row_start($items{$item}{text}."
(Custom text)",$count, "advanced",2);
+ $datatable .= &item_table_row_start($items{$item}{text}."
(Custom text)",$count, "advanced");
}
if ($position eq 'top') {
my $includeempty = 0;
- $datatable .= ''.
- &user_table($cdom,$item,\@sections,
- $settings->{$item},\%lt,$noedit);
+ $datatable .= &user_table($cdom,$item,\@sections,
+ $settings->{$item},\%lt);
} else {
$datatable .= &Apache::lonhtmlcommon::textbox($item.'.text',
- $settings->{$item.'.text'},$items{$item}{size},$disabled);
+ $settings->{$item.'.text'},$items{$item}{size});
}
$datatable .= &item_table_row_end();
}
@@ -3457,21 +2884,15 @@ sub print_feedback {
}
sub user_table {
- my ($cdom,$item,$sections,$currvalue,$lt,$noedit) = @_;
+ my ($cdom,$item,$sections,$currvalue,$lt) = @_;
my $output;
if ($currvalue eq '') {
- unless ($noedit) {
- $output .= &select_recipient($item,'0',$cdom,$sections);
- }
+ $output .= &select_recipient($item,'0',$cdom,$sections);
} else {
my $num = 0;
my @curr = split(/,/,$currvalue);
- $output .= '';
+ $output .= '';
my ($currusers);
- my $disabled;
- if ($noedit) {
- $disabled = ' disabled="disabled"';
- }
foreach my $val (@curr) {
next if ($val eq '');
my ($uname,$udom,$seclist) = ($val =~ /^($match_username):($match_domain)(\(?[^\)]*\)?)$/);
@@ -3483,7 +2904,7 @@ sub user_table {
$currusers .= ''.
''.
''.
''.(' 'x2).
@@ -3494,7 +2915,7 @@ sub user_table {
if (@{$sections}) {
$currusers.= (' 'x3).$lt->{'sec'}.' '.
&select_sections($item,$num,$sections,
- \@selsec,$noedit);
+ \@selsec);
}
}
$currusers .= ' | ';
@@ -3512,16 +2933,12 @@ sub user_table {
''.
'';
}
- unless ($noedit) {
- $output .=
- ''.
+ $output .= ' '.
''.
$lt->{'add'}.' '.
&select_recipient($item,$num,$cdom,$sections).
''.
- ' | ';
- }
- $output .= ' ';
+ ' ';
}
return $output;
}
@@ -3531,7 +2948,7 @@ sub select_recipient {
my $domform = &Apache::loncommon::select_dom_form($cdom,$item.'_udom_'.$num,$includeempty);
my $selectlink =
&Apache::loncommon::selectstudent_link('display',$item.'_uname_'.$num,
- $item.'_udom_'.$num,'only');
+ $item.'_udom_'.$num,1);
my $output =
''.&mt('Username').' '.
' | '.
@@ -3548,17 +2965,14 @@ sub select_recipient {
}
sub select_sections {
- my ($item,$num,$sections,$selected,$noedit) = @_;
- my ($output,@currsecs,$allsec,$disabled);
+ my ($item,$num,$sections,$selected) = @_;
+ my ($output,@currsecs,$allsec);
if (ref($selected) eq 'ARRAY') {
@currsecs = @{$selected};
}
if (!@currsecs) {
$allsec = ' selected="selected"';
}
- if ($noedit) {
- $disabled = ' disabled="disabled"';
- }
if (ref($sections) eq 'ARRAY') {
if (@{$sections}) {
my $mult;
@@ -3568,7 +2982,7 @@ sub select_sections {
$mult .= ' size="4"';
}
}
- $output = '
|