--- loncom/interface/createaccount.pm	2024/08/22 20:12:39	1.72.4.7.2.3
+++ loncom/interface/createaccount.pm	2020/09/08 18:08:29	1.80
@@ -4,7 +4,7 @@
 # kerberos, or SSO) or an e-mail address. Requests to use an e-mail address as
 # username may be processed automatically, or may be queued for approval.
 #
-# $Id: createaccount.pm,v 1.72.4.7.2.3 2024/08/22 20:12:39 raeburn Exp $
+# $Id: createaccount.pm,v 1.80 2020/09/08 18:08:29 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -37,6 +37,7 @@ use Apache::lonacc;
 use Apache::lonnet;
 use Apache::loncommon;
 use Apache::lonhtmlcommon;
+use Apache::lonuserutils;
 use Apache::lonlocal;
 use Apache::lonauth;
 use Apache::resetpw;
@@ -437,9 +438,7 @@ sub javascript_setforms {
                 }
                 $setuserinfo .= '                    server.elements.'.$key.'.value=client.elements.'.$key.'.value;'."\n";
             }
-            if ($usertype ne '') {
-                $setuserinfo .= '                    server.elements.type.value=client.elements.type.value;'."\n";
-            }
+            $setuserinfo .= '                    server.elements.type.value=client.elements.type.value;'."\n"; 
         }
         if ($captcha eq 'original') {
             $setuserinfo .= '                    server.elements.code.value=client.elements.code.value;'."\n".
@@ -527,7 +526,7 @@ sub javascript_checkpass {
     my $mismatchpass = &mt('The passwords you entered did not match.')."\n".
                        &mt('Please try again.'); 
     my ($numrules,$intargjs) =
-        &Apache::loncommon::passwd_validation_js('upass',$domain);
+        &Apache::lonuserutils::passwd_validation_js('upass',$domain);
     &js_escape(\$nopass);
     &js_escape(\$mismatchpass);
     my $js = <<"ENDSCRIPT";
@@ -740,7 +739,7 @@ sub login_box {
                                        $lonhost);
     $output = &serverform($logtoken,$lonhost,undef,$courseid,$context);
     my $unameform = '<input type="text" name="uname" size="20" value="" autocomplete="off" />';
-    my $upassform = '<input type="password" name="upass'.$now.'" size="20" autocomplete="new-password" />';
+    my $upassform = '<input type="password" name="upass'.$now.'" size="20" autocomplete="off" />';
     $output .= '<form name="client" method="post" action="" onsubmit="return(send('."'server','client'".'));">'."\n".
                &Apache::lonhtmlcommon::start_pick_box()."\n".
                &Apache::lonhtmlcommon::row_title($titles{$context},
@@ -983,8 +982,7 @@ sub send_token {
             $msg .= '</form></p>';
             return $msg;
         }
-        my $ip = &Apache::lonnet::get_requestor_ip();
-        my %info = ('ip'         => $ip,
+        my %info = ('ip'         => $ENV{'REMOTE_ADDR'},
                     'time'       => $now,
                     'domain'     => $domain,
                     'username'   => $email,
@@ -1100,9 +1098,8 @@ sub process_mailtoken {
                             &create_account($r,$domain,$domdesc,\%data);
                         if ($result eq 'ok') {
                             $msg = $output;
-                            my $ip = &Apache::lonnet::get_requestor_ip();
                             my $shownow = &Apache::lonlocal::locallocaltime($now);
-                            my $mailmsg = &mt('A LON-CAPA account for the institution: [_1] has been created [_2] from IP address: [_3]. If you did not perform this action or authorize it, please contact the [_4] ([_5]).',$domdesc,$shownow,$ip,$contact_name,$contact_email)."\n";
+                            my $mailmsg = &mt('A LON-CAPA account for the institution: [_1] has been created [_2] from IP address: [_3]. If you did not perform this action or authorize it, please contact the [_4] ([_5]).',$domdesc,$shownow,$ENV{'REMOTE_ADDR'},$contact_name,$contact_email)."\n";
                             my $mailresult = &Apache::resetpw::send_mail($domdesc,$data{'email'},
                                                                         $mailmsg,$contact_name,
                                                                         $contact_email);
@@ -1182,54 +1179,42 @@ sub print_dataentry_form {
         my ($lextkey,$uextkey) = &getkeys($lkey,$ukey);
         my $logtoken=Apache::lonnet::reply('tmpput:'.$ukey.$lkey.'&createaccount:createaccount',
                                            $lonhost);
-        my $showsubmit = 1;
-        my $serverform =
+        $output .=
             '<form name="createaccount" method="post" target="_top" action="/adm/createaccount">';
         if ($courseid ne '') {
-            $serverform .= '<input type="hidden" name="courseid" value="'.$courseid.'"/>'."\n";
+            $output .= '<input type="hidden" name="courseid" value="'.$courseid.'"/>'."\n";
         }
         if (ref($emailusername) eq 'HASH') {
             if (ref($emailusername->{$usertype}) eq 'HASH') {
                 foreach my $field (sort(keys(%{$emailusername->{$usertype}}))) {
-                    $serverform .= '<input type="hidden" name="'.$field.'" value="" />'."\n";
+                    $output .= '<input type="hidden" name="'.$field.'" value="" />'."\n";
                 }
             }
         }
         if ($captcha eq 'original') {
-            $serverform .= '
+            $output .= '
    <input type="hidden" name="crypt" value="" />
    <input type="hidden" name="code" value="" />
 ';
         } elsif ($captcha eq 'recaptcha') {
             if ($recaptchaversion eq '2') {
-                $serverform .= &Apache::lonhtmlcommon::start_pick_box().
-                               &Apache::lonhtmlcommon::row_title(&mt('Validation').'<b>*</b>',
-                                                                 'LC_pick_box_title',
-                                                                 'LC_oddrow_value')."\n".
-                                                                 $captchaform.
-                               &Apache::lonhtmlcommon::row_closure(1)."\n".
-                               &Apache::lonhtmlcommon::row_title()."\n".
-                               '<br /><input type="button" name="createaccount" value="'.
-                               &mt('Create account').'" onclick="checkpass('."'createaccount','newemail'".')" />'.
-                               &Apache::lonhtmlcommon::row_closure(1)."\n".
-                               &Apache::lonhtmlcommon::end_pick_box();
+                $output .= "$captchaform\n";
                 undef($captchaform);
-                undef($showsubmit);
             } else {
-                $serverform .= '
+                $output .= '
    <input type="hidden" name="recaptcha_challenge_field" value="" />
    <input type="hidden" name="recaptcha_response_field" value="" />
 ';
             }
         }
         if ($usertype ne '') {
-            $serverform .= '<input type="hidden" name="type" value="'.
-                           &HTML::Entities::encode($usertype,'\'<>"&').'" />'."\n";
+            $output .= '<input type="hidden" name="type" value="'.
+                       &HTML::Entities::encode($usertype,'\'<>"&').'" />'."\n";
         }
         if ($usernameset eq 'free') {
-            $serverform .= '<input type="hidden" name="username" value="" />'."\n"; 
+            $output .= '<input type="hidden" name="username" value="" />'."\n"; 
         }
-        $serverform .= <<"ENDSERVERFORM";
+        $output .= <<"ENDSERVERFORM";
    <input type="hidden" name="logtoken" value="$logtoken" />
    <input type="hidden" name="serverid" value="$lonhost" />
    <input type="hidden" name="uname" value="" />
@@ -1241,33 +1226,25 @@ sub print_dataentry_form {
 ENDSERVERFORM
         my $beginclientform = '<form name="newemail" method="post" action="" '.
                               'onsubmit="return checkpass('."'createaccount','newemail'".');">'."\n";
-        my $endclientform;
-        unless ($showsubmit) {
-            if ($usertype ne '') {
-                $endclientform = '<input type="hidden" name="type" value="'.
-                                 &HTML::Entities::encode($usertype,'\'<>"&').'" />'."\n";
-            }
-        }
-        $endclientform .= '<input type="hidden" name="udom" value="'.$domain.'" />'."\n".
-                          '<input type="hidden" name="lextkey" value="'.$lextkey.'" />'."\n".
-                          '<input type="hidden" name="uextkey" value="'.$uextkey.'" />'."\n".
-                          '</form>'."\n";
+        my $endclientform = '<input type="hidden" name="udom" value="'.$domain.'" />'."\n".
+                            '<input type="hidden" name="lextkey" value="'.$lextkey.'" />'."\n".
+                            '<input type="hidden" name="uextkey" value="'.$uextkey.'" />'."\n".
+                            '</form>'."\n".
+                            '<p class="LC_info">'.&mt('Fields marked [_1]*[_2] are required.','<b>','</b>').'</p>';
         my ($datatable,$rowcount) =
             &Apache::loncreateuser::personal_data_display('',$domain,'email','selfcreate',
-                                                          '','','',$now,$captchaform,
+                                                          '','',$now,$captchaform,
                                                           $emailusername,$usertype,
-                                                          $usernameset,$condition,$excluded,
-                                                          $showsubmit);
+                                                          $usernameset,$condition,$excluded);
         if ($rowcount) {
-            $output .= '<div class="LC_left_float">'.$beginclientform.$datatable.$endclientform.'</div>'."\n".
-                       '<div class="LC_clear_float_footer"></div>'."\n";
+            $output .= '<div class="LC_left_float">'.$beginclientform.$datatable.$endclientform;
         } else {
             $output .= $beginclientform.$endclientform;
         }
-        $output .= $serverform.
-                   '<p class="LC_info">'.
-                   &mt('Fields marked [_1]*[_2] are required.','<b>','</b>').
-                   '</p>';
+        if ($rowcount) {
+            $output .= '</div>'."\n".
+                       '<div class="LC_clear_float_footer"></div>'."\n";
+        }
     } else {
         $output = &mt('Could not load javascript file [_1]','<tt>londes.js</tt>');
     }
@@ -1428,7 +1405,7 @@ sub create_account {
             unless (($inststatus eq 'default') || ($inststatus eq '')) {
                 &Apache::lonnet::put('environment',{inststatus => $inststatus},$domain,$username);
             }
-            $output .= '<br />'.&mt('Home Server').": $uhome ".
+            $output .= '<br />'.&mt('Home server: [_1]',$uhome).' '.
                        &Apache::lonnet::hostname($uhome).'<br /><br />';
             return ('ok',$output,$uhome);
         } else {
@@ -1601,8 +1578,7 @@ sub username_check {
                     '<input type="hidden" name="udom" value="'.$domain.'" />'."\n".
                     '<input type="hidden" name="phase" value="username_activation" />';
         my $now = time;
-        my $ip = &Apache::lonnet::get_requestor_ip();
-        my %info = ('ip'         => $ip,
+        my %info = ('ip'         => $ENV{'REMOTE_ADDR'},
                     'time'       => $now,
                     'domain'     => $domain,
                     'username'   => $username);