--- loncom/interface/domainprefs.pm	2018/12/08 15:03:25	1.344
+++ loncom/interface/domainprefs.pm	2018/12/26 20:10:24	1.345
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set domain-wide configuration settings
 #
-# $Id: domainprefs.pm,v 1.344 2018/12/08 15:03:25 raeburn Exp $
+# $Id: domainprefs.pm,v 1.345 2018/12/26 20:10:24 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -2836,7 +2836,31 @@ sub lti_toggle_js {
 // <![CDATA[
 
 function toggleLTI(form,setting,item) {
-    if ((setting == 'user') || (setting == 'crs') || (setting == 'passback')) {
+    if (setting == 'requser') {
+        var fieldsets = document.getElementsByClassName('ltioption_'+item);
+        if (fieldsets.length) {
+            var radioname = 'lti_'+setting+'_'+item;
+            var num = form.elements[radioname].length;
+            if (num) {
+                var setvis = '';
+                for (var i=0; i<num; i++) {
+                    if (form.elements[radioname][i].checked) {
+                        if (form.elements[radioname][i].value == '1') {
+                           setvis = 1;
+                           break;
+                        }
+                    }
+                }
+                for (var j=0; j<fieldsets.length; j++) { 
+                    if (setvis) {
+                        fieldsets[j].style.display = 'block';
+                    } else {
+                        fieldsets[j].style.display = 'none';
+                    }
+                }
+            }
+        }
+    } else if ((setting == 'user') || (setting == 'crs') || (setting == 'passback')) {
         var radioname = '';
         var divid = '';
         if (setting == 'user') {
@@ -4767,14 +4791,24 @@ sub print_lti {
         for (my $i=0; $i<@items; $i++) {
             $css_class = $itemcount%2?' class="LC_odd_row"':'';
             my $item = $ordered{$items[$i]};
-            my ($key,$secret,$lifetime,$consumer,$current);
+            my ($key,$secret,$lifetime,$consumer,$requser,$current);
             if (ref($settings->{$item}) eq 'HASH') {
                 $key = $settings->{$item}->{'key'};
                 $secret = $settings->{$item}->{'secret'};
                 $lifetime = $settings->{$item}->{'lifetime'};
                 $consumer = $settings->{$item}->{'consumer'};
+                $requser = $settings->{$item}->{'requser'};
                 $current = $settings->{$item};
             }
+            my $onclickrequser = ' onclick="toggleLTI(this.form,'."'requser','$i'".');"';
+            my %checkedrequser = (
+                                   yes => ' checked="checked"',
+                                   no  => '',
+                                 );
+            if (!$requser) {
+                $checkedrequser{'no'} = $checkedrequser{'yes'};
+                $checkedrequser{'yes'} = '';
+            } 
             my $chgstr = ' onchange="javascript:reorderLTI(this.form,'."'lti_pos_".$item."'".');"';
             $datatable .= '<tr '.$css_class.'><td><span class="LC_nobreak">'
                          .'<select name="lti_pos_'.$item.'"'.$chgstr.'>';
@@ -4792,13 +4826,17 @@ sub print_lti {
                 '<td colspan="2">'.
                 '<fieldset><legend>'.&mt('Required settings').'</legend>'.
                 '<span class="LC_nobreak">'.$lt{'consumer'}.
-                ':<input type="text" size="20" name="lti_consumer_'.$i.'" value="'.$consumer.'" /></span> '.
+                ':<input type="text" size="15" name="lti_consumer_'.$i.'" value="'.$consumer.'" /></span> '.
                 ('&nbsp;'x2).
                 '<span class="LC_nobreak">'.$lt{'version'}.':<select name="lti_version_'.$i.'">'.
                 '<option value="LTI-1p0" selected="selected">1.1</option></select></span> '.
                 ('&nbsp;'x2).
                 '<span class="LC_nobreak">'.$lt{'lifetime'}.':<input type="text" name="lti_lifetime_'.$i.'"'.
-                'value="'.$lifetime.'" size="5" /></span>'.
+                'value="'.$lifetime.'" size="3" /></span>'.
+                ('&nbsp;'x2).
+                 '<span class="LC_nobreak">'.$lt{'requser'}.':'.
+                 '<label><input type="radio" name="lti_requser_'.$i.'" value="1"'.$onclickrequser.$checkedrequser{yes}.' />'.&mt('Yes').'</label>&nbsp;'."\n".
+                 '<label><input type="radio" name="lti_requser_'.$i.'" value="0"'.$onclickrequser.$checkedrequser{no}.' />'.&mt('No').'</label></span>'."\n".
                 '<br /><br />'.
                 '<span class="LC_nobreak">'.$lt{'key'}.
                 ':<input type="text" size="25" name="lti_key_'.$i.'" value="'.$key.'" /></span> '.
@@ -4829,12 +4867,16 @@ sub print_lti {
                   '<td colspan="2">'.
                   '<fieldset><legend>'.&mt('Required settings').'</legend>'.
                   '<span class="LC_nobreak">'.$lt{'consumer'}.
-                  ':<input type="text" size="20" name="lti_consumer_add" value="" /></span> '."\n".
+                  ':<input type="text" size="15" name="lti_consumer_add" value="" /></span> '."\n".
                   ('&nbsp;'x2).
                   '<span class="LC_nobreak">'.$lt{'version'}.':<select name="lti_version_add">'.
                   '<option value="LTI-1p0" selected="selected">1.1</option></select></span> '."\n".
                   ('&nbsp;'x2).
-                  '<span class="LC_nobreak">'.$lt{'lifetime'}.':<input type="text" size="5" name="lti_lifetime_add" value="300" /></span> '."\n".
+                  '<span class="LC_nobreak">'.$lt{'lifetime'}.':<input type="text" size="3" name="lti_lifetime_add" value="300" /></span> '."\n".
+                  ('&nbsp;'x2).
+                  '<span class="LC_nobreak">'.$lt{'requser'}.':'.
+                  '<label><input type="radio" name="lti_requser_add" value="1" onclick="toggleLTI(this.form,'."'requser','add'".');" checked="checked" />'.&mt('Yes').'</label>&nbsp;'."\n".
+                  '<label><input type="radio" name="lti_requser_add" value="0" onclick="toggleLTI(this.form,'."'requser','add'".');" />'.&mt('No').'</label></span>'."\n".
                   '<br /><br />'.
                   '<span class="LC_nobreak">'.$lt{'key'}.':<input type="text" size="25" name="lti_key_add" value="" /></span> '."\n".
                   ('&nbsp;'x2).
@@ -4853,15 +4895,16 @@ sub lti_names {
                                           'url'       => 'URL',
                                           'key'       => 'Key',
                                           'lifetime'  => 'Nonce lifetime (s)',
-                                          'consumer'  => 'LTI Consumer', 
+                                          'consumer'  => 'Consumer',
                                           'secret'    => 'Secret',
+                                          'requser'   => "User's identity sent",
                                           'email'     => 'Email address',
                                           'sourcedid' => 'User ID',
                                           'other'     => 'Other',
                                           'passback'  => 'Can return grades to Consumer:',
                                           'roster'    => 'Can retrieve roster from Consumer:',
                                           'topmenu'   => 'Display LON-CAPA page header',
-                                          'inlinemenu'=> 'Display LON-CAPA inline menu', 
+                                          'inlinemenu'=> 'Display LON-CAPA inline menu',
                                         );
     return %lt;
 }
@@ -4887,6 +4930,7 @@ sub lti_options {
     my $crssecfieldsty = 'none';
     my $secsrcfieldsty = 'none';
     my $passbacksty = 'none';
+    my $optionsty = 'block';
     my $lcauthparm;
     my $lcauthparmstyle = 'display:none';
     my $lcauthparmtext;
@@ -4895,6 +4939,9 @@ sub lti_options {
     my %menutitles = &ltimenu_titles();
 
     if (ref($current) eq 'HASH') {
+        if (!$current->{'requser'}) {
+            $optionsty = 'none';
+        }
         if (($current->{'mapuser'} ne '') && ($current->{'mapuser'} ne 'lis_person_sourcedid')) {
             $checked{'mapuser'}{'sourcedid'} = '';
             if ($current->{'mapuser'} eq 'lis_person_contact_email_primary') {
@@ -4920,7 +4967,7 @@ sub lti_options {
                 $checked{'mapcrstype'}{$type} = ' checked="checked"';
             }
         }
-        if ($current->{'makecrs'}) { 
+        if ($current->{'makecrs'}) {
             $checked{'makecrs'}{'Y'} = '  checked="checked"';
         }
         if (ref($current->{'makeuser'}) eq 'ARRAY') {
@@ -5017,7 +5064,7 @@ sub lti_options {
     my $onclicksecsrc = ' onclick="toggleLTI(this.form,'."'secsrc','$num'".')"';
     my $onclicklcauth = ' onclick="toggleLTI(this.form,'."'lcauth','$num'".')"';
     my $onclickmenu = ' onclick="toggleLTI(this.form,'."'lcmenu','$num'".');"';
-    my $output = '<fieldset><legend>'.&mt('Mapping users').'</legend>'.
+    my $output = '<fieldset class="ltioption_'.$num.'" style="display:'.$optionsty.'"><legend>'.&mt('Mapping users').'</legend>'.
                  '<div class="LC_floatleft"><span class="LC_nobreak">'.&mt('LON-CAPA username').':&nbsp;';
     foreach my $option ('sourcedid','email','other') {
         $output .= '<label><input type="radio" name="lti_mapuser_'.$num.'" value="'.$option.'"'.
@@ -5028,7 +5075,7 @@ sub lti_options {
                '<div class="LC_floatleft" style="display:'.$userfieldsty.';" id="lti_userfield_'.$num.'">'.
                '<input type="text" name="lti_customuser_'.$num.'" '.
                'value="'.$userfield.'" /></div></fieldset>'. 
-               '<fieldset><legend>'.&mt('Mapping course roles').'</legend><table><tr>';
+               '<fieldset class="ltioption_'.$num.'" style="display:'.$optionsty.'"><legend>'.&mt('Mapping course roles').'</legend><table><tr>';
     foreach my $ltirole (@lticourseroles) {
         my ($selected,$selectnone);
         if ($rolemaps{$ltirole} eq '') {
@@ -5052,13 +5099,13 @@ sub lti_options {
         $output .= '</select></td>';
     }
     $output .= '</tr></table></fieldset>'.
-               '<fieldset><legend>'.&mt('Roles which may create user accounts').'</legend>';
+               '<fieldset class="ltioption_'.$num.'" style="display:'.$optionsty.'"><legend>'.&mt('Roles which may create user accounts').'</legend>';
     foreach my $ltirole (@ltiroles) {
         $output .= '<span class="LC_nobreak"><label><input type="checkbox" name="lti_makeuser_'.$num.'" value="'.$ltirole.'"'.
                    $checked{'makeuser'}{$ltirole}.' />'.$ltirole.'</label>&nbsp;</span> ';     
     }
     $output .= '</fieldset>'.
-               '<fieldset><legend>'.&mt('New user accounts created for LTI users').'</legend>'.
+               '<fieldset class="ltioption_'.$num.'" style="display:'.$optionsty.'"><legend>'.&mt('New user accounts created for LTI users').'</legend>'.
                '<table>'.
                &modifiable_userdata_row('lti','instdata_'.$num,$current,$numinrow,$itemcount).
                '</table>'.
@@ -5081,7 +5128,7 @@ sub lti_options {
                '<span id="lti_lcauth_parmtext_'.$num.'">'.$lcauthparmtext.'</span>'.
                '<input type="text" name="lti_lcauthparm_'.$num.'" value="" /></span></td></tr>'.
                '</table></fieldset>'.
-               '<fieldset><legend>'.&mt('Mapping courses').'</legend>'.
+               '<fieldset class="ltioption_'.$num.'" style="display:'.$optionsty.'"><legend>'.&mt('Mapping courses').'</legend>'.
                '<div class="LC_floatleft"><span class="LC_nobreak">'.
                &mt('Unique course identifier').':&nbsp;';
     foreach my $option ('course_offering_sourcedid','context_id','other') {
@@ -5099,20 +5146,20 @@ sub lti_options {
                    ('&nbsp;'x2);
     }
     $output .= '</span></fieldset>'.
-               '<fieldset><legend>'.&mt('Creating courses').'</legend>'.
+               '<fieldset class="ltioption_'.$num.'" style="display:'.$optionsty.'"><legend>'.&mt('Creating courses').'</legend>'.
                '<span class="LC_nobreak">'.&mt('Course created (if absent) on Instructor access').':&nbsp;'.
                '<label><input type="radio" name="lti_makecrs_'.$num.'" value="0"'.
                $checked{'makecrs'}{'N'}.' />'.&mt('No').'</label>'.('&nbsp;'x2).
                '<label><input type="radio" name="lti_makecrs_'.$num.'" value="1"'.
                $checked{'makecrs'}{'Y'}.' />'.&mt('Yes').'</label></span>'.
                '</fieldset>'.
-               '<fieldset><legend>'.&mt('Roles which may self-enroll').'</legend>';
+               '<fieldset class="ltioption_'.$num.'" style="display:'.$optionsty.'"><legend>'.&mt('Roles which may self-enroll').'</legend>';
     foreach my $lticrsrole (@lticourseroles) {
         $output .= '<span class="LC_nobreak"><label><input type="checkbox" name="lti_selfenroll_'.$num.'" value="'.$lticrsrole.'"'.
                    $checked{'selfenroll'}{$lticrsrole}.' />'.$lticrsrole.'</label>&nbsp;</span> ';
     }
     $output .= '</fieldset>'.
-               '<fieldset><legend>'.&mt('Course options').'</legend>'.
+               '<fieldset class="ltioption_'.$num.'" style="display:'.$optionsty.'"><legend>'.&mt('Course options').'</legend>'.
                '<div class="LC_floatleft"><span class="LC_nobreak">'.&mt('Assign users to sections').':&nbsp;'.
                '<label><input type="radio" name="lti_crssec_'.$num.'" value="0"'.
                $checked{'crssec'}{'N'}.$onclicksec.' />'.&mt('No').'</label>'.('&nbsp;'x2).
@@ -5164,7 +5211,7 @@ sub lti_options {
                &mt('Outcomes Service (1.1)').'</label>'.('&nbsp;'x2).
                '<label><input type="radio" name="lti_passbackformat_'.$num.'" value="1.0"'.$pb1p0chk.'/>'.
                &mt('Outcomes Extension (1.0)').'</label></span></div></fieldset>'.
-               '<fieldset><legend>'.&mt('Course defaults (Course Coordinator can override)').'</legend>'.
+               '<fieldset class="ltioption_'.$num.'" style="display:'.$optionsty.'"><legend>'.&mt('Course defaults (Course Coordinator can override)').'</legend>'.
                '<div class="LC_floatleft"><span class="LC_nobreak">'.$lt{'topmenu'}.':&nbsp;'.
                '<label><input type="radio" name="lti_topmenu_'.$num.'" value="0"'.
                $checked{'topmenu'}{'N'}.$onclickmenu.' />'.&mt('No').'</label>'.('&nbsp;'x2).
@@ -11776,7 +11823,7 @@ sub modify_lti {
         if ($position ne '') {
             $allpos[$position] = $itemid;
         }
-        foreach my $item ('consumer','key','secret','lifetime') {
+        foreach my $item ('consumer','key','secret','lifetime','requser') {
             my $formitem = 'form.lti_'.$item.'_'.$idx;
             $env{$formitem} =~ s/(`)/'/g;
             if ($item eq 'lifetime') {
@@ -11798,177 +11845,179 @@ sub modify_lti {
         if ($env{'form.lti_version_'.$idx} eq 'LTI-1p0') {
             $confhash{$itemid}{'version'} = $env{'form.lti_version_'.$idx};
         }
-        if ($env{'form.lti_mapuser_'.$idx} eq 'sourcedid') {
-            $confhash{$itemid}{'mapuser'} = 'lis_person_sourcedid'; 
-        } elsif ($env{'form.lti_mapuser_'.$idx} eq 'email') {
-            $confhash{$itemid}{'mapuser'} = 'lis_person_contact_email_primary';
-        } elsif ($env{'form.lti_mapuser_'.$idx} eq 'other') {
-            my $mapuser = $env{'form.lti_customuser_'.$idx};
-            $mapuser =~ s/(`)/'/g;
-            $mapuser =~ s/^\s+|\s+$//g; 
-            $confhash{$itemid}{'mapuser'} = $mapuser; 
-        }
-        foreach my $ltirole (@lticourseroles) {
-            my $possrole = $env{'form.lti_maprole_'.$ltirole.'_'.$idx};
-            if (grep(/^\Q$possrole\E$/,@courseroles)) {
-                $confhash{$itemid}{'maproles'}{$ltirole} = $possrole;
+        if ($confhash{$itemid}{'requser'}) {
+            if ($env{'form.lti_mapuser_'.$idx} eq 'sourcedid') {
+                $confhash{$itemid}{'mapuser'} = 'lis_person_sourcedid'; 
+            } elsif ($env{'form.lti_mapuser_'.$idx} eq 'email') {
+                $confhash{$itemid}{'mapuser'} = 'lis_person_contact_email_primary';
+            } elsif ($env{'form.lti_mapuser_'.$idx} eq 'other') {
+                my $mapuser = $env{'form.lti_customuser_'.$idx};
+                $mapuser =~ s/(`)/'/g;
+                $mapuser =~ s/^\s+|\s+$//g; 
+                $confhash{$itemid}{'mapuser'} = $mapuser; 
             }
-        }
-        my @possmakeuser = &Apache::loncommon::get_env_multiple('form.lti_makeuser_'.$idx);
-        my @makeuser;
-        foreach my $ltirole (sort(@possmakeuser)) {
-            if ($posslti{$ltirole}) {
-                push(@makeuser,$ltirole);
+            foreach my $ltirole (@lticourseroles) {
+                my $possrole = $env{'form.lti_maprole_'.$ltirole.'_'.$idx};
+                if (grep(/^\Q$possrole\E$/,@courseroles)) {
+                    $confhash{$itemid}{'maproles'}{$ltirole} = $possrole;
+                }
             }
-        }
-        $confhash{$itemid}{'makeuser'} = \@makeuser;
-        if (@makeuser) {
-            my $lcauth = $env{'form.lti_lcauth_'.$idx};
-            if ($lcauth =~ /^(internal|krb4|krb5|localauth)$/) {
-                $confhash{$itemid}{'lcauth'} = $lcauth;
-                if ($lcauth ne 'internal') {
-                    my $lcauthparm = $env{'form.lti_lcauthparm_'.$idx};
-                    $lcauthparm =~ s/^(\s+|\s+)$//g;
-                    $lcauthparm =~ s/`//g;
-                    if ($lcauthparm ne '') {
-                        $confhash{$itemid}{'lcauthparm'} = $lcauthparm;
-                    }
+            my @possmakeuser = &Apache::loncommon::get_env_multiple('form.lti_makeuser_'.$idx);
+            my @makeuser;
+            foreach my $ltirole (sort(@possmakeuser)) {
+                if ($posslti{$ltirole}) {
+                    push(@makeuser,$ltirole);
                 }
-            } else {
-                $confhash{$itemid}{'lcauth'} = 'lti';
             }
-        }
-        my @possinstdata =  &Apache::loncommon::get_env_multiple('form.lti_instdata_'.$idx);
-        if (@possinstdata) {
-            foreach my $field (@possinstdata) {
-                if (exists($fieldtitles{$field})) {
-                    push(@{$confhash{$itemid}{'instdata'}});
+            $confhash{$itemid}{'makeuser'} = \@makeuser;
+            if (@makeuser) {
+                my $lcauth = $env{'form.lti_lcauth_'.$idx};
+                if ($lcauth =~ /^(internal|krb4|krb5|localauth)$/) {
+                    $confhash{$itemid}{'lcauth'} = $lcauth;
+                    if ($lcauth ne 'internal') {
+                        my $lcauthparm = $env{'form.lti_lcauthparm_'.$idx};
+                        $lcauthparm =~ s/^(\s+|\s+)$//g;
+                        $lcauthparm =~ s/`//g;
+                        if ($lcauthparm ne '') {
+                            $confhash{$itemid}{'lcauthparm'} = $lcauthparm;
+                        }
+                    }
+                } else {
+                    $confhash{$itemid}{'lcauth'} = 'lti';
                 }
             }
-        }
-        if (($env{'form.lti_mapcrs_'.$idx} eq 'course_offering_sourcedid') ||
-            ($env{'form.lti_mapcrs_'.$idx} eq 'context_id'))  {
-            $confhash{$itemid}{'mapcrs'} = $env{'form.lti_mapcrs_'.$idx};
-        } elsif ($env{'form.lti_mapcrs_'.$idx} eq 'other') {
-            my $mapcrs = $env{'form.lti_mapcrsfield_'.$idx}; 
-            $mapcrs =~ s/(`)/'/g;
-            $mapcrs =~ s/^\s+|\s+$//g;
-            $confhash{$itemid}{'mapcrs'} = $mapcrs;
-        }
-        my @posstypes = &Apache::loncommon::get_env_multiple('form.lti_mapcrstype_'.$idx);
-        my @crstypes;
-        foreach my $type (sort(@posstypes)) {
-            if ($posscrstype{$type}) {
-                push(@crstypes,$type);
+            my @possinstdata =  &Apache::loncommon::get_env_multiple('form.lti_instdata_'.$idx);
+            if (@possinstdata) {
+                foreach my $field (@possinstdata) {
+                    if (exists($fieldtitles{$field})) {
+                        push(@{$confhash{$itemid}{'instdata'}});
+                    }
+                }
             }
-        }
-        $confhash{$itemid}{'mapcrstype'} = \@crstypes;
-        if ($env{'form.lti_makecrs_'.$idx}) {
-            $confhash{$itemid}{'makecrs'} = 1;
-        }
-        my @possenroll = &Apache::loncommon::get_env_multiple('form.lti_selfenroll_'.$idx);
-        my @selfenroll;
-        foreach my $type (sort(@possenroll)) {
-            if ($posslticrs{$type}) {
-                push(@selfenroll,$type);
+            if (($env{'form.lti_mapcrs_'.$idx} eq 'course_offering_sourcedid') ||
+                ($env{'form.lti_mapcrs_'.$idx} eq 'context_id'))  {
+                $confhash{$itemid}{'mapcrs'} = $env{'form.lti_mapcrs_'.$idx};
+            } elsif ($env{'form.lti_mapcrs_'.$idx} eq 'other') {
+                my $mapcrs = $env{'form.lti_mapcrsfield_'.$idx}; 
+                $mapcrs =~ s/(`)/'/g;
+                $mapcrs =~ s/^\s+|\s+$//g;
+                $confhash{$itemid}{'mapcrs'} = $mapcrs;
             }
-        }
-        $confhash{$itemid}{'selfenroll'} = \@selfenroll;
-        if ($env{'form.lti_crssec_'.$idx}) {
-            if ($env{'form.lti_crssecsrc_'.$idx} eq 'course_section_sourcedid') {
-                $confhash{$itemid}{'section'} = $env{'form.lti_crssecsrc_'.$idx};
-            } elsif ($env{'form.lti_crssecsrc_'.$idx} eq 'other') {
-                my $section = $env{'form.lti_customsection_'.$idx};
-                $section =~ s/(`)/'/g;
-                $section =~ s/^\s+|\s+$//g;
-                if ($section ne '') {
-                    $confhash{$itemid}{'section'} = $section;
+            my @posstypes = &Apache::loncommon::get_env_multiple('form.lti_mapcrstype_'.$idx);
+            my @crstypes;
+            foreach my $type (sort(@posstypes)) {
+                if ($posscrstype{$type}) {
+                    push(@crstypes,$type);
                 }
             }
-        }
-        foreach my $field ('passback','roster','topmenu','inlinemenu') {
-            if ($env{'form.lti_'.$field.'_'.$idx}) {
-                $confhash{$itemid}{$field} = 1;
+            $confhash{$itemid}{'mapcrstype'} = \@crstypes;
+            if ($env{'form.lti_makecrs_'.$idx}) {
+                $confhash{$itemid}{'makecrs'} = 1;
             }
-        }
-        if ($env{'form.lti_passback_'.$idx}) {
-            if ($env{'form.lti_passbackformat_'.$idx} eq '1.0') {
-                $confhash{$itemid}{'passbackformat'} = '1.0';
-            } else {
-                $confhash{$itemid}{'passbackformat'} = '1.1';
+            my @possenroll = &Apache::loncommon::get_env_multiple('form.lti_selfenroll_'.$idx);
+            my @selfenroll;
+            foreach my $type (sort(@possenroll)) {
+                if ($posslticrs{$type}) {
+                    push(@selfenroll,$type);
+                }
             }
-        }
-        if ($env{'form.lti_topmenu_'.$idx} || $env{'form.lti_inlinemenu_'.$idx}) {
-            $confhash{$itemid}{lcmenu} = [];
-            my @possmenu = &Apache::loncommon::get_env_multiple('form.lti_menuitem_'.$idx);
-            foreach my $field (@possmenu) {
-                if (exists($menutitles{$field})) {
-                    if ($field eq 'grades') {
-                        next unless ($env{'form.lti_inlinemenu_'.$idx});
+            $confhash{$itemid}{'selfenroll'} = \@selfenroll;
+            if ($env{'form.lti_crssec_'.$idx}) {
+                if ($env{'form.lti_crssecsrc_'.$idx} eq 'course_section_sourcedid') {
+                    $confhash{$itemid}{'section'} = $env{'form.lti_crssecsrc_'.$idx};
+                } elsif ($env{'form.lti_crssecsrc_'.$idx} eq 'other') {
+                    my $section = $env{'form.lti_customsection_'.$idx};
+                    $section =~ s/(`)/'/g;
+                    $section =~ s/^\s+|\s+$//g;
+                    if ($section ne '') {
+                        $confhash{$itemid}{'section'} = $section;
                     }
-                    push(@{$confhash{$itemid}{lcmenu}},$field);
                 }
             }
-        }
-        unless (($idx eq 'add') || ($changes{$itemid})) {
-            foreach my $field ('mapuser','mapcrs','makecrs','section','passback','roster','lcauth','lcauthparm','topmenu','inlinemenu') {
-                if ($domconfig{$action}{$itemid}{$field} ne $confhash{$itemid}{$field}) {
-                    $changes{$itemid} = 1;
+            foreach my $field ('passback','roster','topmenu','inlinemenu') {
+                if ($env{'form.lti_'.$field.'_'.$idx}) {
+                    $confhash{$itemid}{$field} = 1;
                 }
             }
-            unless ($changes{$itemid}) {
-                if ($domconfig{$action}{$itemid}{'passback'} eq $confhash{$itemid}{'passback'}) {
-                    if ($domconfig{$action}{$itemid}{'passbackformat'} ne $confhash{$itemid}{'passbackformat'}) {
-                        $changes{$itemid} = 1;
+            if ($env{'form.lti_passback_'.$idx}) {
+                if ($env{'form.lti_passbackformat_'.$idx} eq '1.0') {
+                    $confhash{$itemid}{'passbackformat'} = '1.0';
+                } else {
+                    $confhash{$itemid}{'passbackformat'} = '1.1';
+                }
+            }
+            if ($env{'form.lti_topmenu_'.$idx} || $env{'form.lti_inlinemenu_'.$idx}) {
+                $confhash{$itemid}{lcmenu} = [];
+                my @possmenu = &Apache::loncommon::get_env_multiple('form.lti_menuitem_'.$idx);
+                foreach my $field (@possmenu) {
+                    if (exists($menutitles{$field})) {
+                        if ($field eq 'grades') {
+                            next unless ($env{'form.lti_inlinemenu_'.$idx});
+                        }
+                        push(@{$confhash{$itemid}{lcmenu}},$field);
                     }
                 }
             }
-            foreach my $field ('makeuser','mapcrstype','selfenroll','instdata','lcmenu') {
+            unless (($idx eq 'add') || ($changes{$itemid})) {
+                foreach my $field ('mapuser','mapcrs','makecrs','section','passback','roster','lcauth','lcauthparm','topmenu','inlinemenu') {
+                    if ($domconfig{$action}{$itemid}{$field} ne $confhash{$itemid}{$field}) {
+                        $changes{$itemid} = 1;
+                    }
+                }
                 unless ($changes{$itemid}) {
-                    if (ref($domconfig{$action}{$itemid}{$field}) eq 'ARRAY') {
-                        if (ref($confhash{$itemid}{$field}) eq 'ARRAY') {
-                            my @diffs = &Apache::loncommon::compare_arrays($domconfig{$action}{$itemid}{$field},
-                                                                           $confhash{$itemid}{$field});
-                            if (@diffs) {
-                                $changes{$itemid} = 1;
-                            }
-                        } elsif (@{$domconfig{$action}{$itemid}{$field}} > 0) {
+                    if ($domconfig{$action}{$itemid}{'passback'} eq $confhash{$itemid}{'passback'}) {
+                        if ($domconfig{$action}{$itemid}{'passbackformat'} ne $confhash{$itemid}{'passbackformat'}) {
                             $changes{$itemid} = 1;
                         }
-                    } elsif (ref($confhash{$itemid}{$field}) eq 'ARRAY') {
-                        if (@{$confhash{$itemid}{$field}} > 0) {
-                            $changes{$itemid} = 1;
-                        }
-                    } 
+                    }
                 }
-            }
-            unless ($changes{$itemid}) {
-                if (ref($domconfig{$action}{$itemid}{'maproles'}) eq 'HASH') {
-                    if (ref($confhash{$itemid}{'maproles'}) eq 'HASH') {
-                        foreach my $ltirole (keys(%{$domconfig{$action}{$itemid}{'maproles'}})) {
-                            if ($domconfig{$action}{$itemid}{'maproles'}{$ltirole} ne 
-                                $confhash{$itemid}{'maproles'}{$ltirole}) {
+                foreach my $field ('makeuser','mapcrstype','selfenroll','instdata','lcmenu') {
+                    unless ($changes{$itemid}) {
+                        if (ref($domconfig{$action}{$itemid}{$field}) eq 'ARRAY') {
+                            if (ref($confhash{$itemid}{$field}) eq 'ARRAY') {
+                                my @diffs = &Apache::loncommon::compare_arrays($domconfig{$action}{$itemid}{$field},
+                                                                               $confhash{$itemid}{$field});
+                                if (@diffs) {
+                                    $changes{$itemid} = 1;
+                                }
+                            } elsif (@{$domconfig{$action}{$itemid}{$field}} > 0) {
+                                $changes{$itemid} = 1;
+                            }
+                        } elsif (ref($confhash{$itemid}{$field}) eq 'ARRAY') {
+                            if (@{$confhash{$itemid}{$field}} > 0) {
                                 $changes{$itemid} = 1;
-                                last;
                             }
                         }
-                        unless ($changes{$itemid}) {
-                            foreach my $ltirole (keys(%{$confhash{$itemid}{'maproles'}})) {
-                                if ($confhash{$itemid}{'maproles'}{$ltirole} ne 
-                                    $domconfig{$action}{$itemid}{'maproles'}{$ltirole}) {
+                    }
+                }
+                unless ($changes{$itemid}) {
+                    if (ref($domconfig{$action}{$itemid}{'maproles'}) eq 'HASH') {
+                        if (ref($confhash{$itemid}{'maproles'}) eq 'HASH') {
+                            foreach my $ltirole (keys(%{$domconfig{$action}{$itemid}{'maproles'}})) {
+                                if ($domconfig{$action}{$itemid}{'maproles'}{$ltirole} ne 
+                                    $confhash{$itemid}{'maproles'}{$ltirole}) {
                                     $changes{$itemid} = 1;
                                     last;
                                 }
                             }
-                        }
-                    } elsif (keys(%{$domconfig{$action}{$itemid}{'maproles'}}) > 0) {
-                        $changes{$itemid} = 1;
-                    }
-                } elsif (ref($confhash{$itemid}{'maproles'}) eq 'HASH') {
-                    unless ($changes{$itemid}) {
-                        if (keys(%{$confhash{$itemid}{'maproles'}}) > 0) {
+                            unless ($changes{$itemid}) {
+                                foreach my $ltirole (keys(%{$confhash{$itemid}{'maproles'}})) {
+                                    if ($confhash{$itemid}{'maproles'}{$ltirole} ne 
+                                        $domconfig{$action}{$itemid}{'maproles'}{$ltirole}) {
+                                        $changes{$itemid} = 1;
+                                        last;
+                                    }
+                                }
+                            }
+                        } elsif (keys(%{$domconfig{$action}{$itemid}{'maproles'}}) > 0) {
                             $changes{$itemid} = 1;
                         }
+                    } elsif (ref($confhash{$itemid}{'maproles'}) eq 'HASH') {
+                        unless ($changes{$itemid}) {
+                            if (keys(%{$confhash{$itemid}{'maproles'}}) > 0) {
+                                $changes{$itemid} = 1;
+                            }
+                        }
                     }
                 }
             }
@@ -12041,122 +12090,124 @@ sub modify_lti {
                         my $num = length($encconfig{$itemid}{'secret'});
                         $resulttext .= ('*'x$num).'</li>';
                     }
-                    if ($confhash{$itemid}{'mapuser'}) {
-                        my $shownmapuser;
-                        if ($confhash{$itemid}{'mapuser'} eq 'lis_person_sourcedid') {
-                            $shownmapuser = $lt{'sourcedid'}.' (lis_person_sourcedid)';
-                        } elsif ($confhash{$itemid}{'mapuser'} eq 'lis_person_contact_email_primary') {
-                            $shownmapuser = $lt{'email'}.' (lis_person_contact_email_primary)';
-                        } else {
-                            $shownmapuser = &mt('Other').' ('.$confhash{$itemid}{'mapuser'}.')';
-                        } 
-                        $resulttext .= '<li>'.&mt('LON-CAPA username').': '.$shownmapuser.'</li>';
-                    }
-                    if (ref($confhash{$itemid}{'maproles'}) eq 'HASH') {
-                        my $rolemaps;
-                        foreach my $role (@ltiroles) {
-                            if ($confhash{$itemid}{'maproles'}{$role}) {
-                                $rolemaps .= ('&nbsp;'x2).$role.'='.
-                                             &Apache::lonnet::plaintext($confhash{$itemid}{'maproles'}{$role},
-                                                                        'Course').',';
+                    if ($confhash{$itemid}{'requser'}) {
+                        if ($confhash{$itemid}{'mapuser'}) {
+                            my $shownmapuser;
+                            if ($confhash{$itemid}{'mapuser'} eq 'lis_person_sourcedid') {
+                                $shownmapuser = $lt{'sourcedid'}.' (lis_person_sourcedid)';
+                            } elsif ($confhash{$itemid}{'mapuser'} eq 'lis_person_contact_email_primary') {
+                                $shownmapuser = $lt{'email'}.' (lis_person_contact_email_primary)';
+                            } else {
+                                $shownmapuser = &mt('Other').' ('.$confhash{$itemid}{'mapuser'}.')';
                             }
+                            $resulttext .= '<li>'.&mt('LON-CAPA username').': '.$shownmapuser.'</li>';
                         }
-                        if ($rolemaps) {
-                            $rolemaps =~ s/,$//;
-                            $resulttext .= '<li>'.&mt('Role mapping:').$rolemaps.'</li>';
-                        }
-                    }
-                    if (ref($confhash{$itemid}{'makeuser'}) eq 'ARRAY') {
-                        if (@{$confhash{$itemid}{'makeuser'}} > 0) { 
-                            $resulttext .= '<li>'.&mt('Following roles may create user accounts: [_1]',
-                                                      join(', ',@{$confhash{$itemid}{'makeuser'}})).'<br />';
-                            if ($confhash{$itemid}{'lcauth'} eq 'lti') {
-                                $resulttext .= &mt('New users will only be able to authenticate via LTI').'</li>';
-                            } else {
-                                $resulttext .= &mt('New users will be assigned LON-CAPA authentication: [_1]',
-                                                   $confhash{$itemid}{'lcauth'});
-                                if ($confhash{$itemid}{'lcauth'} eq 'internal') {
-                                    $resulttext .= '; '.&mt('a randomly generated password will be created');
-                                } elsif ($confhash{$itemid}{'lcauth'} eq 'localauth') {
-                                    if ($confhash{$itemid}{'lcauthparm'} ne '') {
-                                        $resulttext .= ' '.&mt('with argument: [_1]',$confhash{$itemid}{'lcauthparm'});
-                                    }
+                        if (ref($confhash{$itemid}{'maproles'}) eq 'HASH') {
+                            my $rolemaps;
+                            foreach my $role (@ltiroles) {
+                                if ($confhash{$itemid}{'maproles'}{$role}) {
+                                    $rolemaps .= ('&nbsp;'x2).$role.'='.
+                                                 &Apache::lonnet::plaintext($confhash{$itemid}{'maproles'}{$role},
+                                                                            'Course').',';
+                                }
+                            }
+                            if ($rolemaps) {
+                                $rolemaps =~ s/,$//;
+                                $resulttext .= '<li>'.&mt('Role mapping:').$rolemaps.'</li>';
+                            }
+                        }
+                        if (ref($confhash{$itemid}{'makeuser'}) eq 'ARRAY') {
+                            if (@{$confhash{$itemid}{'makeuser'}} > 0) { 
+                                $resulttext .= '<li>'.&mt('Following roles may create user accounts: [_1]',
+                                                          join(', ',@{$confhash{$itemid}{'makeuser'}})).'<br />';
+                                if ($confhash{$itemid}{'lcauth'} eq 'lti') {
+                                    $resulttext .= &mt('New users will only be able to authenticate via LTI').'</li>';
                                 } else {
-                                    $resulttext .= '; '.&mt('Kerberos domain: [_1]',$confhash{$itemid}{'lcauthparm'});
+                                    $resulttext .= &mt('New users will be assigned LON-CAPA authentication: [_1]',
+                                                       $confhash{$itemid}{'lcauth'});
+                                    if ($confhash{$itemid}{'lcauth'} eq 'internal') {
+                                        $resulttext .= '; '.&mt('a randomly generated password will be created');
+                                    } elsif ($confhash{$itemid}{'lcauth'} eq 'localauth') {
+                                        if ($confhash{$itemid}{'lcauthparm'} ne '') {
+                                            $resulttext .= ' '.&mt('with argument: [_1]',$confhash{$itemid}{'lcauthparm'});
+                                        }
+                                    } else {
+                                        $resulttext .= '; '.&mt('Kerberos domain: [_1]',$confhash{$itemid}{'lcauthparm'});
+                                    }
                                 }
+                                $resulttext .= '</li>';
+                            } else {
+                                $resulttext .= '<li>'.&mt('User account creation not permitted.').'</li>';
                             }
-                            $resulttext .= '</li>';
-                        } else {
-                            $resulttext .= '<li>'.&mt('User account creation not permitted.').'</li>';
                         }
-                    }
-                    if (ref($confhash{$itemid}{'instdata'}) eq 'ARRAY') {
-                        if (@{$confhash{$itemid}{'instdata'}} > 0) {
-                            $resulttext .= '<li>'.&mt('Institutional data will be used when creating a new user for: [_1]',
-                                                      join(', ',map { $fieldtitles{$_}; } @{$confhash{$itemid}{'instdata'}})).'</li>';
-                        } else {
-                            $resulttext .= '<li>'.&mt('No institutional data used when creating a new user.').'</li>';
+                        if (ref($confhash{$itemid}{'instdata'}) eq 'ARRAY') {
+                            if (@{$confhash{$itemid}{'instdata'}} > 0) {
+                                $resulttext .= '<li>'.&mt('Institutional data will be used when creating a new user for: [_1]',
+                                                          join(', ',map { $fieldtitles{$_}; } @{$confhash{$itemid}{'instdata'}})).'</li>';
+                            } else {
+                                $resulttext .= '<li>'.&mt('No institutional data used when creating a new user.').'</li>';
+                            }
                         }
-                    }
-                    if ($confhash{$itemid}{'mapcrs'}) {
-                        $resulttext .= '<li>'.&mt('Unique course identifier').': '.$confhash{$itemid}{'mapcrs'}.'</li>';
-                    }
-                    if (ref($confhash{$itemid}{'mapcrstype'}) eq 'ARRAY') {
-                        if (@{$confhash{$itemid}{'mapcrstype'}} > 0) {
-                            $resulttext .= '<li>'.&mt('Mapping for the following LON-CAPA course types: [_1]',
-                                           join(', ',map { $coursetypetitles{$_}; } @coursetypes)).
-                                           '</li>';
-                        } else {
-                            $resulttext .= '<li>'.&mt('No mapping to LON-CAPA courses').'</li>';
+                        if ($confhash{$itemid}{'mapcrs'}) {
+                            $resulttext .= '<li>'.&mt('Unique course identifier').': '.$confhash{$itemid}{'mapcrs'}.'</li>';
                         }
-                    }
-                    if ($confhash{$itemid}{'makecrs'}) {
-                        $resulttext .= '<li>'.&mt('Instructor may create course (if absent).').'</li>';
-                    } else {
-                        $resulttext .= '<li>'.&mt('Instructor may not create course (if absent).').'</li>';
-                    }
-                    if (ref($confhash{$itemid}{'selfenroll'}) eq 'ARRAY') {
-                        if (@{$confhash{$itemid}{'selfenroll'}} > 0) {
-                            $resulttext .= '<li>'.&mt('Self-enrollment for following roles: [_1]',
-                                                      join(', ',@{$confhash{$itemid}{'selfenroll'}})).
-                                           '</li>';
+                        if (ref($confhash{$itemid}{'mapcrstype'}) eq 'ARRAY') {
+                            if (@{$confhash{$itemid}{'mapcrstype'}} > 0) {
+                                $resulttext .= '<li>'.&mt('Mapping for the following LON-CAPA course types: [_1]',
+                                               join(', ',map { $coursetypetitles{$_}; } @coursetypes)).
+                                               '</li>';
+                            } else {
+                                $resulttext .= '<li>'.&mt('No mapping to LON-CAPA courses').'</li>';
+                            }
+                        }
+                        if ($confhash{$itemid}{'makecrs'}) {
+                            $resulttext .= '<li>'.&mt('Instructor may create course (if absent).').'</li>';
                         } else {
-                            $resulttext .= '<li>'.&mt('Self-enrollment not permitted').'</li>';
+                            $resulttext .= '<li>'.&mt('Instructor may not create course (if absent).').'</li>';
                         }
-                    }
-                    if ($confhash{$itemid}{'section'}) {
-                        if ($confhash{$itemid}{'section'} eq 'course_section_sourcedid') {
-                            $resulttext .= '<li>'.&mt('User section from standard field:').
-                                                 ' (course_section_sourcedid)'.'</li>';  
+                        if (ref($confhash{$itemid}{'selfenroll'}) eq 'ARRAY') {
+                            if (@{$confhash{$itemid}{'selfenroll'}} > 0) {
+                                $resulttext .= '<li>'.&mt('Self-enrollment for following roles: [_1]',
+                                                          join(', ',@{$confhash{$itemid}{'selfenroll'}})).
+                                               '</li>';
+                            } else {
+                                $resulttext .= '<li>'.&mt('Self-enrollment not permitted').'</li>';
+                            }
+                        }
+                        if ($confhash{$itemid}{'section'}) {
+                            if ($confhash{$itemid}{'section'} eq 'course_section_sourcedid') {
+                                $resulttext .= '<li>'.&mt('User section from standard field:').
+                                                     ' (course_section_sourcedid)'.'</li>';  
+                            } else {
+                                $resulttext .= '<li>'.&mt('User section from:').' '.
+                                                      $confhash{$itemid}{'section'}.'</li>';
+                            }
                         } else {
-                            $resulttext .= '<li>'.&mt('User section from:').' '.
-                                                  $confhash{$itemid}{'section'}.'</li>';
+                            $resulttext .= '<li>'.&mt('No section assignment').'</li>';
                         }
-                    } else {
-                        $resulttext .= '<li>'.&mt('No section assignment').'</li>';
-                    }
-                    foreach my $item ('passback','roster','topmenu','inlinemenu') {
-                        $resulttext .= '<li>'.$lt{$item}.':&nbsp;';
-                        if ($confhash{$itemid}{$item}) {
-                            $resulttext .= &mt('Yes');
-                            if ($item eq 'passback') {
-                                if ($confhash{$itemid}{'passbackformat'} eq '1.0') {
-                                    $resulttext .= '&nbsp;('.&mt('Outcomes Extension (1.0)').')';
-                                } elsif ($confhash{$itemid}{'passbackformat'} eq '1.1') {
-                                    $resulttext .= '&nbsp;('.&mt('Outcomes Service (1.1)').')';
+                        foreach my $item ('passback','roster','topmenu','inlinemenu') {
+                            $resulttext .= '<li>'.$lt{$item}.':&nbsp;';
+                            if ($confhash{$itemid}{$item}) {
+                                $resulttext .= &mt('Yes');
+                                if ($item eq 'passback') {
+                                    if ($confhash{$itemid}{'passbackformat'} eq '1.0') {
+                                        $resulttext .= '&nbsp;('.&mt('Outcomes Extension (1.0)').')';
+                                    } elsif ($confhash{$itemid}{'passbackformat'} eq '1.1') {
+                                        $resulttext .= '&nbsp;('.&mt('Outcomes Service (1.1)').')';
+                                    }
                                 }
+                            } else {
+                                $resulttext .= &mt('No');
                             }
-                        } else {
-                            $resulttext .= &mt('No');
+                            $resulttext .= '</li>';
                         }
-                        $resulttext .= '</li>';
-                    }
-                    if (ref($confhash{$itemid}{'lcmenu'}) eq 'ARRAY') {
-                        if (@{$confhash{$itemid}{'lcmenu'}} > 0) {
-                            $resulttext .= '<li>'.&mt('Menu items:').' '.
-                                           join(', ', map { $menutitles{$_}; } (@{$confhash{$itemid}{'lcmenu'}})).'</li>'; 
-                        } else {
-                            $resulttext .= '<li>'.&mt('No menu items displayed in header or online menu').'</li>'; 
+                        if (ref($confhash{$itemid}{'lcmenu'}) eq 'ARRAY') {
+                            if (@{$confhash{$itemid}{'lcmenu'}} > 0) {
+                                $resulttext .= '<li>'.&mt('Menu items:').' '.
+                                               join(', ', map { $menutitles{$_}; } (@{$confhash{$itemid}{'lcmenu'}})).'</li>'; 
+                            } else {
+                                $resulttext .= '<li>'.&mt('No menu items displayed in header or online menu').'</li>'; 
+                            }
                         }
                     }
                     $resulttext .= '</ul></li>';