--- loncom/interface/domainprefs.pm	2007/11/10 03:51:46	1.32
+++ loncom/interface/domainprefs.pm	2008/01/01 18:48:17	1.38
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set domain-wide configuration settings
 #
-# $Id: domainprefs.pm,v 1.32 2007/11/10 03:51:46 raeburn Exp $
+# $Id: domainprefs.pm,v 1.38 2008/01/01 18:48:17 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -68,10 +68,10 @@ sub handler {
     my %domconfig =
       &Apache::lonnet::get_dom('configuration',['login','rolecolors',
                 'quotas','autoenroll','autoupdate','directorysrch',
-                'usercreation','contacts'],$dom);
+                'usercreation','usermodification','contacts'],$dom);
     my @prefs_order = ('rolecolors','login','quotas','autoenroll',
                        'autoupdate','directorysrch','contacts',
-                       'usercreation');
+                       'usercreation','usermodification');
     my %prefs = (
         'rolecolors' =>
                    { text => 'Default color schemes',
@@ -127,11 +127,21 @@ sub handler {
         'usercreation' => 
                   { text => 'User creation',
                     help => 'Domain_User_Creation',
-                    header => [{col1 => 'Setting',
-                                col2 => 'Value',},
+                    header => [{col1 => 'Format Rule Type',
+                                col2 => 'Format Rules in force'},
+                               {col1 => 'User account creation',
+                                col2 => 'Usernames which may be created',},
                                {col1 => 'Context',
                                 col2 => 'Assignable Authentication Types'}],
                   },
+        'usermodification' => 
+                  { text => 'User modification',
+                    help => 'Domain_User_Modification',
+                    header => [{col1 => 'Target user has role',
+                                col2 => 'User information updateable in author context'},
+                               {col1 => 'Target user has role',
+                                col2 => 'User information updateable in course context'}],
+                  },
     );
     my @roles = ('student','coordinator','author','admin');
     my @actions = &Apache::loncommon::get_env_multiple('form.actions');
@@ -271,11 +281,24 @@ sub handler {
               ' />  '.
               '<input type="button" value="uncheck all" '.
               'onclick="javascript:uncheckAll(document.pickactions.actions)"'.
-              ' /></p>');
+              ' /></p><div class="LC_left_float">');
+        my ($numitems,$midpoint,$seconddiv,$count); 
+        $numitems = @prefs_order;
+        $midpoint = int($numitems/2);
+        if ($numitems%2) {
+            $midpoint ++;
+        }
+        $count = 0;
         foreach my $item (@prefs_order) {
-            $r->print('<p><label><input type="checkbox" name="actions" value="'.$item.'" />&nbsp;'.$prefs{$item}->{'text'}.'</label></p>');
+            $r->print('<h4><label><input type="checkbox" name="actions" value="'.$item.'" />&nbsp;'.$prefs{$item}->{'text'}.'</label></h4>');
+            $count ++;
+            if ((!$seconddiv) && ($count >= $midpoint)) {
+                $r->print('</div>'."\n".'<div class="LC_left_float">'."\n");
+                $seconddiv = 1;
+            }
         }
-        $r->print('<h3>'.&mt('Display options').'</h3>'."\n".
+        $r->print('</div><div class="LC_clear_float_footer"></div><h3>'.
+                  &mt('Display options').'</h3>'."\n".
                   '<p><span class="LC_nobreak">'.&mt('Display using: ')."\n".
                   '<label><input type="radio" name="numcols" value="1">'.
                   &mt('one column').'</label>&nbsp;&nbsp;'.
@@ -306,6 +329,8 @@ sub process_changes {
         $output = &modify_directorysrch($dom,%domconfig);
     } elsif ($action eq 'usercreation') {
         $output = &modify_usercreation($dom,%domconfig);
+    } elsif ($action eq 'usermodification') {
+        $output = &modify_usermodification($dom,%domconfig);
     } elsif ($action eq 'contacts') {
         $output = &modify_contacts($dom,%domconfig);
     }
@@ -327,7 +352,7 @@ sub print_config_box {
 #          </tr>');
     $rowtotal ++;
     if (($action eq 'autoupdate') || ($action eq 'rolecolors') || 
-        ($action eq 'usercreation')) {
+        ($action eq 'usercreation') || ($action eq 'usermodification')) {
         my $colspan = ($action eq 'rolecolors')?' colspan="2"':'';
         $output .= '
           <tr>
@@ -341,7 +366,9 @@ sub print_config_box {
         if ($action eq 'autoupdate') {
             $output .= &print_autoupdate('top',$dom,$settings,\$rowtotal);
         } elsif ($action eq 'usercreation') {
-            $output .= &print_usercreation('top',$dom,$settings,\$rowtotal); 
+            $output .= &print_usercreation('top',$dom,$settings,\$rowtotal);
+        } elsif ($action eq 'usermodification') {
+            $output .= &print_usermodification('top',$dom,$settings,\$rowtotal);
         } else {
             $output .= &print_rolecolors($phase,'student',$dom,$confname,$settings,\$rowtotal);
         }
@@ -360,7 +387,20 @@ sub print_config_box {
         if ($action eq 'autoupdate') {
             $output .= &print_autoupdate('bottom',$dom,$settings,\$rowtotal);
         } elsif ($action eq 'usercreation') {
-            $output .= &print_usercreation('bottom',$dom,$settings,\$rowtotal);
+            $output .= &print_usercreation('middle',$dom,$settings,\$rowtotal).'
+           </table>
+          </td>
+         </tr>
+         <tr>
+           <td>
+            <table class="LC_nested">
+             <tr class="LC_info_row">
+              <td class="LC_left_item"'.$colspan.'>'.$item->{'header'}->[2]->{'col1'}.'</td>
+              <td class="LC_right_item">'.$item->{'header'}->[2]->{'col2'}.'</td>             </tr>'.
+            &print_usercreation('bottom',$dom,$settings,\$rowtotal);
+            $rowtotal ++;
+        } elsif ($action eq 'usermodification') {
+            $output .= &print_usermodification('bottom',$dom,$settings,\$rowtotal);
         } else {
             $output .= &print_rolecolors($phase,'coordinator',$dom,$confname,$settings,\$rowtotal).'
            </table>
@@ -1056,14 +1096,7 @@ sub print_autoupdate {
         my ($othertitle,$usertypes,$types) = &sorted_inst_types($dom);
         my @fields = ('lastname','firstname','middlename','gen',
                       'permanentemail','id');
-        my %fieldtitles = &Apache::lonlocal::texthash (
-                            id => 'Student/Employee ID',
-                            permanentemail => 'E-mail address',
-                            lastname => 'Last Name',
-                            firstname => 'First Name',
-                            middlename => 'Middle Name',
-                            gen => 'Generation',
-                      );
+        my %fieldtitles = &Apache::loncommon::personal_data_fieldtitles();
         my $numrows = 0;
         if (ref($types) eq 'ARRAY') {
             if (@{$types} > 0) {
@@ -1290,33 +1323,10 @@ sub print_usercreation {
     my ($position,$dom,$settings,$rowtotal) = @_;
     my $numinrow = 4;
     my $datatable;
-    my %lt = &Apache::lonlocal::texthash (
-                        nondc => 'User creation other than by Domain Coordinator: ',
-                        author => 'When adding a co-author/assistant author',
-                        course => 'When adding users to a course',
-    );
     if ($position eq 'top') {
-        my %checked;
-        if (ref($settings) eq 'HASH') {
-            if (ref($settings->{'cancreate'}) eq 'ARRAY') {
-                foreach my $item (@{$settings->{'cancreate'}}) {
-                    $checked{$item} = ' checked="checked" ';
-                }
-            }
-        }
-        $datatable = '<tr class="LC_odd_row">'.
-                     '<td><span class="LC_nobreak">'.$lt{'nondc'}.
-                     '</span></td><td class="LC_left_item"><table>';
-        foreach my $item ('author','course') {
-            $datatable .= '<tr><td><span class="LC_nobreak"><label>'.
-                          '<input type="checkbox" name="can_createuser" '.
-                          $checked{$item}.' value="'.$item.'" />'.
-                          $lt{$item}.'</label><span></td></tr>';
-        }
-        $datatable .= '</table></td></tr>';
         $$rowtotal ++;
-        my ($rules,$ruleorder) = &Apache::lonnet::inst_userrules($dom,'username');
         my $rowcount = 0;
+        my ($rules,$ruleorder) = &Apache::lonnet::inst_userrules($dom,'username');
         if (ref($rules) eq 'HASH') {
             if (keys(%{$rules}) > 0) {
                 $datatable .= &user_formats_row('username',$settings,$rules,
@@ -1334,6 +1344,59 @@ sub print_usercreation {
                 $rowcount ++;
             }
         }
+    } elsif ($position eq 'middle') {
+        my @creators = ('author','course');
+        my ($rules,$ruleorder) =
+            &Apache::lonnet::inst_userrules($dom,'username');
+        my %lt = &usercreation_types();
+        my %checked;
+        if (ref($settings) eq 'HASH') {
+            if (ref($settings->{'cancreate'}) eq 'HASH') {
+                foreach my $item (@creators) {
+                    $checked{$item} = $settings->{'cancreate'}{$item};
+                }
+            } elsif (ref($settings->{'cancreate'}) eq 'ARRAY') {
+                foreach my $item (@creators) {
+                    if (grep(/^\Q$item\E$/,@{$settings->{'cancreate'}})) {
+                        $checked{$item} = 'none';
+                    }
+                }
+            }
+        }
+        my $rownum = 0;
+        foreach my $item (@creators) {
+            $rownum ++;
+            if ($checked{$item} eq '') {
+                $checked{$item} = 'any';
+            }
+            my $css_class;
+            if ($rownum%2) {
+                $css_class = '';
+            } else {
+                $css_class = ' class="LC_odd_row" ';
+            }
+            $datatable .= '<tr'.$css_class.'>'.
+                         '<td><span class="LC_nobreak">'.$lt{$item}.
+                         '</span></td><td align="right">';
+            my @options = ('any');
+            if (ref($rules) eq 'HASH') {
+                if (keys(%{$rules}) > 0) {
+                    push(@options,('official','unofficial'));
+                }
+            }
+            push(@options,'none');
+            foreach my $option (@options) {
+                my $check = ' ';
+                if ($checked{$item} eq $option) {
+                    $check = ' checked="checked" ';
+                } 
+                $datatable .= '<span class="LC_nobreak"><label>'.
+                              '<input type="radio" name="can_createuser_'.
+                              $item.'" value="'.$option.'"'.$check.'/>&nbsp;'.
+                              $lt{$option}.'</label>&nbsp;&nbsp;</span>';
+            }
+            $datatable .= '</td></tr>';
+        }
     } else {
         my @contexts = ('author','course','domain');
         my @authtypes = ('int','krb4','krb5','loc');
@@ -1350,8 +1413,13 @@ sub print_usercreation {
                     }
                 }
             }
+        } else {
+            foreach my $item (@contexts) {
+                foreach my $auth (@authtypes) {
+                    $checked{$item}{$auth} = ' checked="checked" ';
+                }
+            }
         }
-        my @authtypes = ('int','krb4','krb5','loc');
         my %title = &context_names();
         my %authname = &authtype_names();
         my $rownum = 0;
@@ -1430,6 +1498,18 @@ sub user_formats_row {
     return $output;
 }
 
+sub usercreation_types {
+    my %lt = &Apache::lonlocal::texthash (
+                    author     => 'When adding a co-author',
+                    course     => 'When adding a user to a course',
+                    any        => 'Any',
+                    official   => 'Institutional only ',
+                    unofficial => 'Non-institutional only',
+                    none       => 'None',
+    );
+    return %lt;
+} 
+
 sub authtype_names {
     my %lt = &Apache::lonlocal::texthash(
                       int    => 'Internal',
@@ -1449,6 +1529,96 @@ sub context_names {
     return %context_title;
 }
 
+sub print_usermodification {
+    my ($position,$dom,$settings,$rowtotal) = @_;
+    my $numinrow = 4;
+    my ($context,$datatable,$rowcount);
+    if ($position eq 'top') {
+        $rowcount = 0;
+        $context = 'author'; 
+        foreach my $role ('ca','aa') {
+            $datatable .= &modifiable_userdata_row($context,$role,$settings,
+                                                   $numinrow,$rowcount);
+            $$rowtotal ++;
+            $rowcount ++;
+        }
+    } else {
+        $context = 'course';
+        $rowcount = 0;
+        foreach my $role ('st','ep','ta','in','cr') {
+            $datatable .= &modifiable_userdata_row($context,$role,$settings,
+                                                   $numinrow,$rowcount);
+            $$rowtotal ++;
+            $rowcount ++;
+        }
+    }
+    return $datatable;
+}
+
+sub modifiable_userdata_row {
+    my ($context,$role,$settings,$numinrow,$rowcount) = @_;
+    my $rolename;
+    if ($role eq 'cr') {
+        $rolename = &mt('Custom role');
+    } else {
+        $rolename = &Apache::lonnet::plaintext($role);
+    }
+    my @fields = ('lastname','firstname','middlename','generation',
+                  'permanentemail','id');
+    my %fieldtitles = &Apache::loncommon::personal_data_fieldtitles();
+    my $output;
+    my $css_class = $rowcount%2?' class="LC_odd_row"':'';
+    $output = '<tr '.$css_class.'>'.
+              '<td><span class="LC_nobreak">'.$rolename.'</span></td>'.
+              '<td class="LC_left_item" colspan="2"><table>';
+    my $rem;
+    my %checks;
+    if (ref($settings) eq 'HASH') {
+        if (ref($settings->{$context}) eq 'HASH') {
+            if (ref($settings->{$context}->{$role}) eq 'HASH') {
+                foreach my $field (@fields) {
+                    if ($settings->{$context}->{$role}->{$field}) {
+                        $checks{$field} = ' checked="checked" ';
+                    }
+                }
+            }
+        }
+    }
+    for (my $i=0; $i<@fields; $i++) {
+        my $rem = $i%($numinrow);
+        if ($rem == 0) {
+            if ($i > 0) {
+                $output .= '</tr>';
+            }
+            $output .= '<tr>';
+        }
+        my $check = ' ';
+        if (exists($checks{$fields[$i]})) {
+            $check = $checks{$fields[$i]}
+        } else {
+            if ($role eq 'st') {
+                if (ref($settings) ne 'HASH') {
+                    $check = ' checked="checked" '; 
+                }
+            }
+        }
+        $output .= '<td class="LC_left_item">'.
+                   '<span class="LC_nobreak"><label>'.
+                   '<input type="checkbox" name="canmodify_'.$role.'" '.
+                   'value="'.$fields[$i].'"'.$check.'/>'.$fieldtitles{$fields[$i]}.
+                   '</label></span></td>';
+        $rem = @fields%($numinrow);
+    }
+    my $colsleft = $numinrow - $rem;
+    if ($colsleft > 1 ) {
+        $output .= '<td colspan="'.$colsleft.'" class="LC_left_item">'.
+                   '&nbsp;</td>';
+    } elsif ($colsleft == 1) {
+        $output .= '<td class="LC_left_item">&nbsp;</td>';
+    }
+    $output .= '</tr></table></td></tr>';
+    return $output;
+}
 
 sub users_cansearch_row {
     my ($settings,$types,$usertypes,$dom,$numinrow,$othertitle) = @_;
@@ -1961,7 +2131,7 @@ sub check_configuser {
 sub check_authorstatus {
     my ($dom,$confname,%currroles) = @_;
     my $author_ok;
-    if (!$currroles{':'.$dom.':au'}) {
+    if (!$currroles{$confname.':'.$dom.':au'}) {
         my $start = time;
         my $end = 0;
         $author_ok = 
@@ -2723,7 +2893,7 @@ sub modify_contacts {
             }
             $resulttext .= '</ul>';
         } else {
-            $resulttext = &mt('No changes made to contact information.');
+            $resulttext = &mt('No changes made to contact information');
         }
     } else {
         $resulttext = '<span class="LC_error">'.
@@ -2734,7 +2904,7 @@ sub modify_contacts {
 
 sub modify_usercreation {
     my ($dom,%domconfig) = @_;
-    my ($resulttext,%curr_usercreation,%changes,%authallowed);
+    my ($resulttext,%curr_usercreation,%changes,%authallowed,%cancreate);
     if (ref($domconfig{'usercreation'}) eq 'HASH') {
         foreach my $key (keys(%{$domconfig{'usercreation'}})) {
             $curr_usercreation{$key} = $domconfig{'usercreation'}{$key};
@@ -2746,21 +2916,34 @@ sub modify_usercreation {
                 );
     my @username_rule = &Apache::loncommon::get_env_multiple('form.username_rule');
     my @id_rule = &Apache::loncommon::get_env_multiple('form.id_rule');
-    my @cancreate = &Apache::loncommon::get_env_multiple('form.can_createuser');
-    if (ref($curr_usercreation{'cancreate'}) eq 'ARRAY') {
-        foreach my $type (@{$curr_usercreation{'cancreate'}}) {
-            if (!grep(/^\Q$type\E$/,@cancreate)) {
-                push(@{$changes{'cancreate'}},$type);
-            }
+    my @contexts = ('author','course');
+    foreach my $item(@contexts) {
+        $cancreate{$item} = $env{'form.can_createuser_'.$item};
+    }
+    if (ref($curr_usercreation{'cancreate'}) eq 'HASH') {
+        foreach my $item (@contexts) {
+            if ($curr_usercreation{'cancreate'}{$item} ne $cancreate{$item}) {
+                push(@{$changes{'cancreate'}},$item);
+            } 
         }
-        foreach my $type (@cancreate) {
-            if (!grep(/^\Q$type\E$/,@{$curr_usercreation{'cancreate'}})) {
-                push(@{$changes{'cancreate'}},$type);
+    } elsif (ref($curr_usercreation{'cancreate'}) eq 'ARRAY') {
+        foreach my $item (@contexts) {
+            if (grep(/^\Q$item\E$/,@{$curr_usercreation{'cancreate'}})) {
+                if ($cancreate{$item} ne 'any') {
+                    push(@{$changes{'cancreate'}},$item);
+                }
+            } else {
+                if ($cancreate{$item} ne 'none') {
+                    push(@{$changes{'cancreate'}},$item);
+                }
             }
         }
     } else {
-        push(@{$changes{'cancreate'}},@cancreate);
+        foreach my $item ('author','course') {
+            push(@{$changes{'cancreate'}},$item);
+        }
     }
+
     if (ref($curr_usercreation{'username_rule'}) eq 'ARRAY') {
         foreach my $type (@{$curr_usercreation{'username_rule'}}) {
             if (!grep(/^\Q$type\E$/,@username_rule)) {
@@ -2823,7 +3006,7 @@ sub modify_usercreation {
 
     my %usercreation_hash =  (
             usercreation => {
-                              cancreate     => \@cancreate,
+                              cancreate     => \%cancreate,
                               username_rule => \@username_rule,
                               id_rule       => \@id_rule,
                               authtypes     => \%authhash,
@@ -2836,15 +3019,19 @@ sub modify_usercreation {
         if (keys(%changes) > 0) {
             $resulttext = &mt('Changes made:').'<ul>';
             if (ref($changes{'cancreate'}) eq 'ARRAY') {
-                my $chgtext = '<ul>';
-                foreach my $type (@cancreate) {
-                    $chgtext .= '<li>'.$title{$type}.'</li>';
-                }
-                $chgtext .= '</ul>';
-                if (@cancreate > 0) {
-                    $resulttext .= '<li>'.&mt('Creation of new users is permitted by a Domain Coordinator, and also by other users when: ').$chgtext.'</li>';
-                } else {
-                    $resulttext .= '<li>'.&mt("Creation of new users is now only allowed when the user's role is Domain Coordinator.").'</li>';
+                my %lt = &usercreation_types();
+                foreach my $type (@{$changes{'cancreate'}}) {
+                    my $chgtext; 
+                    if ($cancreate{$type} eq 'none') {
+                        $chgtext = $lt{$type}.' '.&mt('creation of new users is not permitted, except by a Domain Coordinator.');
+                    } elsif ($cancreate{$type} eq 'any') {
+                        $chgtext = $lt{$type}.' '.&mt('creation of new users is permitted for both institutional and non-institutional usernames.'); 
+                    } elsif ($cancreate{$type} eq 'official') {
+                        $chgtext = $lt{$type}.' '.&mt('creation of new users is only permitted for institutional usernames.',$lt{$type});
+                    } elsif ($cancreate{$type} eq 'unofficial') {
+                        $chgtext = $lt{$type}.' '.&mt('creation of new users is only permitted for non-institutional usernames.',$lt{$type});
+                    }
+                    $resulttext .= '<li>'.$chgtext.'</li>';
                 }
             }
             if (ref($changes{'username_rule'}) eq 'ARRAY') {
@@ -2882,7 +3069,6 @@ sub modify_usercreation {
             my %authname = &authtype_names();
             my %context_title = &context_names();
             if (ref($changes{'authtypes'}) eq 'ARRAY') {
-                my @unchanged;
                 my $chgtext = '<ul>';
                 foreach my $type (@{$changes{'authtypes'}}) {
                     my @allowed;
@@ -2904,6 +3090,106 @@ sub modify_usercreation {
         }
     } else {
         $resulttext = '<span class="LC_error">'.
+            &mt('An error occurred: [_1]',$putresult).'</span>';
+    }
+    return $resulttext;
+}
+
+sub modify_usermodification {
+    my ($dom,%domconfig) = @_;
+    my ($resulttext,%curr_usermodification,%changes);
+    if (ref($domconfig{'usermodification'}) eq 'HASH') {
+        foreach my $key (keys(%{$domconfig{'usermodification'}})) {
+            $curr_usermodification{$key} = $domconfig{'usermodification'}{$key};
+        }
+    }
+    my @contexts = ('author','course');
+    my %context_title = (
+                           author => 'In author context',
+                           course => 'In course context',
+                        );
+    my @fields = ('lastname','firstname','middlename','generation',
+                  'permanentemail','id');
+    my %roles = (
+                  author => ['ca','aa'],
+                  course => ['st','ep','ta','in','cr'],
+                );
+    my %fieldtitles = &Apache::loncommon::personal_data_fieldtitles();
+    my %modifyhash;
+    foreach my $context (@contexts) {
+        foreach my $role (@{$roles{$context}}) {
+            my @modifiable =  &Apache::loncommon::get_env_multiple('form.canmodify_'.$role);
+            foreach my $item (@fields) {
+                if (grep(/^\Q$item\E$/,@modifiable)) {
+                    $modifyhash{$context}{$role}{$item} = 1;
+                } else {
+                    $modifyhash{$context}{$role}{$item} = 0;
+                }
+            }
+        }
+        if (ref($curr_usermodification{$context}) eq 'HASH') {
+            foreach my $role (@{$roles{$context}}) {
+                if (ref($curr_usermodification{$context}{$role}) eq 'HASH') {
+                    foreach my $field (@fields) {
+                        if ($modifyhash{$context}{$role}{$field} ne 
+                                $curr_usermodification{$context}{$role}{$field}) {
+                            push(@{$changes{$context}},$role);
+                            last;
+                        }
+                    }
+                }
+            }
+        } else {
+            foreach my $context (@contexts) {
+                foreach my $role (@{$roles{$context}}) {
+                    push(@{$changes{$context}},$role);
+                }
+            }
+        }
+    }
+    my %usermodification_hash =  (
+                                   usermodification => \%modifyhash,
+                                 );
+    my $putresult = &Apache::lonnet::put_dom('configuration',
+                                             \%usermodification_hash,$dom);
+    if ($putresult eq 'ok') {
+        if (keys(%changes) > 0) {
+            $resulttext = &mt('Changes made: ').'<ul>';
+            foreach my $context (@contexts) {
+                if (ref($changes{$context}) eq 'ARRAY') {
+                    $resulttext .= '<li>'.$context_title{$context}.':<ul>';
+                    if (ref($changes{$context}) eq 'ARRAY') {
+                        foreach my $role (@{$changes{$context}}) {
+                            my $rolename;
+                            if ($role eq 'cr') {
+                                $rolename = &mt('Custom');
+                            } else {
+                                $rolename = &Apache::lonnet::plaintext($role);
+                            }
+                            my @modifiable;
+                            $resulttext .= '<li><span class="LC_cusr_emph">'.&mt('Target user with [_1] role',$rolename).'</span> - '.&mt('modifiable fields: ');
+                            foreach my $field (@fields) {
+                                if ($modifyhash{$context}{$role}{$field}) {
+                                    push(@modifiable,$fieldtitles{$field});
+                                }
+                            }
+                            if (@modifiable > 0) {
+                                $resulttext .= join(', ',@modifiable);
+                            } else {
+                                $resulttext .= &mt('none'); 
+                            }
+                            $resulttext .= '</li>';
+                        }
+                        $resulttext .= '</ul></li>';
+                    }
+                }
+            }
+            $resulttext .= '</ul>';
+        } else {
+            $resulttext = &mt('No changes made to user modification settings');
+        }
+    } else {
+        $resulttext = '<span class="LC_error">'.
             &mt('An error occurred: [_1]',$putresult).'</span>';
     }
     return $resulttext;