--- loncom/interface/loncommon.pm	2011/05/03 23:51:18	1.1004
+++ loncom/interface/loncommon.pm	2011/05/27 22:58:13	1.1007
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # a pile of common routines
 #
-# $Id: loncommon.pm,v 1.1004 2011/05/03 23:51:18 www Exp $
+# $Id: loncommon.pm,v 1.1007 2011/05/27 22:58:13 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -443,10 +443,10 @@ sub resourcebrowser_javascript {
 // <![CDATA[
     var reseditbrowser;
     function openresbrowser(formname,reslink) {
-        var url = '/adm/pickresource?form='+formname+'&reslink='.reslink;
+        var url = '/adm/pickresource?form='+formname+'&reslink='+reslink;
         var title = 'Resource_Browser';
         var options = 'scrollbars=1,resizable=1,menubar=0';
-        options += ',width=700,height=600';
+        options += ',width=700,height=500';
         reseditbrowser = open(url,title,options,'1');
         reseditbrowser.focus();
     }
@@ -8929,7 +8929,7 @@ sub modify_html_refs {
                 if ($allfiles{$ref}) {
                     my $newname =  $orig;
                     my ($attrib_regexp,$codebase);
-                    my $attrib_regexp = &unescape($env{'form.embedded_attrib_'.$i});
+                    $attrib_regexp = &unescape($env{'form.embedded_attrib_'.$i});
                     if ($attrib_regexp =~ /:/) {
                         $attrib_regexp =~ s/\:/|/g;
                     }
@@ -8938,7 +8938,7 @@ sub modify_html_refs {
                         $count += $numchg;
                     }
                     if ($env{'form.embedded_codebase_'.$i} ne '') {
-                        my $codebase = &unescape($env{'form.embedded_codebase_'.$i});
+                        $codebase = &unescape($env{'form.embedded_codebase_'.$i});
                         my $numchg = ($content =~ s/(codebase\s*=\s*["']?)\Q$codebase\E(["']?)/$1.$2/i); #' stupid emacs
                         $codebasecount ++;
                     }
@@ -9007,7 +9007,7 @@ sub check_for_upload {
                   &mt('Unable to upload [_1]. (size = [_2] bytes)', 
                       '<span class="LC_filename">'.$fname.'</span>',
                       $filesize).'<br />'.
-                  &mt('Either the file you attempted to upload was empty, or your web browser was unable to read its contents.').'<br />';
+                  &mt('Either the file you attempted to upload was empty, or your web browser was unable to read its contents.').'<br />'.
                   '</span>';
         return ('zero_bytes',$msg);
     }