--- loncom/interface/loncommon.pm	2014/05/04 15:44:46	1.1075.2.71
+++ loncom/interface/loncommon.pm	2013/09/21 13:56:22	1.1156
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # a pile of common routines
 #
-# $Id: loncommon.pm,v 1.1075.2.71 2014/05/04 15:44:46 raeburn Exp $
+# $Id: loncommon.pm,v 1.1156 2013/09/21 13:56:22 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -69,14 +69,12 @@ use Apache::lontexconvert();
 use Apache::lonclonecourse();
 use Apache::lonuserutils();
 use Apache::lonuserstate();
-use Apache::courseclassifier();
 use LONCAPA qw(:DEFAULT :match);
 use DateTime::TimeZone;
 use DateTime::Locale::Catalog;
+use Text::Aspell;
 use Authen::Captcha;
 use Captcha::reCAPTCHA;
-use Crypt::DES;
-use DynaLoader; # for Crypt::DES version
 
 # ---------------------------------------------- Designs
 use vars qw(%defaultdesign);
@@ -161,6 +159,7 @@ sub ssi_with_retries {
 # ----------------------------------------------- Filetypes/Languages/Copyright
 my %language;
 my %supported_language;
+my %supported_codes;
 my %latex_language;		# For choosing hyphenation in <transl..>
 my %latex_language_bykey;	# for choosing hyphenation from metadata
 my %cprtag;
@@ -195,14 +194,15 @@ BEGIN {
             while (my $line = <$fh>) {
                 next if ($line=~/^\#/);
                 chomp($line);
-                my ($key,$two,$country,$three,$enc,$val,$sup,$latex)=(split(/\t/,$line));
+                my ($key,$code,$country,$three,$enc,$val,$sup,$latex)=(split(/\t/,$line));
                 $language{$key}=$val.' - '.$enc;
                 if ($sup) {
                     $supported_language{$key}=$sup;
+		    $supported_codes{$key}   = $code;
                 }
 		if ($latex) {
 		    $latex_language_bykey{$key} = $latex;
-		    $latex_language{$two} = $latex;
+		    $latex_language{$code} = $latex;
 		}
             }
             close($fh);
@@ -666,7 +666,7 @@ if (!Array.prototype.indexOf) {
         var n = 0;
         if (arguments.length > 0) {
             n = Number(arguments[1]);
-            if (n !== n) { // shortcut for verifying if it's NaN
+            if (n !== n) { // shortcut for verifying if it is NaN
                 n = 0;
             } else if (n !== 0 && n !== (1 / 0) && n !== -(1 / 0)) {
                 n = (n > 0 || -1) * Math.floor(Math.abs(n));
@@ -902,12 +902,12 @@ sub check_uncheck_jscript {
 function checkAll(field) {
     if (field.length > 0) {
         for (i = 0; i < field.length; i++) {
-            if (!field[i].disabled) {
+            if (!field[i].disabled) { 
                 field[i].checked = true;
             }
         }
     } else {
-        if (!field.disabled) {
+        if (!field.disabled) { 
             field.checked = true;
         }
     }
@@ -1017,6 +1017,33 @@ sub select_language {
 
 =pod
 
+
+=item * &list_languages()
+
+Returns an array reference that is suitable for use in language prompters.
+Each array element is itself a two element array.  The first element
+is the language code.  The second element a descsriptiuon of the 
+language itself.  This is suitable for use in e.g.
+&Apache::edit::select_arg (once dereferenced that is).
+
+=cut 
+
+sub list_languages {
+    my @lang_choices;
+
+    foreach my $id (&languageids()) {
+	my $code = &supportedlanguagecode($id);
+	if ($code) {
+	    my $selector    = $supported_codes{$id};
+	    my $description = &plainlanguagedescription($id);
+	    push (@lang_choices, [$selector, $description]);
+	}
+    }
+    return \@lang_choices;
+}
+
+=pod
+
 =item * &linked_select_forms(...)
 
 linked_select_forms returns a string containing a <script></script> block
@@ -1237,11 +1264,7 @@ sub help_open_topic {
     $topic=~s/\W/\_/g;
 
     if (!$stayOnPage) {
-        if ($env{'browser.mobile'}) {
-	    $link = "javascript:openMyModal('/adm/help/${filename}.hlp',$width,$height,'yes');";
-        } else {
-            $link = "javascript:void(open('/adm/help/${filename}.hlp', 'Help_for_$topic', 'menubar=0,toolbar=1,scrollbars=1,width=$width,height=$height,resizable=yes'))";
-        }
+	$link = "javascript:openMyModal('/adm/help/${filename}.hlp',$width,$height,'yes');";
     } elsif ($stayOnPage eq 'popup') {
         $link = "javascript:void(open('/adm/help/${filename}.hlp', 'Help_for_$topic', 'menubar=0,toolbar=1,scrollbars=1,width=$width,height=$height,resizable=yes'))";
     } else {
@@ -1292,9 +1315,7 @@ sub helpLatexCheatsheet {
     unless ($not_author) {
         $out .= ' <span>'
 	       .&help_open_topic('Authoring_Output_Tags',&mt('Output Tags'),$stayOnPage,undef,600)
-	       .'</span> <span>'
-               .&help_open_topic('Authoring_Multilingual_Problems',&mt('How to create problems in different languages'),$stayOnPage,undef,600)
-               .'</span>';
+	       .'</span>';
     }
     $out .= '</span>'; # End cheatsheet
     return $out;
@@ -1357,25 +1378,18 @@ sub help_open_menu {
 sub top_nav_help {
     my ($text) = @_;
     $text = &mt($text);
-    my $stay_on_page;
-    unless ($env{'environment.remote'} eq 'on') {
-        $stay_on_page = 1;
-    }
-    my ($link,$banner_link);
-    unless ($env{'request.noversionuri'} =~ m{^/adm/helpmenu}) {
-        $link = ($stay_on_page) ? "javascript:helpMenu('display')"
-	                         : "javascript:helpMenu('open')";
-        $banner_link = &update_help_link(undef,undef,undef,undef,$stay_on_page);
-    }
+    my $stay_on_page = 1;
+
+    my $link = ($stay_on_page) ? "javascript:helpMenu('display')"
+	                     : "javascript:helpMenu('open')";
+    my $banner_link = &update_help_link(undef,undef,undef,undef,$stay_on_page);
+
     my $title = &mt('Get help');
-    if ($link) {
-        return <<"END";
+
+    return <<"END";
 $banner_link
-<a href="$link" title="$title">$text</a>
+ <a href="$link" title="$title">$text</a>
 END
-    } else {
-        return '&nbsp;'.$text.'&nbsp;';
-    }
 }
 
 sub help_menu_js {
@@ -1390,7 +1404,7 @@ sub help_menu_js {
         &Apache::loncommon::start_page('Help Menu', undef,
 				       {'frameset'    => 1,
 					'js_ready'    => 1,
-                                        'use_absolute' => $httphost, 
+                                        'use_absolute' => $httphost,
 					'add_entries' => {
 					    'border' => '0',
 					    'rows'   => "110,*",},});
@@ -1422,10 +1436,9 @@ function helpMenu(target) {
     return;
 }
 function writeHelp(caller) {
-    caller.document.writeln('$start_page\\n<frame name="bannerframe" src="'+banner_link+'" marginwidth="0" marginheight="0" frameborder="0">\\n');
-    caller.document.writeln('<frame name="bodyframe" src="$details_link" marginwidth="0" marginheight="0" frameborder="0">\\n$end_page');
-    caller.document.close();
-    caller.focus();
+    caller.document.writeln('$start_page\\n<frame name="bannerframe" src="'+banner_link+'" />\\n<frame name="bodyframe" src="$details_link" />\\n$end_page')
+    caller.document.close()
+    caller.focus()
 }
 // END LON-CAPA Internal -->
 // ]]>
@@ -1737,6 +1750,8 @@ RESIZE
 
 =head1 Excel and CSV file utility routines
 
+=over 4
+
 =cut
 
 ###############################################################
@@ -1744,8 +1759,6 @@ RESIZE
 
 =pod
 
-=over 4
-
 =item * &csv_translate($text) 
 
 Translate $text to allow it to be output as a 'comma separated values' 
@@ -2194,7 +2207,7 @@ The optional $onchange argument specifie
 
 The optional $incdoms is a reference to an array of domains which will be the only available options.
 
-The optional $excdoms is a reference to an array of domains which will be excluded from the available options. 
+The optional $excdoms is a reference to an array of domains which will be excluded from the available options.
 
 =cut
 
@@ -2212,7 +2225,7 @@ sub select_dom_form {
     }
     if ($includeempty) { @domains=('',@domains); }
     if (ref($excdoms) eq 'ARRAY') {
-        map { $exclude{$_} = 1; } @{$excdoms};
+        map { $exclude{$_} = 1; } @{$excdoms}; 
     }
     my $selectdomain = "<select name=\"$name\" size=\"1\"$onchange>\n";
     foreach my $dom (@domains) {
@@ -2559,7 +2572,7 @@ sub authform_nochange {
               kerb_def_dom => 'MSU.EDU',
               @_,
           );
-    my ($authnum,%can_assign) = &get_assignable_auth($in{'domain'}); 
+    my ($authnum,%can_assign) = &get_assignable_auth($in{'domain'});
     my $result;
     if (!$authnum) {
         $result = &mt('Under your current role you are not permitted to change login settings for this user');
@@ -3055,13 +3068,73 @@ sub get_related_words {
     untie %thesaurus_db;
     return @Words;
 }
+###############################################################
+#
+#  Spell checking
+#
 
 =pod
 
 =back
 
+=head1 Spell checking
+
+=over 4
+
+=item * &check_spelling($wordlist $language)
+
+Takes a string containing words and feeds it to an external
+spellcheck program via a pipeline. Returns a string containing
+them mis-spelled words.
+
+Parameters:
+
+=over 4
+
+=item - $wordlist
+
+String that will be fed into the spellcheck program.
+
+=item - $language
+
+Language string that specifies the language for which the spell
+check will be performed.
+
+=back
+
+=back
+
+Note: This sub assumes that aspell is installed.
+
+
 =cut
 
+
+sub check_spelling {
+    my ($wordlist, $language) = @_;
+    my @misspellings;
+    
+    # Generate the speller and set the langauge.
+    # if explicitly selected:
+
+    my $speller = Text::Aspell->new;
+    if ($language) {
+	$speller->set_option('lang', $language);
+    }
+
+    # Turn the word list into an array of words by splittingon whitespace
+
+    my @words = split(/\s+/, $wordlist);
+
+    foreach my $word (@words) {
+	if(! $speller->check($word)) {
+	    push(@misspellings, $word);
+	}
+    }
+    return join(' ', @misspellings);
+    
+}
+
 # -------------------------------------------------------------- Plaintext name
 =pod
 
@@ -5023,9 +5096,6 @@ Inputs:
 
 =item * $bgcolor, used to override the bgcolor on a webpage to a specific value
 
-=item * $no_inline_link, if true and in remote mode, don't show the
-         'Switch To Inline Menu' link
-
 =item * $args, optional argument valid values are
             no_auto_mt_title -> prevents &mt()ing the title arg
             inherit_jsmath -> when creating popup window in a page,
@@ -5047,7 +5117,7 @@ other decorations will be returned.
 
 sub bodytag {
     my ($title,$function,$addentries,$bodyonly,$domain,$forcereg,
-        $no_nav_bar,$bgcolor,$no_inline_link,$args,$advtoolsref)=@_;
+        $no_nav_bar,$bgcolor,$args,$advtoolsref)=@_;
 
     my $public;
     if ((($env{'user.name'} eq 'public') && ($env{'user.domain'} eq 'public'))
@@ -5071,10 +5141,7 @@ sub bodytag {
     @design{keys(%$addentries)} = @$addentries{keys(%$addentries)}; 
 
  # role and realm
-    my ($role,$realm) = split(m{\./},$env{'request.role'},2);
-    if ($realm) {
-        $realm = '/'.$realm;
-    }
+    my ($role,$realm) = split(/\./,$env{'request.role'},2);
     if ($role  eq 'ca') {
         my ($rdom,$rname) = ($realm =~ m{^/($match_domain)/($match_username)$});
         $realm = &plainname($rname,$rdom);
@@ -5124,23 +5191,7 @@ sub bodytag {
 
     $role = '<span class="LC_nobreak">('.$role.')</span>' if $role;
 
-    if ($env{'request.state'} eq 'construct') { $forcereg=1; }
-
-
-
-    my $funclist;
-    if (($env{'environment.remote'} eq 'on') && ($env{'request.state'} ne 'construct')) {
-        $bodytag .= Apache::lonhtmlcommon::scripttag(Apache::lonmenu::utilityfunctions($httphost), 'start')."\n".
-                    Apache::lonmenu::serverform();
-        my $forbodytag;
-        &Apache::lonmenu::prepare_functions($env{'request.noversionuri'},
-                                            $forcereg,$args->{'group'},
-                                            $args->{'bread_crumbs'},
-                                            $advtoolsref,'',\$forbodytag);
-        unless (ref($args->{'bread_crumbs'}) eq 'ARRAY') {
-            $funclist = $forbodytag;
-        }
-    } else {
+        if ($env{'request.state'} eq 'construct') { $forcereg=1; }
 
         #    if ($env{'request.state'} eq 'construct') {
         #        $titleinfo = &CSTR_pageheader(); #FIXME: Will be removed once all scripts have their own calls
@@ -5152,11 +5203,11 @@ sub bodytag {
         my ($left,$right) = Apache::lonmenu::primary_menu();
 
         if ($env{'request.noversionuri'} =~ m{^/res/adm/pages/}) {
-            if ($dc_info) {
+             if ($dc_info) {
                  $dc_info = qq|<span class="LC_cusr_subheading">$dc_info</span>|;
-            }
-            $bodytag .= qq|<div id="LC_nav_bar">$left $role<br />
-                           <em>$realm</em> $dc_info</div>|;
+             }
+             $bodytag .= qq|<div id="LC_nav_bar">$left $role<br />
+                <em>$realm</em> $dc_info</div>|;
             return $bodytag;
         }
 
@@ -5171,10 +5222,6 @@ sub bodytag {
         }
         $bodytag .= qq|<div id="LC_realm">$realm $dc_info</div>|;
 
-        #if directed to not display the secondary menu, don't.
-        if ($args->{'no_secondary_menu'}) {
-            return $bodytag;
-        }
         #don't show menus for public users
         if (!$public){
             $bodytag .= Apache::lonmenu::secondary_menu($httphost);
@@ -5183,18 +5230,15 @@ sub bodytag {
             if ($env{'request.state'} eq 'construct') {
                 $bodytag .= &Apache::lonmenu::innerregister($forcereg,
                                 $args->{'bread_crumbs'});
-            } elsif ($forcereg) { 
+            } elsif ($forcereg) {
                 $bodytag .= &Apache::lonmenu::innerregister($forcereg,undef,
                                                             $args->{'group'});
             } else {
-                my $forbodytag;
-                &Apache::lonmenu::prepare_functions($env{'request.noversionuri'},
-                                                    $forcereg,$args->{'group'},
-                                                    $args->{'bread_crumbs'},
-                                                    $advtoolsref,'',\$forbodytag);
-                unless (ref($args->{'bread_crumbs'}) eq 'ARRAY') {
-                    $bodytag .= $forbodytag;
-                }
+                $bodytag .= 
+                    &Apache::lonmenu::prepare_functions($env{'request.noversionuri'},
+                                                        $forcereg,$args->{'group'},
+                                                        $args->{'bread_crumbs'},
+                                                        $advtoolsref);
             }
         }else{
             # this is to seperate menu from content when there's no secondary
@@ -5204,54 +5248,6 @@ sub bodytag {
         }
 
         return $bodytag;
-    }
-
-#
-# Top frame rendering, Remote is up
-#
-
-    my $imgsrc = $img;
-    if ($img =~ /^\/adm/) {
-        $imgsrc = &lonhttpdurl($img);
-    }
-    my $upperleft='<img src="'.$imgsrc.'" alt="'.$function.'" />';
-
-    my $help=($no_inline_link?''
-              :&Apache::loncommon::top_nav_help('Help'));
-
-    # Explicit link to get inline menu
-    my $menu= ($no_inline_link?''
-               :'<a href="/adm/remote?action=collapse" target="_top">'.&mt('Switch to Inline Menu Mode').'</a>');
-
-    if ($dc_info) {
-        $dc_info = qq|<span class="LC_cusr_subheading">($dc_info)</span>|;
-    }
-
-    my $name = &plainname($env{'user.name'},$env{'user.domain'});
-    unless ($public) {
-        $name = &aboutmewrapper($name,$env{'user.name'},$env{'user.domain'},
-                                undef,'LC_menubuttons_link');
-    }
-
-    unless ($env{'form.inhibitmenu'}) {
-        $bodytag .= qq|<div id="LC_nav_bar">$name $role</div>
-                       <ol class="LC_primary_menu LC_floatright LC_right">
-                       <li>$help</li>
-                       <li>$menu</li>
-                       </ol><div id="LC_realm"> $realm $dc_info</div>|;
-    }
-    if ($env{'request.state'} eq 'construct') {
-        if (!$public){
-            if ($env{'request.state'} eq 'construct') {
-                $funclist = &Apache::lonhtmlcommon::scripttag(
-                                &Apache::lonmenu::utilityfunctions($httphost), 'start').
-                            &Apache::lonhtmlcommon::scripttag('','end').
-                            &Apache::lonmenu::innerregister($forcereg,
-                                                            $args->{'bread_crumbs'});
-            }
-        }
-    }
-    return $bodytag."\n".$funclist;
 }
 
 sub dc_courseid_toggle {
@@ -5283,19 +5279,12 @@ sub make_attr_string {
 		delete($attr_ref->{$key});
 	    }
 	}
-        if ($env{'environment.remote'} eq 'on') {
-            $attr_ref->{'onload'}  =
-                &Apache::lonmenu::loadevents().  $on_load;
-            $attr_ref->{'onunload'}=
-                &Apache::lonmenu::unloadevents().$on_unload;
-        } else {  
-	    $attr_ref->{'onload'}  = $on_load;
-	    $attr_ref->{'onunload'}= $on_unload;
-        }
+	$attr_ref->{'onload'}  = $on_load;
+	$attr_ref->{'onunload'}= $on_unload;
     }
 
     my $attr_string;
-    foreach my $attr (sort(keys(%$attr_ref))) {
+    foreach my $attr (keys(%$attr_ref)) {
 	$attr_string .= " $attr=\"".$attr_ref->{$attr}.'" ';
     }
     return $attr_string;
@@ -6740,7 +6729,6 @@ ul#LC_secondary_menu li {
   font-weight: bold;
   line-height: 1.8em;
   border-right: 1px solid black;
-  vertical-align: middle;
   float: left;
 }
 
@@ -7294,15 +7282,15 @@ sub headtag {
 
     my $result =
 	'<head>'.
-	&font_settings($args);
+	&font_settings();
 
     my $inhibitprint = &print_suppression();
 
     if (!$args->{'frameset'}) {
 	$result .= &Apache::lonhtmlcommon::htmlareaheaders();
     }
-    if ($args->{'force_register'}) {
-        $result .= &Apache::lonmenu::registerurl(1);
+    if ($args->{'force_register'} && $env{'request.noversionuri'} !~ m{^/res/adm/pages/}) {
+        $result .= Apache::lonxml::display_title();
     }
     if (!$args->{'no_nav_bar'} 
 	&& !$args->{'only_body'}
@@ -7342,11 +7330,7 @@ ADDMETA
     }
     if (!$args->{'no_auto_mt_title'}) { $title = &mt($title); }
     $result .= '<title> LON-CAPA '.$title.'</title>'
-	.'<link rel="stylesheet" type="text/css" href="'.$url.'"';
-    if (!$args->{'frameset'}) {
-        $result .= ' /';
-    }
-    $result .= '>'
+	.'<link rel="stylesheet" type="text/css" href="'.$url.'" />'
         .$inhibitprint
 	.$head_extra;
     if ($env{'browser.mobile'}) {
@@ -7363,21 +7347,15 @@ ADDMETA
 
 Returns neccessary <meta> to set the proper encoding
 
-Inputs: optional reference to HASH -- $args passed to &headtag()
+Inputs: none
 
 =cut
 
 sub font_settings {
-    my ($args) = @_;
     my $headerstring='';
-    if ((!$env{'browser.mathml'} && $env{'browser.unicode'}) ||
-        ((ref($args) eq 'HASH') && ($args->{'browser.unicode'}))) {
+    if (!$env{'browser.mathml'} && $env{'browser.unicode'}) {
 	$headerstring.=
-	    '<meta http-equiv="Content-Type" content="text/html; charset=utf-8"';
-        if (!$args->{'frameset'}) {
-            $headerstring.= ' /';
-        }
-        $headerstring .= '>'."\n";
+	    '<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />';
     }
     return $headerstring;
 }
@@ -7469,7 +7447,6 @@ Inputs: none
 =cut
 
 sub xml_begin {
-    my ($is_frameset) = @_;
     my $output='';
 
     if ($env{'browser.mathml'}) {
@@ -7481,12 +7458,9 @@ sub xml_begin {
 	    .'<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1 plus MathML 2.0 plus SVG 1.1//EN" "http://www.w3.org/2002/04/xhtml-math-svg/xhtml-math-svg.dtd">'
             .'<html xmlns:math="http://www.w3.org/1998/Math/MathML" ' 
 	    .'xmlns="http://www.w3.org/1999/xhtml">';
-    } elsif ($is_frameset) {
-        $output='<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Frameset//EN" "http://www.w3.org/TR/html4/frameset.dtd">'."\n".
-                '<html>'."\n";
     } else {
-	$output='<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">'."\n".
-                '<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">'."\n";
+	$output='<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">'
+           .'<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">';
     }
     return $output;
 }
@@ -7530,16 +7504,14 @@ $args - additional optional args support
              skip_phases    -> hash ref of 
                                     head -> skip the <html><head> generation
                                     body -> skip all <body> generation
-             no_inline_link -> if true and in remote mode, don't show the
-                                    'Switch To Inline Menu' link
              no_auto_mt_title -> prevent &mt()ing the title arg
              inherit_jsmath -> when creating popup window in a page,
                                     should it have jsmath forced on by the
                                     current page
              bread_crumbs ->             Array containing breadcrumbs
              bread_crumbs_component ->  if exists show it as headline else show only the breadcrumbs
-             group          -> includes the current group, if page is for a
-                               specific group
+             group          -> includes the current group, if page is for a 
+                               specific group  
 
 =back
 
@@ -7555,7 +7527,7 @@ sub start_page {
     my ($result,@advtools);
 
     if (! exists($args->{'skip_phases'}{'head'}) ) {
-        $result .= &xml_begin($args->{'frameset'}) . &headtag($title, $head_extra, $args);
+        $result .= &xml_begin() . &headtag($title, $head_extra, $args);
     }
     
     if (! exists($args->{'skip_phases'}{'body'}) ) {
@@ -7569,8 +7541,8 @@ sub start_page {
                          $args->{'function'},       $args->{'add_entries'},
                          $args->{'only_body'},      $args->{'domain'},
                          $args->{'force_register'}, $args->{'no_nav_bar'},
-                         $args->{'bgcolor'},        $args->{'no_inline_link'},
-                         $args,                     \@advtools);
+                         $args->{'bgcolor'},        $args,
+                         \@advtools);
         }
     }
 
@@ -7610,11 +7582,6 @@ sub start_page {
 		}else{
 			$result .= &Apache::lonhtmlcommon::breadcrumbs();
 		}
-    } elsif (($env{'environment.remote'} eq 'on') &&
-             ($env{'form.inhibitmenu'} ne 'yes') &&
-             ($env{'request.noversionuri'} =~ m{^/res/}) &&
-             ($env{'request.noversionuri'} !~ m{^/res/adm/pages/})) {
-        $result .= '<div style="padding:0;margin:0;clear:both"><hr /></div>';
     }
     return $result;
 }
@@ -7661,11 +7628,9 @@ function set_wishlistlink(title, path) {
         title = document.title;
         title = title.replace(/^LON-CAPA /,'');
     }
-    title = encodeURIComponent(title);
     if (!path) {
         path = location.pathname;
     }
-    path = encodeURIComponent(path);
     Win = window.open('/adm/wishlist?mode=newLink&setTitle='+title+'&setPath='+path,
                       'wishlistNewLink','width=560,height=350,scrollbars=0');
 }
@@ -7759,7 +7724,7 @@ sub modal_adhoc_inner {
     my ($funcname,$width,$height,$content)=@_;
     my $innerwidth=$width-20;
     $content=&js_ready(
-               &start_page('Dialog',undef,{'only_body'=>1,'bgcolor'=>'#FFFFFF'}).
+                 &start_page('Dialog',undef,{'only_body'=>1,'bgcolor'=>'#FFFFFF'}).
                  &start_scrollbox($width.'px',$innerwidth.'px',$height.'px','myModal','#FFFFFF',undef,1).
                  $content.
                  &end_scrollbox().
@@ -8404,7 +8369,7 @@ sub get_sections {
         }
     }
 
-    if ($check_students) {
+    if ($check_students) { 
 	my ($classlist) = &Apache::loncoursedata::get_classlist($cdom,$cnum);
 	my $sec_index = &Apache::loncoursedata::CL_SECTION();
 	my $status_index = &Apache::loncoursedata::CL_STATUS();
@@ -8726,11 +8691,11 @@ Incoming parameters:
 2. user's domain
 3. quota name - portfolio, author, or course
    (if no quota name provided, defaults to portfolio).
-4. crstype - official, unofficial, textbook or community, if quota name is
+4. crstype - official, unofficial or community, if quota name is
    course
 
 Returns:
-1. Disk quota (in MB) assigned to student.
+1. Disk quota (in Mb) assigned to student.
 2. (Optional) Type of setting: custom or default
    (individually assigned or default for user's 
    institutional status).
@@ -8800,8 +8765,7 @@ sub get_user_quota {
         if ($quota eq '' || wantarray) {
             if ($quotaname eq 'course') {
                 my %domdefs = &Apache::lonnet::get_domain_defaults($udom);
-                if (($crstype eq 'official') || ($crstype eq 'unofficial') ||
-                    ($crstype eq 'community') || ($crstype eq 'textbook')) {
+                if (($crstype eq 'official') || ($crstype eq 'unofficial') || ($crstype eq 'community')) { 
                     $defquota = $domdefs{$crstype.'quota'};
                 }
                 if ($defquota eq '') {
@@ -8847,14 +8811,14 @@ Incoming parameters:
 
 Returns:
 
-1. Default disk quota (in MB) for user portfolios in the domain.
+1. Default disk quota (in Mb) for user portfolios in the domain.
 2. (Optional) institutional type which determined the value of the
    default quota.
 
 If a value has been stored in the domain's configuration db,
 it will return that, otherwise it returns 20 (for backwards 
 compatibility with domains which have not set up a configuration
-db file; the original statically defined portfolio quota was 20 MB). 
+db file; the original statically defined portfolio quota was 20 Mb). 
 
 If the user's status includes multiple types (e.g., staff and student),
 the largest default quota which applies to the user determines the
@@ -8942,14 +8906,13 @@ space to be exceeded.
 Same, if upload of a file directly to a course/community via Course Editor
 will cause quota for uploaded content for the course to be exceeded.
 
-Inputs: 7 
+Inputs: 6
 1. username or coursenum
 2. domain
 3. context ('author' or 'course')
 4. filename of file for which action is being requested
 5. filesize (kB) of file
 6. action being taken: copy or upload.
-7. quotatype (in course context -- official, unofficial, community or textbook).
 
 Returns: 1 scalar: HTML to display containing warning if quota would be exceeded,
          otherwise return null.
@@ -8959,9 +8922,9 @@ Returns: 1 scalar: HTML to display conta
 =cut
 
 sub excess_filesize_warning {
-    my ($uname,$udom,$context,$filename,$filesize,$action,$quotatype) = @_;
+    my ($uname,$udom,$context,$filename,$filesize,$action) = @_;
     my $current_disk_usage = 0;
-    my $disk_quota = &get_user_quota($uname,$udom,$context,$quotatype); #expressed in MB
+    my $disk_quota = &get_user_quota($uname,$udom,$context); #expressed in MB
     if ($context eq 'author') {
         my $authorspace = $Apache::lonnet::perlvar{'lonDocRoot'}."/priv/$udom/$uname";
         $current_disk_usage = &Apache::lonnet::diskusage($udom,$uname,$authorspace);
@@ -8972,10 +8935,10 @@ sub excess_filesize_warning {
     }
     $disk_quota = int($disk_quota * 1000);
     if (($current_disk_usage + $filesize) > $disk_quota) {
-        return '<p class="LC_warning">'.
+        return '<p><span class="LC_warning">'.
                 &mt("Unable to $action [_1]. (size = [_2] kilobytes). Disk quota will be exceeded.",
-                    '<span class="LC_filename">'.$filename.'</span>',$filesize).'</p>'.
-               '<p>'.&mt('Disk quota is [_1] kilobytes. Your current disk usage is [_2] kilobytes.',
+                    '<span class="LC_filename">'.$filename.'</span>',$filesize).'</span>'.
+               '<br />'.&mt('Disk quota is [_1] kilobytes. Your current disk usage is [_2] kilobytes.',
                             $disk_quota,$current_disk_usage).
                '</p>';
     }
@@ -8985,6 +8948,8 @@ sub excess_filesize_warning {
 ###############################################
 
 
+
+
 sub get_secgrprole_info {
     my ($cdom,$cnum,$needroles,$type)  = @_;
     my %sections_count = &get_sections($cdom,$cnum);
@@ -9426,14 +9391,7 @@ sub personal_data_fieldtitles {
 
 sub sorted_inst_types {
     my ($dom) = @_;
-    my ($usertypes,$order);
-    my %domdefaults = &Apache::lonnet::get_domain_defaults($dom);
-    if (ref($domdefaults{'inststatus'}) eq 'HASH') {
-        $usertypes = $domdefaults{'inststatus'}{'inststatustypes'};
-        $order = $domdefaults{'inststatus'}{'inststatusorder'};
-    } else {
-        ($usertypes,$order) = &Apache::lonnet::retrieve_inst_usertypes($dom);
-    }
+    my ($usertypes,$order) = &Apache::lonnet::retrieve_inst_usertypes($dom);
     my $othertitle = &mt('All users');
     if ($env{'request.course.id'}) {
         $othertitle  = &mt('Any users');
@@ -9842,7 +9800,7 @@ sub ask_for_embedded_content {
         $cdom = $env{'course.'.$env{'request.course.id'}.'.domain'};
         $cnum = $env{'course.'.$env{'request.course.id'}.'.num'};
     }
-    if (($actionurl eq '/adm/portfolio') ||
+    if (($actionurl eq '/adm/portfolio') || 
         ($actionurl eq '/adm/coursegrp_portfolio')) {
         my $current_path='/';
         if ($env{'form.currentpath'}) {
@@ -9874,18 +9832,18 @@ sub ask_for_embedded_content {
             $toplevel = $url;
             if ($args->{'context'} eq 'paste') {
                 ($cdom,$cnum) = ($url =~ m{^\Q/uploaded/\E($match_domain)/($match_courseid)/});
-                ($path) =
+                ($path) = 
                     ($toplevel =~ m{^(\Q/uploaded/$cdom/$cnum/\E(?:docs|supplemental)/(?:default|\d+)/\d+)/});
                 $fileloc = &Apache::lonnet::filelocation('',$toplevel);
                 $fileloc =~ s{^/}{};
             }
         }
-    } elsif ($actionurl eq '/adm/dependencies') {
+    } elsif ($actionurl eq '/adm/dependencies')  {
         if ($env{'request.course.id'} ne '') {
             if (ref($args) eq 'HASH') {
                 $url = $args->{'docs_url'};
                 $title = $args->{'docs_title'};
-                $toplevel = $url;
+                $toplevel = $url; 
                 unless ($toplevel =~ m{^/}) {
                     $toplevel = "/$url";
                 }
@@ -9918,13 +9876,12 @@ sub ask_for_embedded_content {
         } else {
             $embed_file = $file;
         }
-        my ($absolutepath,$cleaned_file);
-        if ($embed_file =~ m{^\w+://}) {
-            $cleaned_file = $embed_file;
+        my $absolutepath;
+        my $cleaned_file = &clean_path($embed_file);
+        if ($cleaned_file =~ m{^\w+://}) {
             $newfiles{$cleaned_file} = 1;
             $mapping{$cleaned_file} = $embed_file;
         } else {
-            $cleaned_file = &clean_path($embed_file);
             if ($embed_file =~ m{^/}) {
                 $absolutepath = $embed_file;
             }
@@ -9956,8 +9913,8 @@ sub ask_for_embedded_content {
     my $dirptr = 16384;
     foreach my $path (keys(%subdependencies)) {
         $currsubfile{$path} = {};
-        if (($actionurl eq '/adm/portfolio') ||
-            ($actionurl eq '/adm/coursegrp_portfolio')) { 
+        if (($actionurl eq '/adm/portfolio') || 
+            ($actionurl eq '/adm/coursegrp_portfolio')) {
             my ($sublistref,$listerror) =
                 &Apache::lonnet::dirlist($url.$path,$udom,$uname,$getpropath);
             if (ref($sublistref) eq 'ARRAY') {
@@ -10099,7 +10056,7 @@ sub ask_for_embedded_content {
         $counter = scalar(keys(%existing));
         $numpathchg = scalar(keys(%pathchanges));
         return ($output,$counter,$numpathchg,\%existing);
-    } elsif (($actionurl eq "/public/$cdom/$cnum/syllabus") &&
+    } elsif (($actionurl eq "/public/$cdom/$cnum/syllabus") && 
              (ref($args) eq 'HASH') && ($args->{'context'} eq 'rewrites')) {
         $counter = scalar(keys(%existing));
         $numpathchg = scalar(keys(%pathchanges));
@@ -10328,7 +10285,7 @@ sub ask_for_embedded_content {
 
 Performs clean-up of directories, subdirectories and filename in an
 embedded object, referenced in an HTML file which is being uploaded
-to a course or portfolio, where
+to a course or portfolio, where 
 "Upload embedded images/multimedia files if HTML file" checkbox was
 checked.
 
@@ -10347,7 +10304,7 @@ sub clean_path {
         @contents = ($embed_file);
     }
     my $lastidx = scalar(@contents)-1;
-    for (my $i=0; $i<=$lastidx; $i++) {
+    for (my $i=0; $i<=$lastidx; $i++) { 
         $contents[$i]=~s{\\}{/}g;
         $contents[$i]=~s/\s+/\_/g;
         $contents[$i]=~s{[^/\w\.\-]}{}g;
@@ -10686,7 +10643,7 @@ sub modify_html_refs {
     }
     my (%allfiles,%codebase,$output,$content);
     my @changes = &get_env_multiple('form.namechange');
-    unless ((@changes > 0)  || ($context eq 'syllabus')) {
+    unless ((@changes > 0) || ($context eq 'syllabus')) {
         if (wantarray) {
             return ('',0,0); 
         } else {
@@ -10821,7 +10778,7 @@ sub modify_html_refs {
                         }
                     }
                     if ($rewrites) {
-                        my $saveresult;
+                        my $saveresult; 
                         my $url = &Apache::lonnet::store_edited_file($container,$content,$udom,$uname,\$saveresult);
                         if ($url eq $container) {
                             my ($fname) = ($container =~ m{/([^/]+)$});
@@ -10927,11 +10884,11 @@ sub check_for_upload {
                     if ($currsize < $filesize) {
                         my $extra = $filesize - $currsize;
                         if (($current_disk_usage + $extra) > $disk_quota) {
-                            my $msg = '<p class="LC_warning">'.
+                            my $msg = '<span class="LC_error">'.
                                       &mt('Unable to upload [_1]. (size = [_2] kilobytes). Disk quota will be exceeded if existing (smaller) file with same name (size = [_3] kilobytes) is replaced.',
-                                          '<span class="LC_filename">'.$fname.'</span>',$filesize,$currsize).'</p>'.
-                                      '<p>'.&mt('Disk quota is [_1] kilobytes. Your current disk usage is [_2] kilobytes.',
-                                                   $disk_quota,$current_disk_usage).'</p>';
+                                          '<span class="LC_filename">'.$fname.'</span>',$filesize,$currsize).'</span>'.
+                                      '<br />'.&mt('Disk quota is [_1] kilobytes. Your current disk usage is [_2] kilobytes.',
+                                                   $disk_quota,$current_disk_usage);
                             return ('will_exceed_quota',$msg);
                         }
                     }
@@ -10940,21 +10897,21 @@ sub check_for_upload {
         }
     }
     if (($current_disk_usage + $filesize) > $disk_quota){
-        my $msg = '<p class="LC_warning">'.
-                &mt('Unable to upload [_1]. (size = [_2] kilobytes). Disk quota will be exceeded.','<span class="LC_filename">'.$fname.'</span>',$filesize).'</p>'.
-                  '<p>'.&mt('Disk quota is [_1] kilobytes. Your current disk usage is [_2] kilobytes.',$disk_quota,$current_disk_usage).'</p>';
+        my $msg = '<span class="LC_error">'.
+                &mt('Unable to upload [_1]. (size = [_2] kilobytes). Disk quota will be exceeded.','<span class="LC_filename">'.$fname.'</span>',$filesize).'</span>'.
+                  '<br />'.&mt('Disk quota is [_1] kilobytes. Your current disk usage is [_2] kilobytes.',$disk_quota,$current_disk_usage);
         return ('will_exceed_quota',$msg);
     } elsif ($found_file) {
         if ($locked_file) {
-            my $msg = '<p class="LC_warning">';
+            my $msg = '<span class="LC_error">';
             $msg .= &mt('Unable to upload [_1]. A locked file by that name was found in [_2].','<span class="LC_filename">'.$fname.'</span>','<span class="LC_filename">'.$port_path.$env{'form.currentpath'}.'</span>');
-            $msg .= '</p>';
+            $msg .= '</span><br />';
             $msg .= &mt('You will be able to rename or delete existing [_1] after a grade has been assigned.','<span class="LC_filename">'.$fname.'</span>');
             return ('file_locked',$msg);
         } else {
-            my $msg = '<p class="LC_error">';
+            my $msg = '<span class="LC_error">';
             $msg .= &mt(' A file by that name: [_1] was found in [_2].','<span class="LC_filename">'.$fname.'</span>',$port_path.$env{'form.currentpath'});
-            $msg .= '</p>';
+            $msg .= '</span>';
             return ('existingfile',$msg);
         }
     }
@@ -11045,43 +11002,16 @@ sub decompress_form {
         }
     }
     if ($mimetype =~ m{^application/(x\-)?(compressed|zip)}) {
-        my @camtasia6 = ("$topdir/","$topdir/index.html",
+        my @camtasia = ("$topdir/","$topdir/index.html",
                         "$topdir/media/",
                         "$topdir/media/$topdir.mp4",
                         "$topdir/media/FirstFrame.png",
                         "$topdir/media/player.swf",
                         "$topdir/media/swfobject.js",
                         "$topdir/media/expressInstall.swf");
-        my @camtasia8 = ("$topdir/","$topdir/$topdir.html",
-                         "$topdir/$topdir.mp4",
-                         "$topdir/$topdir\_config.xml",
-                         "$topdir/$topdir\_controller.swf",
-                         "$topdir/$topdir\_embed.css",
-                         "$topdir/$topdir\_First_Frame.png",
-                         "$topdir/$topdir\_player.html",
-                         "$topdir/$topdir\_Thumbnails.png",
-                         "$topdir/playerProductInstall.swf",
-                         "$topdir/scripts/",
-                         "$topdir/scripts/config_xml.js",
-                         "$topdir/scripts/handlebars.js",
-                         "$topdir/scripts/jquery-1.7.1.min.js",
-                         "$topdir/scripts/jquery-ui-1.8.15.custom.min.js",
-                         "$topdir/scripts/modernizr.js",
-                         "$topdir/scripts/player-min.js",
-                         "$topdir/scripts/swfobject.js",
-                         "$topdir/skins/",
-                         "$topdir/skins/configuration_express.xml",
-                         "$topdir/skins/express_show/",
-                         "$topdir/skins/express_show/player-min.css",
-                         "$topdir/skins/express_show/spritesheet.png");
-        my @diffs = &compare_arrays(\@paths,\@camtasia6);
+        my @diffs = &compare_arrays(\@paths,\@camtasia);
         if (@diffs == 0) {
-            $is_camtasia = 6;
-        } else {
-            @diffs = &compare_arrays(\@paths,\@camtasia8);
-            if (@diffs == 0) {
-                $is_camtasia = 8;
-            }
+            $is_camtasia = 1;
         }
     }
     my $output;
@@ -11093,7 +11023,8 @@ sub decompress_form {
 function camtasiaToggle() {
     for (var i=0; i<document.uploaded_decompress.autoextract_camtasia.length; i++) {
         if (document.uploaded_decompress.autoextract_camtasia[i].checked) {
-            if (document.uploaded_decompress.autoextract_camtasia[i].value == $is_camtasia) {
+            if (document.uploaded_decompress.autoextract_camtasia[i].value == 1) {
+
                 document.getElementById('camtasia_titles').style.display='block';
             } else {
                 document.getElementById('camtasia_titles').style.display='none';
@@ -11155,7 +11086,7 @@ ENDCAM
     if ($is_camtasia) {
         $output .= $lt{'auto'}.'<br />'.
                    '<span class="LC_nobreak">'.$lt{'proa'}.'<label>'.
-                   '<input type="radio" name="autoextract_camtasia" value="'.$is_camtasia.'" onclick="javascript:camtasiaToggle();" checked="checked" />'.
+                   '<input type="radio" name="autoextract_camtasia" value="1" onclick="javascript:camtasiaToggle();" checked="checked" />'.
                    $lt{'yes'}.'</label>&nbsp;<label>'.
                    '<input type="radio" name="autoextract_camtasia" value="0" onclick="javascript:camtasiaToggle();" />'.
                    $lt{'no'}.'</label></span><br />'.
@@ -11278,7 +11209,7 @@ sub decompress_uploaded_file {
 sub process_decompression {
     my ($docudom,$docuname,$file,$destination,$dir_root,$hiddenelem) = @_;
     my ($dir,$error,$warning,$output);
-    if ($file !~ /\.(zip|tar|bz2|gz|tar.gz|tar.bz2|tgz)$/i) {
+    if ($file !~ /\.(zip|tar|bz2|gz|tar.gz|tar.bz2|tgz)$/) {
         $error = &mt('Filename not a supported archive file type.').
                  '<br />'.&mt('Filename should end with one of: [_1].',
                               '.zip, .tar, .bz2, .gz, .tar.gz, .tar.bz2, .tgz');
@@ -11388,7 +11319,6 @@ sub process_decompression {
                                                            \%titles,\%children);
                         }
                         if ($env{'form.autoextract_camtasia'}) {
-                            my $version = $env{'form.autoextract_camtasia'};
                             my %displayed;
                             my $total = 1;
                             $env{'form.archive_directory'} = [];
@@ -11407,15 +11337,12 @@ sub process_decompression {
                                     $env{'form.archive_'.$i} = 'display';
                                     $env{'form.archive_title_'.$i} = $env{'form.camtasia_foldername'};
                                     $displayed{'folder'} = $i;
-                                } elsif ((($item eq "$contents[0]/index.html") && ($version == 6)) ||
-                                         (($item eq "$contents[0]/$contents[0]".'.html') && ($version == 8))) {
+                                } elsif ($item eq "$contents[0]/index.html") {
                                     $env{'form.archive_'.$i} = 'display';
                                     $env{'form.archive_title_'.$i} = $env{'form.camtasia_moviename'};
                                     $displayed{'web'} = $i;
                                 } else {
-                                    if ((($item eq "$contents[0]/media") && ($version == 6)) ||
-                                        ((($item eq "$contents[0]/scripts") || ($item eq "$contents[0]/skins") ||
-                                             ($item eq "$contents[0]/skins/express_show")) && ($version == 8))) {
+                                    if ($item eq "$contents[0]/media") {
                                         push(@{$env{'form.archive_directory'}},$i);
                                     }
                                     $env{'form.archive_'.$i} = 'dependency';
@@ -11860,7 +11787,7 @@ sub process_extracted_files {
         $folders{'0'} = $items[-2];
         if ($env{'form.folderpath'} =~ /\:1$/) {
             $containers{'0'}='page';
-        } else {
+        } else {  
             $containers{'0'}='sequence';
         }
     }
@@ -11980,7 +11907,7 @@ sub process_extracted_files {
                     }
                 }
             } else {
-                $warning .= &mt('Item extracted from archive: [_1] has unexpected path.',$path).'<br />';
+                $warning .= &mt('Item extracted from archive: [_1] has unexpected path.',$path).'<br />'; 
             }
         }
         for (my $i=1; $i<=$numitems; $i++) {
@@ -12002,7 +11929,7 @@ sub process_extracted_files {
                         }
                         if ($itemidx eq '') {
                             $itemidx =  0;
-                        }
+                        } 
                         if (grep(/^\Q$referrer{$i}\E$/,@archdirs)) {
                             if ($mapinner{$referrer{$i}}) {
                                 $fullpath = "$prefix$dir/$docstype/$mapinner{$referrer{$i}}";
@@ -12049,12 +11976,12 @@ sub process_extracted_files {
                                     $showpath = "$relpath/$title";
                                 } else {
                                     $showpath = "/$title";
-                                }
+                                } 
                                 $result .= '<li>'.&mt('[_1] included as a dependency',$showpath).'</li>'."\n";
-                            }
+                            } 
                             unless ($ishome) {
                                 my $fetch = "$fullpath/$title";
-                                $fetch =~ s/^\Q$prefix$dir\E//;
+                                $fetch =~ s/^\Q$prefix$dir\E//; 
                                 $prompttofetch{$fetch} = 1;
                             }
                         }
@@ -12064,7 +11991,7 @@ sub process_extracted_files {
                                     $path,$env{'form.archive_content_'.$referrer{$i}}).'<br />';
                 }
             } else {
-                $warning .= &mt('Item extracted from archive: [_1] has unexpected path.',$path).'<br />';
+                $warning .= &mt('Item extracted from archive: [_1] has unexpected path.',$path).'<br />'; 
             }
         }
         if (keys(%todelete)) {
@@ -12142,7 +12069,7 @@ sub cleanup_empty_dirs {
 
 =pod
 
-=item * &get_folder_hierarchy()
+=item &get_folder_hierarchy()
 
 Provides hierarchy of names of folders/sub-folders containing the current
 item,
@@ -13254,14 +13181,14 @@ generated by lonerrorhandler.pm, CHECKRP
 lonsupportreq.pm, loncoursequeueadmin.pm, searchcat.pl respectively.
 
 Inputs:
-defmail (scalar - email address of default recipient),
+defmail (scalar - email address of default recipient), 
 mailing type (scalar: errormail, packagesmail, helpdeskmail,
 requestsmail, updatesmail, or idconflictsmail).
 
 defdom (domain for which to retrieve configuration settings),
 
-origmail (scalar - email address of recipient from loncapa.conf,
-i.e., predates configuration by DC via domainprefs.pm
+origmail (scalar - email address of recipient from loncapa.conf, 
+i.e., predates configuration by DC via domainprefs.pm 
 
 Returns: comma separated list of addresses to which to send e-mail.
 
@@ -13455,7 +13382,7 @@ sub extract_categories {
 
 =pod
 
-=item * &recurse_categories()
+=item *&recurse_categories()
 
 Recursively used to generate breadcrumb trails for course categories.
 
@@ -13526,7 +13453,7 @@ sub recurse_categories {
 
 =pod
 
-=item * &assign_categories_table()
+=item *&assign_categories_table()
 
 Create a datatable for display of hierarchical categories in a domain,
 with checkboxes to allow a course to be categorized. 
@@ -13603,7 +13530,7 @@ sub assign_categories_table {
 
 =pod
 
-=item * &assign_category_rows()
+=item *&assign_category_rows()
 
 Create a datatable row for display of nested categories in a domain,
 with checkboxes to allow a course to be categorized,called recursively.
@@ -13669,12 +13596,6 @@ sub assign_category_rows {
     return $text;
 }
 
-=pod
-
-=back
-
-=cut
-
 ############################################################
 ############################################################
 
@@ -13805,7 +13726,7 @@ sub commit_studentrole {
                     }
                 }
             } else {
-                if ($secchange) {       
+                if ($secchange) { 
                     $$logmsg .= &mt('Error when attempting section change for [_1] from old section "[_2]" to new section: "[_3]" in course [_4] -error:',$uname,$oldsec,$sec,$cid).' '.$modify_section_result.$linefeed;
                 } else {
                     $$logmsg .= &mt('Error when attempting to modify role for [_1] for section: "[_2]" in course [_3] -error:',$uname,$sec,$cid).' '.$modify_section_result.$linefeed;
@@ -13927,7 +13848,7 @@ sub check_clone {
 }
 
 sub construct_course {
-    my ($args,$logmsg,$courseid,$crsudom,$crsunum,$udom,$uname,$context,$cnum,$category,$coderef) = @_;
+    my ($args,$logmsg,$courseid,$crsudom,$crsunum,$udom,$uname,$context,$cnum,$category) = @_;
     my $outcome;
     my $linefeed =  '<br />'."\n";
     if ($context eq 'auto') {
@@ -14024,12 +13945,8 @@ sub construct_course {
                    'plc.users.denied',
                    'hidefromcat',
                    'checkforpriv',
-                   'categories',
-                   'internal.uniquecode'],
+                   'categories'],
                    $$crsudom,$$crsunum);
-        if ($args->{'textbook'}) {
-            $cenv{'internal.textbook'} = $args->{'textbook'};
-        }
     }
 
 #
@@ -14213,25 +14130,6 @@ sub construct_course {
 	}
     }
 
-#
-#  generate and store uniquecode (available to course requester), if course should have one.
-#
-    if ($args->{'uniquecode'}) {
-        my ($code,$error) = &make_unique_code($$crsudom,$$crsunum);
-        if ($code) {
-            $cenv{'internal.uniquecode'} = $code;
-            my %crsinfo =
-                &Apache::lonnet::courseiddump($$crsudom,'.',1,'.','.',$$crsunum,undef,undef,'.');
-            if (ref($crsinfo{$$crsudom.'_'.$$crsunum}) eq 'HASH') {
-                $crsinfo{$$crsudom.'_'.$$crsunum}{'uniquecode'} = $code;
-                my $putres = &Apache::lonnet::courseidput($$crsudom,\%crsinfo,$crsuhome,'notime');
-            }
-            if (ref($coderef)) {
-                $$coderef = $code;
-            }
-        }
-    }
-
     if ($args->{'disresdis'}) {
         $cenv{'pch.roles.denied'}='st';
     }
@@ -14300,60 +14198,6 @@ sub construct_course {
     return (1,$outcome);
 }
 
-sub make_unique_code {
-    my ($cdom,$cnum) = @_;
-    # get lock on uniquecodes db
-    my $lockhash = {
-                      $cnum."\0".'uniquecodes' => $env{'user.name'}.
-                                                  ':'.$env{'user.domain'},
-                   };
-    my $tries = 0;
-    my $gotlock = &Apache::lonnet::newput_dom('uniquecodes',$lockhash,$cdom);
-    my ($code,$error);
-
-    while (($gotlock ne 'ok') && ($tries<3)) {
-        $tries ++;
-        sleep 1;
-        $gotlock = &Apache::lonnet::newput_dom('uniquecodes',$lockhash,$cdom);
-    }
-    if ($gotlock eq 'ok') {
-        my %currcodes = &Apache::lonnet::dump_dom('uniquecodes',$cdom);
-        my $gotcode;
-        my $attempts = 0;
-        while ((!$gotcode) && ($attempts < 100)) {
-            $code = &generate_code();
-            if (!exists($currcodes{$code})) {
-                $gotcode = 1;
-                unless (&Apache::lonnet::newput_dom('uniquecodes',{ $code => $cnum },$cdom) eq 'ok') {
-                    $error = 'nostore';
-                }
-            }
-            $attempts ++;
-        }
-        my @del_lock = ($cnum."\0".'uniquecodes');
-        my $dellockoutcome = &Apache::lonnet::del_dom('uniquecodes',\@del_lock,$cdom);
-    } else {
-        $error = 'nolock';
-    }
-    return ($code,$error);
-}
-
-sub generate_code {
-    my $code;
-    my @letts = qw(B C D G H J K M N P Q R S T V W X Z);
-    for (my $i=0; $i<6; $i++) {
-        my $lettnum = int (rand 2);
-        my $item = '';
-        if ($lettnum) {
-            $item = $letts[int( rand(18) )];
-        } else {
-            $item = 1+int( rand(8) );
-        }
-        $code .= $item;
-    }
-    return $code;
-}
-
 ############################################################
 ############################################################
 
@@ -14381,12 +14225,11 @@ sub group_term {
 }
 
 sub course_types {
-    my @types = ('official','unofficial','community','textbook');
+    my @types = ('official','unofficial','community');
     my %typename = (
                          official   => 'Official course',
                          unofficial => 'Unofficial course',
                          community  => 'Community',
-                         textbook   => 'Textbook course',
                    );
     return (\@types,\%typename);
 }
@@ -14571,12 +14414,6 @@ sub init_user_environment {
 	    $env{'browser.interface'}=$form->{'interface'};
 	}
 
-        if ($form->{'iptoken'}) {
-            my $lonhost = $r->dir_config('lonHostID');
-            $initial_env{"user.noloadbalance"} = $lonhost;
-            $env{'user.noloadbalance'} = $lonhost;
-        }
-
         my %is_adv = ( is_adv => $env{'user.adv'} );
         my %domdef;
         unless ($domain eq 'public') {
@@ -14589,7 +14426,7 @@ sub init_user_environment {
                                                   undef,\%userenv,\%domdef,\%is_adv);
         }
 
-        foreach my $crstype ('official','unofficial','community','textbook') {
+        foreach my $crstype ('official','unofficial','community') {
             $userenv{'canrequest.'.$crstype} =
                 &Apache::lonnet::usertools_access($username,$domain,$crstype,
                                                   'reload','requestcourses',
@@ -14603,7 +14440,7 @@ sub init_user_environment {
         my %reqauthor = &Apache::lonnet::get('requestauthor',['author_status','author'],
                                              $domain,$username);
         my $reqstatus = $reqauthor{'author_status'};
-        if ($reqstatus eq 'approval' || $reqstatus eq 'approved') {
+        if ($reqstatus eq 'approval' || $reqstatus eq 'approved') { 
             if (ref($reqauthor{'author'}) eq 'HASH') {
                 $userenv{'requestauthorqueued'} = $reqstatus.':'.
                                                   $reqauthor{'author'}{'timestamp'};
@@ -14694,535 +14531,6 @@ sub clean_symb {
     return ($symb,$enc);
 }
 
-############################################################
-############################################################
-
-=pod
-
-=head1 Routines for building display used to search for courses
-
-
-=over 4
-
-=item * &build_filters()
-
-Create markup for a table used to set filters to use when selecting
-courses in a domain.  Used by lonpickcourse.pm, lonmodifycourse.pm
-and quotacheck.pl
-
-
-Inputs:
-
-filterlist - anonymous array of fields to include as potential filters
-
-crstype - course type
-
-roleelement - fifth arg in selectcourse_link() populates fifth arg in javascript: opencrsbrowser() function, used
-              to pop-open a course selector (will contain "extra element").
-
-multelement - if multiple course selections will be allowed, this will be a hidden form element: name: multiple; value: 1
-
-filter - anonymous hash of criteria and their values
-
-action - form action
-
-numfiltersref - ref to scalar (count of number of elements in institutional codes -- e.g., 4 for year, semester, department, and number)
-
-caller - caller context (e.g., set to 'modifycourse' when routine is called from lonmodifycourse.pm)
-
-cloneruname - username of owner of new course who wants to clone
-
-clonerudom - domain of owner of new course who wants to clone
-
-typeelem - text to use for left column in row containing course type (i.e., Course, Community or Course/Community)
-
-codetitlesref - reference to array of titles of components in institutional codes (official courses)
-
-codedom - domain
-
-formname - value of form element named "form".
-
-fixeddom - domain, if fixed.
-
-prevphase - value to assign to form element named "phase" when going back to the previous screen
-
-cnameelement - name of form element in form on opener page which will receive title of selected course
-
-cnumelement - name of form element in form on opener page which will receive courseID  of selected course
-
-cdomelement - name of form element in form on opener page which will receive domain of selected course
-
-setroles - includes access constraint identifier when setting a roles-based condition for acces to a portfolio file
-
-clonetext - hidden form elements containing list of courses cloneable by intended course owner when DC creates a course
-
-clonewarning - warning message about missing information for intended course owner when DC creates a course
-
-
-Returns: $output - HTML for display of search criteria, and hidden form elements.
-
-
-Side Effects: None
-
-=cut
-
-# ---------------------------------------------- search for courses based on last activity etc.
-
-sub build_filters {
-    my ($filterlist,$crstype,$roleelement,$multelement,$filter,$action,
-        $numtitlesref,$caller,$cloneruname,$clonerudom,$typeelement,
-        $codetitlesref,$codedom,$formname,$fixeddom,$prevphase,
-        $cnameelement,$cnumelement,$cdomelement,$setroles,
-        $clonetext,$clonewarning) = @_;
-    my ($list,$jscript);
-    my $onchange = 'javascript:updateFilters(this)';
-    my ($domainselectform,$sincefilterform,$createdfilterform,
-        $ownerdomselectform,$persondomselectform,$instcodeform,
-        $typeselectform,$instcodetitle);
-    if ($formname eq '') {
-        $formname = $caller;
-    }
-    foreach my $item (@{$filterlist}) {
-        unless (($item eq 'descriptfilter') || ($item eq 'instcodefilter') ||
-                ($item eq 'sincefilter') || ($item eq 'createdfilter')) {
-            if ($item eq 'domainfilter') {
-                $filter->{$item} = &LONCAPA::clean_domain($filter->{$item});
-            } elsif ($item eq 'coursefilter') {
-                $filter->{$item} = &LONCAPA::clean_courseid($filter->{$item});
-            } elsif ($item eq 'ownerfilter') {
-                $filter->{$item} = &LONCAPA::clean_username($filter->{$item});
-            } elsif ($item eq 'ownerdomfilter') {
-                $filter->{'ownerdomfilter'} =
-                    &LONCAPA::clean_domain($filter->{$item});
-                $ownerdomselectform = &select_dom_form($filter->{'ownerdomfilter'},
-                                                       'ownerdomfilter',1);
-            } elsif ($item eq 'personfilter') {
-                $filter->{$item} = &LONCAPA::clean_username($filter->{$item});
-            } elsif ($item eq 'persondomfilter') {
-                $persondomselectform = &select_dom_form($filter->{'persondomfilter'},
-                                                        'persondomfilter',1);
-            } else {
-                $filter->{$item} =~ s/\W//g;
-            }
-            if (!$filter->{$item}) {
-                $filter->{$item} = '';
-            }
-        }
-        if ($item eq 'domainfilter') {
-            my $allow_blank = 1;
-            if ($formname eq 'portform') {
-                $allow_blank=0;
-            } elsif ($formname eq 'studentform') {
-                $allow_blank=0;
-            }
-            if ($fixeddom) {
-                $domainselectform = '<input type="hidden" name="domainfilter"'.
-                                    ' value="'.$codedom.'" />'.
-                                    &Apache::lonnet::domain($codedom,'description');
-            } else {
-                $domainselectform = &select_dom_form($filter->{$item},
-                                                     'domainfilter',
-                                                      $allow_blank,'',$onchange);
-            }
-        } else {
-            $list->{$item} = &HTML::Entities::encode($filter->{$item},'<>&"');
-        }
-    }
-
-    # last course activity filter and selection
-    $sincefilterform = &timebased_select_form('sincefilter',$filter);
-
-    # course created filter and selection
-    if (exists($filter->{'createdfilter'})) {
-        $createdfilterform = &timebased_select_form('createdfilter',$filter);
-    }
-
-    my %lt = &Apache::lonlocal::texthash(
-                'cac' => "$crstype Activity",
-                'ccr' => "$crstype Created",
-                'cde' => "$crstype Title",
-                'cdo' => "$crstype Domain",
-                'ins' => 'Institutional Code',
-                'inc' => 'Institutional Categorization',
-                'cow' => "$crstype Owner/Co-owner",
-                'cop' => "$crstype Personnel Includes",
-                'cog' => 'Type',
-             );
-
-    if (($formname eq 'ccrs') || ($formname eq 'requestcrs')) {
-        my $typeval = 'Course';
-        if ($crstype eq 'Community') {
-            $typeval = 'Community';
-        }
-        $typeselectform = '<input type="hidden" name="type" value="'.$typeval.'" />';
-    } else {
-        $typeselectform =  '<select name="type" size="1"';
-        if ($onchange) {
-            $typeselectform .= ' onchange="'.$onchange.'"';
-        }
-        $typeselectform .= '>'."\n";
-        foreach my $posstype ('Course','Community') {
-            $typeselectform.='<option value="'.$posstype.'"'.
-                ($posstype eq $crstype ? ' selected="selected" ' : ''). ">".&mt($posstype)."</option>\n";
-        }
-        $typeselectform.="</select>";
-    }
-
-    my ($cloneableonlyform,$cloneabletitle);
-    if (exists($filter->{'cloneableonly'})) {
-        my $cloneableon = '';
-        my $cloneableoff = ' checked="checked"';
-        if ($filter->{'cloneableonly'}) {
-            $cloneableon = $cloneableoff;
-            $cloneableoff = '';
-        }
-        $cloneableonlyform = '<span class="LC_nobreak"><label><input type="radio" name="cloneableonly" value="1" '.$cloneableon.'/>&nbsp;'.&mt('Required').'</label>'.('&nbsp;'x3).'<label><input type="radio" name="cloneableonly" value="" '.$cloneableoff.' />&nbsp;'.&mt('No restriction').'</label></span>';
-        if ($formname eq 'ccrs') {
-            $cloneabletitle = &mt('Cloneable for [_1]',$cloneruname.':'.$clonerudom);
-        } else {
-            $cloneabletitle = &mt('Cloneable by you');
-        }
-    }
-    my $officialjs;
-    if ($crstype eq 'Course') {
-        if (exists($filter->{'instcodefilter'})) {
-#            if (($fixeddom) || ($formname eq 'requestcrs') ||
-#                ($formname eq 'modifycourse') || ($formname eq 'filterpicker')) {
-            if ($codedom) {
-                $officialjs = 1;
-                ($instcodeform,$jscript,$$numtitlesref) =
-                    &Apache::courseclassifier::instcode_selectors($codedom,'filterpicker',
-                                                                  $officialjs,$codetitlesref);
-                if ($jscript) {
-                    $jscript = '<script type="text/javascript">'."\n".
-                               '// <![CDATA['."\n".
-                               $jscript."\n".
-                               '// ]]>'."\n".
-                               '</script>'."\n";
-                }
-            }
-            if ($instcodeform eq '') {
-                $instcodeform =
-                    '<input type="text" name="instcodefilter" size="10" value="'.
-                    $list->{'instcodefilter'}.'" />';
-                $instcodetitle = $lt{'ins'};
-            } else {
-                $instcodetitle = $lt{'inc'};
-            }
-            if ($fixeddom) {
-                $instcodetitle .= '<br />('.$codedom.')';
-            }
-        }
-    }
-    my $output = qq|
-<form method="post" name="filterpicker" action="$action">
-<input type="hidden" name="form" value="$formname" />
-|;
-    if ($formname eq 'modifycourse') {
-        $output .= '<input type="hidden" name="phase" value="courselist" />'."\n".
-                   '<input type="hidden" name="prevphase" value="'.
-                   $prevphase.'" />'."\n";
-    } elsif ($formname ne 'quotacheck') {
-        my $name_input;
-        if ($cnameelement ne '') {
-            $name_input = '<input type="hidden" name="cnameelement" value="'.
-                          $cnameelement.'" />';
-        }
-        $output .= qq|
-<input type="hidden" name="cnumelement" value="$cnumelement" />
-<input type="hidden" name="cdomelement" value="$cdomelement" />
-$name_input
-$roleelement
-$multelement
-$typeelement
-|;
-        if ($formname eq 'portform') {
-            $output .= '<input type="hidden" name="setroles" value="'.$setroles.'" />'."\n";
-        }
-    }
-    if ($fixeddom) {
-        $output .= '<input type="hidden" name="fixeddom" value="'.$fixeddom.'" />'."\n";
-    }
-    $output .= "<br />\n".&Apache::lonhtmlcommon::start_pick_box();
-    if ($sincefilterform) {
-        $output .= &Apache::lonhtmlcommon::row_title($lt{'cac'})
-                  .$sincefilterform
-                  .&Apache::lonhtmlcommon::row_closure();
-    }
-    if ($createdfilterform) {
-        $output .= &Apache::lonhtmlcommon::row_title($lt{'ccr'})
-                  .$createdfilterform
-                  .&Apache::lonhtmlcommon::row_closure();
-    }
-    if ($domainselectform) {
-        $output .= &Apache::lonhtmlcommon::row_title($lt{'cdo'})
-                  .$domainselectform
-                  .&Apache::lonhtmlcommon::row_closure();
-    }
-    if ($typeselectform) {
-        if (($formname eq 'ccrs') || ($formname eq 'requestcrs')) {
-            $output .= $typeselectform;
-        } else {
-            $output .= &Apache::lonhtmlcommon::row_title($lt{'cog'})
-                      .$typeselectform
-                      .&Apache::lonhtmlcommon::row_closure();
-        }
-    }
-    if ($instcodeform) {
-        $output .= &Apache::lonhtmlcommon::row_title($instcodetitle)
-                  .$instcodeform
-                  .&Apache::lonhtmlcommon::row_closure();
-    }
-    if (exists($filter->{'ownerfilter'})) {
-        $output .= &Apache::lonhtmlcommon::row_title($lt{'cow'}).
-                   '<table><tr><td>'.&mt('Username').'<br />'.
-                   '<input type="text" name="ownerfilter" size="20" value="'.
-                   $list->{'ownerfilter'}.'" /></td><td>'.&mt('Domain').'<br />'.
-                   $ownerdomselectform.'</td></tr></table>'.
-                   &Apache::lonhtmlcommon::row_closure();
-    }
-    if (exists($filter->{'personfilter'})) {
-        $output .= &Apache::lonhtmlcommon::row_title($lt{'cop'}).
-                   '<table><tr><td>'.&mt('Username').'<br />'.
-                   '<input type="text" name="personfilter" size="20" value="'.
-                   $list->{'personfilter'}.'" /></td><td>'.&mt('Domain').'<br />'.
-                   $persondomselectform.'</td></tr></table>'.
-                   &Apache::lonhtmlcommon::row_closure();
-    }
-    if (exists($filter->{'coursefilter'})) {
-        $output .= &Apache::lonhtmlcommon::row_title(&mt('LON-CAPA course ID'))
-                  .'<input type="text" name="coursefilter" size="25" value="'
-                  .$list->{'coursefilter'}.'" />'
-                  .&Apache::lonhtmlcommon::row_closure();
-    }
-    if ($cloneableonlyform) {
-        $output .= &Apache::lonhtmlcommon::row_title($cloneabletitle).
-                   $cloneableonlyform.&Apache::lonhtmlcommon::row_closure();
-    }
-    if (exists($filter->{'descriptfilter'})) {
-        $output .= &Apache::lonhtmlcommon::row_title($lt{'cde'})
-                  .'<input type="text" name="descriptfilter" size="40" value="'
-                  .$list->{'descriptfilter'}.'" />'
-                  .&Apache::lonhtmlcommon::row_closure(1);
-    }
-    $output .= &Apache::lonhtmlcommon::end_pick_box().'<p>'.$clonetext."\n".
-               '<input type="hidden" name="updater" value="" />'."\n".
-               '<input type="submit" name="gosearch" value="'.
-               &mt('Search').'" /></p>'."\n".'</form>'."\n".'<hr />'."\n";
-    return $jscript.$clonewarning.$output;
-}
-
-=pod
-
-=item * &timebased_select_form()
-
-Create markup for a dropdown list used to select a time-based
-filter e.g., Course Activity, Course Created, when searching for courses
-or communities
-
-Inputs:
-
-item - name of form element (sincefilter or createdfilter)
-
-filter - anonymous hash of criteria and their values
-
-Returns: HTML for a select box contained a blank, then six time selections,
-         with value set in incoming form variables currently selected.
-
-Side Effects: None
-
-=cut
-
-sub timebased_select_form {
-    my ($item,$filter) = @_;
-    if (ref($filter) eq 'HASH') {
-        $filter->{$item} =~ s/[^\d-]//g;
-        if (!$filter->{$item}) { $filter->{$item}=-1; }
-        return &select_form(
-                            $filter->{$item},
-                            $item,
-                            {      '-1' => '',
-                                '86400' => &mt('today'),
-                               '604800' => &mt('last week'),
-                              '2592000' => &mt('last month'),
-                              '7776000' => &mt('last three months'),
-                             '15552000' => &mt('last six months'),
-                             '31104000' => &mt('last year'),
-                    'select_form_order' =>
-                           ['-1','86400','604800','2592000','7776000',
-                            '15552000','31104000']});
-    }
-}
-
-=pod
-
-=item * &js_changer()
-
-Create script tag containing Javascript used to submit course search form
-when course type or domain is changed, and also to hide 'Searching ...' on
-page load completion for page showing search result.
-
-Inputs: None
-
-Returns: markup containing updateFilters() and hideSearching() javascript functions.
-
-Side Effects: None
-
-=cut
-
-sub js_changer {
-    return <<ENDJS;
-<script type="text/javascript">
-// <![CDATA[
-function updateFilters(caller) {
-    if (typeof(caller) != "undefined") {
-        document.filterpicker.updater.value = caller.name;
-    }
-    document.filterpicker.submit();
-}
-
-function hideSearching() {
-    if (document.getElementById('searching')) {
-        document.getElementById('searching').style.display = 'none';
-    }
-    return;
-}
-
-// ]]>
-</script>
-
-ENDJS
-}
-
-=pod
-
-=item * &search_courses()
-
-Process selected filters form course search form and pass to lonnet::courseiddump
-to retrieve a hash for which keys are courseIDs which match the selected filters.
-
-Inputs:
-
-dom - domain being searched
-
-type - course type ('Course' or 'Community' or '.' if any).
-
-filter - anonymous hash of criteria and their values
-
-numtitles - for institutional codes - number of categories
-
-cloneruname - optional username of new course owner
-
-clonerudom - optional domain of new course owner
-
-domcloner - Optional "domcloner" flag; has value=1 if user has ccc priv in domain being filtered by,
-            (used when DC is using course creation form)
-
-codetitles - reference to array of titles of components in institutional codes (official courses).
-
-
-Returns: %courses - hash of courses satisfying search criteria, keys = course IDs, values are corresponding colon-separated escaped description, institutional code, owner and type.
-
-
-Side Effects: None
-
-=cut
-
-
-sub search_courses {
-    my ($dom,$type,$filter,$numtitles,$cloneruname,$clonerudom,$domcloner,$codetitles) = @_;
-    my (%courses,%showcourses,$cloner);
-    if (($filter->{'ownerfilter'} ne '') ||
-        ($filter->{'ownerdomfilter'} ne '')) {
-        $filter->{'combownerfilter'} = $filter->{'ownerfilter'}.':'.
-                                       $filter->{'ownerdomfilter'};
-    }
-    foreach my $item ('descriptfilter','coursefilter','combownerfilter') {
-        if (!$filter->{$item}) {
-            $filter->{$item}='.';
-        }
-    }
-    my $now = time;
-    my $timefilter =
-       ($filter->{'sincefilter'}==-1?1:$now-$filter->{'sincefilter'});
-    my ($createdbefore,$createdafter);
-    if (($filter->{'createdfilter'} ne '') && ($filter->{'createdfilter'} !=-1)) {
-        $createdbefore = $now;
-        $createdafter = $now-$filter->{'createdfilter'};
-    }
-    my ($instcodefilter,$regexpok);
-    if ($numtitles) {
-        if ($env{'form.official'} eq 'on') {
-            $instcodefilter =
-                &Apache::courseclassifier::instcode_search_str($dom,$numtitles,$codetitles);
-            $regexpok = 1;
-        } elsif ($env{'form.official'} eq 'off') {
-            $instcodefilter = &Apache::courseclassifier::instcode_search_str($dom,$numtitles,$codetitles);
-            unless ($instcodefilter eq '') {
-                $regexpok = -1;
-            }
-        }
-    } else {
-        $instcodefilter = $filter->{'instcodefilter'};
-    }
-    if ($instcodefilter eq '') { $instcodefilter = '.'; }
-    if ($type eq '') { $type = '.'; }
-
-    if (($clonerudom ne '') && ($cloneruname ne '')) {
-        $cloner = $cloneruname.':'.$clonerudom;
-    }
-    %courses = &Apache::lonnet::courseiddump($dom,
-                                             $filter->{'descriptfilter'},
-                                             $timefilter,
-                                             $instcodefilter,
-                                             $filter->{'combownerfilter'},
-                                             $filter->{'coursefilter'},
-                                             undef,undef,$type,$regexpok,undef,undef,
-                                             undef,undef,$cloner,$env{'form.cc_clone'},
-                                             $filter->{'cloneableonly'},
-                                             $createdbefore,$createdafter,undef,
-                                             $domcloner);
-    if (($filter->{'personfilter'} ne '') && ($filter->{'persondomfilter'} ne '')) {
-        my $ccrole;
-        if ($type eq 'Community') {
-            $ccrole = 'co';
-        } else {
-            $ccrole = 'cc';
-        }
-        my %rolehash = &Apache::lonnet::get_my_roles($filter->{'personfilter'},
-                                                     $filter->{'persondomfilter'},
-                                                     'userroles',undef,
-                                                     [$ccrole,'in','ad','ep','ta','cr'],
-                                                     $dom);
-        foreach my $role (keys(%rolehash)) {
-            my ($cnum,$cdom,$courserole) = split(':',$role);
-            my $cid = $cdom.'_'.$cnum;
-            if (exists($courses{$cid})) {
-                if (ref($courses{$cid}) eq 'HASH') {
-                    if (ref($courses{$cid}{roles}) eq 'ARRAY') {
-                        if (!grep(/^\Q$courserole\E$/,@{$courses{$cid}{roles}})) {
-                            push (@{$courses{$cid}{roles}},$courserole);
-                        }
-                    } else {
-                        $courses{$cid}{roles} = [$courserole];
-                    }
-                    $showcourses{$cid} = $courses{$cid};
-                }
-            }
-        }
-        %courses = %showcourses;
-    }
-    return %courses;
-}
-
-
-=pod
-
-=back
-
-=cut
-
-
 sub build_release_hashes {
     my ($checkparms,$checkresponsetypes,$checkcrstypes,$anonsurvey,$randomizetry) = @_;
     return unless((ref($checkparms) eq 'HASH') && (ref($checkresponsetypes) eq 'HASH') &&
@@ -15438,15 +14746,15 @@ sub captcha_display {
     if ($captcha eq 'original') {
         $output = &create_captcha();
         unless ($output) {
-            $error = 'captcha';
+            $error = 'captcha'; 
         }
     } elsif ($captcha eq 'recaptcha') {
         $output = &create_recaptcha($pubkey);
         unless ($output) {
-            $error = 'recaptcha';
+            $error = 'recaptcha'; 
         }
     }
-    return ($output,$error,$captcha);
+    return ($output,$error);
 }
 
 sub captcha_response {
@@ -15522,9 +14830,8 @@ sub create_captcha {
         if (-e $Apache::lonnet::perlvar{'lonCaptchaDir'}.'/'.$md5sum.'.png') {
             $output = '<input type="hidden" name="crypt" value="'.$md5sum.'" />'."\n".
                       &mt('Type in the letters/numbers shown below').'&nbsp;'.
-                      '<input type="text" size="5" name="code" value="" autocomplete="off" />'.
-                      '<br />'.
-                      '<img src="'.$captcha_params{'www_output_dir'}.'/'.$md5sum.'.png" alt="captcha" />';
+                     '<input type="text" size="5" name="code" value="" /><br />'.
+                     '<img src="'.$captcha_params{'www_output_dir'}.'/'.$md5sum.'.png" />';
             last;
         }
     }
@@ -15594,82 +14901,11 @@ sub check_recaptcha {
     return $captcha_chk;
 }
 
-sub emailusername_info {
-    my @fields = ('firstname','lastname','institution','web','location','officialemail');
-    my %titles = &Apache::lonlocal::texthash (
-                     lastname      => 'Last Name',
-                     firstname     => 'First Name',
-                     institution   => 'School/college/university',
-                     location      => "School's city, state/province, country",
-                     web           => "School's web address",
-                     officialemail => 'E-mail address at institution (if different)',
-                 );
-    return (\@fields,\%titles);
-}
+=pod
 
-sub cleanup_html {
-    my ($incoming) = @_;
-    my $outgoing;
-    if ($incoming ne '') {
-        $outgoing = $incoming;
-        $outgoing =~ s/;/&#059;/g;
-        $outgoing =~ s/\#/&#035;/g;
-        $outgoing =~ s/\&/&#038;/g;
-        $outgoing =~ s/</&#060;/g;
-        $outgoing =~ s/>/&#062;/g;
-        $outgoing =~ s/\(/&#040/g;
-        $outgoing =~ s/\)/&#041;/g;
-        $outgoing =~ s/"/&#034;/g;
-        $outgoing =~ s/'/&#039;/g;
-        $outgoing =~ s/\$/&#036;/g;
-        $outgoing =~ s{/}{&#047;}g;
-        $outgoing =~ s/=/&#061;/g;
-        $outgoing =~ s/\\/&#092;/g
-    }
-    return $outgoing;
-}
+=back
 
-# Use:
-#   my $answer=reply("encrypt:passwd:$udom:$uname:$upass",$tryserver);
-#
-##################################################
-#          password associated functions         #
-##################################################
-sub des_keys {
-    # Make a new key for DES encryption.
-    # Each key has two parts which are returned separately.
-    # Please note:  Each key must be passed through the &hex function
-    # before it is output to the web browser.  The hex versions cannot
-    # be used to decrypt.
-    my @hexstr=('0','1','2','3','4','5','6','7',
-                '8','9','a','b','c','d','e','f');
-    my $lkey='';
-    for (0..7) {
-        $lkey.=$hexstr[rand(15)];
-    }
-    my $ukey='';
-    for (0..7) {
-        $ukey.=$hexstr[rand(15)];
-    }
-    return ($lkey,$ukey);
-}
-
-sub des_decrypt {
-    my ($key,$cyphertext) = @_;
-    my $keybin=pack("H16",$key);
-    my $cypher;
-    if ($Crypt::DES::VERSION>=2.03) {
-        $cypher=new Crypt::DES $keybin;
-    } else {
-        $cypher=new DES $keybin;
-    }
-    my $plaintext=
-        $cypher->decrypt(unpack("a8",pack("H16",substr($cyphertext,0,16))));
-    $plaintext.=
-        $cypher->decrypt(unpack("a8",pack("H16",substr($cyphertext,16,16))));
-    $plaintext=substr($plaintext,1,ord(substr($plaintext,0,1)) );
-    return $plaintext;
-}
+=cut
 
 1;
 __END__;