--- loncom/interface/loncommon.pm	2007/04/16 22:50:44	1.523
+++ loncom/interface/loncommon.pm	2007/07/03 00:30:47	1.544
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # a pile of common routines
 #
-# $Id: loncommon.pm,v 1.523 2007/04/16 22:50:44 albertel Exp $
+# $Id: loncommon.pm,v 1.544 2007/07/03 00:30:47 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -378,7 +378,7 @@ sub coursebrowser_javascript {
     my ($domainfilter,$sec_element,$formname)=@_;
     my $crs_or_grp_alert = &mt('Please select the type of LON-CAPA entity - Course or Group - for which you wish to add/modify a user role');
    my $output = '
-<script type="text/javascript" language="Javascript" >
+<script type="text/javascript">
     var stdeditbrowser;'."\n";
    $output .= <<"ENDSTDBRW";
     function opencrsbrowser(formname,uname,udom,desc,extra_element,multflag,crstype) {
@@ -524,7 +524,8 @@ function uncheckAll(field) {
     if (field.length > 0) {
         for (i = 0; i < field.length; i++) {
             field[i].checked = false ;
-        }     } else {
+        }
+    } else {
         field.checked = false ;
     }
 }
@@ -1078,7 +1079,7 @@ sub changable_area {
 =pod
 
 =back
-
+ 
 =head1 Excel and CSV file utility routines
 
 =over 4
@@ -1212,7 +1213,7 @@ sub create_workbook {
 
 =item * create_text_file
 
-Create a file to write to and eventually make available to the usre.
+Create a file to write to and eventually make available to the user.
 If file creation fails, outputs an error message on the request object and 
 return undefs.
 
@@ -1467,6 +1468,8 @@ sub home_server_option_list {
 
 =pod
 
+=back 
+
 =cut
 
 ###############################################################
@@ -2052,6 +2055,7 @@ if $first is set to 'lastname' then it r
 ###############################################################
 sub plainname {
     my ($uname,$udom,$first)=@_;
+    return if (!defined($uname) || !defined($udom));
     my %names=&getnames($uname,$udom);
     my $name=&Apache::lonnet::format_name($names{'firstname'},
 					  $names{'middlename'},
@@ -2083,6 +2087,7 @@ if the user does not
 
 sub nickname {
     my ($uname,$udom)=@_;
+    return if (!defined($uname) || !defined($udom));
     my %names=&getnames($uname,$udom);
     my $name=$names{'nickname'};
     if ($name) {
@@ -2098,6 +2103,7 @@ sub nickname {
 
 sub getnames {
     my ($uname,$udom)=@_;
+    return if (!defined($uname) || !defined($udom));
     if ($udom eq 'public' && $uname eq 'public') {
 	return ('lastname' => &mt('Public'));
     }
@@ -2114,6 +2120,19 @@ sub getnames {
     }
 }
 
+# -------------------------------------------------------------------- getemails
+=pod
+
+=item * getemails($uname,$udom)
+
+Gets a user's email information and returns it as a hash with keys:
+notification, critnotification, permanentemail
+
+For notification and critnotification, values are comma-separated lists 
+of e-mail address(es); for permanentemail, value is a single e-mail address.
+ 
+=cut
+
 sub getemails {
     my ($uname,$udom)=@_;
     if ($udom eq 'public' && $uname eq 'public') {
@@ -2661,7 +2680,6 @@ sub get_student_answers {
   $moreenv{'grade_target'}='answer';
   %moreenv=(%form,%moreenv);
   $feedurl = &Apache::lonnet::clutter($feedurl);
-  &Apache::lonenc::check_encrypt(\$feedurl);
   my $userview=&Apache::lonnet::ssi($feedurl,%moreenv);
   return $userview;
 }
@@ -2912,7 +2930,7 @@ sub blockcheck {
         }
         my $no_ownblock = 0;
         my $no_userblock = 0;
-        if ($otheruser) {
+        if ($otheruser && $activity ne 'com') {
             # Check if current user has 'evb' priv for this
             if (defined($own_courses{$course})) {
                 foreach my $sec (keys(%{$own_courses{$course}})) {
@@ -3165,7 +3183,7 @@ Returns: Determines which domain should
 ###############################################
 sub determinedomain {
     my $domain=shift;
-   if (! $domain) {
+    if (! $domain) {
         # Determine domain if we have not been given one
         $domain = $Apache::lonnet::perlvar{'lonDefDomain'};
         if ($env{'user.domain'}) { $domain=$env{'user.domain'}; }
@@ -3248,8 +3266,12 @@ sub domainlogo {
     # See if there is a logo
     if ($designhash{$domain.'.login.domlogo'} ne '') {
         my $imgsrc = $designhash{$domain.'.login.domlogo'};
-        if ($imgsrc =~ /^\/(adm|res)/) {
-            $imgsrc = &lonhttpdurl($imgsrc);
+        if ($imgsrc =~ m{^/(adm|res)/}) {
+	    if ($imgsrc =~ m{^/res/}) {
+		my $local_name = &Apache::lonnet::filelocation('',$imgsrc);
+		&Apache::lonnet::repcopy($local_name);
+	    }
+	   $imgsrc = &lonhttpdurl($imgsrc);
         } 
         return '<img src="'.$imgsrc.'" alt="'.$domain.'" />';
     } elsif (defined(&Apache::lonnet::domain($domain,'description'))) {
@@ -3298,7 +3320,11 @@ sub designparm {
     }
     if (($which =~ /^(student|coordinator|author|admin)\.img$/) ||
         ($which =~ /login\.(img|logo|domlogo)/)) {
-        if ($output =~ /^\/(adm|res)\//) {
+        if ($output =~ m{^/(adm|res)/}) {
+	    if ($output =~ m{^/res/}) {
+		my $local_name = &Apache::lonnet::filelocation('',$output);
+		&Apache::lonnet::repcopy($local_name);
+	    }
             $output = &lonhttpdurl($output);
         }
     }
@@ -3411,9 +3437,7 @@ sub bodytag {
     my $bodytag = "<body $extra_body_attr>".
 	&Apache::lontexconvert::init_math_support();
 
-    if ($bodyonly 
-	|| ($env{'request.state'} eq 'construct' 
-	    && $env{'environment.remote'} ne 'off' )) {
+    if ($bodyonly) {
         return $bodytag;
     } elsif ($env{'browser.interface'} eq 'textual') {
 # Accessibility
@@ -3717,13 +3741,32 @@ form, .inline { display: inline; }
 .LC_diff_removed {
   color: red;
 }
+
+.LC_info,
 .LC_success,
 .LC_diff_added {
   color: green;
 }
+.LC_unknown {
+  color: yellow;
+}
+
 .LC_icon {
   border: 0px;
 }
+.LC_indexer_icon {
+  border: 0px;
+  height: 22px;
+}
+.LC_docs_spacer {
+  width: 25px;
+  height: 1px;
+  border: 0px;
+}
+
+.LC_internal_info {
+  color: #999;
+}
 
 table.LC_pastsubmission {
   border: 1px solid black;
@@ -3786,7 +3829,7 @@ table#LC_title_bar td.LC_title_bar_role_
 }
 
 table#LC_menubuttons_mainmenu {
-  background: $pgbg;
+  width: 100%;
   border: 0px;
   border-spacing: 1px;
   padding: 0px 1px;
@@ -3851,20 +3894,27 @@ table#LC_mainmenu td.LC_mainmenu_column
   font-size: smaller;
 }
 
+.LC_menubuttons_link {
+  text-decoration: none;
+}
+
 .LC_menubuttons_category {
   color: $font;
+  background: $pgbg;
   font-family: $sans;
   font-size: larger;
   font-weight: bold;
 }
 
 td.LC_menubuttons_text {
+  width: 90%;
   color: $font;
   font-family: $sans;
 }
+
 td.LC_menubuttons_img {
-  background: $tabbg;
 }
+
 .LC_current_location {
   font-family: $sans;
   background: $tabbg;
@@ -3874,6 +3924,45 @@ td.LC_menubuttons_img {
   font-weight: bold;
 }
 
+.LC_rolesmenu_is {
+  font-family: $sans;
+}
+
+.LC_rolesmenu_selected {
+  font-family: $sans;
+}
+
+.LC_rolesmenu_future {
+  font-family: $sans;
+}
+
+
+.LC_rolesmenu_will {
+  font-family: $sans;
+}
+
+.LC_rolesmenu_will_not {
+  font-family: $sans;
+}
+
+.LC_rolesmenu_expired {
+  font-family: $sans;
+}
+
+.LC_rolesinfo {
+  font-family: $sans;
+}
+
+.LC_dropadd_labeltext {
+  font-family: $sans;
+  text-align: right;
+}
+
+.LC_preferences_labeltext {
+  font-family: $sans;
+  text-align: right;
+}
+
 table.LC_aboutme_port {
   border: 0px;
   border-collapse: collapse;
@@ -4278,21 +4367,13 @@ span.LC_feedback_link {
 }
 
 table.LC_prior_tries {
-    border-width: 1px;
-    border-style: solid;
-    border-color: gray;
-    border-collapse: collapse;
+  border: 1px solid #000000;
+  border-collapse: separate;
+  border-spacing: 1px;
 }
 
 table.LC_prior_tries td {
-    border-width: 1px;
-    border-style: solid;
-    border-color: gray;
-    padding: 3px;
-}
-table.LC_prior_tries tr.LC_correct {
-    font-weight: bold;
-    background: #aaffaa;
+  padding: 2px;
 }
 
 .LC_answer_correct {
@@ -4323,7 +4404,16 @@ table.LC_prior_tries tr.LC_correct {
 }
 
 
-span.LC_prior_numerical {
+span.LC_prior_numerical,
+span.LC_prior_string,
+span.LC_prior_custom,
+span.LC_prior_reaction,
+span.LC_prior_math {
+  font-family: monospace;
+  white-space: pre;
+}
+
+span.LC_prior_string {
   font-family: monospace;
   white-space: pre;
 }
@@ -4332,13 +4422,41 @@ table.LC_prior_option {
   width: 100%;
   border-collapse: collapse;
 }
-table.LC_prior_option tr td {
-  border-style: solid;
-  border-width: 1px
+table.LC_prior_rank, table.LC_prior_match {
+  border-collapse: collapse;
+}
+table.LC_prior_option tr td,
+table.LC_prior_rank tr td,
+table.LC_prior_match tr td {
+  border: 1px solid #000000;
 }
 
 span.LC_nobreak {
-    white-space: nowrap;
+  white-space: nowrap;
+}
+
+.LC_docs_course_commands div{
+   float: left;
+   border: 4px solid #AAAAAA;
+   padding: 4px;
+   background: #DDDDCC;
+}
+
+.LC_docs_copy {
+   color: #000099;
+   font-size: x-small;
+}
+.LC_docs_cut {
+   color: #550044;
+   font-size: x-small;
+}
+.LC_docs_rename {
+   color: #009900;
+   font-size: x-small;
+}
+.LC_docs_remove {
+   color: #990000;
+   font-size: x-small;
 }
 
 END
@@ -4809,7 +4927,7 @@ sub get_users_function {
 
 =pod
 
-=item * &check_user_status
+=item * &check_user_status()
 
 Determines current status of supplied role for a
 specific user. Roles can be active, previous or future.
@@ -5170,11 +5288,18 @@ Incoming parameters:
 2. user's domain
 
 Returns:
-1. Disk quota (in Mb) assigned to student. 
+1. Disk quota (in Mb) assigned to student.
+2. (Optional) Type of setting: custom or default
+   (individually assigned or default for user's 
+   institutional status).
+3. (Optional) - User's institutional status (e.g., faculty, staff
+   or student - types as defined in localenroll::inst_usertypes 
+   for user's domain, which determines default quota for user.
+4. (Optional) - Default quota which would apply to the user.
 
 If a value has been stored in the user's environment, 
-it will return that, otherwise it returns the default
-for users in the domain.
+it will return that, otherwise it returns the maximal default
+defined for the user's instituional status(es) in the domain.
 
 =cut
 
@@ -5183,7 +5308,7 @@ for users in the domain.
 
 sub get_user_quota {
     my ($uname,$udom) = @_;
-    my $quota;
+    my ($quota,$quotatype,$settingstatus,$defquota);
     if (!defined($udom)) {
         $udom = $env{'user.domain'};
     }
@@ -5193,23 +5318,38 @@ sub get_user_quota {
     if (($udom eq '' || $uname eq '') ||
         ($udom eq 'public') && ($uname eq 'public')) {
         $quota = 0;
+        $quotatype = 'default';
+        $defquota = 0; 
     } else {
+        my $inststatus;
         if ($udom eq $env{'user.domain'} && $uname eq $env{'user.name'}) {
             $quota = $env{'environment.portfolioquota'};
+            $inststatus = $env{'environment.inststatus'};
         } else {
-            my %userenv = &Apache::lonnet::dump('environment',$udom,$uname);
+            my %userenv = 
+                &Apache::lonnet::get('environment',['portfolioquota',
+                                     'inststatus'],$udom,$uname);
             my ($tmp) = keys(%userenv);
             if ($tmp !~ /^(con_lost|error|no_such_host)/i) {
                 $quota = $userenv{'portfolioquota'};
+                $inststatus = $userenv{'inststatus'};
             } else {
                 undef(%userenv);
             }
         }
+        ($defquota,$settingstatus) = &default_quota($udom,$inststatus);
         if ($quota eq '') {
-            $quota = &default_quota($udom);
+            $quota = $defquota;
+            $quotatype = 'default';
+        } else {
+            $quotatype = 'custom';
         }
     }
-    return $quota;
+    if (wantarray) {
+        return ($quota,$quotatype,$settingstatus,$defquota);
+    } else {
+        return $quota;
+    }
 }
 
 ###############################################
@@ -5218,32 +5358,68 @@ sub get_user_quota {
 
 =item * &default_quota()
 
-Retrieves default quota assigned for storage of user portfolio files
+Retrieves default quota assigned for storage of user portfolio files,
+given an (optional) user's institutional status.
 
 Incoming parameters:
 1. domain
+2. (Optional) institutional status(es).  This is a : separated list of 
+   status types (e.g., faculty, staff, student etc.)
+   which apply to the user for whom the default is being retrieved.
+   If the institutional status string in undefined, the domain
+   default quota will be returned. 
 
 Returns:
 1. Default disk quota (in Mb) for user portfolios in the domain.
+2. (Optional) institutional type which determined the value of the
+   default quota.
 
 If a value has been stored in the domain's configuration db,
 it will return that, otherwise it returns 20 (for backwards 
 compatibility with domains which have not set up a configuration
 db file; the original statically defined portfolio quota was 20 Mb). 
 
+If the user's status includes multiple types (e.g., staff and student),
+the largest default quota which applies to the user determines the
+default quota returned.
+
 =cut
 
 ###############################################
 
 
 sub default_quota {
-    my ($udom) = @_;
-    my %defaults = &Apache::lonnet::get_dom('configuration',
-                                            ['portfolioquota'],$udom);
-    if ($defaults{'portfolioquota'} ne '') {
-        return $defaults{'portfolioquota'};
+    my ($udom,$inststatus) = @_;
+    my ($defquota,$settingstatus);
+    my %quotahash = &Apache::lonnet::get_dom('configuration',
+                                            ['quota'],$udom);
+    if (ref($quotahash{'quota'}) eq 'HASH') {
+        if ($inststatus ne '') {
+            my @statuses = split(/:/,$inststatus);
+            foreach my $item (@statuses) {
+                if ($quotahash{'quota'}{$item} ne '') {
+                    if ($defquota eq '') {
+                        $defquota = $quotahash{'quota'}{$item};
+                        $settingstatus = $item;
+                    } elsif ($quotahash{'quota'}{$item} > $defquota) {
+                        $defquota = $quotahash{'quota'}{$item};
+                        $settingstatus = $item;
+                    }
+                }
+            }
+        }
+        if ($defquota eq '') {
+            $defquota = $quotahash{'quota'}{'default'};
+            $settingstatus = 'default';
+        }
     } else {
-        return '20';
+        $settingstatus = 'default';
+        $defquota = 20;
+    }
+    if (wantarray) {
+        return ($defquota,$settingstatus);
+    } else {
+        return $defquota;
     }
 }
 
@@ -6323,35 +6499,53 @@ sub commit_customrole {
 }
 
 sub commit_standardrole {
-    my ($udom,$uname,$url,$three,$start,$end,$one,$two,$sec) = @_;
-    my $output;
-    my $logmsg;
+    my ($udom,$uname,$url,$three,$start,$end,$one,$two,$sec,$context) = @_;
+    my ($output,$logmsg,$linefeed);
+    if ($context eq 'auto') {
+        $linefeed = "\n";
+    } else {
+        $linefeed = "<br />\n";
+    }  
     if ($three eq 'st') {
-        my $result = &commit_studentrole(\$logmsg,$udom,$uname,$url,$three,$start,$end,$one,$two,$sec);
-        if (($result =~ /^error/) || ($result eq 'not_in_class') || ($result eq 'unknown_course')) {
+        my $result = &commit_studentrole(\$logmsg,$udom,$uname,$url,$three,$start,$end,
+                                         $one,$two,$sec,$context);
+        if (($result =~ /^error/) || ($result eq 'not_in_class') || 
+            ($result eq 'unknown_course')) {
             $output = "Error: $result\n"; 
         } else {
-            $output = &mt('Assigning').' '.$three.' in '.$url.
+            $output = $logmsg.$linefeed.&mt('Assigning').' '.$three.' in '.$url.
                ($start?', '.&mt('starting').' '.localtime($start):'').
-               ($end?', '.&mt('ending').' '.localtime($end):'').
-               ': <b>'.$result.'</b><br />'.
-               &mt('Add to classlist').': <b>ok</b><br />';
+               ($end?', '.&mt('ending').' '.localtime($end):'').': ';
+            if ($context eq 'auto') {
+                $output .= $result.$linefeed.&mt('Add to classlist').': ok';
+            } else {
+               $output .= '<b>'.$result.'</b>'.$linefeed.
+               &mt('Add to classlist').': <b>ok</b>';
+            }
+            $output .= $linefeed;
         }
     } else {
         $output = &mt('Assigning').' '.$three.' in '.$url.
                ($start?', '.&mt('starting').' '.localtime($start):'').
-               ($end?', '.&mt('ending').' '.localtime($end):'').': <b>'.
-               &Apache::lonnet::assignrole(
-                   $udom,$uname,$url,$three,$end,$start).
-                   '</b><br />';
+               ($end?', '.&mt('ending').' '.localtime($end):'').': ';
+        my $result = &Apache::lonnet::assignrole($udom,$uname,$url,$three,$end,$start);
+        if ($context eq 'auto') {
+            $output .= $result.$linefeed;
+        } else {
+            $output .= '<b>'.$result.'</b>'.$linefeed;
+        }
     }
     return $output;
 }
 
 sub commit_studentrole {
-    my ($logmsg,$udom,$uname,$url,$three,$start,$end,$one,$two,$sec) = @_;
-    my $linefeed =  '<br />'."\n";
-    my $result;
+    my ($logmsg,$udom,$uname,$url,$three,$start,$end,$one,$two,$sec,$context) = @_;
+    my ($result,$linefeed);
+    if ($context eq 'auto') {
+        $linefeed = "\n";
+    } else {
+        $linefeed = '<br />'."\n";
+    }
     if (defined($one) && defined($two)) {
         my $cid=$one.'_'.$two;
         my $oldsec=&Apache::lonnet::getsection($udom,$uname,$cid);
@@ -6398,9 +6592,12 @@ sub commit_studentrole {
 ############################################################
 
 sub construct_course {
-    my ($args,$logmsg,$courseid,$crsudom,$crsunum,$udom,$uname) = @_;
+    my ($args,$logmsg,$courseid,$crsudom,$crsunum,$udom,$uname,$context) = @_;
     my $outcome;
-
+    my $linefeed =  '<br />'."\n";
+    if ($context eq 'auto') {
+        $linefeed = "\n";
+    }
 #
 # Open course
 #
@@ -6420,27 +6617,65 @@ sub construct_course {
     # Utils::Course. This needs to at least be output as a comment
     # if anyone ever decides to not show this, and Utils::Course::new
     # will need to be suitably modified.
-    $outcome .= &mt('New LON-CAPA [_1] ID: [_2]<br />',$crstype,$$courseid);
+    $outcome .= &mt('New LON-CAPA [_1] ID: [_2]',$crstype,$$courseid).$linefeed;
+
 #
 # Check if created correctly
 #
     ($$crsudom,$$crsunum)= &LONCAPA::split_courseid($$courseid);
     my $crsuhome=&Apache::lonnet::homeserver($$crsunum,$$crsudom);
-    $outcome .= &mt('Created on').': '.$crsuhome.'<br>';
+    $outcome .= &mt('Created on').': '.$crsuhome.$linefeed;
 #
 # Are we cloning?
 #
     my $cloneid='';
     if (($args->{'clonecourse'}) && ($args->{'clonedomain'})) {
+        my $can_clone = 0;
 	$cloneid='/'.$args->{'clonedomain'}.'/'.$args->{'clonecourse'};
         my ($clonecrsudom,$clonecrsunum)= &LONCAPA::split_courseid($cloneid);
 	my $clonehome=&Apache::lonnet::homeserver($clonecrsunum,$clonecrsudom);
+        my $clonemsg;
 	if ($clonehome eq 'no_host') {
-	    $outcome .=
-    '<br /><font color="red">'.&mt('Attempting to clone non-existing [_1]',$crstype).' '.$cloneid.'</font>';
+            $clonemsg = &mt('Attempting to clone non-existing [_1]',$crstype);
+            if ($context eq 'auto') {
+                $outcome .= $clonemsg;
+            } else {
+	        $outcome .= '<font color="red">'.$clonemsg.'</font>';
+            }
+            $outcome .= $linefeed;
 	} else {
-	    $outcome .= 
-    '<br /><font color="green">'.&mt('Cloning [_1] from [_2]',$crstype,$clonehome).'</font>';
+            my %clonedesc = &Apache::lonnet::coursedescription($cloneid,{'one_time' => 1});
+            if ($env{'request.role.domain'} eq $args->{'form.clonedomain'}) {
+                $can_clone = 1;
+            } else {
+                my %clonehash = &Apache::lonnet::get('environment',['cloners'],
+                            $args->{'clonedomain'},$args->{'clonecourse'});
+                my @cloners = split(/,/,$clonehash{'cloners'});
+                my %roleshash =
+                    &Apache::lonnet::get_my_roles($args->{'ccuname'},
+                        $args->{'ccdomain'},'userroles',['active'],['cc'],
+                        [$args->{'clonedomain'}]);
+                if (($roleshash{$args->{'clonecourse'}.':'.$args->{'clonedomain'}.':cc'}) || (grep(/^\Q$args->{'ccuname'}\E:\Q$args->{'ccdomain'}\E$/,@cloners))) {
+                    $can_clone = 1;
+                } else {
+                    $clonemsg = &mt('The new course was not cloned from an existing course because the course owner ([_1]) does not have cloning rights in the existing course ([_2]).',$args->{'ccuname'}.':'.$args->{'ccdomain'},$clonedesc{'description'});
+                    if ($context eq 'auto') {
+                        $outcome .= $clonemsg;
+                    } else {
+                        $outcome .= '<font color="red">'.$clonemsg.'</font>';
+                    }
+                    $outcome .= $linefeed;
+                }
+            }
+        }
+        if ($can_clone) {
+	    $clonemsg = &mt('Cloning [_1] from [_2]',$crstype,$clonehome);
+            if ($context eq 'auto') {
+                $outcome = $clonemsg;
+            } else { 
+                $outcome .= '<font color="green">'.$clonemsg.'</font>';
+            }
+            $outcome .= $linefeed;
 	    my %oldcenv=&Apache::lonnet::dump('environment',$$crsudom,$$crsunum);
 # Copy all files
 	    &Apache::lonclonecourse::copycoursefiles($cloneid,$$courseid);
@@ -6561,11 +6796,24 @@ sub construct_course {
                 'dnhr' => 'does not have rights to access enrollment in these classes',
                 'adby' => 'as determined by the policies of your institution on access to official classlists'
         );
-        $outcome .= '<font color="red">'.$lt{'tclb'}.' ('.$cenv{'internal.courseowner'}.') - '.$lt{'dnhr'}.' ('.$lt{'adby'}.').<br /><ul>'."\n";
-        foreach (@badclasses) {
-            $outcome .= "<li>$_</li>\n";
-        }
-        $outcome .= "</ul><br /><br /></font>\n";
+        my $badclass_msg = $cenv{'internal.courseowner'}.') - '.$lt{'dnhr'}.
+                           ' ('.$lt{'adby'}.')';
+        if ($context eq 'auto') {
+            $outcome .= $badclass_msg.$linefeed;
+            $outcome .= '<font color="red">'.$badclass_msg.$linefeed.'<ul>'."\n";
+            foreach my $item (@badclasses) {
+                if ($context eq 'auto') {
+                    $outcome .= " - $item\n";
+                } else {
+                    $outcome .= "<li>$item</li>\n";
+                }
+            }
+            if ($context eq 'auto') {
+                $outcome .= $linefeed;
+            } else {
+                $outcome .= "</ul><br /><br /></font>\n";
+            }
+        } 
     }
     if ($args->{'no_end_date'}) {
         $args->{'endaccess'} = 0;
@@ -6581,8 +6829,13 @@ sub construct_course {
     $cenv{'internal.autharg'} = $args->{'autharg'}; 
     if ( ($cenv{'internal.authtype'} =~ /^krb/) && ($cenv{'internal.autoadds'} == 1)) {
         if (! defined($cenv{'internal.autharg'}) || $cenv{'internal.autharg'}  eq '') {
-            $outcome .= '<font color="red" size="+1">'.
-                      &mt('As you did not include the default Kerberos domain to be used for authentication in this class, the institutional data used by the automated enrollment process must include the Kerberos domain for each new student').'</font></p>';
+            my $krb_msg = &mt('As you did not include the default Kerberos domain to be used for authentication in this class, the institutional data used by the automated enrollment process must include the Kerberos domain for each new student'); 
+            if ($context eq 'auto') {
+                $outcome .= $krb_msg;
+            } else {
+                $outcome .= '<font color="red" size="+1">'.$krb_msg.'</font>';
+            }
+            $outcome .= $linefeed;
         }
     }
     if (($args->{'ccdomain'}) && ($args->{'ccuname'})) {
@@ -6638,8 +6891,8 @@ sub construct_course {
     # By default, use standard grading
     if (!defined($cenv{'grading'})) { $cenv{'grading'} = 'standard'; }
 
-    $outcome .= ('<br />'.&mt('Setting environment').': '.                 
-          &Apache::lonnet::put('environment',\%cenv,$$crsudom,$$crsunum).'<br>');
+    $outcome .= $linefeed.&mt('Setting environment').': '.                 
+          &Apache::lonnet::put('environment',\%cenv,$$crsudom,$$crsunum).$linefeed;
 #
 # Open all assignments
 #
@@ -6649,7 +6902,7 @@ sub construct_course {
                            $storeunder.'.type' => 'date_start');
        
        $outcome .= &mt('Opening all assignments').': '.&Apache::lonnet::cput
-                 ('resourcedata',\%storecontent,$$crsudom,$$crsunum).'<br>';
+                 ('resourcedata',\%storecontent,$$crsudom,$$crsunum).$linefeed;
    }
 #
 # Set first page
@@ -6676,7 +6929,7 @@ sub construct_course {
 	(my $outtext,$errtext) = &LONCAPA::map::storemap($map,1);
 
 	if ($errtext) { $fatal=2; }
-        $outcome .= ($fatal?$errtext:'write ok').'<br />';
+        $outcome .= ($fatal?$errtext:'write ok').$linefeed;
     }
     return $outcome;
 }