--- loncom/interface/loncommon.pm 2010/12/05 17:40:24 1.925.2.22 +++ loncom/interface/loncommon.pm 2010/12/06 18:00:41 1.925.2.25 @@ -1,7 +1,7 @@ # The LearningOnline Network with CAPA # a pile of common routines # -# $Id: loncommon.pm,v 1.925.2.22 2010/12/05 17:40:24 raeburn Exp $ +# $Id: loncommon.pm,v 1.925.2.25 2010/12/06 18:00:41 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -4581,7 +4581,7 @@ sub bodytag { my %cicourses; my $udom = $env{'user.domain'}; my %allnums = &get_faculty_cnums(); - if ($udom ne '' && ref($allnums{$udom} eq 'HASH') { + if (($udom ne '') && (ref($allnums{$udom}) eq 'HASH')) { foreach my $key (%{$allnums{$udom}}) { $cicourses{$udom.'_'.$key} = $allnums{$udom}->{$key}; } @@ -11021,15 +11021,16 @@ sub needs_gci_custom { my %allnums = &get_faculty_cnums(); my $cnums = $allnums{$udom}; return unless (ref($cnums) eq 'HASH'); - if ($env{'user.role.st./\Q$udom\E/'.$cnums->{'review'}}) { + return unless (scalar(keys(%{$cnums})) > 1); + if ($env{"user.role.st./$udom/$cnums->{'review'}"}) { my ($start,$end) = - split('.',$env{'user.role.st./\Q$udom\E/'.$cnums->{'review'}}); + split('.',$env{"user.role.st./$udom/$cnums->{'review'}"}); if (((!$start) || ($start && $start <= $now)) && ((!$end) || ($end > $now))) { $custommenu = 1; - if ($env{'user.role.cc./\Q$udom\E/'.$cnums->{'review'}}) { + if ($env{"user.role.cc./$udom/$cnums->{'review'}"}) { my ($ccstart,$ccend) = - split('.',$env{'user.role.cc./\Q$udom\E/'.$cnums->{'review'}}); + split('.',$env{"user.role.cc./$udom/$cnums->{'review'}"}); if (((!$start) || ($start && $start <= $now)) && ((!$end) || ($end > $now))) { $custommenu = ''; @@ -11046,6 +11047,7 @@ sub ci_tabs { my %tabs = ( gci => ['review','submit','managetest','tutorial'], slci => ['review'], + ); return $tabs{$domain}; } @@ -11072,10 +11074,10 @@ sub get_faculty_cnums { gci => { review => '9615072b469884921gcil1', submit => '1H96711d710194bfegcil1', - tutorial' => '5422913620b814c90gcil1', + tutorial => '5422913620b814c90gcil1', }, slci => { - review => '', + review => '4V80581c93ffc4c38gcil1', } ); return %cnums;