--- loncom/interface/lonconfigsettings.pm	2022/02/21 16:12:49	1.21.4.13.2.4
+++ loncom/interface/lonconfigsettings.pm	2022/04/05 16:43:34	1.21.4.13.2.6
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Handler to set domain-wide configuration settings
 #
-# $Id: lonconfigsettings.pm,v 1.21.4.13.2.4 2022/02/21 16:12:49 raeburn Exp $
+# $Id: lonconfigsettings.pm,v 1.21.4.13.2.6 2022/04/05 16:43:34 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -147,39 +147,61 @@ $linkprot_check .= <<ENDJS;
 
 var linkprotradio = '';
 var secretinput = '';
+var posscheck = '';
+
 ENDJS
                     if (@changeable) {
                         foreach my $num (@changeable) {
                             ($numrules,$intargjs) =
                                 &Apache::loncommon::passwd_validation_js('secretinput',$dom,'linkprot',$num);
-                            if ($numrules) {
-                                $linkprot_check .= <<ENDJS;
-
+                            $linkprot_check .= <<ENDJS;
+posscheck = '';
 linkprotradio = document.display.elements['linkprot_changesecret_$num'];
-secretinput = document.display.elements['linkprot_secret_$num'].value;
 if (linkprotradio.length) {
     for (var i=0; i<linkprotradio.length; i++) {
         if (linkprotradio[i].checked) {
             if (linkprotradio[i].value == 1) {
-                $intargjs
+                posscheck = 1;
             }
         }
     }
 }
+
+ENDJS
+                            if ($numrules) {
+                                $linkprot_check .= <<ENDJS;
+if (posscheck) {
+    secretinput = document.display.elements['linkprot_secret_$num'].value;
+    $intargjs
+}
+
 ENDJS
                             }
+                            $linkprot_check .= <<ENDJS;
+if (posscheck) {
+    uncheckLinkProtMakeVis('visible','$num');
+    document.display.elements['linkprot_secret_$num'].type = 'password';
+}
+
+ENDJS
                         }
                     }
                     if (@settable) {
-                        foreach my $num (@changeable) {
+                        foreach my $num (@settable) {
                             ($numrules,$intargjs) =
                                 &Apache::loncommon::passwd_validation_js('secretinput',$dom,'linkprot',$num);
                             if ($numrules) {
                                 $linkprot_check .= <<ENDJS;
 secretinput = document.display.elements['linkprot_secret_$num'].value;
 $intargjs
+
 ENDJS
                             }
+                            $linkprot_check .= <<ENDJS;
+uncheckLinkProtMakeVis('visible','$num');
+document.display.elements['linkprot_secret_$num'].type = 'password';
+
+ENDJS
                         }
                     }
                     ($numrules,$intargjs) =
@@ -190,8 +212,14 @@ secretinput = document.display.elements[
 if (document.display.elements['linkprot_add'].checked) {
     $intargjs
 }
+
 ENDJS
                     }
+                    $linkprot_check .= <<ENDJS;
+uncheckLinkProtMakeVis('visible','add');
+document.display.elements['linkprot_secret_add'].type = 'password';
+
+ENDJS
                 }
             }
         }
@@ -352,6 +380,12 @@ $jscript
                             my %domdefs = &Apache::lonnet::get_domain_defaults($dom);
                             $ltiauth = $domdefs{'crsltiauth'};
                         }
+                        my $ishome;
+                        my $chome = $env{'course.'.$env{'request.course.id'}.'.home'};
+                        unless (($chome eq 'no_host') || ($chome eq '')) {
+                            my @ids=&Apache::lonnet::current_machine_ids();
+                            foreach my $id (@ids) { if ($id eq $chome) { $ishome=1; } }
+                        }
                         my $posslti = scalar(keys(%{$values->{'linkprot'}}));
                         for (my $i=0; $i<=$posslti; $i++) {
                             my $num = $i;
@@ -367,6 +401,9 @@ $jscript
                                 $onload .= "toggleLinkProtReqUser(document.display,'requser','optional','1','block','$num');".
                                            "toggleLinkProtReqUser(document.display,'mapuser','userfield','other','inline-block','$num');";
                             }
+                            if ($ishome) {
+                                $onload .= "uncheckLinkProtMakeVis('visible','$num');";
+                            }
                         }
                     }
                 }
@@ -466,7 +503,8 @@ sub make_changes {
                     $errors =
                         &Apache::courseprefs::process_changes($dom,$confname,$item,$values,
                                                               $prefs->{$item},$changes{$item},
-                                                              $allitems,\%disallowed,$crstype);
+                                                              $allitems,\%disallowed,$crstype,
+                                                              \%lastact);
                     if (keys(%{$changes{$item}}) > 0) {
                         $numchanged ++;
                     }