--- loncom/interface/loncoursedata.pm	2003/06/16 15:55:27	1.77
+++ loncom/interface/loncoursedata.pm	2003/10/03 15:33:25	1.81.2.2
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: loncoursedata.pm,v 1.77 2003/06/16 15:55:27 matthew Exp $
+# $Id: loncoursedata.pm,v 1.81.2.2 2003/10/03 15:33:25 albertel Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -143,16 +143,28 @@ sub get_sequence_assessment_data {
     #
     # We need to keep track of which sequences contain homework problems
     # 
+    my $previous_too;
     my $previous;
     while (scalar(@Nested_Sequences)) {
+        $previous_too = $previous;
         $previous = $curRes;
         $curRes = $iterator->next();
         my $currentmap = $Nested_Sequences[-1]; # Last one on the stack
         if ($curRes == $iterator->BEGIN_MAP()) {
+            if (! ref($previous)) {
+                $previous = $previous_too;
+            }
+            if (! ref($previous)) {
+                next;
+            }
             # get the map itself, instead of BEGIN_MAP
             $title = $previous->title();
             $symb  = $previous->symb();
             $src   = $previous->src();
+            # pick up the filename if there is no title available
+            if (! defined($title) || $title eq '') {
+                ($title) = ($src=~/\/([^\/]*)$/);
+            }
             $randompick = $previous->randompick();
             my $newmap = { title    => $title,
                            src      => $src,
@@ -860,6 +872,36 @@ sub get_student {
 
 =pod
 
+=item &clear_internal_caches()
+
+Causes the internal caches used in get_student_id, get_student,
+get_symb_id, get_symb, get_part_id, and get_part to be undef'd.
+
+Needs to be called before the first operation with the MySQL database
+for a given Apache request.
+
+=cut
+
+################################################
+################################################
+sub clear_internal_caches {
+    $have_read_part_table = 0;
+    undef(%ids_by_part);
+    undef(%parts_by_id);
+    $have_read_symb_table = 0;
+    undef(%ids_by_symb);
+    undef(%symbs_by_id);
+    $have_read_student_table = 0;
+    undef(%ids_by_student);
+    undef(%students_by_id);
+}
+
+
+################################################
+################################################
+
+=pod
+
 =item &update_student_data()
 
 Input: $sname, $sdom, $courseid
@@ -908,7 +950,7 @@ sub update_student_data {
                                  $sname.':'.$sdom.' in course '.$courseid.
                                  ':'.$tmp[0]);
         $returnstatus = 'error getting data';
-        return $returnstatus;
+        return ($returnstatus,undef);
     }
     if (scalar(@tmp) < 1) {
         return ('no data',undef);
@@ -932,7 +974,7 @@ sub update_student_data {
     my $num_parameters = 0;
     my $store_performance_command = 'INSERT INTO '.$performance_table.
         ' VALUES '."\n";
-    return 'error' if (! defined($dbh));
+    return ('error',undef) if (! defined($dbh));
     while (my ($current_symb,$param_hash) = each(%student_data)) {
         #
         # make sure the symb is set up properly
@@ -986,14 +1028,14 @@ sub update_student_data {
         &Apache::lonnet::logthis(' bigass insert error:'.$dbh->errstr());
         &Apache::lonnet::logthis('command = '.$store_parameters_command);
         $returnstatus = 'error: unable to insert parameters into database';
-        return $returnstatus,\%student_data;
+        return ($returnstatus,\%student_data);
     }
     $dbh->do($store_performance_command);
     if ($dbh->err()) {
         &Apache::lonnet::logthis(' bigass insert error:'.$dbh->errstr());
         &Apache::lonnet::logthis('command = '.$store_performance_command);
         $returnstatus = 'error: unable to insert performance into database';
-        return $returnstatus,\%student_data;
+        return ($returnstatus,\%student_data);
     }
     $elapsed += Time::HiRes::time - $start;
     #
@@ -1049,7 +1091,7 @@ sub ensure_current_data {
         !$found_student     || !$found_part   ||
         !$found_performance || !$found_parameters) {
         if (&init_dbs($courseid)) {
-            return 'error';
+            return ('error',undef);
         }
     }
     #
@@ -1153,6 +1195,33 @@ sub get_student_data_from_performance_ca
         $studentdata->{$symb}->{$base.'.awarddetail'} = $awarddetail;
         $studentdata->{$symb}->{'timestamp'} = $time if (defined($time) && $time ne '');
     }
+    ## Get misc parameters
+    $request = 'SELECT c.symb,a.parameter,a.value '.
+        "FROM $student_table AS b ".
+        "LEFT JOIN $parameters_table AS a ON b.student_id=a.student_id ".
+        "LEFT JOIN $symb_table AS c ON c.symb_id = a.symb_id ".
+        "WHERE student='$student'";
+    if (defined($symb) && $symb ne '') {
+        $request .= " AND c.symb=".$dbh->quote($symb);
+    }
+    $sth = $dbh->prepare($request);
+    $sth->execute();
+    if ($sth->err()) {
+        &Apache::lonnet::logthis("Unable to execute MySQL request:");
+        &Apache::lonnet::logthis("\n".$request."\n");
+        &Apache::lonnet::logthis("error is:".$sth->errstr());
+        if (defined($symb) && $symb ne '') {
+            $studentdata = $studentdata->{$symb};
+        }
+        return $studentdata;
+    }
+    #
+    foreach my $row (@{$sth->fetchall_arrayref}) {
+        $rows_retrieved++;
+        my ($symb,$parameter,$value) = (@$row);
+        $studentdata->{$symb}->{$parameter}  = $value;
+    }
+    #
     if (defined($symb) && $symb ne '') {
         $studentdata = $studentdata->{$symb};
     }
@@ -1217,13 +1286,12 @@ sub get_current_state {
 #        }
 #    }
     #
-    if (defined($data)) {
-        if (defined($symb)) {
-            return %{$data->{$symb}};
-        } else {
-            return %$data;
-        }
-    } elsif ($status eq 'no data') {
+    if (defined($data) && defined($symb) && ref($data->{$symb})) {
+        return %{$data->{$symb}};
+    } elsif (defined($data) && ! defined($symb) && ref($data)) {
+        return %$data;
+    } 
+    if ($status eq 'no data') {
         return ();
     } else {
         if ($status ne 'okay' && $status ne '') {
@@ -1364,6 +1432,25 @@ sub get_problem_statistics {
     }
     #
     $dbh->do('DROP TABLE '.$stats_table);  # May return an error
+    #
+    # Store in metadata
+    #
+    if ($num) {
+	my %storestats=();
+
+        my $urlres=(split(/\_\_\_/,$symb))[2];
+
+	$storestats{$courseid.'___'.$urlres.'___timestamp'}=time;       
+	$storestats{$courseid.'___'.$urlres.'___stdno'}=$num;
+	$storestats{$courseid.'___'.$urlres.'___avetries'}=$mean;	   
+	$storestats{$courseid.'___'.$urlres.'___difficulty'}=$DegOfDiff;
+
+	$urlres=~/^(\w+)\/(\w+)/; 
+	&Apache::lonnet::put('nohist_resevaldata',\%storestats,$1,$2); 
+    }
+    #
+    # Return result
+    #
     return { num_students => $num,
              tries        => $tries,
              max_tries    => $mod,
@@ -1373,7 +1460,7 @@ sub get_problem_statistics {
              num_solved   => $Solved,
              num_override => $solved,
              per_wrong    => $wrongpercent,
-             deg_of_diff  => $DegOfDiff }
+             deg_of_diff  => $DegOfDiff };
 }
 
 sub execute_SQL_request {