--- loncom/interface/loncoursegroups.pm	2006/07/19 23:28:20	1.53
+++ loncom/interface/loncoursegroups.pm	2006/07/21 02:51:31	1.57
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: loncoursegroups.pm,v 1.53 2006/07/19 23:28:20 raeburn Exp $
+# $Id: loncoursegroups.pm,v 1.57 2006/07/21 02:51:31 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -840,6 +840,11 @@ function changeSort(caller) {
           ({href=>"/adm/coursegroups",
             text=>"Groups",
             faq=>9,bug=>'Instructor Interface',});
+        if ($env{'form.refpage'} eq 'grouplist') {
+            &Apache::lonhtmlcommon::add_breadcrumb
+             ({href=>"/adm/$cdom/$cnum/$env{'form.groupname'}/smppg?ref=grouplist",
+               text=>"Group: $description",});
+        }
     }
 
     my %trail = ();
@@ -1820,7 +1825,7 @@ sub privilege_specificity {
     }
     &topic_bar($r,$img,$lt{'uprv'});
     if ((($action eq 'create') && (@{$available} > 0)) || 
-        (($action eq 'modify') && ($formname eq 'change_settings'))) {  
+        (($action eq 'modify') && ($formname eq 'change_settings'))) {
         my %specific = (
                       'No'  => 'checked="checked"',
                       'Yes' => '',
@@ -1877,6 +1882,7 @@ sub privilege_specificity {
     } else {
         if ($action eq 'create') {
             $r->print($lt{'asyo'});
+            $r->print('<input type="hidden" name="specificity" value="No" />');
         } elsif ($action eq 'modify' && $formname eq 'pick_members') {
             my @defprivs;
             if (ref($$stored{'defpriv'}) eq 'ARRAY') {
@@ -2485,7 +2491,9 @@ sub member_privileges_form {
                       'members being added or modified, '. 
                       'there are no optional privileges to set '.
                       'for specific members.',
-            'algr' => 'All group members will receive the same privileges.',
+            'algr' => 'All new group members will receive the same privileges.',            'ifex' => 'If previously expired members are being re-enabled, or '.
+                      'if access for future members is being activated now, '.
+                      'previously set privileges will be preserved.',
             'asno' => 'As no group members are being added, '.
                       'there are no specific user privileges to set.',
             'asng' => 'As no group tools will be made available to users, '.
@@ -2619,7 +2627,7 @@ END
             }
         } else {
             if (keys(%{$usertools}) > 0) {
-                $r->print($lt{'algr'}.'<br /><br />');
+                $r->print($lt{'algr'}.'<br />'.$lt{'ifex'}.'<br /><br />');
                 &display_defprivs($r,$tools,$toolprivs,\@defprivs);
             } else {
                 $r->print($lt{'asno'}.'<br />');
@@ -2800,7 +2808,47 @@ sub write_group_data {
                 $r->print(&mt('A problem occurred when creating folders for the new [_1]. [_2].<br />',$gpterm,$result));
             }
             $r->print(&mt('[_1] [_2] was created.<br />',$ucgpterm,$groupname));
-        } else {
+        } elsif ($action eq 'modify') {
+            my (@oldtools,@newtools); 
+            if (ref($$stored{'tool'}) eq 'ARRAY') {
+                @oldtools = @{$$stored{'tool'}};
+            }
+            if (ref($tools) eq 'ARRAY') {
+                @newtools = @{$tools};
+            }
+            if (!grep(/^discussion$/,@oldtools) && 
+                 grep(/^discussion$/,@newtools)) {
+                my $crspath = '/uploaded/'.$cdom.'/'.$cnum.'/';
+                my $boardsmap = $crspath.'group_boards_'.$groupname.'.sequence';
+                my $navmap = Apache::lonnavmaps::navmap->new();
+                my $bbmapres = $navmap->getResourceByUrl($boardsmap);
+                undef($navmap);
+                if (!$bbmapres) {
+                    my $grpmap = $crspath.'group_folder_'.$groupname.'.sequence';
+                    my $disctitle = &mt('Discussion Boards');
+                    my $outcome = &map_updater($cdom,$cnum,'group_boards_'.
+                                               $groupname.'.sequence','bbseq',
+                                               $disctitle,$grpmap);
+                    my ($furl,$ferr) = 
+                        &Apache::lonuserstate::readmap($cdom.'/'.$cnum);
+                    $navmap = Apache::lonnavmaps::navmap->new();
+                    # modify parameter
+                    if ($outcome eq 'ok') {
+                        my $parm_result = &parm_setter($navmap,$cdom,$boardsmap,
+                                                       $groupname);
+                        if ($parm_result) {
+                            $r->print(&mt('Error while setting parameters '.
+                                          'for Discussion Boards folder: '.
+                                          '[_1]<br />.',$parm_result));
+                        } else {
+                            $r->print(&mt('Discussion Boards Folder created.<br />'));
+                        }
+                    } else {
+                        $r->print($outcome);
+                    }
+                    undef($navmap);
+                }
+            }
             $r->print(&mt('[_1] [_2] was updated.<br />',$ucgpterm,$groupname));
         }
     } else {
@@ -3313,7 +3361,7 @@ sub add_group_folder {
         my $grpfolder = &mt('[_1] Folder -',$ucgpterm,).$description;
         $grppage='/adm/'.$cdom.'/'.$cnum.'/'.$groupname.'/smppg';
         my $grptitle = &mt('Group homepage').' - '.$description;
-        my ($seqid,$discussions,$disctitle);
+        my ($discussions,$disctitle);
         my $outcome = &map_updater($cdom,$cnum,'group_folder_'.$groupname.'.sequence',
                                    'grpseq',$grpfolder,$allgrpsmap,$grppage,
                                    $grptitle);
@@ -3325,7 +3373,6 @@ sub add_group_folder {
         # Link to folder for bulletin boards
         $grpmap = $crspath.'group_folder_'.$groupname.'.sequence';
         if (grep/^discussion$/,@{$tools}) {
-            $seqid = $now + 1;
             $disctitle = &mt('Discussion Boards');
             my $outcome = &map_updater($cdom,$cnum,'group_boards_'.$groupname.
                                        '.sequence','bbseq',$disctitle,$grpmap);
@@ -3342,9 +3389,6 @@ sub add_group_folder {
     # modify parameters
     my $parm_result;
     if ($action eq 'create') {
-        if ($allgrpsmap) { 
-            $parm_result .= &parm_setter($navmap,$cdom,$allgrpsmap,$groupname);
-        }
         if ($grpmap) {
             $parm_result .= &parm_setter($navmap,$cdom,$grpmap,$groupname);
         }