--- loncom/interface/loncoursegroups.pm	2006/07/19 23:28:20	1.53
+++ loncom/interface/loncoursegroups.pm	2006/07/28 18:44:27	1.58
@@ -1,6 +1,6 @@
 # The LearningOnline Network with CAPA
 #
-# $Id: loncoursegroups.pm,v 1.53 2006/07/19 23:28:20 raeburn Exp $
+# $Id: loncoursegroups.pm,v 1.58 2006/07/28 18:44:27 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -840,6 +840,11 @@ function changeSort(caller) {
           ({href=>"/adm/coursegroups",
             text=>"Groups",
             faq=>9,bug=>'Instructor Interface',});
+        if ($env{'form.refpage'} eq 'grouplist') {
+            &Apache::lonhtmlcommon::add_breadcrumb
+             ({href=>"/adm/$cdom/$cnum/$env{'form.groupname'}/smppg?ref=grouplist",
+               text=>"Group: $description",});
+        }
     }
 
     my %trail = ();
@@ -960,6 +965,7 @@ sub retrieve_settings {
 	foreach my $role (sort(keys(%{$groupinfo{'autosec'}}))) {
             if (ref($groupinfo{'autosec'}{$role}) eq 'ARRAY') {
 	        foreach my $section (@{$groupinfo{'autosec'}{$role}}) {
+
 	            push (@{$stored{'sec_'.$role}},$section);
 	        }
 	        if (@{$groupinfo{'autosec'}{$role}} > 0) {
@@ -1201,7 +1207,7 @@ sub general_settings_form {
 			       $gpterm,$ucgpterm);
         &mapping_options($r,$action,$formname,$page,$sectioncount,
                          $states,$stored,$navbuttons,4,5,
-			 $gpterm,$ucgpterm,$crstype);
+			 $gpterm,$ucgpterm,$crstype,$cdom,$cnum);
         $nexttext = $$navbuttons{'mose'};
     }
     $prevtext = $$navbuttons{'gtpp'};
@@ -1820,7 +1826,7 @@ sub privilege_specificity {
     }
     &topic_bar($r,$img,$lt{'uprv'});
     if ((($action eq 'create') && (@{$available} > 0)) || 
-        (($action eq 'modify') && ($formname eq 'change_settings'))) {  
+        (($action eq 'modify') && ($formname eq 'change_settings'))) {
         my %specific = (
                       'No'  => 'checked="checked"',
                       'Yes' => '',
@@ -1877,6 +1883,7 @@ sub privilege_specificity {
     } else {
         if ($action eq 'create') {
             $r->print($lt{'asyo'});
+            $r->print('<input type="hidden" name="specificity" value="No" />');
         } elsif ($action eq 'modify' && $formname eq 'pick_members') {
             my @defprivs;
             if (ref($$stored{'defpriv'}) eq 'ARRAY') {
@@ -2407,7 +2414,7 @@ sub choose_privs_form {
         my $img2 = 8;
         &mapping_options($r,$action,$formname,$page,$sectioncount,
                          $states,$stored,$navbuttons,$img1,$img2,
-                         $gpterm,$ucgpterm,$crstype);
+                         $gpterm,$ucgpterm,$crstype,$cdom,$cnum);
     }
     my $prevtext = $$navbuttons{'gtps'};
     &display_navbuttons($r,$formname,$$states{$action}[$page-1],$prevtext,
@@ -2485,7 +2492,9 @@ sub member_privileges_form {
                       'members being added or modified, '. 
                       'there are no optional privileges to set '.
                       'for specific members.',
-            'algr' => 'All group members will receive the same privileges.',
+            'algr' => 'All new group members will receive the same privileges.',            'ifex' => 'If previously expired members are being re-enabled, or '.
+                      'if access for future members is being activated now, '.
+                      'previously set privileges will be preserved.',
             'asno' => 'As no group members are being added, '.
                       'there are no specific user privileges to set.',
             'asng' => 'As no group tools will be made available to users, '.
@@ -2619,7 +2628,7 @@ END
             }
         } else {
             if (keys(%{$usertools}) > 0) {
-                $r->print($lt{'algr'}.'<br /><br />');
+                $r->print($lt{'algr'}.'<br />'.$lt{'ifex'}.'<br /><br />');
                 &display_defprivs($r,$tools,$toolprivs,\@defprivs);
             } else {
                 $r->print($lt{'asno'}.'<br />');
@@ -2800,7 +2809,47 @@ sub write_group_data {
                 $r->print(&mt('A problem occurred when creating folders for the new [_1]. [_2].<br />',$gpterm,$result));
             }
             $r->print(&mt('[_1] [_2] was created.<br />',$ucgpterm,$groupname));
-        } else {
+        } elsif ($action eq 'modify') {
+            my (@oldtools,@newtools); 
+            if (ref($$stored{'tool'}) eq 'ARRAY') {
+                @oldtools = @{$$stored{'tool'}};
+            }
+            if (ref($tools) eq 'ARRAY') {
+                @newtools = @{$tools};
+            }
+            if (!grep(/^discussion$/,@oldtools) && 
+                 grep(/^discussion$/,@newtools)) {
+                my $crspath = '/uploaded/'.$cdom.'/'.$cnum.'/';
+                my $boardsmap = $crspath.'group_boards_'.$groupname.'.sequence';
+                my $navmap = Apache::lonnavmaps::navmap->new();
+                my $bbmapres = $navmap->getResourceByUrl($boardsmap);
+                undef($navmap);
+                if (!$bbmapres) {
+                    my $grpmap = $crspath.'group_folder_'.$groupname.'.sequence';
+                    my $disctitle = &mt('Discussion Boards');
+                    my $outcome = &map_updater($cdom,$cnum,'group_boards_'.
+                                               $groupname.'.sequence','bbseq',
+                                               $disctitle,$grpmap);
+                    my ($furl,$ferr) = 
+                        &Apache::lonuserstate::readmap($cdom.'/'.$cnum);
+                    $navmap = Apache::lonnavmaps::navmap->new();
+                    # modify parameter
+                    if ($outcome eq 'ok') {
+                        my $parm_result = &parm_setter($navmap,$cdom,$boardsmap,
+                                                       $groupname);
+                        if ($parm_result) {
+                            $r->print(&mt('Error while setting parameters '.
+                                          'for Discussion Boards folder: '.
+                                          '[_1]<br />.',$parm_result));
+                        } else {
+                            $r->print(&mt('Discussion Boards Folder created.<br />'));
+                        }
+                    } else {
+                        $r->print($outcome);
+                    }
+                    undef($navmap);
+                }
+            }
             $r->print(&mt('[_1] [_2] was updated.<br />',$ucgpterm,$groupname));
         }
     } else {
@@ -3029,7 +3078,7 @@ sub process_membership {
 
 sub mapping_options {
     my ($r,$action,$formname,$page,$sectioncount,$states,$stored,
-        $navbuttons,$img1,$img2,$gpterm,$ucgpterm,$crstype) = @_;
+        $navbuttons,$img1,$img2,$gpterm,$ucgpterm,$crstype,$cdom,$cnum) = @_;
     my %lt = &Apache::lonlocal::texthash(
         'auto' => "Settings for automatic $gpterm enrollment",
         'gmma' => "$ucgpterm membership mapping to specific sections/roles",
@@ -3046,7 +3095,8 @@ sub mapping_options {
         'mapr' => "Mapping of roles and sections affected by automatic $gpterm enrollment/disenrollment follows scheme chosen below.",
     );
     &automapping($r,$action,$stored,\%lt,$img1);
-    &mapping_settings($r,$sectioncount,\%lt,$stored,$img2,$crstype);
+    &mapping_settings($r,$sectioncount,\%lt,$stored,$img2,$crstype,$cdom,$cnum,
+                      $action);
     return;
 }
 
@@ -3079,7 +3129,7 @@ sub automapping {
 }
 
 sub mapping_settings {
-    my ($r,$sectioncount,$lt,$stored,$image,$crstype) = @_;
+    my ($r,$sectioncount,$lt,$stored,$image,$crstype,$cdom,$cnum,$action) = @_;
     my @sections = keys(%{$sectioncount});
     if (@sections > 0) {
         @sections = sort {$a cmp $b} @sections;
@@ -3090,7 +3140,7 @@ sub mapping_settings {
     }
     &topic_bar($r,$image,$$lt{'pirs'});
     my @roles = &standard_roles();
-    my %customroles = &my_custom_roles();
+    my %customroles = &course_custom_roles($cdom,$cnum);
     $r->print(&Apache::loncommon::start_data_table().
 	      &Apache::loncommon::start_data_table_header_row());
     $r->print('
@@ -3101,52 +3151,73 @@ sub mapping_settings {
     }
     $r->print(&Apache::loncommon::end_data_table_header_row()."\n");
     foreach my $role (@roles) {
-        my $plrole=&Apache::lonnet::plaintext($role,$crstype);
-        my $sections_sel;
-        if (@sections > 0) {
-            if ($role eq 'cc') {
-                $sections_sel = '<td align="right">'.
-                                &mt('all sections').'<input type="hidden" '. 
-                                'name="sec_cc" value="all" /></td>';
-            } else { 
-                $sections_sel='<td align="right">'.
-                              &sections_selection(\@sections,'sec_'.$role).
-                              '</td>';
-            }
-        }
-        $r->print(&Apache::loncommon::start_data_table_row().
-		  '<td><input type="checkbox" '.
-                  'name="autorole" value="'.$role.'" /></td><td>'.$plrole.
-                  '</td>'.$sections_sel.
-		  &Apache::loncommon::end_data_table_row());
+        my $roletitle=&Apache::lonnet::plaintext($role,$crstype);
+        $r->print(&print_autorole_item($role,$roletitle,\@sections));
     }
+    my @customs;
     foreach my $role (sort(keys(%customroles))) {
-        my $sections_sel;
-        if (@sections > 0) {
-            $sections_sel = 
-		'<td>'.&sections_selection(\@sections,'sec_'.$role).'</td>';
-        }
-        $r->print(&Apache::loncommon::start_data_table_row().
-		  '<td><input type="checkbox" '.
-                  'value="'.$role.'" /></td><td>'.&mt('Custom role: ').
-                  '<i>'.$role.'</i></td>'.$sections_sel.
-		  &Apache::loncommon::end_data_table_row());
+        my ($roletitle) = ($role =~ m|^cr/[^/]+/[^/]+/(.+)$|);
+        $role =~ s/\//_/g;
+        push (@customs,$role);
+        $r->print(&print_autorole_item($role,$roletitle,\@sections));
+    }
+    if ($action eq 'modify') {
+        foreach my $role (@{$$stored{'autorole'}}) {
+            if ((!grep(/^\Q$role\E$/,@customs)) && 
+                (!grep(/^\Q$role\E$/,@roles))) {
+                my $roletitle;
+                if ($role =~ /^cr/) {
+                    ($roletitle) = ($role =~ m|_([^_]+)$|);
+                } else {
+                    $roletitle = &Apache::lonnet::plaintext($role,$crstype);
+                }
+                $r->print(&print_autorole_item($role,$roletitle,\@sections));
+            }
+        }
     }
     $r->print(&Apache::loncommon::end_data_table());
     return;
 }
 
+sub print_autorole_item {
+    my ($role,$roletitle,$sections) = @_;
+    my $sections_sel;
+    if (@{$sections} > 0) {
+        if ($role eq 'cc') {
+            $sections_sel = '<td align="right">'.
+                            &mt('all sections').'<input type="hidden" '.
+                            'name="sec_cc" value="all" /></td>';
+        } else {
+            $sections_sel='<td align="right">'.
+                          &sections_selection($sections,'sec_'.$role).
+                          '</td>';
+        }
+    }
+    my $output = &Apache::loncommon::start_data_table_row().
+                 '<td><input type="checkbox" '.
+                 'name="autorole" value="'.$role.'" />'.
+                 '</td><td>'.$roletitle.'</td>'.$sections_sel.
+                 &Apache::loncommon::end_data_table_row();
+    return $output;
+} 
+
 sub standard_roles {
     my @roles = ('cc','in','ta','ep','st');
     return @roles;
 }
 
-sub my_custom_roles {
+sub course_custom_roles {
+    my ($cdom,$cnum) = @_;
     my %returnhash=();
-    my %rolehash=&Apache::lonnet::dump('roles');
-    foreach (keys %rolehash) {
-        if ($_=~/^rolesdef\_(\w+)$/) {
-            $returnhash{$1}=$1;
+    my %coursepersonnel=&Apache::lonnet::dump('nohist_userroles',$cdom,$cnum);
+    foreach my $person (sort(keys(%coursepersonnel))) {
+        my ($role) = ($person =~ /^([^:]+):/);
+        my ($end,$start) = split(/:/,$coursepersonnel{$person});
+        if ($end == -1 && $start == -1) {
+            next;
+        }
+        if ($role =~ m|^cr/[^/]+/[^/]+/[^/]|) {
+            $returnhash{$role} ++;
         }
     }
     return %returnhash;
@@ -3313,7 +3384,7 @@ sub add_group_folder {
         my $grpfolder = &mt('[_1] Folder -',$ucgpterm,).$description;
         $grppage='/adm/'.$cdom.'/'.$cnum.'/'.$groupname.'/smppg';
         my $grptitle = &mt('Group homepage').' - '.$description;
-        my ($seqid,$discussions,$disctitle);
+        my ($discussions,$disctitle);
         my $outcome = &map_updater($cdom,$cnum,'group_folder_'.$groupname.'.sequence',
                                    'grpseq',$grpfolder,$allgrpsmap,$grppage,
                                    $grptitle);
@@ -3325,7 +3396,6 @@ sub add_group_folder {
         # Link to folder for bulletin boards
         $grpmap = $crspath.'group_folder_'.$groupname.'.sequence';
         if (grep/^discussion$/,@{$tools}) {
-            $seqid = $now + 1;
             $disctitle = &mt('Discussion Boards');
             my $outcome = &map_updater($cdom,$cnum,'group_boards_'.$groupname.
                                        '.sequence','bbseq',$disctitle,$grpmap);
@@ -3342,9 +3412,6 @@ sub add_group_folder {
     # modify parameters
     my $parm_result;
     if ($action eq 'create') {
-        if ($allgrpsmap) { 
-            $parm_result .= &parm_setter($navmap,$cdom,$allgrpsmap,$groupname);
-        }
         if ($grpmap) {
             $parm_result .= &parm_setter($navmap,$cdom,$grpmap,$groupname);
         }