CVS log for loncom/interface/loncoursegroups.pm

Up to [LON-CAPA] / loncom / interface

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

- For 2.11.4 (modified)
  Include changes in 1.132

- Domain configuration for default cumulative quota for all group portfolio
  spaces in course can be overridden for a specific course by a Domain
  Coordinator.

- For 2.11
  Backport 1.131

- Prevent localization of group description in breadcrumbs for group tools.

- For 2.11
  Backport 1.128 (part).

- For 2.11
  - Backport 1.128 (part), 1.130.

- satisfy w3c validation
- remove unwanted </b>
- replace a </td> with the needed </th>

- Remove debug lines.

- Bug 6780. No "Groups" item in inline menu for users with unprivileged
  course roles if all group home pages are hidden, and no group tools
  enabled.

  Move &display_group_links() from lonsimplepage.pm to longroup.pm to
  facilitate re-use.

- Coding style: keys()

- Use complete phrases to facilitate translation.
- 'syllabus' may not be used as a group name
- before displaying message containing invalid group name, convert characters
  in proposed name which could be mark-up to entities.

Fix wording typos

Reinstate original logics accidentally disrupted in rev. 1.123

- Internationalization:
    - Added missing &mt() calls
    - Proper compilation of translation phrases
- Standard style

- MB instead of Mb

- Bug 6669
  - lonhtmlgateway::process_incoming_html() used instead of
    lonfeedback::clear_out_html() to ensure fields contain valid xhtml.
    (more HTML tags now supported).
 - requires perl-XML-LibXML 1.62 or newer:
   update needed on CentOS/RHEL/Scientific Linux 5; SLES 9/10; RHEL 4.

- Fix typo in rev. 1.119

- Some preliminary changes to aid translation (more work needed).

Exclude HTML tags from translation phrases.
Update corresponding German translation file phrases and translations.

XHTML: action attribute in <form> tag required (dummy attribute added)

- Localization: move HTML mark-up out of &mt().

Use standard styles (info/warning/error)

- course's environment now has: internal.contentchange to store timestamp
  of when folders/composite pages uploaded to main content area of a
  course last changed.
- map::storemap() includes additional (third) arg -- if true, will cause
  update to internal.contentchange in course's environment.db
- internal.contentchange is also updated by nightly run of refresh_courseids.db
  in case course modification occurred on pre-2.11 server.
- internal.contentchange is stored for 10 mins in memcached, via &get_coursechange()
  routine in lonnet.pm

- Change to behavior of portfolio::get_dir_list() in portfolio.pm rev. 1.233.
  - error is passed as second item in a pair of return values.
  - first item in return values is a reference to an array of actual files.

- Prevent script error in Internet Explorer.

- Prevent ISE in case where Course Group folder has been removed using
  Course Editor.

- New routine in longroup.pm: &get_group_link() to get link to group homepage.
  - supports situations where group homepage has encrypted url.

Inserted confirm-success-boxes due to consistent screen layout.

- Backport 1.104, 1.105, 1.108.

- Eliminate localized phrase defined elsewhere.

- Backport 1.103, 1.107.

- Restore pre-1.92 behavior:
  - only display columns for which tools were enabled.

Added generate_menu()-call in modify_menu() and inserted corresponding icons.

Corrected typos from loncoursegroups.pm 1.104

- Accommodate Communities.

- Fix headers in user privileges table (step 4), broken in rev 1.92.

Replaced hardcoded styles for fieldset legends by CSS:
- legends are nearly always wanted to be in bold:
  Added style and removed now unnecessary <b> tags
- Padding wanted for legend texts:
  Added style and removed now unnecessary &nbsp;

XHTML: Attributes in lower-case only (<form method="post" ...)

Replaced table using special style "thinborder" by fieldset (group settings: specific privs for each user).
Removed now totally unused style "thinborder".

Optimized the design for group settings above step 4:
- Added missing &mt call to (un/) available group tools display
- Changed group tools table to simple list

(work in progress)

Optimized the design for group settings step 2 (start and end date):
- Replaced hardcoded table by standard pick_box
- Removed now unused special styles (done now)
- Use standard texts for Start and End Dates
- Replaced "None" by "No end date" to clarify the meaning of the related checkbox
  and to allow proper translation

(work in progress)

Optimized and corrected group settings step 1:
- Replaced hardcoded table by standard pick_box
- Removed now unused special styles (in progress)
- Added padding to topic_bar
- Script code: Added some comments and line breaks for better readability
- Optimized and corrected collaborative tools table:
    - Same amount of columns now
    - Repaired row closures
    - Optimized no-wrap for each tooltext-checkbox-combination
    - Got rid of dummy columns to get proper padding
    - Re-use same code for column split instead of two code blocks
    - Moved "(un)check all" buttons to standard place at top of table
    - Added info style to allocate disk quota message

(work in progress)

consistent wording:
changed "group files" to "group portfolio"
changed "file repository" to "group portfolio"
changed "group portfolio files" to "group portfolio"

Box title is now the main title of the next page and the link text or the former page title will be set to the subtitle in the near future.
Group: consistent wording

edited all chat / Chat => chat room, one entry in mydesk.tab for chatroom and added some missing translations in de.pm

consistent wording, short button names.

Collaborative Tool, keys were displayed in the table header, now are values displayed.

short button names, consistent e-mail spelling,

mt function added, email renamed because its not email

XHTML conform multiple selection

- Backport 1.88.

- span works better than div here (the : could be swallowed up in the table cells).

- Backport 1.85, 1.86. and a part of 1.87.

- Early return from &parm_setter() if navmap object unavailable.

- Warning inside "LC_warning" div.

- Backport 1.84.

- Backport 1.83.

- Provide warning messages in cases where a $navmap object is unavailable.

- Append warning about failed release of lock.
- Unbalanced HTML

Replaced
  <nobr>...</nobr>
by
  <span class="LC_nobreak">...</span>

- lonsearchcat.pm: Added missing start tag for nobreak area
- lonsurveyreports.pm: Added missing end tag for nobreak area

- Separated HTML formats from translations:
    Moved HTML tags from text to parameters and changed related German translations.
    More changes like this needed.
- Added some missing translations, e.g. for lonprintout.pm
- Optimized/corrected some translations

consistent capitalized titles, links, buttons.

[Part 2 of changes which started with version 1.79]
Optimized localization and usage of standard styles:
- Added missing &mt() calls to "check all" and "uncheck all" buttons texts
- Added other missing &mt() calls
- Optimized &mt() calls, e.g. don't include HTML Tags, use parameters, optimized usage of group and course type variables, etc.
- Added LON-CAPA standard warning and error styles to warning and error messages

Notes:
- Not all cases are tested (restart of web server without problems)
- More improvements are needed, e.g. get rid of some concatenated phrases, add &mt() to javascript alerts, etc.
- Still some missing &mt() calls, e.g. tool names

Optimized localization and usage of standard styles (part 1):
- Optimized &mt() calls, e.g. don't include HTML Tags, use parameters, optimized usage of group and course type variables, etc.
- Added LON-CAPA standard success, warning and error styles to success, warning and error messages

Note: so far untested (restart of web server without problems)
[-> 3466]

- subroutine: topic_bar() moved to lonhtmlcommon.pm to be more widely available.
- @buildsections no longer needed as loncommon::get_course_users() can handle sectionpick including 'none' and/or 'all'.

- Define $context.
- Remove surplus quote.

Passing $context arg to &lonnet::modify_group_roles().

Localization:
Optimized mt() calls for creating folder names for group folder and group homepage

- arguments in calls to lonnet::get_dir_list() and lonnet::diskusage() modified to use new versions of these subs and to eliminate the need to call &propath() on session server side.

- Arguments missing in recursive call to  &group_files().

Include help item in breadcrumb row if user has group management priv.

bug 1931 - All user management functionality reached from a single icon/button/text link
- Extra links available on user management main menu in domain (custom role editor) and course context (custom role editor, automated enrollment manager - if enabled - and manage course groups.

mydesk.tab - change buttons
loncreateuser.pm - modify main menu
loncoursegroups.pm - add "Re-enable deleted group" link adjacent to "Create a group" link, if deleted groups exist.

- switch Store to Save

Use &getfile() to check if map exists for "All groups folder".

- style

Checking for existence of allgroups_folder.sequence uses map.pm to check the file system instead of using navmap object to check current user's session.

Locking added while allgroups_folder.sequence is being added, to avoid contention between two CCs adding the first group to a course at the same time.

rat::loadmap() now checks for a return value of -1, as lonnet::getfile() returns -1 when the file is missing.  Not sure when the existing branch (checks for -2) is triggered.

Check if group to re-enable really is still a deleted group, before proceeding.

Re-enable a previously deleted group.  Member reinstatement requires work.

Delete a group.  groupnames of deleted groups may not be used as names of new groups in the same course.  Still need to decide what action to take about access controls for group portfolio files in deleted groups.

- complet switch to LONCAPA::map

	Add spaces to message.

Documentation for course groups, including creation/modification information.

loncommon::start_page() does its own &mt().  Current status type should be retained when changing sorting used in roster display.  Roster can be displayed in a pop-up window.  Links provided to open pop-up window in table listing course groups, where membership > 0. Membership roster now available (via popup) to users with mdg or vcg privilege in cases where membership roster is not enbled in the group.

Bug 4943.  Can now include custom roles used in course to build list of course users from which group members are selected.  Also form element names can now contain non-alpha characters without breaking SetFormElements() javascript by referring to elements as formName.elements['name'] etc.  Need to rewrite any / in custom role as _ has been eliminated (so conversion no longer required for autosec records in coursegroup.db).

Custom roles can now be used in automated group memebership adds and drops.

Group creation was calling &parm_setter() for the "Course Groups" folder".  Apparently this was causing all resources in the "Main Documents" Folder to be hidden from students by default. Let's not do that.

If discussion functionality is added to a group wen modifying settings, a new discussion board folder is created for the group and an entry is added to the group_folder_$groupname sequence, if one does not currently exist.

remove extra white space.  Set "specificity" to default "No" even if no tools are added when creating a group, in case tools are added later. $seqid no longer used (discussion sequence name no longer needs it).

Style - naming.  Caller (grppage) obsolete.  Store uploaded photos in right place. Add "Edit group settings" link for users with mdg priv in course.  Priv checking for roles with section specificity. Ensure vcg and mdg privs see page contents as well as links to group tools. Some &mt().  loncoursegroups - wording changes.  Add breadcrumb for access via "Edit settings" link on group home page.

Bug 4853.  Wording changes.  Also can now configure automatic group enrollment during course creation when no sections exist.  quota information (Mb) displayed to 2 decimal places.  Eliminate javascript error on add members page when modifiying a course by removing setFormElements() onload in this case.  Some replacement of gpterm with group now all groups will be termed groups, regardless of course type.

Counts for active, future and previous now stored in a hash in longroup. Breadcrumbs includes link to all groups if route to roster page was via the 'Groups' link in inline menu.  Title of a group bulletin board can now be returned from longroup.pm for a specified board.  Priv checking for vcg and mdg for roles which include section specifier.  Group privs allow editing of group board posts by poster, and detailed view of course roster information.

Adding element to query string so breadcrumbs display on group home page in appropriate context. Improved wording regarding the total disk quota for course groups.

- couple of spannign tables elemetns removed

Replacing grppg with smppg for file name of group home pages. Detection of group context from presence of course's domain and coursenumber in page URL (instead of a username and user domain).

- change user table data_tabled

Changing sequence names for all groups folder, individual group folder, and group's discussion board folder when creating group.

- some more argument eliminations

- membership privlideges selector css
- elminate alot of rwocolor and tab color passing

- auto addtion of roles selector cssed

- css user addition to groups

- through step 4 of group creation cssed

- more css of groups
   - date settings
   - first step of new group creation

- cssed more of the groups settings forms
   - topic bars
   - first step of adding new members

- start css on course groups interface
- data table can take optional additional class attrs

Bug 4898.

Client side javascript and server side perl to enforce group portfolio quota constraints dictated by course quota limit.  Updates to messages displayed when creation of folder hierarchy or setting of hide parameter(s) is unsuccessful.

Moving generation of fixed privs and toolprivs hashes from loncoursegroups.pm to longroup.pm to be more widely available. Routine used to retrieve group membership information also moved (to be available for group roster display).

Increase colspan by 1 to accommodate addition of sections column in rev 1.31.

- hiding the cr roles for now BUG#4852

Moving get_bbfolder_url() and get_group_bbinfo() to longroup.pm.  symb no longer needed for each bulletinboard when building links in groupboards.pm.  Total number of discussion boards now displayed in view group table for each group.  Also some alignment changes in this table.

Display of discussion boards in a group, and the ability for users with board creation privileges in the group to add new boards.  When a group is first created a group folder is created containing the group homepage, and a discussion boards folder is created if discussion is enabled for the group. A "course groups" folder is also appended to the top level map in the course, if it does not already exist. Only works with standard courses which use default.sequence as the top level map. Hidden resource parameter is also applied to course group folders with default as hidden, and unhidden set for corresponding groups. Group bulletin boards use coursedom and coursenum as identifiers (instead of user domain and username as for normal boards) to allow them to be differentiated in lonfeedback.pm.  A locking mechanism should be implemented to make group creation atomic to avoid overwriting of .sequence files if two groups are created within a second of each other in the same course. Also need to address modification to group settings, when discussion functionality is enabled/disabled, as folder may need to be created and/or hidden parameter modified.

- BUG#4885
    - all section at top of modify list
    - section column added to display (and is sortable)
    - test nosection -> worked fine

- add note that uses need to log out and back in to get access to the group
  (BUG#4855)

File sizes for uploads to course group portfolios may not exceed quota set for group's file repository. When creating a course, a quota can be specified.  The sum of quotas assigned to all groups in a course can not exceed the total quota defined for the course (when the course was created).  - client side and server side enforcement still needed here.  Portfolio permissions modified to allow any user with group creation rights in a course access to all course group portfolio functions.  All uses of words: group, Group, course and Course in "Course Groups Manager" now replaced with context-sensitive terminology provided by loncommon::course_type() and loncommon::group_term() which will supply appropriate text once a decision is made on Group vs Group. Currently "ANGEL-like Discussion Groups" are called Groups, regular courses are called Courses; and within regular courses sectionesque units are called groups, and within Groups they are called teams.

- typo

- extraneous time get

Remove extra loop which was causing duplication of privileges.

Adding privileges for coursegroups for renaming course group portfolio files (and editing metadata), and setting access controls.

&Apache::lonnet::unescape -> &unescape
&Apache::lonnet::escape -> &escape

- typo

- styleploice

Enabling sorting by column in tabular display of course groups.  This table now includes links for both viewing and modifying a specific group, if a user has appropriate privileges.  Group access dates no longer reset when enabling new functionality or changing privileges for existing users. Fixes so addition of new members sets group privileges for only these users.

Replace _all with all (reserved word) for all sections in choose membership filter.  Members were being added back in after deletion/expiration etc.  Now compare old privs with new privs to prevent this.

- don't want these to register

- <label>

&coursegroups() and &get_group_settings() moved to longroup.pm, which contains general utility functions for asking about groups.  Also contains &group_changes() which is used to add/drop group memberships as a result of role changes, as determined by group settings for auto-add and auto-drop. 'none' and 'all' are now reserved words which may not be used as section or group names, so they can be used instead of _all and _none  when specifying auto-add and auto-drop settings for all sections or no section roles.

- morphing get_sections so it's easier to use

- changing loncommon::coursegroups to be easier to use

- upadte breadcrumbs calls

- start_page takes care of registering urls and the loadeventes/ unloadevents needed

Retrieve user selections for roles, access type and sections to generate membership list when adding new member to an existing group.

- lets go with "typos"

- ws fix

- start_page

Breadcrumb links only need to behave in a unique way when completing creation of a new course.  Also need to make sure %usertools contains users as keys when modifying existing membership.  Lastly only suppress display of privileges information on results page when completing deletion or expiration of memberships.

Add option to create new group when displaying groups page with "no groups" message, when user has mgr privilege.  Add togglefunc form element to the elements set by SetFormElements() on page load when returning to pick_members and change_members forms from a subsequent page, (via click in breadcrumb or the "Go to previous page" button).

Can now change the status of group members (delete, expire, activate, re-enable), change the functionality available to members (if group is configured to allow different members to use different functionality), and/or change member privileges for each of the functions (if group is configured to allow different members to receive different privileges).  If granularity in functionality, and/or in privileges is required, but was not set to be so during initial group creation, this can be changed by modifying the default group settings first.

Re-enable groups links in ENRL page. Add interface to allow group creator to specify mapping of different roles/sections to a group to support auto-add and auto-drop changes in group membership based on role changes of course participants. Implement ability to modify group settings, and to add new members. Changes to loncommon.pm to accommodate extraction of mapping options (roles & sections) when parsing group record in coursegroups.db file. Still working on ability to change functions/privileges/status of existing members.

Modify lonnet::get_coursegroups() to return a hash for consistency with other lonnet routines, and move sanity checking functionality to loncommon::coursegroups. Additional routines in lonnet to find out about groups.  Some fix-ups to loncoursegroups.pm

Course groups. Work still in progress. Creation of group, addition of members, assignment of member privileges etc.

Some clean up.

Start on interface to manage course groups.