--- loncom/interface/loncoursequeueadmin.pm 2010/02/22 09:47:56 1.20 +++ loncom/interface/loncoursequeueadmin.pm 2010/03/30 15:23:51 1.23 @@ -1,7 +1,7 @@ # The LearningOnline Network # Utilities to administer domain course requests and course self-enroll requests # -# $Id: loncoursequeueadmin.pm,v 1.20 2010/02/22 09:47:56 bisitz Exp $ +# $Id: loncoursequeueadmin.pm,v 1.23 2010/03/30 15:23:51 raeburn Exp $ # # Copyright Michigan State University Board of Trustees # @@ -27,6 +27,8 @@ # ### +=pod + =head1 NAME Apache::loncoursequeueadmin.pm @@ -48,6 +50,8 @@ described at http://www.lon-capa.org. =item display_queued_requests() +=item build_queue_display() + =item update_request_queue() =item get_student_counts() @@ -62,6 +66,10 @@ described at http://www.lon-capa.org. =item queued_selfenrollment() +=item update_coursereq_status() + +=item process_official_reqs() + =back =cut @@ -251,34 +259,20 @@ sub display_queued_requests { } else { $formaction = '/adm/createcourse'; $namespace = 'courserequestqueue'; - %requesthash = &Apache::lonnet::dump_dom($namespace,$dom,'_approval'); + my $disposition = 'approval'; + if ($context eq 'pending') { + $disposition = 'pending'; + } + %requesthash = &Apache::lonnet::dump_dom($namespace,$dom,'_'.$disposition); $nextelement = ''; } - my ($output,%queue_by_date,%crstypes); + my ($output,%queue_by_date); if (keys(%requesthash) > 0) { $output = '
'."\n". ''."\n". - $nextelement."\n". - &Apache::loncommon::start_data_table(). - &Apache::loncommon::start_data_table_header_row(). - ''.&mt('Action').''. - ''.&mt('Requestor').''; - if ($context eq 'course') { - $output .= ''.&mt('Section').''. - ''.&mt('Date requested').''; - } else { - %crstypes = &Apache::lonlocal::texthash ( - official => 'Official course', - unofficial => 'Unofficial course', - community => 'Community', - ); - $output .= ''.&mt('Type').''. - ''.&mt('Date requested').''. - ''.&mt('Details').''; - } - $output .= &Apache::loncommon::end_data_table_header_row(); + $nextelement."\n"; foreach my $item (keys(%requesthash)) { - my ($timestamp,$entry); + my ($timestamp,$entry,$pending); if ($context eq 'course') { ($timestamp, my $usec) = split(/:/,$requesthash{$item}); $entry = $item.':'.$usec; @@ -287,85 +281,163 @@ sub display_queued_requests { if (ref($requesthash{$item}) eq 'HASH') { my ($cnum,$disposition) = split('_',$item); $entry = $cnum.':'.$requesthash{$item}{'ownername'}.':'. - $requesthash{$item}{'ownerdom'}.':'. - $requesthash{$item}{'crstype'}.':'. - $requesthash{$item}{'description'}; + $requesthash{$item}{'ownerdom'}.':'; + if ($context eq 'pending') { + $entry .= $requesthash{$item}{'instcode'}; + } else { + $entry .= $requesthash{$item}{'crstype'}; + } + $entry .= ':'.$requesthash{$item}{'description'}; } } if ($entry ne '') { - if (exists($queue_by_date{$timestamp})) { - if (ref($queue_by_date{$timestamp}) eq 'ARRAY') { - push(@{$queue_by_date{$timestamp}},$entry); - } + if (ref($queue_by_date{$timestamp}) eq 'ARRAY') { + push(@{$queue_by_date{$timestamp}},$entry); } else { - @{$queue_by_date{$timestamp}} = ($entry); + $queue_by_date{$timestamp} = [$entry]; } } } - my @sortedtimes = sort {$a <=> $b} (keys(%queue_by_date)); - my $count = 0; - foreach my $item (@sortedtimes) { - if (ref($queue_by_date{$item}) eq 'ARRAY') { - foreach my $request (sort(@{$queue_by_date{$item}})) { - my ($row,$approve,$reject,$showtime,$showsec,$namelink, - $detailslink,$crstype); - $showtime = &Apache::lonlocal::locallocaltime($item); - if ($context eq 'course') { - my ($puname,$pudom,$pusec) = split(/:/,$request); - $approve = $count.':'.$puname.':'.$pudom.':'.$pusec; - $reject = $puname.':'.$pudom; - $showsec = $pusec; - if ($showsec eq '') { - $showsec = &mt('none'); - } - $namelink = &Apache::loncommon::aboutmewrapper( - &Apache::loncommon::plainname($puname,$pudom), - $puname,$pudom); + if (keys(%queue_by_date) > 0) { + if ($context eq 'course') { + $output .= '

'.&mt('Self-enrollment requests queued pending approval by a Coordinator').'

'; + } elsif ($context eq 'pending') { + $output .= '

'.&mt('Requests for official courses queued pending validation').'

'. + '

'.&mt('Requests are validated against institutional data to confirm that the requestor is an instructor of record.').'
'. + &mt('Validation is attempted when the request is submitted.').' '.&mt('If unvalidated, the request will be held in a queue.').' '.&mt('Validation of pending requests is automatically repeated daily.').'

'; + } else { + $output .= '

'.&mt('Course/Community requests queued pending approval by a Domain Coordinator').'

'; + } + $output .= &build_queue_display($dom,$context,\%queue_by_date). + ''; + } else { + $output .= '
'; + if ($context eq 'course') { + $output .= &mt('There are currently no enrollment requests awaiting approval.'); + } elsif ($context eq 'pending') { + $output .= &mt('There are currently no requests for official courses awaiting validation.'); + } elsif ($context eq 'domain') { + $output .= &mt('There are currently no course or community requests awaiting approval.'); + } + $output .= '
'; + } + if ($context eq 'pending') { + $output .= '

'."\n". + '

'.&mt('Any course/community requests which are successfully validated will be created immediately.').' '.&mt('Unvalidated requests will be listed for manual approval/rejection.').'

'; + } else { + $output .= '
'; + } + $output .= '
'; + } else { + $output .= '
'; + if ($context eq 'course') { + $output .= &mt('There are currently no enrollment requests awaiting approval.'); + } elsif ($context eq 'pending') { + $output .= &mt('There are currently no requests for official courses awaiting validation.'); + } else { + $output .= &mt('There are currently no course or community requests awaiting approval.'); + } + $output .= '
'; + } + return $output; +} +sub build_queue_display { + my ($dom,$context,$queue) = @_; + return unless (ref($queue) eq 'HASH'); + my %crstypes; + my $output = &Apache::loncommon::start_data_table(). + &Apache::loncommon::start_data_table_header_row(); + unless ($context eq 'pending') { + $output .= ''.&mt('Action').''; + } + $output .= ''.&mt('Requestor').''; + if ($context eq 'course') { + $output .= ''.&mt('Section').''. + ''.&mt('Date requested').''; + } elsif ($context eq 'pending' || $context eq 'stillpending') { + $output .= ''.&mt('Institutional code').''. + ''.&mt('Date requested').''. + ''.&mt('Details').''; + } else { + %crstypes = &Apache::lonlocal::texthash ( + official => 'Official course', + unofficial => 'Unofficial course', + community => 'Community', + ); + $output .= ''.&mt('Type').''. + ''.&mt('Date requested').''. + ''.&mt('Details').''; + } + $output .= &Apache::loncommon::end_data_table_header_row(); + my @sortedtimes = sort {$a <=> $b} (keys(%{$queue})); + my $count = 0; + foreach my $item (@sortedtimes) { + if (ref($queue->{$item}) eq 'ARRAY') { + foreach my $request (sort(@{$queue->{$item}})) { + my ($row,$approve,$reject,$showtime,$showsec,$namelink, + $detailslink,$crstype,$instcode); + $showtime = &Apache::lonlocal::locallocaltime($item); + if ($context eq 'course') { + my ($puname,$pudom,$pusec) = split(/:/,$request); + $approve = $count.':'.$puname.':'.$pudom.':'.$pusec; + $reject = $puname.':'.$pudom; + $showsec = $pusec; + if ($showsec eq '') { + $showsec = &mt('none'); + } + $namelink = &Apache::loncommon::aboutmewrapper( + &Apache::loncommon::plainname($puname,$pudom), + $puname,$pudom); + } else { + my ($cnum,$ownername,$ownerdom,$type,$cdesc); + my $queue = 'approval'; + if ($context eq 'pending' || $context eq 'stillpending') { + ($cnum,$ownername,$ownerdom,$instcode,$cdesc)=split(/:/,$request,5); + $queue = 'pending'; } else { - my ($cnum,$ownername,$ownerdom,$type,$cdesc)=split(/:/,$request,5); - $detailslink=''.$cdesc.''; + ($cnum,$ownername,$ownerdom,$type,$cdesc)=split(/:/,$request,5); $crstype = $type; if (defined($crstypes{$type})) { $crstype = $crstypes{$type}; } - $approve = $count.':'.$cnum; - $reject = $cnum; - $namelink = &Apache::loncommon::aboutmewrapper( - &Apache::loncommon::plainname($ownername,$ownerdom), - $ownername,$ownerdom); } + $detailslink=''.$cdesc.''; + $approve = $count.':'.$cnum; + $reject = $cnum; + $namelink = &Apache::loncommon::aboutmewrapper( + &Apache::loncommon::plainname($ownername,$ownerdom), + $ownername,$ownerdom); + } + unless ($context eq 'pending') { $row = '
'. '
'. - ''.$namelink.''."\n"; - if ($context eq 'course') { - $row .= ''.$showsec.''."\n". - ''.$showtime.''."\n"; - } else { - $row .= ''.$crstype.''."\n". - ''.$showtime.''."\n". - ''.$detailslink.''."\n"; - } - $output .= &Apache::loncommon::start_data_table_row()."\n". - $row. - &Apache::loncommon::end_data_table_row()."\n"; - $count ++; + ''.&mt('Reject').'
'; } + $row .= ''.$namelink.''."\n"; + if ($context eq 'course') { + $row .= ''.$showsec.''."\n". + ''.$showtime.''."\n"; + } else { + if ($context eq 'pending' || $context eq 'stillpending') { + $row .= ''.$instcode.''."\n"; + } else { + $row .= ''.$crstype.''."\n"; + } + $row .= ''.$showtime.''."\n". + ''.$detailslink.''."\n"; + } + $output .= &Apache::loncommon::start_data_table_row()."\n". + $row. + &Apache::loncommon::end_data_table_row()."\n"; + $count ++; } } - $output .= &Apache::loncommon::end_data_table(). - ''; - } else { - if ($context eq 'course') { - $output .= &mt('There are currently no enrollment requests.'); - } else { - $output .= &mt('There are currently no course or community requests awaiting approval.'); - } } + $output .= &Apache::loncommon::end_data_table(); return $output; } @@ -377,7 +449,7 @@ sub update_request_queue { @existing,@missingreq,@invalidusers,@limitexceeded,@completed, @processing_errors,@warn_approves,@warn_rejects,@approvals,@warn_dels, @rejections,@rejectionerrors,@nopermissions,%courseroles, - %communityroles,%domdefs,%approvalmsg,%rejectionmsg,$crstype); + %communityroles,%domdefs,%approvalmsg,%rejectionmsg,$crstype,$queue); @approvals = &Apache::loncommon::get_env_multiple('form.approvereq'); @rejections = &Apache::loncommon::get_env_multiple('form.rejectreq'); $now = time; @@ -412,7 +484,11 @@ sub update_request_queue { $domdesc = &Apache::lonnet::domain($cdom); $namespace = 'courserequestqueue'; $beneficiary = 'courserequestor'; - %requesthash = &Apache::lonnet::dump_dom($namespace,$cdom,'_approval'); + $queue = 'approval'; + if ($env{'form.queue'} eq 'pending') { + $queue = 'pending'; + } + %requesthash = &Apache::lonnet::dump_dom($namespace,$cdom,'_'.$queue); my $chome = &Apache::lonnet::domain($cdom,'primary'); $hostname = &Apache::lonnet::hostname($chome); $protocol = $Apache::lonnet::protocol{$chome}; @@ -521,12 +597,12 @@ sub update_request_queue { } } else { my ($num,$cnum) = split(':',$item); - if (ref($requesthash{$cnum.'_approval'}) eq 'HASH') { + if (ref($requesthash{$cnum.'_'.$queue}) eq 'HASH') { if (&Apache::lonnet::homeserver($cnum,$cdom) eq 'no_host') { - my $ownername = $requesthash{$cnum.'_approval'}{'ownername'}; - my $ownerdom = $requesthash{$cnum.'_approval'}{'ownerdom'}; - $crstype = $requesthash{$cnum.'_approval'}{'crstype'}; - my $coursedesc = $requesthash{$cnum.'_approval'}{'description'}; + my $ownername = $requesthash{$cnum.'_'.$queue}{'ownername'}; + my $ownerdom = $requesthash{$cnum.'_'.$queue}{'ownerdom'}; + $crstype = $requesthash{$cnum.'_'.$queue}{'crstype'}; + my $coursedesc = $requesthash{$cnum.'_'.$queue}{'description'}; my $longroles = \%courseroles; if ($crstype eq 'community') { $longroles = \%communityroles; @@ -552,7 +628,7 @@ sub update_request_queue { &Apache::lonnet::restore($requestkey,'courserequests', $ownerdom,$ownername); if ((ref($history{'details'}) eq 'HASH') && - ($history{'disposition'} eq 'approval')) { + ($history{'disposition'} eq $queue)) { my ($logmsg,$newusermsg,$addresult,$enrollcount,$response,$keysmsg); my $result = &course_creation($cdom,$cnum,$context,$history{'details'},\$logmsg, \$newusermsg,\$addresult,\$enrollcount, @@ -565,7 +641,7 @@ sub update_request_queue { } push(@completed,$cnum); - unless (&Apache::lonnet::del_dom($namespace,[$cnum.'_approval'],$cdom) eq 'ok') { + unless (&Apache::lonnet::del_dom($namespace,[$cnum.'_'.$queue],$cdom) eq 'ok') { push(@warn_dels,$cnum); } &send_selfserve_notification($ownername.':'.$ownerdom,$approvedmsg, @@ -615,7 +691,7 @@ sub update_request_queue { } my @changes = (@completed,@rejections); if ($context eq 'domain') { - @changes = map {$_.'_approval'} (@changes); + @changes = map {$_.'_'.$queue} (@changes); } if (@rejections) { foreach my $item (@rejections) { @@ -638,13 +714,13 @@ sub update_request_queue { } } else { my $cnum = $item; - if (ref($requesthash{$cnum.'_approval'}) eq 'HASH') { + if (ref($requesthash{$cnum.'_'.$queue}) eq 'HASH') { if (&Apache::lonnet::homeserver($cnum,$cdom) eq 'no_host') { my $requestkey = $cdom.'_'.$cnum; - my $ownername = $requesthash{$cnum.'_approval'}{'ownername'}; - my $ownerdom = $requesthash{$cnum.'_approval'}{'ownerdom'}; - my $coursedesc = $requesthash{$cnum.'_approval'}{'description'}; - $crstype = $requesthash{$cnum.'_approval'}{'crstype'}; + my $ownername = $requesthash{$cnum.'_'.$queue}{'ownername'}; + my $ownerdom = $requesthash{$cnum.'_'.$queue}{'ownerdom'}; + my $coursedesc = $requesthash{$cnum.'_'.$queue}{'description'}; + $crstype = $requesthash{$cnum.'_'.$queue}{'crstype'}; if ($crstype eq 'community') { $rejectedmsg = $rejectionmsg{'community'}; } else { @@ -657,7 +733,7 @@ sub update_request_queue { &Apache::lonnet::restore($requestkey,'courserequests', $ownerdom,$ownername); if ((ref($history{'details'}) eq 'HASH') && - ($history{'disposition'} eq 'approval')) { + ($history{'disposition'} eq $queue)) { my %reqhash = ( reqtime => $history{'reqtime'}, crstype => $history{'crstype'}, @@ -682,7 +758,7 @@ sub update_request_queue { } else { push(@warn_rejects,$cnum); } - unless (&Apache::lonnet::del_dom($namespace,[$cnum.'_approval'],$cdom) eq 'ok') { + unless (&Apache::lonnet::del_dom($namespace,[$cnum.'_'.$queue],$cdom) eq 'ok') { push(@warn_dels,$cnum); } } else { @@ -745,8 +821,8 @@ sub update_request_queue { $output .= '

'.&mt('The following courses/communities were created:').'