--- loncom/interface/loncreateuser.pm	2010/03/05 06:37:43	1.334
+++ loncom/interface/loncreateuser.pm	2010/03/21 21:05:42	1.337
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Create a user
 #
-# $Id: loncreateuser.pm,v 1.334 2010/03/05 06:37:43 raeburn Exp $
+# $Id: loncreateuser.pm,v 1.337 2010/03/21 21:05:42 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -1455,6 +1455,8 @@ sub display_existing_roles {
             $newkey .= '_'.$newrole;
             if ($start ne '' && $end ne '') {
                 $newvalue .= '_'.$end.'_'.$start;
+            } elsif ($end ne '') {
+                $newvalue .= '_'.$end;
             }
             $rolesdump{$newkey} = $newvalue;
         }
@@ -2622,7 +2624,7 @@ sub update_user_data {
                     if (ref($usertypes) eq 'HASH') {
                         $newsettings{'inststatus'} = join(', ',map{ $usertypes->{$_}; } (@inststatuses)); 
                     } else {
-                        $newsettings{'inststatus'} = join(', ',map{ $usertypes->{$_}; } (@inststatuses));
+                        $newsettings{'inststatus'} = join(', ',@inststatuses);
                     }
                 }
             } else {
@@ -2635,6 +2637,7 @@ sub update_user_data {
             }
         } elsif ($context ne 'selfcreate') {
             $canshow{'inststatus'} = 1;
+            $newsettings{'inststatus'} = $oldsettings{'inststatus'};
         }
         $changeHash{'portfolioquota'} = $userenv{'portfolioquota'};
         if ($context eq 'domain') {
@@ -2695,12 +2698,6 @@ sub update_user_data {
         $oldsettings{'quota'} = $oldportfolioquota.' Mb';
         $newsettings{'quota'} = $newportfolioquota.' Mb';
         if ((keys(%namechanged) > 0) || (keys(%changed) > 0)) {
-            $changeHash{'firstname'}  = $env{'form.cfirstname'};
-            $changeHash{'middlename'} = $env{'form.cmiddlename'};
-            $changeHash{'lastname'}   = $env{'form.clastname'};
-            $changeHash{'generation'} = $env{'form.cgeneration'};
-            $changeHash{'id'}         = $env{'form.cid'};
-            $changeHash{'permanentemail'} = $env{'form.cpermanentemail'};
             my ($chgresult,$namechgresult);
             if (keys(%changed) > 0) {
                 $chgresult = 
@@ -2741,13 +2738,16 @@ sub update_user_data {
                 }
             }
             if (keys(%namechanged) > 0) {
-            # Make the change
+                foreach my $field (@userinfo) {
+                    $changeHash{$field}  = $env{'form.c'.$field};
+                }
+# Make the change
                 $namechgresult =
                     &Apache::lonnet::modifyuser($env{'form.ccdomain'},
                         $env{'form.ccuname'},$changeHash{'id'},undef,undef,
                         $changeHash{'firstname'},$changeHash{'middlename'},
                         $changeHash{'lastname'},$changeHash{'generation'},
-                        $changeHash{'id'},undef,$changeHash{'permanentemail'});
+                        $changeHash{'id'},undef,$changeHash{'permanentemail'},undef,\@userinfo);
                 %userupdate = (
                                lastname   => $env{'form.clastname'},
                                middlename => $env{'form.cmiddlename'},
@@ -4129,7 +4129,7 @@ sub handler {
             $r->print(&Apache::lonhtmlcommon::breadcrumbs("Update Users",
                                                           'Course_View_Class_List'));
             if ($permission->{'cusr'}) {
-                &Apache::lonuserutils::update_user_list($r,$context,$setting,$choice);
+                &Apache::lonuserutils::update_user_list($r,$context,$setting,$choice,$crstype);
                 $r->print(&Apache::loncommon::end_page());
             } else {
                 $r->print(&mt('You are not authorized to make bulk changes to user roles'));