--- loncom/interface/loncreateuser.pm	2010/03/19 20:21:18	1.335
+++ loncom/interface/loncreateuser.pm	2010/04/28 14:55:58	1.342
@@ -1,7 +1,7 @@
 # The LearningOnline Network with CAPA
 # Create a user
 #
-# $Id: loncreateuser.pm,v 1.335 2010/03/19 20:21:18 raeburn Exp $
+# $Id: loncreateuser.pm,v 1.342 2010/04/28 14:55:58 wenzelju Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -2385,15 +2385,17 @@ sub update_user_data {
                     }
                 }
                 foreach my $item (@requestcourses) {
-                    $newcustom{$item} = $env{'form.crsreq_'.$item};
-                    if ($env{'form.crsreq_'.$item} eq 'autolimit') {
-                        $newcustom{$item} .= '=';
-                        unless ($env{'form.crsreq_'.$item.'_limit'} =~ /\D/) {
-                            $newcustom{$item} .= $env{'form.crsreq_'.$item.'_limit'};
+                    if ($env{'form.custom'.$item} == 1) {
+                        $newcustom{$item} = $env{'form.crsreq_'.$item};
+                        if ($env{'form.crsreq_'.$item} eq 'autolimit') {
+                            $newcustom{$item} .= '=';
+                            unless ($env{'form.crsreq_'.$item.'_limit'} =~ /\D/) {
+                                $newcustom{$item} .= $env{'form.crsreq_'.$item.'_limit'};
+                            }
                         }
+                        $changed{$item} = &tool_admin($item,$newcustom{$item},
+                                                      \%changeHash,'requestcourses');
                     }
-                    $changed{$item} = &tool_admin($item,$newcustom{$item},
-                                                  \%changeHash,'requestcourses');
                 }
             }
             if ($canmodify_status{'inststatus'}) {
@@ -2574,7 +2576,8 @@ sub update_user_data {
         }
         my ($quotachanged,$oldportfolioquota,$newportfolioquota,$oldinststatus,
             $newinststatus,$oldisdefault,$newisdefault,%oldsettings,
-            %oldsettingstext,%newsettings,%newsettingstext,@disporder);
+            %oldsettingstext,%newsettings,%newsettingstext,@disporder,
+            $olddefquota,$oldsettingstatus,$newdefquota,$newsettingstatus);
         @disporder = ('inststatus');
         if ($env{'request.role.domain'} eq $env{'form.ccdomain'}) {
             push(@disporder,'requestcourses');
@@ -2582,8 +2585,10 @@ sub update_user_data {
             push(@disporder,'reqcrsotherdom');
         }
         push(@disporder,('quota','tools'));
-        my ($defquota,my $settingstatus) = 
+        $oldinststatus = $userenv{'inststatus'};
+        ($olddefquota,$oldsettingstatus) = 
             &Apache::loncommon::default_quota($env{'form.ccdomain'},$oldinststatus);
+        ($newdefquota,$newsettingstatus) = ($olddefquota,$oldsettingstatus);
         my %canshow;
         if (&Apache::lonnet::allowed('mpq',$env{'form.ccdomain'})) {
             $canshow{'quota'} = 1;
@@ -2600,7 +2605,6 @@ sub update_user_data {
             $canshow{'inststatus'} = 1;
         }
         my (%changeHash,%changed);
-        $oldinststatus = $userenv{'inststatus'};
         if ($oldinststatus eq '') {
             $oldsettings{'inststatus'} = $othertitle; 
         } else {
@@ -2620,11 +2624,13 @@ sub update_user_data {
                     $changeHash{'inststatus'} = $newinststatus;
                     if ($newinststatus ne $oldinststatus) {
                         $changed{'inststatus'} = $newinststatus;
+                        ($newdefquota,$newsettingstatus) =
+                            &Apache::loncommon::default_quota($env{'form.ccdomain'},$newinststatus);
                     }
                     if (ref($usertypes) eq 'HASH') {
                         $newsettings{'inststatus'} = join(', ',map{ $usertypes->{$_}; } (@inststatuses)); 
                     } else {
-                        $newsettings{'inststatus'} = join(', ',map{ $usertypes->{$_}; } (@inststatuses));
+                        $newsettings{'inststatus'} = join(', ',@inststatuses);
                     }
                 }
             } else {
@@ -2633,10 +2639,13 @@ sub update_user_data {
                 $newsettings{'inststatus'} = $othertitle;
                 if ($newinststatus ne $oldinststatus) {
                     $changed{'inststatus'} = $changeHash{'inststatus'};
+                    ($newdefquota,$newsettingstatus) =
+                        &Apache::loncommon::default_quota($env{'form.ccdomain'},$newinststatus);
                 }
             }
         } elsif ($context ne 'selfcreate') {
             $canshow{'inststatus'} = 1;
+            $newsettings{'inststatus'} = $oldsettings{'inststatus'};
         }
         $changeHash{'portfolioquota'} = $userenv{'portfolioquota'};
         if ($context eq 'domain') {
@@ -2654,12 +2663,12 @@ sub update_user_data {
                     }
                 } else {
                     $changed{'quota'} = &quota_admin('',\%changeHash);
-                    $newportfolioquota = $defquota;
+                    $newportfolioquota = $newdefquota;
                     $newisdefault = 1;
                 }
             } else {
                 $oldisdefault = 1;
-                $oldportfolioquota = $defquota;
+                $oldportfolioquota = $olddefquota;
                 if ($env{'form.customquota'} == 1) {
                     if ($env{'form.portfolioquota'} eq '') {
                         $newportfolioquota = 0;
@@ -2669,15 +2678,15 @@ sub update_user_data {
                     }
                     $changed{'quota'} = &quota_admin($newportfolioquota,\%changeHash);
                 } else {
-                    $newportfolioquota = $defquota;
+                    $newportfolioquota = $newdefquota;
                     $newisdefault = 1;
                 }
             }
             if ($oldisdefault) {
-                $oldsettingstext{'quota'} = &get_defaultquota_text($settingstatus);
+                $oldsettingstext{'quota'} = &get_defaultquota_text($oldsettingstatus);
             }
             if ($newisdefault) {
-                $newsettingstext{'quota'} = &get_defaultquota_text($settingstatus);
+                $newsettingstext{'quota'} = &get_defaultquota_text($newsettingstatus);
             }
             &tool_changes('tools',\@usertools,\%oldsettings,\%oldsettingstext,\%userenv,
                           \%changeHash,\%changed,\%newsettings,\%newsettingstext);
@@ -2697,12 +2706,6 @@ sub update_user_data {
         $oldsettings{'quota'} = $oldportfolioquota.' Mb';
         $newsettings{'quota'} = $newportfolioquota.' Mb';
         if ((keys(%namechanged) > 0) || (keys(%changed) > 0)) {
-            $changeHash{'firstname'}  = $env{'form.cfirstname'};
-            $changeHash{'middlename'} = $env{'form.cmiddlename'};
-            $changeHash{'lastname'}   = $env{'form.clastname'};
-            $changeHash{'generation'} = $env{'form.cgeneration'};
-            $changeHash{'id'}         = $env{'form.cid'};
-            $changeHash{'permanentemail'} = $env{'form.cpermanentemail'};
             my ($chgresult,$namechgresult);
             if (keys(%changed) > 0) {
                 $chgresult = 
@@ -2743,13 +2746,16 @@ sub update_user_data {
                 }
             }
             if (keys(%namechanged) > 0) {
-            # Make the change
+                foreach my $field (@userinfo) {
+                    $changeHash{$field}  = $env{'form.c'.$field};
+                }
+# Make the change
                 $namechgresult =
                     &Apache::lonnet::modifyuser($env{'form.ccdomain'},
                         $env{'form.ccuname'},$changeHash{'id'},undef,undef,
                         $changeHash{'firstname'},$changeHash{'middlename'},
                         $changeHash{'lastname'},$changeHash{'generation'},
-                        $changeHash{'id'},undef,$changeHash{'permanentemail'});
+                        $changeHash{'id'},undef,$changeHash{'permanentemail'},undef,\@userinfo);
                 %userupdate = (
                                lastname   => $env{'form.clastname'},
                                middlename => $env{'form.cmiddlename'},
@@ -4131,7 +4137,7 @@ sub handler {
             $r->print(&Apache::lonhtmlcommon::breadcrumbs("Update Users",
                                                           'Course_View_Class_List'));
             if ($permission->{'cusr'}) {
-                &Apache::lonuserutils::update_user_list($r,$context,$setting,$choice);
+                &Apache::lonuserutils::update_user_list($r,$context,$setting,$choice,$crstype);
                 $r->print(&Apache::loncommon::end_page());
             } else {
                 $r->print(&mt('You are not authorized to make bulk changes to user roles'));
@@ -4382,7 +4388,7 @@ sub print_main_menu {
          [
             {
              linktext => $links{$linkcontext}{'upload'},
-             icon => 'sctr.png',
+             icon => 'uplusr.png',
              #help => 'Course_Create_Class_List',
              url => '/adm/createuser?action=upload',
              permission => $permission->{'cusr'},
@@ -4390,7 +4396,7 @@ sub print_main_menu {
             },
             {
              linktext => $links{$linkcontext}{'listusers'},
-             icon => 'edit-find.png',
+             icon => 'mngcu.png',
              #help => 'Course_View_Class_List',
              url => '/adm/createuser?action=listusers',
              permission => ($permission->{'view'} || $permission->{'cusr'}),
@@ -4522,7 +4528,7 @@ sub print_main_menu {
             push(@{ $menu[2]->{items} }, 
                 {
                  linktext => 'User Self-Enrollment',
-                 icon => 'cstr.png',
+                 icon => 'self_enroll.png',
                  #help => 'Course_Self_Enrollment',
                  url => '/adm/createuser?action=selfenroll',
                  permission => $permission->{'cusr'},
@@ -6271,7 +6277,8 @@ sub update_selfenroll_config {
                             $newnum ++;
                         }
                     }
-                    for (my $j=0; $j<$env{'form.selfenroll_types_total'}; $j++) {                        if ((!grep(/^$j$/,@deletedoms)) && (!grep(/^$j$/,@activations))) {
+                    for (my $j=0; $j<$env{'form.selfenroll_types_total'}; $j++) {
+                        if ((!grep(/^$j$/,@deletedoms)) && (!grep(/^$j$/,@activations))) {
                             my @types = &Apache::loncommon::get_env_multiple('form.selfenroll_types_'.$j);
                             if (@types > 0) {
                                 @types = sort(@types);