--- loncom/interface/loncreateuser.pm	2001/11/16 07:00:53	1.21
+++ loncom/interface/loncreateuser.pm	2002/02/08 19:40:42	1.24
@@ -1,6 +1,30 @@
 # The LearningOnline Network with CAPA
 # Create a user
 #
+# $Id: loncreateuser.pm,v 1.24 2002/02/08 19:40:42 matthew Exp $
+#
+# Copyright Michigan State University Board of Trustees
+#
+# This file is part of the LearningOnline Network with CAPA (LON-CAPA).
+#
+# LON-CAPA is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# LON-CAPA is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with LON-CAPA; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+#
+# /home/httpd/html/adm/gpl.txt
+#
+# http://www.lon-capa.org/
+#
 # (Create a course
 # (My Desk
 #
@@ -22,7 +46,7 @@
 # 05/10,10/16 Gerd Kortemeyer 
 # 11/12,11/13,11/15 Scott Harrison
 #
-# $Id: loncreateuser.pm,v 1.21 2001/11/16 07:00:53 harris41 Exp $
+# $Id: loncreateuser.pm,v 1.24 2002/02/08 19:40:42 matthew Exp $
 ###
 
 package Apache::loncreateuser;
@@ -39,7 +63,7 @@ my $authformint;
 my $authformfsys;
 my $authformloc;
 
-sub BEGIN {
+BEGIN {
     $ENV{'SERVER_NAME'}=~/(\w+\.\w+)$/;
     my $krbdefdom=$1;
     $krbdefdom=~tr/a-z/A-Z/;
@@ -242,14 +266,14 @@ ENDENHEAD
     my $uhome=&Apache::lonnet::homeserver($ccuname,$ccdomain);
     my %incdomains; 
     my %inccourses;
-    map {
+    foreach (%Apache::lonnet::hostdom) {
        $incdomains{$_}=1;
-    } values %Apache::lonnet::hostdom;
-    map {
+    }
+    foreach (keys(%ENV)) {
 	if ($_=~/^user\.priv\.cm\.\/(\w+)\/(\w+)/) {
 	    $inccourses{$1.'_'.$2}=1;
         }
-    } %ENV;
+    }
     if ($uhome eq 'no_host') {
 	$r->print(<<ENDNUSER);
 <h2>New user $ccuname at $ccdomain</h2>
@@ -282,7 +306,7 @@ ENDNUSER
            $r->print('<h4>Revoke Existing Roles</h4>'.
              '<table border=2><tr><th>Revoke</th><th>Role</th><th>Extent</th>'.
 		     '<th>Start</th><th>End</th>');
-           map {
+	   foreach (split(/&/,$rolesdump)) {
              if ($_!~/^rolesdef\&/) {
 
               my ($area,$role)=split(/=/,$_);
@@ -336,7 +360,7 @@ ENDNUSER
                         ($tstart?localtime($tstart):'&nbsp;').'</td><td>'.
                         ($tend?localtime($tend):'&nbsp;')."</td></tr>\n");
 	     }
-	   } split(/&/,$rolesdump);
+	   } 
 	   $r->print('</table>');
          }   
 	my $currentauth=&Apache::lonnet::queryauthenticate($ccuname,$ccdomain);
@@ -464,9 +488,9 @@ ENDCOAUTH
     $r->print('<h4>Domain Level</h4>'.
     '<table border=2><tr><th>Activate</th><th>Role</th><th>Extent</th>'.
     '<th>Start</th><th>End</th></tr>');
-    map {
+    foreach ( sort( keys(%incdomains))) {
 	my $thisdomain=$_;
-        map {
+        foreach ('dc','li','dg','au') {
             if (&Apache::lonnet::allowed('c'.$_,$thisdomain)) {
                my $plrole=&Apache::lonnet::plaintext($_);
                $r->print(<<ENDDROW);
@@ -483,8 +507,8 @@ ENDCOAUTH
 </tr>
 ENDDROW
             }
-        } ('dc','li','dg','au');
-    } sort keys %incdomains;
+        } 
+    }
     $r->print('</table>');
 #
 # Course level
@@ -492,7 +516,7 @@ ENDDROW
     $r->print('<h4>Course Level</h4>'.
     '<table border=2><tr><th>Activate</th><th>Role</th><th>Extent</th>'.
     '<th>Group/Section</th><th>Start</th><th>End</th></tr>');
-    map {
+    foreach (sort( keys(%inccourses))) {
 	my $thiscourse=$_;
 	my $protectedcourse=$_;
         $thiscourse=~s:_:/:g;
@@ -501,7 +525,7 @@ ENDDROW
         my $bgcol=$thiscourse;
         $bgcol=~s/[^8-9b-e]//g;
         $bgcol=substr($bgcol.$bgcol.$bgcol.'ffffff',0,6);
-        map {
+        foreach  ('st','ta','ep','ad','in','cc') {
             if (&Apache::lonnet::allowed('c'.$_,$thiscourse)) {
                my $plrole=&Apache::lonnet::plaintext($_);
                $r->print("
@@ -523,8 +547,8 @@ ENDDROW
 </tr>
 ENDROW
             }
-        } ('st','ta','ep','ad','in','cc');
-    } sort keys %inccourses;
+        }
+    } 
     $r->print('</table>');
     $r->print('<input type=submit value="Modify User">');
     $r->print('</form></body></html>');
@@ -617,7 +641,7 @@ ENDTHREEHEAD
    }
     my $now=time;
     $r->print('<h3>Modifying Roles</h3>');
-    map {
+    foreach (keys (%ENV)) {
 	if (($_=~/^form\.rev\:([^\_]+)\_([^\_]+)$/) && ($ENV{$_})) {
            $r->print('Revoking '.$2.' in '.$1.': '.
           &Apache::lonnet::assignrole($ENV{'form.cdomain'},$ENV{'form.cuname'},
@@ -634,8 +658,8 @@ ENDTHREEHEAD
 	              $ENV{'course.'.$cid.'.home'}).'<br>');
            }
 	}
-    } keys %ENV;
-    map {
+    } 
+    foreach (keys(%ENV)) {
 	if (($_=~/^form\.act\_([^\_]+)\_([^\_]+)\_([^\_]+)$/) && ($ENV{$_})) {
             my $url='/'.$1.'/'.$2;
             if ($ENV{'form.sec_'.$1.'_'.$2.'_'.$3}) {
@@ -677,7 +701,7 @@ ENDTHREEHEAD
           &Apache::lonnet::assignrole($ENV{'form.cdomain'},$ENV{'form.cuname'},
                                       $url,$2,$end,$start).'<br>');
         }
-    } keys %ENV;
+    }
     $r->print('</body></html>');
 }