--- loncom/interface/londocs.pm	2013/03/31 22:36:01	1.538
+++ loncom/interface/londocs.pm	2013/04/03 02:00:19	1.543
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Documents
 #
-# $Id: londocs.pm,v 1.538 2013/03/31 22:36:01 raeburn Exp $
+# $Id: londocs.pm,v 1.543 2013/04/03 02:00:19 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -834,7 +834,7 @@ sub print_paste_buffer {
                         $othercourse = 1;
                         if ($env{"user.priv.cm./$srcdom/$srcnum"} =~ /\Q:mdc&F\E/) {
                             if ($canpaste) {
-                                $othercrs = '<br />'.&mt('(from another course).');
+                                $othercrs = '<br />'.&mt('(from another course)');
                             }
                         } else {
                             $canpaste = 0;
@@ -902,7 +902,7 @@ sub print_paste_buffer {
     my ($pasteform,$form_start,$buttons,$form_end);
     if ($pasteitems) {
         $pasteitems .= '<div style="padding:0;clear:both;margin:0;border:0"></div>';
-        $form_start = '<form name="pasteform" action="/adm/coursedocs" method="post">';
+        $form_start = '<form name="pasteform" action="/adm/coursedocs" method="post" onsubmit="return validateClipboard();">';
         if (@pasteable) {
             $buttons = '<input type="submit" name="pastemarked" value="'.&mt('Paste selected').'" />'.('&nbsp;'x2);
         }
@@ -1009,6 +1009,7 @@ sub paste_popup_js {
     my %lt = &Apache::lonlocal::texthash(
                                           show => 'Show Options',
                                           hide => 'Hide Options',
+                                          none => 'No items selected from clipboard.',
                                         );
     return <<"END";
 
@@ -1038,11 +1039,33 @@ function showOptions(caller,suffix) {
     return;
 }
 
+function validateClipboard() {
+    var numchk = 0;
+    if (document.pasteform.pasting.length > 1) {
+        for (var i=0; i<document.pasteform.pasting.length; i++) {
+            if (document.pasteform.pasting[i].checked) {
+                numchk ++;
+            }
+        }
+    } else {
+        if (document.pasteform.pasting.type == 'checkbox') {
+            if (document.pasteform.pasting.checked) {
+                numchk ++; 
+            } 
+        }
+    }
+    if (numchk > 0) { 
+        return true;
+    } else {
+        alert("$lt{'none'}");
+        return false;
+    }
+}
+
 END
 
 }
 
-
 sub do_paste_from_buffer {
     my ($coursenum,$coursedom,$folder,$container,$errors) = @_;
 
@@ -2170,7 +2193,9 @@ sub update_parameter {
                     }
                 }
             } else {
-                map { $allchecked{$which}{$_} = 1; } split(/,/,$env{'form.all'.$which});
+                if ($env{'form.all'.$which}) {
+                    map { $allchecked{$which}{$_} = 1; } split(/,/,$env{'form.all'.$which});
+                }
             }
         }
         my $haschanges = 0;
@@ -2244,7 +2269,9 @@ sub update_parameter {
 
 sub handle_edit_cmd {
     my ($coursenum,$coursedom) =@_;
-    return if ($env{'form.cmd'} eq '');
+    if ($env{'form.cmd'} eq '') {
+        return 0;
+    }
     my ($cmd,$idx)=split('_',$env{'form.cmd'});
 
     my $ratstr = $LONCAPA::map::resources[$LONCAPA::map::order[$idx]];
@@ -2349,24 +2376,30 @@ sub editor {
             my ($paste_res,$save_error,$pastemsgarray,$lockerror) =
                 &do_paste_from_buffer($coursenum,$coursedom,$folder,$container,
                                       \%paste_errors);
-                if (ref($pastemsgarray) eq 'ARRAY') {
-                    if (@{$pastemsgarray} > 0) {
-                          
-                        $r->print('<p class="LC_info">'.
-                                  join('<br />',@{$pastemsgarray}).
-                                  '</p>');
-                    }
-                }
-                if ($lockerror) {
-                    $r->print('<p class="LC_error">'.
-                              $lockerror.
+            if (ref($pastemsgarray) eq 'ARRAY') {
+                if (@{$pastemsgarray} > 0) {
+                    $r->print('<p class="LC_info">'.
+                              join('<br />',@{$pastemsgarray}).
                               '</p>');
                 }
-                if ($save_error ne '') {
-                    return $save_error; 
+            }
+            if ($lockerror) {
+                $r->print('<p class="LC_error">'.
+                          $lockerror.
+                          '</p>');
+            }
+            if ($save_error ne '') {
+                return $save_error; 
+            }
+            if ($paste_res) {
+                my %errortext = &Apache::lonlocal::texthash (
+                                    fail      => 'Storage of folder contents failed',
+                                    failread  => 'Reading folder contents failed',
+                                    failstore => 'Storage of folder contents failed',
+                                );
+                if ($errortext{$paste_res}) {
+                    $r->print('<p class="LC_error">'.$errortext{$paste_res}.'</p>');
                 }
-            if ($paste_res ne 'ok') {
-                $r->print('<p class="LC_error">'.$paste_res.'</p>');
             }
             if (keys(%paste_errors) > 0) {
                 $r->print('<p class="LC_warning">'."\n".
@@ -2566,9 +2599,13 @@ sub editor {
 
     my ($to_show,$output,@allidx,@allmapidx,%filters,%lists,%curr_groups);
     %filters =  (
-                  canremove => [],
-                  cancut    => [],
-                  cancopy   => [],
+                  canremove      => [],
+                  cancut         => [],
+                  cancopy        => [],
+                  hiddenresource => [],
+                  encrypturl     => [],
+                  randomorder    => [],
+                  randompick     => [],
                 );
     %curr_groups = &Apache::longroup::coursegroups();
     &Apache::loncommon::start_data_table_count(); #setup a row counter 
@@ -2618,9 +2655,13 @@ sub editor {
                 if ($folder !~ /^supplemental/) {
                     $lists{'canhide'} = join(',',@allidx);
                     $lists{'canrandomlyorder'} = join(',',@allmapidx);
-                    foreach my $item ('canremove','cancut','cancopy') {
+                    my @possfilters = ('canremove','cancut','cancopy','hiddenresource','encrypturl',
+                                       'randomorder','randompick');
+                    foreach my $item (@possfilters) {
                         if (ref($filters{$item}) eq 'ARRAY') {
-                            $lists{$item} = join(',',@{$filters{$item}}); 
+                            if (@{$filters{$item}} > 0) {
+                                $lists{$item} = join(',',@{$filters{$item}});
+                            }
                         }
                     }
                     if (@allidx > 0) {
@@ -2742,7 +2783,11 @@ sub multiple_check_form {
         '<input type="hidden" name="allidx" value="'.$listsref->{'canhide'}.'" />';
     if ($caller eq 'settings') {
         $output .= 
-        '<input type="hidden" name="allmapidx" value="'.$listsref->{'canrandomlyorder'}.'" />';
+        '<input type="hidden" name="allmapidx" value="'.$listsref->{'canrandomlyorder'}.'" />'."\n".
+        '<input type="hidden" name="currhiddenresource" value="'.$listsref->{'hiddenresource'}.'" />'."\n".
+        '<input type="hidden" name="currencrypturl" value="'.$listsref->{'encrypturl'}.'" />'."\n".
+        '<input type="hidden" name="currrandomorder" value="'.$listsref->{'randomorder'}.'" />'."\n".
+        '<input type="hidden" name="currrandompick" value="'.$listsref->{'randompick'}.'" />'."\n";
     } elsif ($caller eq 'actions') {
         $output .=
         '<input type="hidden" name="allremoveidx" id="allremoveidx" value="'.$listsref->{'canremove'}.'" />'.
@@ -3025,7 +3070,7 @@ END
 	}
 
 	if ($denied{'copy'}) {
-            $copylink=(<<ENDCOPY);
+            $copylink=(<<ENDCOPY)
 <span style="visibility: hidden;">$lt{'cp'}</span>
 ENDCOPY
         } else {
@@ -3034,7 +3079,7 @@ ENDCOPY
 	    $copylink=(<<ENDCOPY);
 <form name="$formname" method="post" action="/adm/coursedocs">
 $form_common
-<input type="checkbox" name="copy" id="copy_$orderidx" value="$orderidx" onclick="javascript:singleCheck(this,'$orderidx','copy');" class="LC_hidden"><a href="$js" class="LC_docs_copy">$lt{'cp'}</a>
+<input type="checkbox" name="copy" id="copy_$orderidx" value="$orderidx" onclick="javascript:singleCheck(this,'$orderidx','copy');" class="LC_hidden" /><a href="$js" class="LC_docs_copy">$lt{'cp'}</a>
 $form_end
 ENDCOPY
             if (($ishash) && (ref($filtersref->{'cancopy'}) eq 'ARRAY')) {
@@ -3051,7 +3096,8 @@ ENDCUT
 	    $cutlink=(<<ENDCUT);
 <form name="$formname" method="post" action="/adm/coursedocs">
 $form_common
-<input type="checkbox" name="cut" id="cut_$orderidx" value="$orderidx" onclick="javascript:singleCheck(this,'$orderidx','cut');" class="LC_hidden"><a href="$js" class="LC_docs_cut">$lt{'ct'}</a>
+<input type="hidden" name="skip_$orderidx" id="skip_cut_$orderidx" value="$skip_confirm" />
+<input type="checkbox" name="cut" id="cut_$orderidx" value="$orderidx" onclick="javascript:singleCheck(this,'$orderidx','cut');" class="LC_hidden" /><a href="$js" class="LC_docs_cut">$lt{'ct'}</a>
 $form_end
 ENDCUT
             if (($ishash) && (ref($filtersref->{'cancut'}) eq 'ARRAY')) {
@@ -3068,7 +3114,8 @@ ENDREM
             $removelink=(<<ENDREM);
 <form name="$formname" method="post" action="/adm/coursedocs">
 $form_common
-<input type="checkbox" name="remove" id="remove_$orderidx" value="$orderidx" onclick="javascript:singleCheck(this,'$orderidx','remove');" class="LC_hidden"><a href="$js" class="LC_docs_remove">$lt{'rm'}</a>
+<input type="hidden" name="skip_$orderidx" id="skip_remove_$orderidx" value="$skip_confirm" />
+<input type="checkbox" name="remove" id="remove_$orderidx" value="$orderidx" onclick="javascript:singleCheck(this,'$orderidx','remove');" class="LC_hidden" /><a href="$js" class="LC_docs_remove">$lt{'rm'}</a>
 $form_end
 ENDREM
             if (($ishash) && (ref($filtersref->{'canremove'}) eq 'ARRAY')) {
@@ -3100,11 +3147,10 @@ ENDREN
    $selectbox
    $form_end
 </td>
-<td class="LC_docs_entry_commands"><span class="LC_nobreak">
+<td class="LC_docs_entry_commands LC_nobreak">
 $removelink
 $cutlink
 $copylink
-</span>
 </td>
 END
     }
@@ -3191,6 +3237,9 @@ END
             my $rpckchk;
             if ($rpicknum) {
                 $rpckchk = ' checked="checked"';
+                if (($ishash) && (ref($filtersref->{'randompick'}) eq 'ARRAY')) {
+                    push(@{$filtersref->{'randompick'}},$orderidx.':'.$rpicknum);
+                }
             }
             my $formname = 'edit_randompick_'.$orderidx;
 	    $rand_pick_text = 
@@ -3203,8 +3252,13 @@ $form_common."\n".
             }
             $rand_pick_text .= '</span></span>'.
                                $form_end;
-    	    my $ro_set=
-	        ((&LONCAPA::map::getparameter($orderidx,'parameter_randomorder'))[0]=~/^yes$/i?' checked="checked"':'');
+            my $ro_set;
+            if ((&LONCAPA::map::getparameter($orderidx,'parameter_randomorder'))[0]=~/^yes$/i) {
+                $ro_set = 'checked="checked"';
+                if (($ishash) && (ref($filtersref->{'randomorder'}) eq 'ARRAY')) {
+                    push(@{$filtersref->{'randomorder'}},$orderidx);
+                }
+            }
             my $formname = 'edit_rorder_'.$orderidx;
 	    $rand_order_text = 
 '<form action="/adm/coursedocs" method="post" name="'.$formname.'">'."\n".
@@ -3281,10 +3335,19 @@ $form_end;
  	my %lt=&Apache::lonlocal::texthash(
  			      'hd' => 'Hidden',
  			      'ec' => 'URL hidden');
-	my $enctext=
-	    ((&LONCAPA::map::getparameter($orderidx,'parameter_encrypturl'))[0]=~/^yes$/i?' checked="checked"':'');
-	my $hidtext=
-	    ((&LONCAPA::map::getparameter($orderidx,'parameter_hiddenresource'))[0]=~/^yes$/i?' checked="checked"':'');
+        my ($enctext,$hidtext);
+        if ((&LONCAPA::map::getparameter($orderidx,'parameter_encrypturl'))[0]=~/^yes$/i) {
+            $enctext = ' checked="checked"';
+            if (($ishash) && (ref($filtersref->{'encrypturl'}) eq 'ARRAY')) {
+                push(@{$filtersref->{'encrypturl'}},$orderidx);
+            }
+        }
+        if ((&LONCAPA::map::getparameter($orderidx,'parameter_hiddenresource'))[0]=~/^yes$/i) {
+            $hidtext = ' checked="checked"';
+            if (($ishash) && (ref($filtersref->{'randomorder'}) eq 'ARRAY')) {
+                push(@{$filtersref->{'hiddenresource'}},$orderidx);
+            }
+        }
         my $formhidden = 'edit_hiddenresource_'.$orderidx;
         my $formurlhidden = 'edit_encrypturl_'.$orderidx;
 	$line.=(<<ENDPARMS);
@@ -5275,10 +5338,14 @@ sub editing_js {
                                           p_rmr1 => 'WARNING: Removing a resource makes associated grades and scores inaccessible!',
                                           p_rmr2a => 'Remove[_99]',
                                           p_rmr2b => '?[_99]',
+                                          p_rmr3a => 'Remove those [_2]',
+                                          p_rmr3b => 'items?[_2]',
                                           p_ctr1a => 'WARNING: Cutting a resource makes associated grades and scores inaccessible!',
                                           p_ctr1b => 'Grades remain inaccessible if resource is pasted into another folder.',
                                           p_ctr2a => 'Cut[_98]',
                                           p_ctr2b => '?[_98]',
+                                          p_ctr3a => 'Cut those[_2]',
+                                          p_ctr3b => 'items?[_2]',
                                           rpck    => 'Enter number to pick (e.g., 3)',
                                           imsfile => 'You must choose an IMS package for import',
                                           imscms  => 'You must select which Course Management System was the source of the IMS package',
@@ -5286,6 +5353,9 @@ sub editing_js {
                                           titbl   => 'Title is blank',
                                           more    => '(More ...)',
                                           less    => '(Less ...)',
+                                          noor    => 'No actions selected or changes to settings specified.',
+                                          noch    => 'No changes to settings specified.',
+                                          noac    => 'No actions selected.',
                                         );
 
     my $crstype = &Apache::loncommon::course_type();
@@ -5643,69 +5713,78 @@ function propagateState(form,param) {
 }
 
 function checkForSubmit(targetform,param,context,idx,folderpath,index,oldtitle,skip_confirm,container,folder) {
+    var dosettings;
+    var doaction;
     var control = document.togglemultsettings;
     if (context == 'actions') {
         control = document.togglemultactions;
+        doaction = 1; 
+    } else {
+        dosettings = 1;
     }
-    if (control.showmultpick.length) {
-        for (var i=0; i<control.showmultpick.length; i++) {
-            if (control.showmultpick[i].checked) {
-                if (control.showmultpick[i].value == 0) {
-                    if (context == 'settings') {
-                        targetform.changeparms.value=param;
-                        targetform.submit();
-                    } else {
-                        targetform.cmd.value=param+'_'+index;
-                        targetform.folderpath.value=folderpath;
-                        targetform.markcopy.value=idx+':'+param;
-                        targetform.copyfolder.value=folder+'.'+container;
-                        if (param == 'remove') {
-                            if (skip_confirm || confirm('$lt{"p_rmr1"}\\n\\n$lt{"p_rmr2a"} "'+oldtitle+'" $lt{"p_rmr2b"}')) {
-                                targetform.markcopy.value='';
-                                targetform.copyfolder.value='';
-                                targetform.submit();
-                            }
-                        }
-                        if (param == 'cut') {
-                            if (skip_confirm || confirm('$lt{"p_ctr1a"}\\n$lt{"p_ctr1b"}\\n\\n$lt{"p_ctr2a"} "'+oldtitle+'" $lt{"p_ctr2b"}')) {
-                                targetform.submit();
-                            }
-                        }
-                        if (param == 'copy') {
-                            targetform.submit();
-                        }
-                        targetform.markcopy.value='';
-                        targetform.copyfolder.value='';
-                        targetform.cmd.value='';
-                        targetform.folderpath.value='';
-                    }
-                } else {
-                    if (context == 'actions') {
-                        if (document.getElementById(param+'_'+idx)) {
-                            item = document.getElementById(param+'_'+idx);
-                            if (item.type == 'checkbox') {
-                                if (item.checked) {
-                                    item.checked = false;
-                                } else {
-                                    item.checked = true;
-                                }
-                            }
+    if (control) {
+        if (control.showmultpick.length) {
+            for (var i=0; i<control.showmultpick.length; i++) {
+                if (control.showmultpick[i].checked) {
+                    if (control.showmultpick[i].value == 1) {
+                        if (context == 'settings') {
+                            dosettings = 0;
+                        } else {
+                            doaction = 0;
                         }
                     }
                 }
-            } else {
-                if (document.getElementById(param+'_'+idx)) {
-                    checkbox = document.getElementById(param+'_'+idx);
-                    singleCheck(checkbox,idx,param);
-                }
             }
         }
-    } else {
-        if (context == 'settings') {
+    }
+    if (context == 'settings') {
+        if (dosettings == 1) {
             targetform.changeparms.value=param;
             targetform.submit();
         }
     }
+    if (context == 'actions') {
+        if (doaction == 1) {
+            targetform.cmd.value=param+'_'+index;
+            targetform.folderpath.value=folderpath;
+            targetform.markcopy.value=idx+':'+param;
+            targetform.copyfolder.value=folder+'.'+container;
+            if (param == 'remove') {
+                if (skip_confirm || confirm('$lt{"p_rmr1"}\\n\\n$lt{"p_rmr2a"} "'+oldtitle+'" $lt{"p_rmr2b"}')) {
+                    targetform.markcopy.value='';
+                    targetform.copyfolder.value='';
+                    targetform.submit();
+                }
+            }
+            if (param == 'cut') {
+                if (skip_confirm || confirm('$lt{"p_ctr1a"}\\n$lt{"p_ctr1b"}\\n\\n$lt{"p_ctr2a"} "'+oldtitle+'" $lt{"p_ctr2b"}')) {
+                    targetform.submit();
+                    return;
+                }
+            }
+            if (param == 'copy') {
+                targetform.submit();
+                return;
+            }
+            targetform.markcopy.value='';
+            targetform.copyfolder.value='';
+            targetform.cmd.value='';
+            targetform.folderpath.value='';
+            return;
+        } else {
+            if (document.getElementById(param+'_'+idx)) {
+                item = document.getElementById(param+'_'+idx);
+                if (item.type == 'checkbox') {
+                    if (item.checked) {
+                        item.checked = false;
+                    } else {
+                        item.checked = true;
+                        singleCheck(item,idx,param);
+                    }
+                }
+            }
+        }
+    }
     return;
 }
 
@@ -5910,6 +5989,8 @@ function checkSubmits() {
     var numchanges = 0;
     var form = document.saveactions;
     var doactions = multiActions();
+    var cutwarnings = 0;
+    var remwarnings = 0;
     if (doactions == 1) {
         var remidxlist = document.cumulativeactions.allremoveidx.value;
         if ((remidxlist != '') && (remidxlist != null)) {
@@ -5919,6 +6000,11 @@ function checkSubmits() {
                     if (document.getElementById('remove_'+remidxs[i]).checked) {
                         form.multiremove.value += remidxs[i]+',';
                         numchanges ++;
+                        if (document.getElementById('skip_remove_'+remidxs[i])) {
+                            if (document.getElementById('skip_remove_'+remidxs[i]).value == 0) {
+                                remwarnings ++;
+                            }
+                        }
                     }
                 }
             }
@@ -5931,6 +6017,11 @@ function checkSubmits() {
                     if (document.getElementById('cut_'+cutidxs[i]).checked == true) {
                         form.multicut.value += cutidxs[i]+',';
                         numchanges ++;
+                        if (document.getElementById('skip_cut_'+cutidxs[i])) {
+                            if (document.getElementById('skip_cut_'+cutidxs[i]).value == 0) {
+                                cutwarnings ++;
+                            }
+                        }
                     }
                 }
             }
@@ -5952,10 +6043,12 @@ function checkSubmits() {
         }
     }
     var dosettings = multiSettings();
+    var haschanges = 0;
     if (dosettings == 1) {
         form.allencrypturl.value = '';
         form.allhiddenresource.value = '';
-        form.changeparams.value = 'all'; 
+        form.changeparms.value = 'all';
+        var patt=new RegExp(",\$");
         var allidxlist = document.cumulativesettings.allidx.value;
         if ((allidxlist != '') && (allidxlist != null)) {
             var allidxs = allidxlist.split(',');
@@ -5972,6 +6065,8 @@ function checkSubmits() {
                         }
                     }
                 }
+                form.allhiddenresource.value = form.allhiddenresource.value.replace(patt,"");
+                form.allencrypturl.value = form.allencrypturl.value.replace(patt,"");
             }
         }
         form.allrandompick.value = '';
@@ -5990,12 +6085,55 @@ function checkSubmits() {
                     form.allrandomorder.value += allmapidxs[i]+',';
                 }
             }
+            form.allrandompick.value = form.allrandompick.value.replace(patt,"");
+            form.allrandomorder.value = form.allrandomorder.value.replace(patt,"");
+        }
+        if (document.cumulativesettings.currhiddenresource.value != form.allhiddenresource.value) {
+            haschanges = 1;
+        }
+        if (document.cumulativesettings.currencrypturl.value != form.allencrypturl.value) {
+            haschanges = 1;
+        }
+        if (document.cumulativesettings.currrandomorder.value != form.allrandomorder.value) {
+            haschanges = 1;
+        }
+        if (document.cumulativesettings.currrandompick.value != form.allrandompick.value) {
+            haschanges = 1;
+        }
+    }
+    if (doactions == 1) {
+        if (numchanges > 0) {
+            if ((cutwarnings > 0) || (remwarnings > 0)) {
+                if (remwarnings > 0) {
+                    if (!confirm('$lt{"p_rmr1"}\\n\\n$lt{"p_rmr3a"} '+remwarnings+' $lt{"p_rmr3b"}')) {
+                        return false;
+                    }
+                }
+                if (cutwarnings > 0) {
+                    if (!confirm('$lt{"p_ctr1a"}\\n$lt{"p_ctr1b"}\\n\\n$lt{"p_ctr3a"} '+cutwarnings+' $lt{"p_ctr3b"}')) {
+                        return false;
+                    }
+                }
+            }
+            form.submit();
+            return true;
+        }
+    }
+    if (dosettings == 1) {
+        if (haschanges == 1) {
+            form.submit();
+            return true;
+        }
+    }
+    if ((dosettings == 1) && (doactions == 1)) {
+        alert("$lt{'noor'}");
+    } else {
+        if (dosettings == 1) {
+            alert("$lt{'noch'}");
+        } else {
+            alert("$lt{'noac'}");
         }
     }
-    if ((numchanges > 0) || (dosettings == 1)) {
-        form.submit(); 
-        return true;
-    } 
     return false;
 }