--- loncom/interface/lonextresedit.pm	2025/06/14 20:48:54	1.8.2.4.4.5
+++ loncom/interface/lonextresedit.pm	2025/06/14 02:50:25	1.37
@@ -1,7 +1,7 @@
 # The LearningOnline Network
 # Documents
 #
-# $Id: lonextresedit.pm,v 1.8.2.4.4.5 2025/06/14 20:48:54 raeburn Exp $
+# $Id: lonextresedit.pm,v 1.37 2025/06/14 02:50:25 raeburn Exp $
 #
 # Copyright Michigan State University Board of Trustees
 #
@@ -284,10 +284,8 @@ sub process_changes {
                 if ($ferr) {
                     $errormsg = &mt('Reload failed: [_1].',$ferr);
                 } else {
-                    unless ($supplementalflag) {
-                        &Apache::loncommon::update_content_constraints($cdom,$cnum,$chome,
-                                                                       $cdom.'_'.$cnum);
-                    }
+                    &Apache::loncommon::update_content_constraints($cdom,$cnum,$chome,
+                                                                   $cdom.'_'.$cnum);
                 }
             }
             if (($type eq 'tool') && ($newgradable)) {
@@ -368,7 +366,7 @@ sub update_exttool {
         } elsif ($item eq 'delay') {
             if ($newhash{'desturl'} eq '') {
                 $newhash{$item} = '';
-            }
+	    }
             unless ($newhash{$item} =~ /^(\d+\.?\d*)$/) {
                 $newhash{$item} = '';
             }
@@ -440,10 +438,10 @@ sub extedit_form {
     my ($formname,$formid,$toggle,$fieldsetid,$urlid,$subdivid,$dispdivstyle,$dimendivstyle,
         $windivstyle,$linktextstyle,$explanationstyle,$labelstyle,$titlestyle,$providerstyle,
         $appendstyle,$gradablestyle,$returnurlstyle,$subdivstyle,$desturlstyle,
-        $desturlinfostyle,$desturlfixedstyle,$legend,$urlelem,$toolelem,%toolattr);
+	$desturlinfostyle,$desturlfixedstyle,$legend,$urlelem,$toolelem,%toolattr);
     $formname = 'new'.$type;
     $toggle = $type;
-    $fieldsetid = 'upload'.$type.'form';
+    $fieldsetid = 'external'.$type.'form';
     $urlid = $type.'url';
     map { $toolattr{$_} = $type.$_; } ('dispdiv','dimendiv','dimenwidth','dimenheight',
                                        'crstitlediv','crslabeldiv','crsappenddiv',
@@ -470,7 +468,7 @@ sub extedit_form {
     if ($supplementalflag) {
         $formname = 'newsupp'.$type;
         $toggle = 'supp'.$type;
-        $fieldsetid = 'uploadsupp'.$type.'form';
+        $fieldsetid = 'externalsupp'.$type.'form';
         $urlid = 'supp'.$type.'url';
         map { $toolattr{$_} = 'supp'.$toolattr{$_}; } (keys(%toolattr));
     }
@@ -478,7 +476,7 @@ sub extedit_form {
         $crsappend,$fieldsetstyle,$action,$hiddenelem,$form,$width,$height,$tooltarget,
         $linktext,$explanation,$path,$returnurl,$chkgrd,$chknogrd,%chkstate,
         $chknoreturn,$chkreturndef,$chkreturncust,$customreturn,$backtourl,$desturl,$delay,
-        $chknodest,$chkdest);
+	$chknodest,$chkdest);
     $fieldsetstyle = 'display: none;';
     $action = '/adm/coursedocs';
     my $protocol = ($ENV{'SERVER_PORT'} == 443?'https':'http');
@@ -510,7 +508,7 @@ sub extedit_form {
             $active = '<input type="hidden" name="active" value="'.$tabid.'" />';
         }
         $formname = 'edit'.$type.'_'.$residx;
-        $fieldsetid = 'upload'.$type.$residx;
+        $fieldsetid = 'external'.$type.$residx;
         $urlid = $type.'url_'.$residx;
         map { $toolattr{$_} .= '_'.$residx; } (keys(%toolattr));
         $srcclass = ' class="LC_nobreak"';
@@ -525,7 +523,7 @@ sub extedit_form {
         if ($type eq 'tool') {
             $link = $lt{'et'};
         }
-        $link = '<a class="LC_menubuttons_link" href="javascript:toggleUpload('."'$toggle'".');">'.$link.'</a>'.$helpitem;
+        $link = '<a class="LC_menubuttons_link" href="javascript:toggleExternal('."'$toggle'".');">'.$link.'</a>'.$helpitem;
         if ($type eq 'tool') {
             $legend = $lt{'te'};
         } else {
@@ -629,7 +627,7 @@ sub extedit_form {
                         if ($ltihash->{'crsconf'}->{'returnurl'}) {
                             $returnurl = $toolhash{'returnurl'};
                             $returnurlstyle = 'display:inline';
-                            $backtourl = $toolhash{'backtourl'}; 
+                            $backtourl = $toolhash{'backtourl'};
                             if ($returnurl eq 'none') {
                                 $chknoreturn = ' checked="checked"';
                                 $customreturn = 'hidden';
@@ -643,19 +641,19 @@ sub extedit_form {
                         }
                         if ($ltihash->{'crsconf'}->{'desturl'}) {
                             $desturl = $toolhash{'desturl'};
-                            $desturlstyle = 'display:inline';
-                            $delay = $toolhash{'delay'};
+			    $desturlstyle = 'display:inline';
+                            $delay = $toolhash{'delay'}; 
                             $showprovider = 1;
-                            if ($desturl ne '') {
+			    if ($desturl ne '') {
                                 $desturlinfostyle = 'display:inline';
                                 $chkdest = ' checked="checked"';
-                                $chknodest = '';
-                            } else {
-                                $desturlinfostyle = 'display:none';
-                                $chkdest = '';
+				$chknodest = ''; 
+			    } else {
+				$desturlinfostyle = 'display:none';
+			        $chkdest = ''; 
                                 $chknodest = ' checked="checked"';
-                            }
-                        } else {
+			    } 
+			} else {
                             $nocrsdest = 1;
                         }
                     }
@@ -758,8 +756,8 @@ sub extedit_form {
             $chknoreturn = '';
             $chkreturndef = ' checked="checked"';
             $chkreturncust = '';
-            $chknodest = ' checked="checked"';
-            $chkdest = '';
+	    $chknodest = ' checked="checked"';
+	    $chkdest = '';
         }
         my $onclickreturl = ' onclick="updateReturnUrl('."this.form,'$toolattr{'customreturnurl'}','$toolattr{'returnurldiv'}','exttoolreturnurl'".');"';
         my $onclickdest = ' onclick="updateDestUrl('."this.form,'$toolattr{'desturlinfodiv'}','$toolattr{'desturldiv'}','exttooldest'".');"';
@@ -847,8 +845,10 @@ sub extedit_form {
         $chooser = "
 <div>
 <span$srcclass>
+<label>
 $extsrc
 $urlelem
+</label>
 $preview
 </span>
 </div>
@@ -866,8 +866,10 @@ $active
 $chooser
 <div $idattr style="$subdivstyle">
 <span$srcclass>
+<label>
 $title
 <input type="text" size="$size" name="exttitle" value="$orig_title" $disabled />
+</label>
 <input type="hidden" name="importdetail" value="" />
 $pathitem
 $hiddenelem
@@ -965,7 +967,7 @@ sub extedit_javascript {
     my ($toolsjs,$exttoolnums,$exttooloptions);
     if (ref($toolsref) eq 'HASH') {
         $toolsjs = "        var ltitools = new Array();\n".
-                   "        var ltitoolsProvider = new Array();\n".
+	           "        var ltitoolsProvider = new Array();\n".
                    "        var ltitoolsPath = new Array();\n".
                    "        var ltitoolsTarget = new Array();\n".
                    "        var ltitoolsWidth = new Array();\n".
@@ -1330,14 +1332,14 @@ function setExternal(extform,residx,type
 }
 
 function editext(residx,type) {
-    if (document.getElementById('upload'+type+residx)) {
-        var curr = document.getElementById('upload'+type+residx).style.display;
+    if (document.getElementById('external'+type+residx)) {
+        var curr = document.getElementById('external'+type+residx).style.display;
         if (curr == 'none') {
             disp = 'block';
         } else {
             disp = 'none';
         }
-        document.getElementById('upload'+type+residx).style.display=disp;
+        document.getElementById('external'+type+residx).style.display=disp;
     }
     resize_scrollbox('contentscroll','1','1');
     return;
@@ -1745,7 +1747,7 @@ function updateReturnUrl(form,typeid,div
                 for (var i=0; i<radelem.length; i++) {
                     if (radelem[i].checked) {
                         if (radelem[i].value == 'custom') {
-                            inputtype = 'text';            
+                            inputtype = 'text';
                         } else {
                             inputtype = 'hidden';
                         }